From patchwork Thu Nov 10 18:38:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2474 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A92C23F039 for ; Thu, 10 Nov 2022 19:41:21 +0100 (CET) Received: by mail-pj1-f71.google.com with SMTP id my9-20020a17090b4c8900b002130d29fd7csf3894070pjb.7 for ; Thu, 10 Nov 2022 10:41:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668105680; cv=pass; d=google.com; s=arc-20160816; b=unWeXu1Aqh72a8C3gyHXsDwnABNkQSj7RTXoICMUbYD6ZAt6nvb+KdAAQel+0WKYsU Jd/+KGLIi35MIvI6oETSHySTE+F5RRfJFAhBf4drAZHJI0ynsGahpmcKUwU54MEboNfI iR6wN6rwxnc22ylIPTsVUYqgiG0AyO6frjcY6bqX8ZX0yfFjYkh6AtO+Jjd0UnRRvQr+ wSWQqcFtiwiE3n/vDs7Fot++lffvnOpUgIYLVCYqD9/zovPjbxXOmuUDXURIDeLoVpOm UVOmK4xxjouFS68crDET+n3rw7vYxeZCX8f7G1HMcS8x8iXF1D3hM7L+uvibRpZrCKq5 Cb8g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=6n+KGK9YTzfrDBs9XJXs8YrVdcRo3os0ty9oaTj0dPw=; b=Mb+VFwzL0vH0/KLqU2ae/5YjZ6QUDQSS2wAwuh0ROCE9lpxGSokQOTaqWuu0ZXOeik yIEgHg7gg9ubOcZNCk1tNU5fhAc2SpseQbTLctEvI86EMEZKa2RlNKWkUZnkY3at9Zlb RYVQ5PRfOPHbUET+LzPcwe7hQjDfl5hmUL61qL+6bbQwBxeJ/dO2XwWpVRBzgn7eBRt0 F4dEmB52lAuJ7S9bYCim5NO248dL6QEK/5UTdpeqR6cGLaac02Xs4KNdCAwnIgboMFaO knBAKam0cUpCx4m1twgZ0GrGFy/B0Ub3jt7FDzS92ojPFFnNKhUkBsRz94FtbtdJI/1Z RtUA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=VXDFnV+e; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6n+KGK9YTzfrDBs9XJXs8YrVdcRo3os0ty9oaTj0dPw=; b=Mjgqjd07aR3iZsvKm/Q8s/sk7rJRPaK3EyXkb+fJszmA9rsqYIW5r5lTOkfFFIQDM2 pWohqguE7V7MxavX0TPJSBHIyJbinnZcviir9ssaktoauR1CpXTiYoRhlbe1sf7anams uyLplI90sWFOEORohKRbOrxkgeYg8TiFMQhWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6n+KGK9YTzfrDBs9XJXs8YrVdcRo3os0ty9oaTj0dPw=; b=qBSFUKhcqY52o1MHP7btxLnJsCXM4MQLHPXKHOzjzNElI9tgYkzmh/vfw2eJfi7oaS pFbPOz+L2YKWeOmROkyiPGA8PQFcePV1G+6FQz3sE1c9ahVtUKt4hwruzZQd+0H502yd xRdnkvCmSlUQdWZoekJp0c1qMy/+AYUEEaIkInx8kc9w2ZuoeLOwoB5/nDscEPTk8tr4 2XMMmLYPVOccaEvb/5CQu4TlBJ99bJFWXffVF0HP5MtQAgRYOZWj3oy46vvmOqx9h4mh ZRSwaqiXyE9KsJgUT2z5Ga074NLGfeaFSLEyK1pmChmwKBe4R3LD4Yu2PXSyos9LBlA3 olXw== X-Gm-Message-State: ACrzQf12LbIJ164F9azZ8Sq0Vj66cYJJg1am2RCabVZnc9w0f4oWh0Yt SDvTaFfJwHgPUOp7Q8DiU6R+wEkU X-Google-Smtp-Source: AMsMyM6oqWFjThl3yz35Gaw6ghPLKmxcycQTWQ3VLxT8iwkA1vXnQMlIqUfr7iR+cbOewaITEQIcig== X-Received: by 2002:a17:902:e810:b0:186:e9ff:4ec2 with SMTP id u16-20020a170902e81000b00186e9ff4ec2mr62832053plg.26.1668105680497; Thu, 10 Nov 2022 10:41:20 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:f68f:b0:186:9fc5:6c01 with SMTP id l15-20020a170902f68f00b001869fc56c01ls1648908plg.6.-pod-prod-gmail; Thu, 10 Nov 2022 10:41:19 -0800 (PST) X-Received: by 2002:a17:903:22cb:b0:186:a8ae:d107 with SMTP id y11-20020a17090322cb00b00186a8aed107mr49530810plg.119.1668105679523; Thu, 10 Nov 2022 10:41:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668105679; cv=none; d=google.com; s=arc-20160816; b=H85zIRlMZHEVx4AncyKiJz5q1rgzMLoIfkDQ1oDvTOE6l3tWvdO9ljH4f/Pp/8mgFH iX5oX3DaOcnLY2/3QVCnQC1ZbqhosfDz83//nP6LfFLlRSUlDEzdtA71ryOB6xRRfBU+ tkbgGvCB4dhIjYf0fAsQ5muPQVOGrXGA1410EyUp6VLwHeGbXOsbe76hJuMSnI7TNPLi KhjKcUz+/1jlVdXjVHNB4wXxIOtWLEdO6enCVeuQBIFFmgx+kwUpLqXpSHe/UhE10OAP REsUfO9TxjbrY+Ly2fyoFJbeoQBhGFP58O5zAqiGzFbxN7l8OYKgat1bK3HZW3vQPCWV SJlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ahKEBxaNtaA33OFl+eyGOGbGztMU8PeqwlZcki2k/x4=; b=tMduRCPGH0YuL4Cx+bPJdSHBaBAreq3X6/YHhsEJeumT0O97IOJXIwYD7rM5SbtcuM w5zp9awKZRO51lewQFDC6TwZcF9eTFH7Q2VLA/vkq3KyJbzop57yMn6LKN2mc6OhaBWg UoNnVmPVXClLjb3MDfg2Plbr5Kk1KLf91/7KBsooSSWZvUMhyECHyDgavBjbT0Ws7ufR LG4qaBbTAW07tgrb/LNiauMTOx9+uIburfK8p8c3RXbJWhvQsWKgH5QpKq8qwj7nx7mV OJg7g4awsfdATLMrhdNe2THIhC/paCaAS3GDEP1l5AP401hvoVyWQ4jvgwpbNoH27sTr k6Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=VXDFnV+e; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id y20-20020a170902ed5400b00184e333125bsor20623plb.103.2022.11.10.10.41.19 for (Google Transport Security); Thu, 10 Nov 2022 10:41:19 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:903:240a:b0:183:6555:7a89 with SMTP id e10-20020a170903240a00b0018365557a89mr64973897plo.68.1668105679220; Thu, 10 Nov 2022 10:41:19 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:b5a4:486a:f07:f67e]) by smtp.gmail.com with ESMTPSA id c2-20020a170903234200b001869efb722csm11635627plh.215.2022.11.10.10.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 10:41:18 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v8 09/14] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Date: Fri, 11 Nov 2022 00:08:48 +0530 Message-Id: <20221110183853.3678209-10-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221110183853.3678209-1-jagan@amarulasolutions.com> References: <20221110183853.3678209-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=VXDFnV+e; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Finding the right input bus format throughout the pipeline is hard so add atomic_get_input_bus_fmts callback and initialize with the proper input format from list of supported output formats. This format can be used in pipeline for negotiating bus format between the DSI-end of this bridge and the other component closer to pipeline components. List of Pixel formats are taken from, AN13573 i.MX 8/RT MIPI DSI/CSI-2, Rev. 0, 21 March 2022 3.7.4 Pixel formats Table 14. DSI pixel packing formats v8: * added pixel formats supported by NXP AN13573 i.MX 8/RT MIPI DSI/CSI-2 v7, v6, v5, v4: * none v3: * include media-bus-format.h v2: * none v1: * new patch Signed-off-by: Jagan Teki Tested-by: Marek Szyprowski --- drivers/gpu/drm/bridge/samsung-dsim.c | 53 +++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 0fe153b29e4f..33e5ae9c865f 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -1321,6 +1322,57 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +/* + * This pixel output formats list referenced from, + * AN13573 i.MX 8/RT MIPI DSI/CSI-2, Rev. 0, 21 March 2022 + * 3.7.4 Pixel formats + * Table 14. DSI pixel packing formats + */ +static const u32 samsung_dsim_pixel_output_fmts[] = { + MEDIA_BUS_FMT_UYVY8_1X16, + MEDIA_BUS_FMT_RGB101010_1X30, + MEDIA_BUS_FMT_RGB121212_1X36, + MEDIA_BUS_FMT_RGB565_1X16, + MEDIA_BUS_FMT_RGB666_1X18, + MEDIA_BUS_FMT_RGB888_1X24, +}; + +static bool samsung_dsim_pixel_output_fmt_supported(u32 fmt) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(samsung_dsim_pixel_output_fmts); i++) { + if (samsung_dsim_pixel_output_fmts[i] == fmt) + return true; + } + + return false; +} + +static u32 * +samsung_dsim_atomic_get_input_bus_fmts(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state, + u32 output_fmt, + unsigned int *num_input_fmts) +{ + u32 *input_fmts; + + if (!samsung_dsim_pixel_output_fmt_supported(output_fmt)) + return NULL; + + *num_input_fmts = 1; + + input_fmts = kmalloc(sizeof(*input_fmts), GFP_KERNEL); + if (!input_fmts) + return NULL; + + input_fmts[0] = output_fmt; + + return input_fmts; +} + static int samsung_dsim_atomic_check(struct drm_bridge *bridge, struct drm_bridge_state *bridge_state, struct drm_crtc_state *crtc_state, @@ -1385,6 +1437,7 @@ static const struct drm_bridge_funcs samsung_dsim_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_get_input_bus_fmts = samsung_dsim_atomic_get_input_bus_fmts, .atomic_check = samsung_dsim_atomic_check, .atomic_pre_enable = samsung_dsim_atomic_pre_enable, .atomic_enable = samsung_dsim_atomic_enable,