From patchwork Thu Nov 10 18:38:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2475 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8C0933F039 for ; Thu, 10 Nov 2022 19:41:28 +0100 (CET) Received: by mail-pf1-f198.google.com with SMTP id x11-20020a056a000bcb00b0056c6ec11eefsf1435829pfu.14 for ; Thu, 10 Nov 2022 10:41:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668105687; cv=pass; d=google.com; s=arc-20160816; b=OhpnzTtKIHfIZddK99k5dzO5VbbrRsUZdKTasFGEyclx7KAa/PYGdbfgNgx9fxRu0X 6Fr6aVKBN3U8dN50uKqwlQVjP9FLgsV/23mhiH6NeEIK8fbwNtYO0lSo50rg/r5+Hg72 4cwtAQAfclDq86+P6rBI4YIR8kRDCoIkgQ2hWZKU1RsWLCilROsmdnAql1E62lq4Uu8H KaIEqyCITbQry/VpKDHr2eNm9XgQYBZm7zytJtpCSaHzwM0wdPiMy6smVcSan9E3t/xF +x3rEEHIkwQpHTySHTPjen8vPHS0aau50bO1yhVyaAoliajdBphHJXaeiSf28IWt6spI w4vQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Aj0SNVYzMzK+siEPdHQkLoYvauHW7E9bar921WcUpYE=; b=fHBxZ1hhJyTLwXTFzRnLDCvWwSxuchb0EbP88e7ue7QExsMYcv9hCLMACz98BZV/B4 ATjRA3BhZWIEfmB39aQpTMf/oIWJHTXCYSN42+RSjEo2xn8Rbd1PL60BkYfSBw7ktI8h j36/exFidqACOjQrm7Ba1dIL2LsQjISVB39e5bg6tvbJE3dw/N1YVhiDTzaV/b2X4Hvf mBU6HVW7qmd2JhA0FTDb5oi5EJR/N/IAiVjABcKsJugcLMgz9EwFN+ubTCqccjA9qhiM l1gDqjYmjGrQSA4nuVYM5+JoAqmMXNPSZ9k2yHJJjSfNkAAI38/GTx8C4/qj7KyVy3sL CoVg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=kW6ySL9n; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Aj0SNVYzMzK+siEPdHQkLoYvauHW7E9bar921WcUpYE=; b=efus6C5xaoddz5qGpeyypcSM9zeMMJFDQqGdYSxIprW1C3DnL9fSgQPeTy7AeuluAp KWhFjte5VVYi6KSkP2JyQfvvPEDOlKpTZrSEYWpY01LWLH12kdsycVQO8r1/RTGYwJUG mOkmu8MpmL4E9j1eX3Zg8uS6BvVhv0UTXJLQo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Aj0SNVYzMzK+siEPdHQkLoYvauHW7E9bar921WcUpYE=; b=4ZRzjf9DLw7655ceJ7505BUoxgniL/9+PK/0RXlD6aACcK3d7sXIhUA/OWyDYTG2xh Ee2f0QQghmK0J6vJz1W8zvtNoE8ALrtPmz/KyoO28Tld6zmXMLuJcpEh0dvQeaZefR13 jImd6rZ5teK6TUyJQKeF8InZuqqm8q9r5cl2s16oX5dXL42ukKoKfF30ORW3OeNaKjj9 Qh90cvclsbXFG4S5v9t1W2FLoGiaxJEJocRdzK+MJxVA2xZIUhtIC80NcLHSdHPEGAJg G3lIx8x4oXSECfuoys1wfBmOnnt0xExSnNl+/UlNS9qt1v4uo8/gsjaUfQ7rUeYFILrY ODzw== X-Gm-Message-State: ACrzQf024BsoKcYXaaMPz3vEXYaQHq420LSzKg5RF/NVHDYP/mSRXIb7 p58fvuvaA35iHQK3giQGCbvDB40P X-Google-Smtp-Source: AMsMyM791K7AodIxeVcGoCxvzgnA+oxy7KH2m+SCnhYaABTZyRhik1xzbhULAyHMbrGEc8H9HckjRw== X-Received: by 2002:a17:90a:5d06:b0:212:f8e5:81ab with SMTP id s6-20020a17090a5d0600b00212f8e581abmr1735966pji.114.1668105687363; Thu, 10 Nov 2022 10:41:27 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:1b2a:b0:214:246b:918a with SMTP id q39-20020a17090a1b2a00b00214246b918als4146995pjq.2.-pod-canary-gmail; Thu, 10 Nov 2022 10:41:26 -0800 (PST) X-Received: by 2002:a17:902:db11:b0:188:515e:81a2 with SMTP id m17-20020a170902db1100b00188515e81a2mr39702345plx.85.1668105686560; Thu, 10 Nov 2022 10:41:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668105686; cv=none; d=google.com; s=arc-20160816; b=L3vZQn4k0F1kQgtdSvaxhvWz/sCN92AfrQgs1wGFC9OU8Qy0Eu9WGvLAZGCwX2fkDK 0mbIxBC7M/rpsgpt/D4SHlE8ZJCpGWc7JzE8+gd9OcTFfAkorBg0mopSMgI1PoRVBB6a jHI1Coa6Cdp9w/IZGn3ypS8PLX/6YSTeNewvvh5mKQALSnnQ+pICHClVh6/dBgR3NWJi bkVmn5zEAFdkyRZy8jqgCRuyL9gN38vs7G2iV/p3AaYpln7LFF2M4XM4hxsxlAJCw/Px D3G7Cfa/BD7ZNvH9VSrUxpXST65b5IkGrSP2O2gHO97o0D7+Mxf/6Q4ATRCbH+mJYeZ4 MVWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=+uQe3bmrV0zmghe9Tre6aGt5ad4Xsr/J3KkGBkCAzjo=; b=hLxAbvyRFi4Vp3NLBNBdYL9ytEqMY0RvvULt4gmEj098eK/p9MII1dhsGcJyLy7MOz +ezCzQPpzdKkF3Cg4GQr7Zx7lnoZNnAcvKYNIWvyCJ+sunMKKDk+EiHspY5plmPXi1Qa ed3oXRUq4GR4mmYqD6mgR3U+pIHaUtMG7OtdB6YAUWubAII/vmPJcV2zBwojjKueBbWe TCYx/HhRlOyOOJujlkmA+5O0wu0GJSgh4Ncx+IWgA4zFhm2BoV1exXIF8jHS4+1wPzjK vJChIm1MrNnHWP0owTi5ilpaTGHkptHzgGTd/HoDUhCIPFK3sdmLHar+sdEjz2FecO/9 7X8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=kW6ySL9n; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 7-20020a620407000000b0056bfb4f3d76sor9375889pfe.75.2022.11.10.10.41.26 for (Google Transport Security); Thu, 10 Nov 2022 10:41:26 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a63:1053:0:b0:439:4c73:821c with SMTP id 19-20020a631053000000b004394c73821cmr2977955pgq.109.1668105686267; Thu, 10 Nov 2022 10:41:26 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:b5a4:486a:f07:f67e]) by smtp.gmail.com with ESMTPSA id c2-20020a170903234200b001869efb722csm11635627plh.215.2022.11.10.10.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 10:41:25 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v8 10/14] drm: bridge: samsung-dsim: Add input_bus_flags Date: Fri, 11 Nov 2022 00:08:49 +0530 Message-Id: <20221110183853.3678209-11-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221110183853.3678209-1-jagan@amarulasolutions.com> References: <20221110183853.3678209-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=kW6ySL9n; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting the i.MX8M Mini/Nano DSI host to add additional Data Enable signal active low (DE_LOW). This makes the valid data transfer on each horizontal line. So, add additional bus flags DE_LOW setting via input_bus_flags for i.MX8M Mini/Nano platforms. v8: * add DE_LOW for i.MX8M Mini/Nano platforms. v7, v6: * none v5: * rebased based on updated bridge changes v4, v3, v2, v1: * none Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 33e5ae9c865f..65f7d8522bc1 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1627,6 +1627,10 @@ static const struct samsung_dsim_host_ops samsung_dsim_generic_host_ops = { .unregister_host = samsung_dsim_unregister_host, }; +static const struct drm_bridge_timings samsung_dsim_bridge_timings_de_low = { + .input_bus_flags = DRM_BUS_FLAG_DE_LOW, +}; + int samsung_dsim_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -1709,6 +1713,10 @@ int samsung_dsim_probe(struct platform_device *pdev) dsi->bridge.of_node = dev->of_node; dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; + /* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */ + if (dsi->plat_data->hw_type == SAMSUNG_DSIM_TYPE_IMX8MM) + dsi->bridge.timings = &samsung_dsim_bridge_timings_de_low; + if (dsi->plat_data->host_ops && dsi->plat_data->host_ops->register_host) ret = dsi->plat_data->host_ops->register_host(dsi);