From patchwork Fri Dec 9 15:23:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2524 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id E5D933F039 for ; Fri, 9 Dec 2022 16:25:54 +0100 (CET) Received: by mail-pf1-f197.google.com with SMTP id v23-20020aa78097000000b005748c087db1sf3487838pff.2 for ; Fri, 09 Dec 2022 07:25:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670599553; cv=pass; d=google.com; s=arc-20160816; b=nByB2y02B6fPRzCMpuJLCGKv8FJr8Zgsk9QqFPHIJV3lrKH4/z0nmCXQN+Hgv32mVD UKFmqf3RdyTqT0JQJyqnyshYHIcI+N8hSP7D4Z2orp98a0SblKCg7TQnidvcLBiHn5YA O9SMqiAyV5Swah2JbOM07So17yJSORIW0LJaPTL7oDZLFjPldyz1OjLbrCfgjffu5zUG xf5xgDfCRlyVvvE1Pxsxa4hIJhBXVUC18APflAvoFNScR+R+jAiAO3RDCIfz7PZ5LIHL t4vkH1rh/+2MJf51vO1xXEp1NTTynU/lqKz7OYJmBCnUWrDRHymJzW5TmfFZsixJMB8f 24Cg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=t5SKFRy/NGGxTSHjVbUzpa7OYlt8D69a1EKWFggm+ak=; b=PtRtmfb2rlqmWMelv0qlz22gG6Fn7ozAlA2U7WbABnL0NrGWg3WKEc7qP+o4HwD/q9 cQ3yCcaFgiTCbImCUZILYnlhBswNzV0NmF1wtjZ7uYg0wa/X/itk6jgWC2mip4kmZBHI F2ohxBJs0KwxHQWn96cqZw2qphc/dZvtojVoVRvIYu324B0iVRbfOTv1RfnKVPXyy1JM 0wzgsbN04L04cG41Lam7ANo1ZiSGOJArhEbaZidHDcieTqDnT0VkVXmtkNhRR9B+FWbE tV/VMrT1WkLiGMqJJ+XAoyh6QRnt+HmpqvcsAnw304Pl0uotzckObJ3E59Q/h9OsUW// 4mfA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ryEFa27h; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=t5SKFRy/NGGxTSHjVbUzpa7OYlt8D69a1EKWFggm+ak=; b=HGek7qir4n79375PM1wLUI7mjU1AC81eChOie6s7JOV2nbR6h04/Rjl4aGh6W1wox3 ogPnNTxgZH7vLPHBkiqHdVzAyIGukGncDk5FbDnIOevi04rYlm26V/z1ydS17uqyC/rC 2Lmg+uns2N3VOYqtpMDoHmQoHoUBkVmoWplrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t5SKFRy/NGGxTSHjVbUzpa7OYlt8D69a1EKWFggm+ak=; b=UAn53fq9G+Jz9Qocyy3+H8VzlTQWq47OJZvKhLQyy6H9rMvIv6+LLjDY7wiu5zeGYc KVw7PSACsQx4yMlWgMttpXmRqUMStSEpEhqBqPfbhAPVM5abFEQoqaiNSFhsoSgbz75e km4EU++Rb+rlKa+MCZ+oh3VWCoinx69oxluScNawgOcbS81wNrpnCKK4QevmYKSQSK+r WfMQQTrHcuxYc1fAmPckA/ys6bZN0cWcokPnOnhAmvV0OH+swp0pjoqMiDeyHgOWaNah fUWuX2wFB51BcjG/C5ogE6pMlR7yVTAAKmESPAdGsFwbLWQDo1jM6JNHpf6hwpLQZL8w WSIw== X-Gm-Message-State: ANoB5pnhrs2gnEM/T6E/nj7h3FdmoUoR0U/mIDaZOWWYFjsVHeF+k6JI Ww92EENfRLK535Gigbm2RsYF9F/K X-Google-Smtp-Source: AA0mqf7exlC7ouI3+TIrpIjmSFr/HfQcg6FHO28NOerJpYBt0mDi/9owxmzv6BRP5ogL4eTbgpE+3Q== X-Received: by 2002:a05:6a00:4009:b0:563:2ada:30a3 with SMTP id by9-20020a056a00400900b005632ada30a3mr79265564pfb.27.1670599553567; Fri, 09 Dec 2022 07:25:53 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:ed49:b0:178:3881:c7e3 with SMTP id y9-20020a170902ed4900b001783881c7e3ls8465504plb.11.-pod-prod-gmail; Fri, 09 Dec 2022 07:25:53 -0800 (PST) X-Received: by 2002:a17:903:204d:b0:189:6453:f455 with SMTP id q13-20020a170903204d00b001896453f455mr5069119pla.35.1670599552734; Fri, 09 Dec 2022 07:25:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670599552; cv=none; d=google.com; s=arc-20160816; b=cRT9+zldBB57BxJVg48sISiCbTCtlpAUXodMbe7t5DifeywyjH5XSN3h44a1LFbr9W z/3PvDtupH8iLcbdv6VTDNzI6V7+oQMXxlpKZd7dvGsFSL5gFJd8rX1CIcQTWTPi243a yIiVMgPsroJt2su2fVGGUjDpVId/uDcqaTP1bXIe7RMLwolopo0X/Ytwa2bSgcFt6qSe Voz7NYF6o0CXFeRahZR5S9abzQ+SP1SUSA3SJFWAm5h/3lhmyuYBhn4ikOMk0bCrq5uu TDm43Q1UKxK1zt9hJCcOBcwOOsmB1Co6xmh1mwF0ZaaXOjJG4ErG+TNvuHIwVFIld95I Z3rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=LFDauSpXdcfcdulBlIlfj04e257Z0kmZtXLY+iJX2Pg=; b=OngnzR1N/PhgsYAUwF1SDUCjgAwZkti7PFGRxM3PUUHvIV7izNZjHU7hxiTay5DrxP UHeR5y3lb50ODBeVxBAyeWCw7AaMMngRG1EFeO7e57s1XvWtuDDmutQFEPuZd6Rl9wVu w8QcL9LVcHFZRkKdpd7+Zd3hm3byH7CWc6kx1KS7oaF0WiCDYZ+UZThd+0Znx7nsmM11 gMyDiq2EBkF/E6qNQBVN6oDCVKRQMj8AtizUOOknWIKRqwfyGAnWjv6B3wKrg+W9YQXQ AcUJ9cRFjjD9QJA9oFMx/fq3XaaogM6IzlkzTeF5f7wkJPhJbOIPSyhpsS6h1TbPGYkE 8vQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ryEFa27h; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id y20-20020a170902e19400b00188fd910157sor1052582pla.107.2022.12.09.07.25.52 for (Google Transport Security); Fri, 09 Dec 2022 07:25:52 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:e787:b0:187:1d13:f6d1 with SMTP id cp7-20020a170902e78700b001871d13f6d1mr5927784plb.52.1670599552412; Fri, 09 Dec 2022 07:25:52 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:6ba1:bbda:c542:ba0b]) by smtp.gmail.com with ESMTPSA id x14-20020a170902ec8e00b00188c5f0f9e9sm1477587plg.199.2022.12.09.07.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 07:25:51 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki , Nicolas Boichat Subject: [PATCH v9 05/18] drm: exynos: dsi: Properly name HSA/HBP/HFP/HSE bits Date: Fri, 9 Dec 2022 20:53:30 +0530 Message-Id: <20221209152343.180139-6-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221209152343.180139-1-jagan@amarulasolutions.com> References: <20221209152343.180139-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ryEFa27h; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , HSA/HBP/HFP/HSE mode bits in Processor Reference Manuals specify a naming conversion as 'disable mode bit' due to its bit definition, 0 = Enable and 1 = Disable. For HSE bit, the i.MX 8M Mini/Nano/Plus Applications Processor Reference Manual named this bit as 'HseDisableMode' but the bit definition is quite opposite like 0 = Disables transfer 1 = Enables transfer which clearly states that HSE is not a disable bit. HSE is named as per the manual even though it is not a disable bit however the driver logic for handling HSE is based on the MIPI_DSI_MODE_VIDEO_HSE flag itself. Cc: Nicolas Boichat Signed-off-by: Jagan Teki Reviewed-by: Marek Vasut --- Changes for v9: - new patch drivers/gpu/drm/exynos/exynos_drm_dsi.c | 33 +++++++++++++++++++------ 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 50a2a9ca88a9..b64bb6006b7d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -75,10 +75,27 @@ #define DSIM_MAIN_PIX_FORMAT_RGB565 (0x4 << 12) #define DSIM_SUB_VC (((x) & 0x3) << 16) #define DSIM_MAIN_VC (((x) & 0x3) << 18) -#define DSIM_HSA_MODE (1 << 20) -#define DSIM_HBP_MODE (1 << 21) -#define DSIM_HFP_MODE (1 << 22) -#define DSIM_HSE_MODE (1 << 23) +#define DSIM_HSA_DISABLE_MODE (1 << 20) +#define DSIM_HBP_DISABLE_MODE (1 << 21) +#define DSIM_HFP_DISABLE_MODE (1 << 22) +/* + * The i.MX 8M Mini Applications Processor Reference Manual, + * Rev. 3, 11/2020 Page 4091 + * The i.MX 8M Nano Applications Processor Reference Manual, + * Rev. 2, 07/2022 Page 3058 + * The i.MX 8M Plus Applications Processor Reference Manual, + * Rev. 1, 06/2021 Page 5436 + * named this bit as 'HseDisableMode' but the bit definition + * is quite opposite like + * 0 = Disables transfer + * 1 = Enables transfer + * which clearly states that HSE is not a disable bit. + * + * This bit is named as per the manual even though it is not + * a disable bit however the driver logic for handling HSE + * is based on the MIPI_DSI_MODE_VIDEO_HSE flag itself. + */ +#define DSIM_HSE_DISABLE_MODE (1 << 23) #define DSIM_AUTO_MODE (1 << 24) #define DSIM_VIDEO_MODE (1 << 25) #define DSIM_BURST_MODE (1 << 26) @@ -804,13 +821,13 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi) if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_AUTO_VERT) reg |= DSIM_AUTO_MODE; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSE) - reg |= DSIM_HSE_MODE; + reg |= DSIM_HSE_DISABLE_MODE; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HFP) - reg |= DSIM_HFP_MODE; + reg |= DSIM_HFP_DISABLE_MODE; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HBP) - reg |= DSIM_HBP_MODE; + reg |= DSIM_HBP_DISABLE_MODE; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HSA) - reg |= DSIM_HSA_MODE; + reg |= DSIM_HSA_DISABLE_MODE; } if (dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET)