From patchwork Fri Dec 9 15:23:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2529 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 721E73F039 for ; Fri, 9 Dec 2022 16:27:21 +0100 (CET) Received: by mail-pl1-f197.google.com with SMTP id u15-20020a170902e5cf00b001899d29276esf4484108plf.10 for ; Fri, 09 Dec 2022 07:27:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670599640; cv=pass; d=google.com; s=arc-20160816; b=pnMjOc+m2AVODDU16YinjIE3G0Dy5F1BS4zRZOMadOe4y6gi8DYD4mQJudVQsAVdf5 udtSsXeWbYCMZTfdeTbCkzVhr4wUjTCLjNl0bi50qQL2xGTlj42l9hXGYjjxE8zVGmv4 4RHwNcjHWiFjyOEO3fBxv1e8RvK1JXUHRHmFJNuTRlfEyHvIJSs+40zIcSWgmnlF5u0K 0els+KRt2rFJl2Kto5GPtkZJVW+wwecTCrheurUzbbrDllOMG4aYVXTZJR6yJ/xu9FGY 10GN/v9T1YBoAq3xlgzz+i6V89x+LHYP1RPumFImoJ2V5E2UKor0xl+WayC4ibiO5iG2 v3pA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Furx0D00ZaE/Fumh1IxyzJyF9srZhYJARbXuVPq4yjw=; b=C+vNbF5+M3qQlEb2IOY5wIHteUuONuFvyQW3cyGW2PEVo+xtRs09vRNAxaguBdcIsA WVEz4lWjholYZdB7Ebc1lWp+R39UWgVqFEjK+JG+gEJQg4jAZXcDXJ5+P+dmxX58xkzU w0X1LMUc9gpgNsqKsmf8FG6glUWvuNLAJw86gECZ8wl6xtEUcbyYhQ+zv4DhYXKOZvYD qTBzFtlkejGDFVAKvQadJQqdAc4Klws4IVCHUTcEEwTgqjPo45dXVo5DqA8rYukICaKj 74/3JHnVdsAFZsSF810Ip7ftpzP4LTd7Zwb7jWd2HUwbbpkjel4c/9+rbQ1SQwjgXD87 Ab8A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ckqoKKbe; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Furx0D00ZaE/Fumh1IxyzJyF9srZhYJARbXuVPq4yjw=; b=RxzJjjxwTcHfMwveAm6C8HleLEmO6iFgKzl1Ks1+DNFKDp6uTntQVmP7ij9OIQmRGs ZqRhu36V5t/2jE6+cAoJqtiQoQekx6Y/z9jL+sNvUl1scs9X5c3zsGiVz3jRmVCFj8Dz 7fJdvWMRns159EO+LYFSp1Yo3Z/3+C1DFxqW4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Furx0D00ZaE/Fumh1IxyzJyF9srZhYJARbXuVPq4yjw=; b=6G6iWre9gKfPukHiD8iEdBF+rUUls2Afmyxby7TNleS0kQVbJDRBZZfSL0w827WWug E8LZn+A8D3PDUzhrA/93nsg+YXazHZ7ap9GzfAK90MLWTfjZGE2Maoq1Gdz/C+ma047l gN8fFQeuIDbcLmFJ1O4GqV8b+jZUwekAzR7vHApvFfT1pwJrin/wdFjmiB07/EvE675F JogM+tuBVY9khb3bh99kPvRx98ftweF9GjU5Yk4pJE6KwODYtBjhyZJ8yicHz1j78KjH Cd7MQrUKeZk+DFGU7L/6hc2w4ACAtwjRJtE9I8oWRNsobwq/0fhwLp9q5/k0Due3pS/O Lq9g== X-Gm-Message-State: ANoB5pnbaV7+X0MKglO6kxUz3m3PxN1bn4I04Iaxgy5ohhsKwV9CAJF+ +iQjCR/rJRikhhgWejzSk8IekOeT X-Google-Smtp-Source: AA0mqf6Huuk1SzI2idoXDxEnFnNFenP0689STzRJC1+lgzfHuV9BxwbYKAHxXFtRqjOC2mo0LKURVQ== X-Received: by 2002:a17:903:32ca:b0:189:9031:675c with SMTP id i10-20020a17090332ca00b001899031675cmr48230952plr.139.1670599640272; Fri, 09 Dec 2022 07:27:20 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:e305:b0:186:af8a:6095 with SMTP id q5-20020a170902e30500b00186af8a6095ls8494013plc.4.-pod-prod-gmail; Fri, 09 Dec 2022 07:27:19 -0800 (PST) X-Received: by 2002:a17:903:3255:b0:189:acbc:f031 with SMTP id ji21-20020a170903325500b00189acbcf031mr7167792plb.22.1670599639326; Fri, 09 Dec 2022 07:27:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670599639; cv=none; d=google.com; s=arc-20160816; b=CiqQ6giLSSD7oslHDx0oIA6z7sOJUR18vUZ620/8Zt3adoBwO0FYxV0QewczCjAG2H SxmtKlT46xIHBGBVcqAKKdoW3qipR5Mt2GKy+MLLs6LtwrNnHUoxmun0wUfq0lvA0Jgj W/4k/xJMKZzOrFOEfpsODNJSqgOC++GJF0TTM4cLZYjc83FWQEsNx0TwDDYvE96cYuYu mr7l2VPbpvY/mWso7tdthZpztdLOmvWbswOQpJdYnMzPdshnylvzJb0HN/vWpokeOxYG jjPhYH64fxZ9ZIxMpmiOh1XIWVGgZ6l6wbptGYKwPC3EP6OQdKvc5bq/bmq4wZv6qykE W3QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=dwbU4HbazHtFryGlvubFfUrK1mgrKcuqi1e+gJ7LS7g=; b=TdypgRx1BvE2+hiXy2Bl6Rtg0KZM3QPC0Ze+5psrGiaozB3fiyiNkO9ttceKXk8Ztg +ZAsylTEBxqiA6wJSUISIZ+DenCopdhLgMUTWW7p8cRXzFXcP0wfuKoLd06RcqpJQXfb HGDoZFAWDu1ljWUBzejwnc3E0B/QbAyMijVbCAXoS6yvgFptZTNKvezGIFoVU/zgbfhM tpipSRHK5iHUzX0jtA+3LMWqN17lfSy2jOPNdXcX5Q8AxMv1SgGS7VdpoSRgWpT+djSR sslxcboC11CEjpYqwsO6cu0ipk5tQ2GDxtx20IGLwsXzikKMi4Oon/BQzGndEYdD2QAW wq+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ckqoKKbe; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 17-20020a170902e9d100b00189b72ef027sor1039184plk.108.2022.12.09.07.27.19 for (Google Transport Security); Fri, 09 Dec 2022 07:27:19 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:ce08:b0:189:d2e4:9829 with SMTP id k8-20020a170902ce0800b00189d2e49829mr10001128plg.15.1670599639006; Fri, 09 Dec 2022 07:27:19 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:6ba1:bbda:c542:ba0b]) by smtp.gmail.com with ESMTPSA id x14-20020a170902ec8e00b00188c5f0f9e9sm1477587plg.199.2022.12.09.07.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 07:27:18 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer Date: Fri, 9 Dec 2022 20:53:35 +0530 Message-Id: <20221209152343.180139-11-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221209152343.180139-1-jagan@amarulasolutions.com> References: <20221209152343.180139-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ckqoKKbe; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The existing drm panels and bridges in Exynos required host initialization during the first DSI command transfer even though the initialization was done before. This host reinitialization is handled via DSIM_STATE_REINITIALIZED flag and triggers from host transfer. Do this exclusively for Exynos. Initial logic is derived from Marek Szyprowski changes. Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- Changes from v9: - derived from v8 - added comments drivers/gpu/drm/bridge/samsung-dsim.c | 15 ++++++++++++++- include/drm/bridge/samsung-dsim.h | 5 +++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 2e15d753fdd0..ec3ab679afd9 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1254,6 +1254,19 @@ static int samsung_dsim_init(struct samsung_dsim *dsi, unsigned int flag) { const struct samsung_dsim_driver_data *driver_data = dsi->driver_data; + /* + * FIXME: + * The existing drm panels and bridges in Exynos required host + * initialization during the first DSI command transfer even though + * the initialization was done before. + * + * This host reinitialization is handled via DSIM_STATE_REINITIALIZED + * flag and triggers from host transfer. Do this exclusively for Exynos. + */ + if ((dsi->plat_data->hw_type == SAMSUNG_DSIM_TYPE_IMX8MM) && + dsi->state & DSIM_STATE_REINITIALIZED) + return 0; + if (dsi->state & flag) return 0; @@ -1467,7 +1480,7 @@ static ssize_t samsung_dsim_host_transfer(struct mipi_dsi_host *host, if (!(dsi->state & DSIM_STATE_ENABLED)) return -EINVAL; - ret = samsung_dsim_init(dsi, DSIM_STATE_INITIALIZED); + ret = samsung_dsim_init(dsi, DSIM_STATE_REINITIALIZED); if (ret) return ret; diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index b8132bf8e36f..0c5a905f3de7 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -17,8 +17,9 @@ struct samsung_dsim; #define DSIM_STATE_ENABLED BIT(0) #define DSIM_STATE_INITIALIZED BIT(1) -#define DSIM_STATE_CMD_LPM BIT(2) -#define DSIM_STATE_VIDOUT_AVAILABLE BIT(3) +#define DSIM_STATE_REINITIALIZED BIT(2) +#define DSIM_STATE_CMD_LPM BIT(3) +#define DSIM_STATE_VIDOUT_AVAILABLE BIT(4) enum samsung_dsim_type { SAMSUNG_DSIM_TYPE_EXYNOS3250,