From patchwork Fri Dec 9 15:23:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2530 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id F39273F039 for ; Fri, 9 Dec 2022 16:27:30 +0100 (CET) Received: by mail-pl1-f197.google.com with SMTP id u15-20020a170902e5cf00b001899d29276esf4484392plf.10 for ; Fri, 09 Dec 2022 07:27:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670599650; cv=pass; d=google.com; s=arc-20160816; b=zXyJVjO54qoUNoA9jGu8ToXEUg8cu4C51hpUM5Wb1c+VU0vAqyMtvzScDZowznk8uF qUi1LxqhZ5XhZdrgiLxy703BBATZEbNcaHMtibsaFq4lwMV8OvNk7fq3eTgQaGuti/0P SD00vrbdF/0TdjOC82QPRKQKlj+f1DmcYyGnfCrdjx+4bKBog+h2TYTFtnoQ0gLL/FXW BTk89pStC5qPFxXvR4r4MwB5i8Hr1VmQK+aiCqXez8+Ou2G6GAlEVfu9rq2OXJ5pI3lV CB7C9Ffwjux8oKhoz68G3hHXIEjO266WN9IHu4dQemWa5qKf5JCIDhCgXcM6hyHo2r2S KrYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=6Ja3dCE9kw2Y8fgNGxq2W4D1AcA9G74xqAqL1JyWdUQ=; b=aC+z4ec3RH0c1fyZzKbLb7d+orcLkjs/fGPO6NuCQZsPsWJ2o0kh+5d4HuLf/W0PTR pFVTwvKBucwdIsKvDQvkNRamyI3Yd2/UNFSk+iUpq+uKVpAVA36W9YIDTBPqPaS8u0jq xhVSAh7mNzKdA+l14Y341wAgU5YPg57df2cIO94X0mdIoB5WrtV2RS7wf5YAJ6Aa69PX UjKge76OIJS6gO8WNnyxOLWKg3JEMw/DjHCD4EWpMxe9gJcFNDSnlWB7qXRyGu8FXQ/t +HJlkcwSJtp6PlXN3Wjgz8HZF5O8QaXF9GOSs8+DRnShfBaycE4mqW71HSfPuPhFq+TX BBJg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nSJNeITl; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6Ja3dCE9kw2Y8fgNGxq2W4D1AcA9G74xqAqL1JyWdUQ=; b=eS1xDPnakA+XQ69QLxDk2AjEZSg5Dvy0OzbifCUBiI/WvALwOZdpLKjvtAzaeycxuc 1pS3jfhg1jXx7yDA0EcWZturBnyXUoV1AfijCKheTPlYCUOs14fiCwgvruLyzd7DJHB7 Xi1Y3/de1L4OBLRAzfCAp/0JYNZgA4wCKvN70= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6Ja3dCE9kw2Y8fgNGxq2W4D1AcA9G74xqAqL1JyWdUQ=; b=a5QC6NVCZNS52EsJlkJ4LDQpPvtmiMIZI89ebbH217/Q5WmGyFJtYB695BoJDoaUqH 0Qxj98f/xcuJCQQWN+vy8lBPi4N6LkTVAJBMixk2EflUldZxY/IiW8JR5tiJO4JMF+Qy ULxhA091G+1yZole4Jmb1k4sx9pJN0oj/QtcQ+LRJqr+TPq18yrhgIH4w5p1x0hVAkFa nB2Z8B9m9Gx0NrGsQ0M0U1i3GoyfzSJjN4tm9oun4RwGg76BT4T5n+XIBkTXuV1XFMyi 0y/L+q1e9ElG47An6C4mZcSHcBlY7FhvmA+zwGDom8jxuMBEpvU9fvxY3vMurYqoNpTn IdvA== X-Gm-Message-State: ANoB5pnjo9sMIZeSbp/FXHbvRSM84vRsNcfZm6H8pM5UCBeAMo3VgM5B iQJm6HApPRAf04QqNKdK9pfRX6Eg X-Google-Smtp-Source: AA0mqf7qFQJF/Wvq7nJ2eL+0K2tNt3P6Tn98xqiEyJMqWKGqKTm9HKnK86OmFi9S8hRK3eVQM/6Lvg== X-Received: by 2002:a63:592:0:b0:478:ab04:f293 with SMTP id 140-20020a630592000000b00478ab04f293mr18851685pgf.345.1670599650631; Fri, 09 Dec 2022 07:27:30 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:903:2151:b0:189:33cd:635 with SMTP id s17-20020a170903215100b0018933cd0635ls8489295ple.5.-pod-prod-gmail; Fri, 09 Dec 2022 07:27:30 -0800 (PST) X-Received: by 2002:a17:903:228f:b0:189:ec2c:bb0c with SMTP id b15-20020a170903228f00b00189ec2cbb0cmr9059711plh.28.1670599649751; Fri, 09 Dec 2022 07:27:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670599649; cv=none; d=google.com; s=arc-20160816; b=qOd5i6nmIYh5PEam8dcD8VlXWMB4/9Z0na6FDIH5qx89+bu456xFlAROyZtmO6d0tj hHS9wqzqxy9mwMlUdniPG9AtZk4rJicJ/v6vISxQAddDE64m5B6kFZvQbCrmEI8RjBl8 1mFC6hIP3WgBbM3nFQsa4WYVIfUWFca6fTT61dqAuTLTS/a4aPWOD8ZR6u7ycZeHh41P tvqOv7Z/OR1c3+Wva1IPnIXXIBvImhFkhQeKZQ0CQE3+Hbty9vZRFzwBSmHWwAejLeHZ UmyPwjeZwRe+QuOPdTO0OI96TjzRlAnq2LkXrB6FYF0VVhQm9Wo+GYx+4j1ZsVoHylnF VUAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=OfCnS0osLOS8xaWpCmO4LYnynxznfz+nnT8/dn7VQfk=; b=UMiSKl/xB4aROrCuRN4Gwf9wxYLkyDWlQPwyA+pqr+912MOWypc+bbe9NDeIX5j44K 3CHv/zNK7MjwNthFLySn6pgKvvA8j8gGYj1THKZ5XkyhKhqhDnZdLlixxRnmNEbYlcU8 GvBC7rxaXbUq68U9YJXBrmFtVD+cPtEOLOE3gSBN4n3TMcM0Bw+HmM9XnyxLjkfinDet G6FDRkEHeVzg6NpSHan+CFjbFDr4WMGEH3YY8E7bxpA6epaoKgWvToMXuHmIt7gIdgNI Rnfh8wqmf8hUYvSFs058qzGfUMNFdhtV+7P5Z9RrxiwnjY+fEyLtl5nO/IAtwp16AgDv 41FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nSJNeITl; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id j11-20020a170903024b00b00189b8a2064fsor958034plh.177.2022.12.09.07.27.29 for (Google Transport Security); Fri, 09 Dec 2022 07:27:29 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:e807:b0:189:63be:8acb with SMTP id u7-20020a170902e80700b0018963be8acbmr8774321plg.59.1670599649351; Fri, 09 Dec 2022 07:27:29 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:6ba1:bbda:c542:ba0b]) by smtp.gmail.com with ESMTPSA id x14-20020a170902ec8e00b00188c5f0f9e9sm1477587plg.199.2022.12.09.07.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 07:27:28 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v9 11/18] drm: bridge: samsung-dsim: Add atomic_check Date: Fri, 9 Dec 2022 20:53:36 +0530 Message-Id: <20221209152343.180139-12-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221209152343.180139-1-jagan@amarulasolutions.com> References: <20221209152343.180139-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nSJNeITl; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like an explicit fixing up of mode_flags is required for DSIM IP present in i.MX8M Mini/Nano SoCs. At least the LCDIF + DSIM needs active low sync polarities in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work properly. On the other hand the i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020 says. "13.6.3.5.2 RGB interface Vsync, Hsync, and VDEN are active high signals." i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 3.6.3.5.2 RGB interface i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 13.6.2.7.2 RGB interface both claim "Vsync, Hsync, and VDEN are active high signals.", the LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. No clear evidence about whether it can be documentation issues or something, so added a comment FIXME for this and updated the active low sync polarities using SAMSUNG_DSIM_TYPE_IMX8MM hw_type. v9: * none v8: * update the comments about sync signals polarities * added clear commit message by including i.MX8M Nano details v7: * fix the hw_type checking logic v6: * none v5: * rebase based new bridge changes [mszyprow] * remove DSIM_QUIRK_FIXUP_SYNC_POL * add hw_type check for sync polarities change. v4: * none v3: * add DSIM_QUIRK_FIXUP_SYNC_POL to handle mode_flasg fixup v2: * none v1: * fix mode flags in atomic_check instead of mode_fixup Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index ec3ab679afd9..c79f7dc49e17 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1342,6 +1342,32 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +static int samsung_dsim_atomic_check(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state) +{ + struct samsung_dsim *dsi = bridge_to_dsi(bridge); + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; + + /* + * The i.MX8M Mini/Nano glue logic between LCDIF and DSIM + * inverts HS/VS/DE sync signals polarity, therefore, while + * i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 + * 13.6.3.5.2 RGB interface + * i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 + * 13.6.2.7.2 RGB interface + * both claim "Vsync, Hsync, and VDEN are active high signals.", the + * LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. + */ + if (dsi->plat_data->hw_type == SAMSUNG_DSIM_TYPE_IMX8MM) { + adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); + adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); + } + + return 0; +} + static void samsung_dsim_mode_set(struct drm_bridge *bridge, const struct drm_display_mode *mode, const struct drm_display_mode *adjusted_mode) @@ -1364,6 +1390,7 @@ static const struct drm_bridge_funcs samsung_dsim_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_check = samsung_dsim_atomic_check, .atomic_pre_enable = samsung_dsim_atomic_pre_enable, .atomic_enable = samsung_dsim_atomic_enable, .atomic_disable = samsung_dsim_atomic_disable,