From patchwork Fri Dec 9 15:23:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2531 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 9EB7C3F0CC for ; Fri, 9 Dec 2022 16:27:50 +0100 (CET) Received: by mail-pj1-f72.google.com with SMTP id pi14-20020a17090b1e4e00b0021d20da7a51sf3026852pjb.2 for ; Fri, 09 Dec 2022 07:27:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670599669; cv=pass; d=google.com; s=arc-20160816; b=uIx14HNGVpMnI6UiSQ5IeyuUZYa0qwwDQ/6m1LkvX8WnskYiMTm1bWrB0oLT1GofYi TB2k0Sh2ArXtJ5/ZQKagnQqCmAIII5ch04KpVANRvtUj3Km10mU9ZNoblLJ7qhcZFdyq jxFmS3L74Oj0ivucQ/bsOGYkePFoQToFSX8whLVVEnX4Atvifm3uIVy3IaarTon3ah8h IXCY+gGD0+v/QRd8blNGkeHSXnBmUdopivXEwhBSkE9BUMDT+0PfVsE3Qu9XhFy8rim6 nw4W+eGSypmQvcIBAeQgCTOSZenAUwZ4uZYB6nhBayHNx6iHRzcRFg4vBGeyKi2AMikx 9TTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=54MMU+j0ZwcJ8N07rlINsZLO1yTsAobn1Khb7ij8UmY=; b=sGQZRl/sZu2R0xXQ1pImaSCcdbI80nJ2uV34ed0EggdFQ/hSEmLvqgF2Vjy33QemzD zv5Rzvn+qGGHHlET7Js4tBscc2VcegjZVOvVh4ofnDbTYAhVLDh9L3BJ86EqxqnZm2u9 ZUFRR1Vu50prtFNIVm/yco4fEbK1jXuXIDy3nSxAQU0LhoKFIOrVpxCqsswSTncWKa5h T6aWSAmeMdxueCAbrX9l6i8zjLxRl7y6umONQfg2YEL21Uq9xSQ9NbXaoXeVXwt8Ryi6 4Fyqeq9fv4ajgaob85a/dT9WST7639sVCYn3B4z9SgwlmwUl//nvY1RehTNKnj953Ou5 fJbw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NyjM87Fw; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=54MMU+j0ZwcJ8N07rlINsZLO1yTsAobn1Khb7ij8UmY=; b=SgoGnA/4wPDvg/C5ERx90EqcsrkR+S7T349W5Szj2OLsSQ/q7KWdFkWHCxlEXdXTeE Vs10sgtu2SZ0jOSo0jf5MDby1eqDf02uADUJE34//LPJr1ZWiF0DYLDOweny/ovNREBV vk2gNy/BbG9iOXCMKe2srEM2i8ZdwuzPyAFU0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=54MMU+j0ZwcJ8N07rlINsZLO1yTsAobn1Khb7ij8UmY=; b=rho48jQtX3rsCObxFt7tJ631krQLZEOgs0uyp1cyeKR+v2EB+gD8yTURhQsE9Yqjj5 qgM95qlrBZ5TSSOKD5ftvbYL3PMJWtCG9hp4A1Dt020Szuiumm+NsLaEWMWqP+/Y57o3 8UPidgPcOPac/AQB6KcAEJ8/w2z/3AUFBF4LirNdMCGslBooUE+4NQQT6S8meJ3NzuYR 4wDpag2UXvGgPo3fVbtIGfSIp+/xpPw3jfDu2umsfI0V/DJteNMWoGcUEWnyAPcXi8wV TT3FNguDCqU6/IBnLX8ZmQWH4Yl17uB/occo/M9IndbmXJQho7BHhhftHYLNJjwk5ofq 8f6w== X-Gm-Message-State: ANoB5plPrKRDglwHz/wDeM9S9UBIY5UDGxgwoJHVZVDs8hQ8w7Tx+Cy/ RXlJ/IGh158qwTEv2ofoC8cH3rUe X-Google-Smtp-Source: AA0mqf6+9FCsNSI5jTUIBdJ56lCjDfQB0hzN4E0XFs+vtildckt0foF8/cXByvOu+0D8KYSmsdmKrQ== X-Received: by 2002:a63:d043:0:b0:478:d3a9:1f30 with SMTP id s3-20020a63d043000000b00478d3a91f30mr12708371pgi.367.1670599669364; Fri, 09 Dec 2022 07:27:49 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:ed49:b0:178:3881:c7e3 with SMTP id y9-20020a170902ed4900b001783881c7e3ls8469090plb.11.-pod-prod-gmail; Fri, 09 Dec 2022 07:27:48 -0800 (PST) X-Received: by 2002:a17:902:8548:b0:18c:fd25:a934 with SMTP id d8-20020a170902854800b0018cfd25a934mr1322403plo.61.1670599668446; Fri, 09 Dec 2022 07:27:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670599668; cv=none; d=google.com; s=arc-20160816; b=kEq97Wiqr711tqiRBL0LtuSglRAEjwZ6NEeHry2r8vzWZzWWCeFaD6hvg66a87+QBx 5KDRqHWrQ1fKVeAGB3+s1vTWxnb5USxSR0MXObHSvD9V++SsKR71WeLqM8LPgfst/uL1 diysjadVS6I/E8hia5e7jB7+D2mGuYAOO7S4s6KxpIm/QpPKrHkrXSw38TtupZ/9871W h2l8Cx5mjD+0KABMwlWVtXtxKwwMabu9MOodUgZGsyitM7vULz4GNWxK1tXNgmFZUv9h qT5MqjNr/vSI1oSYrR8uVKe15nPYYtqj3jwPxmC8lws0NoGHiMWqa/b423SVXJzPMDg0 /pNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=vW9M8s0Vbvr7hHyCYd21b5KP7VTw4GLG2GncUlEkbew=; b=Qv5R7/dqP9Oy/GUJp/Cseb1ANJ0uXxiYHTATVJpDepNWGow258bsg3d8wSFoylB+9Y kqw0uoit6PrqzjCchiajwcoBheXvJlK5c8aTuy4iKFc5NV/Rzxt3MgI9Ish41V4vLbq7 I/u7xTKoqAoRttVgfxCEocWXta0lE/AT+xvXij+9m30fUhtFZcUurqfjVp6V62Vo2jAz hUQB1K5zDq0xZkSaWFmSPB269VcUZBqGTAdKYCpxfiAs+q87n6Eg4KAcP2bXQopKDHzI 4GWcd1lLbSWEQBhRHbMfef4/XzbHsrx3wk5EfQPFuT7nvl1DbizjdUuR0lcJ71JD2J9E DvKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NyjM87Fw; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id u12-20020a170902e20c00b00189e9b885b3sor1009926plb.172.2022.12.09.07.27.48 for (Google Transport Security); Fri, 09 Dec 2022 07:27:48 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:e743:b0:185:4880:91bc with SMTP id p3-20020a170902e74300b00185488091bcmr7928096plf.60.1670599668115; Fri, 09 Dec 2022 07:27:48 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:6ba1:bbda:c542:ba0b]) by smtp.gmail.com with ESMTPSA id x14-20020a170902ec8e00b00188c5f0f9e9sm1477587plg.199.2022.12.09.07.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 07:27:47 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v9 12/18] drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset Date: Fri, 9 Dec 2022 20:53:37 +0530 Message-Id: <20221209152343.180139-13-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221209152343.180139-1-jagan@amarulasolutions.com> References: <20221209152343.180139-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NyjM87Fw; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like PLL PMS_P offset value varies between platforms that have Samsung DSIM IP. However, there is no clear evidence for it as both Exynos and i.MX 8M Mini Application Processor Reference Manual is still referring the PMS_P offset as 13. The offset 13 is not working for i.MX8M Mini SoCs but the downstream NXP sec-dsim.c driver is using offset 14 for i.MX8M Mini SoC platforms [1] [2]. PMS_P value set in sec_mipi_dsim_check_pll_out using PLLCTRL_SET_P() with offset 13 and then an additional offset of one bit added in sec_mipi_dsim_config_pll via PLLCTRL_SET_PMS(). Not sure whether it is reference manual documentation or something else but this patch trusts the downstream code and handle PLL_P offset via platform driver data so-that imx8mm driver data shall use pll_p_offset to 14. Similar to Mini the i.MX8M Nano/Plus also has P=14, unlike Exynos. [1] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n210 [2] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n211 v9: * none v8: * updated commit message for 8M Nano/Plus v7, v6: * none v5: * updated clear commit message v4, v3, v2: * none v1: * updated commit message * add downstream driver link Reviewed-by: Marek Vasut Signed-off-by: Frieder Schrempf Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 10 ++++++++-- include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index c79f7dc49e17..9203116f1efb 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -184,7 +184,7 @@ /* DSIM_PLLCTRL */ #define DSIM_FREQ_BAND(x) ((x) << 24) #define DSIM_PLL_EN (1 << 23) -#define DSIM_PLL_P(x) ((x) << 13) +#define DSIM_PLL_P(x, offset) ((x) << (offset)) #define DSIM_PLL_M(x) ((x) << 4) #define DSIM_PLL_S(x) ((x) << 1) @@ -384,6 +384,7 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -396,6 +397,7 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -406,6 +408,7 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -417,6 +420,7 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 0, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5433_reg_values, }; @@ -428,6 +432,7 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 1, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5422_reg_values, }; @@ -559,7 +564,8 @@ static unsigned long samsung_dsim_set_pll(struct samsung_dsim *dsi, writel(driver_data->reg_values[PLL_TIMER], dsi->reg_base + driver_data->plltmr_reg); - reg = DSIM_PLL_EN | DSIM_PLL_P(p) | DSIM_PLL_M(m) | DSIM_PLL_S(s); + reg = DSIM_PLL_EN | DSIM_PLL_P(p, driver_data->pll_p_offset) | + DSIM_PLL_M(m) | DSIM_PLL_S(s); if (driver_data->has_freqband) { static const unsigned long freq_bands[] = { diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index 0c5a905f3de7..df3d030daec6 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -53,6 +53,7 @@ struct samsung_dsim_driver_data { unsigned int max_freq; unsigned int wait_for_reset; unsigned int num_bits_resol; + unsigned int pll_p_offset; const unsigned int *reg_values; };