From patchwork Fri Dec 9 15:23:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2532 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 96B763F0CC for ; Fri, 9 Dec 2022 16:28:12 +0100 (CET) Received: by mail-pg1-f197.google.com with SMTP id g1-20020a636b01000000b00479222d9875sf697508pgc.12 for ; Fri, 09 Dec 2022 07:28:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670599691; cv=pass; d=google.com; s=arc-20160816; b=gKqaXxO7fAJjQCf+zoEQJ91TdeA7mXiYN7Co8NvJRvQSfNKKIa/TKZZkqEzBGIFp/7 W74UeuXzcxYxgMHZeV8XejxVB37tLYLkIajJaOjXtLBRthfr/xToxWT8PSCazYVL97cu 4l2fBqlnxXjEoUmQqP1Xog89XNVNB2WNFabmYedcsOFHAJHW3Fdo3Czqy3+VHyrozIG4 F7EdoPejElnfBS+31twdOC5J6GGyUZdv3GFlqMSxBiOTcAUlpqOO95dfyqSdo18b/Z1w WshHAJkf49qwn10iFsD8nPuy72tNXyp/9O7Ro1BElmHsC2ZlybZ6LM6PjzPxCoNnRkNK 9bmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=1o6HS6FzhVDFxL5VavNgrJPCh8eYYXe6fDRihVFQPn4=; b=qxOT4w9kOciD4xRE8RoSlZelYMupU2Qz7pjGj020+w/6LGUhswZB4K5rNIy7Qk82xD glLAwGNZ9px5KGQqz6P66TB9595kp7W5K9RbpsUsAxKAjUsJDrqfPZ28IC1GggKMhzNF FWhJMO16SQeYSaE7Ccwr62r5kagfEaziX7ZYcTH0OiUsAhsk5h9WayrX10OsbE98n7eI nYqXKR4HRNsauYBMjMbvlGegnR003tij0fPFMrtXGrTMR1vhkLMC3OfHlfzTKCXyuL6r ThZYZRnuxuTof/bDbuHqyH+8F0voMdy9JHuotW9qvaNVtnseO2Fd53ZScBkL9TPEXSto 7zLg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lq0Dd3U+; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1o6HS6FzhVDFxL5VavNgrJPCh8eYYXe6fDRihVFQPn4=; b=agSuzCOfFViUgKiZFWMmSn9tzn+aWxBhGwyfI8eSQtgi8u0q1KB10mwqW+sAoX2WiB mocafet9ZUJgfo8H5Olw47scnOqxK/zT+uDd4Kd3MDjo20rruQgQY2tq/2Eep8HgAY9E JHVUvE5f+r0L/SmuUo/7GE1cV2mrZSh2Av79E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1o6HS6FzhVDFxL5VavNgrJPCh8eYYXe6fDRihVFQPn4=; b=KpE+eVmQyi938Sa2Aa5pDNBs70qR7w4QvT0dHZMGMxbGN6cwvX0X83e6Z16XZE/EmP 7NsO6XdKJXsfbo6wB2coWmMWF3MRwLGutqsB7jvDqc6OIOvCHCWzT6CjOVInPol2u+Db 8M5f0E7kEU0Njfe7Jj0GAxSnxZLXFde944SN/7X6NnGHYUF9gody2jXl89+T6510uKPz JAEPFRP7GjRBIbCnmK5/BUt/7b5T8cBHO/2l7XVFhXUh+gN268a5z3V823om4OMkXaux ZPpeyLHuIbYw2OijtByVpd2I6yLRCtNHL5hqBRoQcba5Nqrryi905hNznOaIWumgZ2qd sxJg== X-Gm-Message-State: ANoB5pmeQNgQPojr7jRQdLhGeytG044vqlvRxmccpcawl/ubVzuL5KGe B11WL6xaA3p8D8DtyTNrDOo4KIjt X-Google-Smtp-Source: AA0mqf4NNT12DEX0qcKAtfgypuJtKQ3jGlzHGu5WNG9J3L2Vz8FB31JsKIhNKWwRT3WDy66ckI9Xfw== X-Received: by 2002:a17:90b:2647:b0:219:7a3:2168 with SMTP id pa7-20020a17090b264700b0021907a32168mr69378322pjb.160.1670599691427; Fri, 09 Dec 2022 07:28:11 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:a898:b0:210:6f33:e22d with SMTP id h24-20020a17090aa89800b002106f33e22dls9220779pjq.2.-pod-control-gmail; Fri, 09 Dec 2022 07:28:10 -0800 (PST) X-Received: by 2002:a05:6a20:9f96:b0:a3:9f32:a9d1 with SMTP id mm22-20020a056a209f9600b000a39f32a9d1mr8666310pzb.31.1670599690465; Fri, 09 Dec 2022 07:28:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670599690; cv=none; d=google.com; s=arc-20160816; b=Tx3Q2PYRhnd+8+Pz+z7QXJ7rDCyToxGV8O6FycACM8Tam+RkiHb/Y38gOKCZG0/k5O +KNLIWnWnCYKfGL3w6+Wg8iKsciusMXbIMlQMnuIvDXYxSzFynnXOv7a/e4LrTkhMNKh OWnmrloB+TxjsXgchWQxKWNShRkfplDNpWwkssJ/vEWKGf8Eg4vkeG7BWY1ID2Y4Z3j/ Im4HlnbbvkcF4Xmp8jN/53hakdSunHmS68zg9BlEMIFUncmZFjPnXmANmqRhZ/BVe9k8 CJG+WZ/s6Cw7eVp8llsjeZSUNYyniKHFUsmUPSZ0bHrse0w5nRax0OjXIJT/LxJqv+Qx wTXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Ymr+DEOHacJTvc2Uck5JB4sOzfEDxvLbYqSHqNsRapU=; b=yPCbAdtrwh9LskreAq9TzKHjfjwW8pnjALrNREskq6AcsDE3jfByT7yqca3OAp3fOI 3KbeY+3knLg0BGqfI5pS5VyOb3d8s67kOnPrgsO5NpOfXBRagNKeZ+LP0BNL90J0M8tJ 7xhsXseRDR7vWpCJoEfHgDYcPYDXrDOw+krpDIW0C2Q+l1c66CT5Z+mtr22Er5lmcfvS uv2Qtqqc7hoYrz5WE8fJ0x4b4VAYFMEG1o+5IMfBNr0cZ6pCQiq4MaH8Z2dm4PwCuAKT pdZjCGuiELgTeeY+cin7Acq4FkFM1H8IaMOVPU2fFw9LsgT2IzJocWC7zNu6CRlkPAh7 853A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lq0Dd3U+; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ju20-20020a170903429400b0018980f60677sor1073581plb.23.2022.12.09.07.28.10 for (Google Transport Security); Fri, 09 Dec 2022 07:28:10 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:e806:b0:185:4421:72e5 with SMTP id u6-20020a170902e80600b00185442172e5mr7789428plg.42.1670599690133; Fri, 09 Dec 2022 07:28:10 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:6ba1:bbda:c542:ba0b]) by smtp.gmail.com with ESMTPSA id x14-20020a170902ec8e00b00188c5f0f9e9sm1477587plg.199.2022.12.09.07.27.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 07:28:09 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v9 13/18] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Date: Fri, 9 Dec 2022 20:53:38 +0530 Message-Id: <20221209152343.180139-14-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221209152343.180139-1-jagan@amarulasolutions.com> References: <20221209152343.180139-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lq0Dd3U+; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Finding the right input bus format throughout the pipeline is hard so add atomic_get_input_bus_fmts callback and initialize with the proper input format from list of supported output formats. This format can be used in pipeline for negotiating bus format between the DSI-end of this bridge and the other component closer to pipeline components. List of Pixel formats are taken from, AN13573 i.MX 8/RT MIPI DSI/CSI-2, Rev. 0, 21 March 2022 3.7.4 Pixel formats Table 14. DSI pixel packing formats v9: * added MEDIA_BUS_FMT_FIXED * return MEDIA_BUS_FMT_RGB888_1X24 output_fmt if supported output_fmt list is unsupported. * added MEDIA_BUS_FMT_YUYV10_1X20, MEDIA_BUS_FMT_YUYV12_1X24 v8: * added pixel formats supported by NXP AN13573 i.MX 8/RT MIPI DSI/CSI-2 v7, v6, v5, v4: * none v3: * include media-bus-format.h v2: * none v1: * new patch Tested-by: Marek Szyprowski Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/samsung-dsim.c | 69 +++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 9203116f1efb..ef0d802d25bf 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -1348,6 +1349,73 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +/* + * This pixel output formats list referenced from, + * AN13573 i.MX 8/RT MIPI DSI/CSI-2, Rev. 0, 21 March 2022 + * 3.7.4 Pixel formats + * Table 14. DSI pixel packing formats + */ +static const u32 samsung_dsim_pixel_output_fmts[] = { + MEDIA_BUS_FMT_YUYV10_1X20, + MEDIA_BUS_FMT_YUYV12_1X24, + MEDIA_BUS_FMT_UYVY8_1X16, + MEDIA_BUS_FMT_RGB101010_1X30, + MEDIA_BUS_FMT_RGB121212_1X36, + MEDIA_BUS_FMT_RGB565_1X16, + MEDIA_BUS_FMT_RGB666_1X18, + MEDIA_BUS_FMT_RGB888_1X24, + + MEDIA_BUS_FMT_FIXED, +}; + +static bool samsung_dsim_pixel_output_fmt_supported(u32 fmt) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(samsung_dsim_pixel_output_fmts); i++) { + if (samsung_dsim_pixel_output_fmts[i] == fmt) + return true; + } + + return false; +} + +static u32 * +samsung_dsim_atomic_get_input_bus_fmts(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state, + u32 output_fmt, + unsigned int *num_input_fmts) +{ + u32 *input_fmts; + + if (!samsung_dsim_pixel_output_fmt_supported(output_fmt)) + /* + * Some bridge/display drivers are still not able to pass the + * correct format, so handle those pipelines by falling back + * to the default format till the supported formats finalized. + */ + output_fmt = MEDIA_BUS_FMT_RGB888_1X24; + + input_fmts = kmalloc(sizeof(*input_fmts), GFP_KERNEL); + if (!input_fmts) + return NULL; + + switch (output_fmt) { + case MEDIA_BUS_FMT_FIXED: + input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24; + break; + default: + input_fmts[0] = output_fmt; + break; + } + + *num_input_fmts = 1; + + return input_fmts; +} + static int samsung_dsim_atomic_check(struct drm_bridge *bridge, struct drm_bridge_state *bridge_state, struct drm_crtc_state *crtc_state, @@ -1396,6 +1464,7 @@ static const struct drm_bridge_funcs samsung_dsim_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_get_input_bus_fmts = samsung_dsim_atomic_get_input_bus_fmts, .atomic_check = samsung_dsim_atomic_check, .atomic_pre_enable = samsung_dsim_atomic_pre_enable, .atomic_enable = samsung_dsim_atomic_enable,