From patchwork Mon Dec 12 14:55:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2541 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id CEB1C40CCE for ; Mon, 12 Dec 2022 15:55:37 +0100 (CET) Received: by mail-pl1-f200.google.com with SMTP id c12-20020a170902d48c00b00189e5443387sf10623579plg.15 for ; Mon, 12 Dec 2022 06:55:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670856936; cv=pass; d=google.com; s=arc-20160816; b=gw3tZpmIzvI8DppSuqnsB4260o6aiLGTW3aqBpbWTMCv4q+UlaVN7oWUiWBljOfWVI YDndfurm+mcE7u4FQwJ+//u+8TarXfp719aDHzHANJirle7oJ04Ojov6tFrUb9UgHpPW hrn+ZK+R1hufqL7oiUOhCxrG0c+BocGshvz8M2f9S0AJOuD3xuCQuhxm+k0ue2YYD3h3 Alg7dVmycTAxMBxeNkbHBNlTeXovUIo7zqkMWeV5C4KuO/CyU4n4A0oLyXTtE+N1jus6 EQh1HeNWCOCfzLqvnC1ui8UpErUSF0pC2nJ4TqagQibUIrthf6tSwh9SaLr2GhB0gKqa 661w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=d2Au4olZnbJ3W4O+wgqgaid2/iHKZpS1z1hPdlv9L7U=; b=ykBKD4ldNYhJ5Nhf9dCskrs/H8K+cElidX7bEh4T5cn9WPLOY+Ozx4KiWq8+78Lbde HzSFxiILfgYgAQZNlIr6GeK1bKdoN/LjpqCZH0YBoDDRW5ICGFveJ5jGb0lIAe3WQg4B tgdED8lffLJDWaH7p5m2POijLOHBb3nN5Itz6EH5L4DfrgeaUtD02uQmCJ1Gtli3FciN /NoN+Xn6gyDkcuPmRCxYBvCZRJ8tz9okv14nvt4zoJUtRbBmGa6MQCf45121Xx81gBrg IG4DUaeeviAlIiWcPwVGF6d8VcirOQ2ADWNQKSxJZuBIOT525UZnei/+cqmGshZ/MSPs l4gQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=BuTOUmaR; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=d2Au4olZnbJ3W4O+wgqgaid2/iHKZpS1z1hPdlv9L7U=; b=HiIAKA354u8bBCsIiaYmfI7P12sAYcvf7r2KvoRrpHIU889aqOza0j7AN5J+x7+9l3 arzW/J5chfQSIuiC4S38KJ56j9JAvrsq8mAEH+t8Dq3vAlyf6pXfP7/4UssdtQ6U7kxy VUuRbApglKlkPcclDGbTzN6FYLyMcOCMJhI6k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d2Au4olZnbJ3W4O+wgqgaid2/iHKZpS1z1hPdlv9L7U=; b=XnLQm3qqhsSHpPrqJIIGZkG0FPn67Xx/OrloSbLlNIloGIOXY+oUZZX1fiaWYfr1yR BTPewHrnYVD5moeGgfonrQzlcN/pkIoXON7P/AYEDCHC1mrMjSE2UZ6pB8i3TO53IwU1 uP6YEqqFJQcn++refv4ICIADzqrGur86hrAFa49ufex5CX1V5XVgI7BWWU1hQ8iXILrB g/0VFVNC59I0xa42ue8lSPGKMfS5w7Q5SEp7Pl8ceh9Gvfq2cB1bDe7Bv+w7o6gSHqgF E7zJa59hmFxU2y3XXq+QG8A74pIXnKXrrCmzaxi0Qbmjbp9xKxCLATiPF/ZFCRArnxIz 94cw== X-Gm-Message-State: ANoB5plOtWiT9tsEx4QMW909zgcr8OYzDVB18K+GOCL8G6IvGisQX+4v smrwQlEbEyxQewxsrim1o1yejaCL X-Google-Smtp-Source: AA0mqf45/Wb/6Wmb7IjbwVIiqGGDMlJTgtCH2OQI+sTWiiSFPbZBglFD0zuzX1KjHPDTZ+nQAw8Y9w== X-Received: by 2002:a65:64d1:0:b0:478:980a:53fb with SMTP id t17-20020a6564d1000000b00478980a53fbmr22681258pgv.484.1670856936479; Mon, 12 Dec 2022 06:55:36 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:7143:b0:202:a0c3:702 with SMTP id g3-20020a17090a714300b00202a0c30702ls17104554pjs.1.-pod-control-gmail; Mon, 12 Dec 2022 06:55:35 -0800 (PST) X-Received: by 2002:a17:902:d717:b0:188:fc68:d366 with SMTP id w23-20020a170902d71700b00188fc68d366mr16756535ply.40.1670856935614; Mon, 12 Dec 2022 06:55:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670856935; cv=none; d=google.com; s=arc-20160816; b=E3eX2ti6fYFZJig+hKjgqNVJ0s0d/uC/XJ0DQSYBRkeScK6xH0tcP4gQZUHL57eMss kEE+GbrAuSulVQEk+sn6AYLZRw2MGHaR9mqFMeE51PTSXGq+ws5A8uIb61ppFwSVwBwM b9zSRPGLJpTEuuoxKPvH7Mu+20nIPsgWjZsrMRKnRqkQjstJQxCBJ63z9v/b8UCHDPYR uxMjY7dMNnSbILFODOmZ/fgEcnbviU2u9WAt/2rFkO1YB7E7PRkX95mt1WEo0YsFfpo0 pUrxxLQKiMgwO16EQLlepREE0MY0Oi3eO2GMogW3LuJYWqey1Kmhd6kuKXZSNOWR+5Mm 2JLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=y/y5vw0u9kB/6hX1ihxQilGZuqMG9YrydhtDvt3iYOI=; b=MjG9E8B5+4ncYeY+/kVmW/2KwW8Yx5nblwrTxCHlgL5BOj8cnwGAqneLefpgZlv0Uh PxePKYx+dGkdegJeDCncebc3X8xYqwsaF3v08hXj/gPRXNCJ8X/JQ36d8BuTumyl9GLg Ma0XeG5D9yjCcnyy/z4K6tr5Immbb/tamwFHV99DGf74Kgt+Ke0JVI3c/HllJYG33oDR uV2azPpCHn21LL+DOz5hH3L7YJZ7/YbkUbZE/Cv/74J9j/AkQ32w5LiZdBWAWJqg+qGz JKalJ1iIm0tyT3zBcVvsYdk5RitRZJKZa9XkLgfoTv3vmlz6xp3r1yunm+NLUmAkphs4 A0Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=BuTOUmaR; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id q10-20020a170902daca00b00186c3728de2sor4250339plx.86.2022.12.12.06.55.35 for (Google Transport Security); Mon, 12 Dec 2022 06:55:35 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:b494:b0:188:635d:4ca9 with SMTP id y20-20020a170902b49400b00188635d4ca9mr17072148plr.2.1670856935321; Mon, 12 Dec 2022 06:55:35 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:c713:dc69:f2de:e52f]) by smtp.gmail.com with ESMTPSA id e11-20020a170902784b00b001782aab6318sm6463272pln.68.2022.12.12.06.55.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 06:55:34 -0800 (PST) From: Jagan Teki To: Marek Szyprowski , Inki Dae , Seung-Woo Kim , Kyungmin Park , Neil Armstrong , Robert Foss , Andrzej Hajda , Sam Ravnborg Cc: Marek Vasut , linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amarula , Jagan Teki Subject: [PATCH v10 3/3] drm: exynos: dsi: Restore proper bridge chain order Date: Mon, 12 Dec 2022 20:25:08 +0530 Message-Id: <20221212145508.15096-4-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221212145508.15096-1-jagan@amarulasolutions.com> References: <20221212145508.15096-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=BuTOUmaR; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Marek Szyprowski Restore the proper bridge chain by finding the previous bridge in the chain instead of passing NULL. This establishes a proper bridge chain while attaching downstream bridges. Reviewed-by: Marek Vasut Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- Changes for v10: - collect Marek review tag drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index ec673223d6b7..e5b1540c4ae4 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1428,7 +1428,8 @@ static int exynos_dsi_attach(struct drm_bridge *bridge, { struct exynos_dsi *dsi = bridge_to_dsi(bridge); - return drm_bridge_attach(bridge->encoder, dsi->out_bridge, NULL, flags); + return drm_bridge_attach(bridge->encoder, dsi->out_bridge, bridge, + flags); } static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = { @@ -1474,7 +1475,10 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host, drm_bridge_add(&dsi->bridge); - drm_bridge_attach(encoder, &dsi->bridge, NULL, 0); + drm_bridge_attach(encoder, &dsi->bridge, + list_first_entry_or_null(&encoder->bridge_chain, + struct drm_bridge, + chain_node), 0); /* * This is a temporary solution and should be made by more generic way.