From patchwork Mon Dec 12 18:29:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2547 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B028D3F1DA for ; Mon, 12 Dec 2022 19:29:49 +0100 (CET) Received: by mail-pj1-f70.google.com with SMTP id o18-20020a17090aac1200b00219ca917708sf434797pjq.8 for ; Mon, 12 Dec 2022 10:29:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670869788; cv=pass; d=google.com; s=arc-20160816; b=pGSujwAd5JjOzra3dqmBAyJZsY67yHGdrLHQ0DiF9kcKk9PsP1J13nGfvFRN5QCRaG PHFa0powR5NVI0igOjpx8w1SKsrAoYuuQ8HFA7NZ9zmX4839xGbjCvl7iEOJB50MXvCH pRvKWVI2Fut/F6ZPKS7QvD4BwdicgXU9jc2IhKImDJYLWU6mD3bHpE7HAxmw9XBXTLdf ARMTCRA4hEnXZ/3uVehZOefm963BQ/N87dQ9ZauXmAfrvoKPGFHeI7c5j1cynN18MpzN fcwO4uscDbarCJ2Lr1QVMGfTwHnifRKVb7ca/tUFUpfap8ozVR68/Klr5b44bq6J+a9r yTAA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Ad00E/Q4GFPsoPpt94axr+8ndxM9prseWstVAvqb4PU=; b=z7aeOwnIkt4EiWnq5jwYfb06hDh+5Wl0fDsCImBznNUuf2/YnT2S22O2rVxONK2xhr YgcDbScF6RNMR0vcZxyYJF4myPvyWNyv32TRcFinUIqQ39YTjZLFErsazKBiChNYzK+j 7GQgJqmxMv1w3xaURFDRkHVJD31O8LxaTxcuQCRoA0jSjc1dmQcC+Ugbymy9yrsTYSaW ORicbk1TbidfuKR16xkq7mXFvWxjJ5XI6jShlhfIRpbDmuQUv07wF+8jGEn6QIXcrIeP JLT/c773Hcy3yLMgi5ZMxzUQ+djAdk/Skwl9CM+U0Kbz5HRpi1zJzhELRZdMDh/iW5xl GWgQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Gh4sGxHl; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ad00E/Q4GFPsoPpt94axr+8ndxM9prseWstVAvqb4PU=; b=nns/TJ+eReSScIU/ZqnpVb9zp2yvmegObHYeiacxha/T3CgxOdIE56VFCzbF852hjA zjXavMk2uW6f2SiTZnFIfYDjsviFbnHyvAWZfu/jnhT8PAArDTpW+6ABRzi+XXEvezJt bajrs6kkZuLF1+sVpWNFmqmJvQ4c2sPIhuWus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ad00E/Q4GFPsoPpt94axr+8ndxM9prseWstVAvqb4PU=; b=hERnvGdTwpKfce8DFwDbo2lSKtAk17hBhdzj8zvvRyVH/8ZF0F4lh/6q8NP8YNkqjH CvXklLFSZOwyd2APX24UokbvjC8CwszVVFBhZM8KR4JPN+KYlzxwdRHROW/PiTbaiyq8 4P4BBQD0ODk+8lQ7NpW9gVsxAlBfsRD0aUbNpfwi/3VCuRzDHD6I9nALCCVfkOFG9rVL Kgv0PRKc+W1CT96cPJoKmTVDjPSvulQmMrqui0eAsoqhHnu/SY3TVi7iA08WYOg4YQRF GYWY7aWy7xxEnJtmfEFNGqv2MXtNqkujjVwpLG2Qm5C7nBfX86VudlSHyZ5wVfVV+tl1 Kc+Q== X-Gm-Message-State: ANoB5pk82KgTe+rw0/RnT6Uq7ffeyPc0hK0V5BLw2O07jNmow0zQLGc8 TifuQiYVjiDN9AGFyZvUo6ZMFIUc X-Google-Smtp-Source: AA0mqf7+bTErR1cEVh2XZ21yULlnwxt/N0IYpRvzLNnH/8jKTT+4/sClXdLt+uk9/Gx/p8q3ECiFPQ== X-Received: by 2002:a17:902:700c:b0:18f:438a:cfe3 with SMTP id y12-20020a170902700c00b0018f438acfe3mr472299plk.124.1670869788357; Mon, 12 Dec 2022 10:29:48 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:7894:b0:178:5938:29de with SMTP id q20-20020a170902789400b00178593829dels16240509pll.2.-pod-prod-gmail; Mon, 12 Dec 2022 10:29:47 -0800 (PST) X-Received: by 2002:a17:902:7088:b0:188:d4ea:252c with SMTP id z8-20020a170902708800b00188d4ea252cmr17509988plk.6.1670869787491; Mon, 12 Dec 2022 10:29:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670869787; cv=none; d=google.com; s=arc-20160816; b=NQRq4jN/Nj+yABsORNu2zPAfnrZpx0J2MBjU1H+xLPcNldIZFT3BB9ZJ23a8nvy3f6 VHaUxia0UztvsrH65NYtHWS8hQBB6uUzKfp13i9cOLTyUuXlBPummAyQfUzZlZO1xN5S I6z9mXJUSbZWlGfEADEpaxZSzVXZnd7hmHpZqsYhn2tFKD57X+cNTfwKEsxlTSvXS5za 0pKTCFddUcBo+ANTAq9B1cL9PxiaHpa3Xg3KwpRtjAHFVRbB19UEEybTTOPkD9LlTFir 1ME5OMb0FY4o0Ea7Laxj4ISKllSKcApjO8O03uoAcf7FtEMLmxCw7li00HhSTrRjJc/u Ghgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=+3thu+TFV75UQnUKi5H5iMkprh+mVb/ueAKw6cINH6Y=; b=zRWqSPKa9/1SO2BkVDmmzVGJ32E6lUyHTlpFOEvrY0ROLFhXnYBcjPoxsMHGosPIlh qkczY9DcXzawQONK2skRMN+Nfy0bTxZ2NDxW9izX1jyX8Fdyrty1m9mD+5e/mcsc4SBL 42CukfsOnKCB+7r6qJ+BCvXuYiuKZO6m6d5VbQOWPAQOE6jiDAHt5q+xzvH3tOaDSbRj zwISd0tohC21WYZxvbaKDjBaIwVreXYLluI1czllXI6YXSYoEIJgqqnmiCvvrzqbheqA Qdzj8YSLQOHyQS99ombaLRx8Jbp0aPLxIuKHUJhaJCxFKsLjieE5I3K9qpand0ZyfPba u50w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Gh4sGxHl; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id e2-20020a170902744200b001895afb6979sor4530186plt.182.2022.12.12.10.29.47 for (Google Transport Security); Mon, 12 Dec 2022 10:29:47 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6a21:3996:b0:a7:345a:1024 with SMTP id ad22-20020a056a21399600b000a7345a1024mr22612382pzc.50.1670869787169; Mon, 12 Dec 2022 10:29:47 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:c713:dc69:f2de:e52f]) by smtp.gmail.com with ESMTPSA id n28-20020a634d5c000000b0046fefb18a09sm5357998pgl.91.2022.12.12.10.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 10:29:46 -0800 (PST) From: Jagan Teki To: Marek Szyprowski , Inki Dae , Seung-Woo Kim , Kyungmin Park , Neil Armstrong , Robert Foss , Andrzej Hajda , Sam Ravnborg Cc: Marek Vasut , linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amarula , Jagan Teki Subject: [PATCH v11 3/3] drm: exynos: dsi: Restore proper bridge chain order Date: Mon, 12 Dec 2022 23:59:23 +0530 Message-Id: <20221212182923.29155-4-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221212182923.29155-1-jagan@amarulasolutions.com> References: <20221212182923.29155-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Gh4sGxHl; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Restore the proper bridge chain by finding the previous bridge in the chain instead of passing NULL. This establishes a proper bridge chain while attaching downstream bridges. Reviewed-by: Marek Vasut Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf --- Changes for v11: - add bridge.pre_enable_prev_first Changes for v10: - collect Marek review tag drivers/gpu/drm/exynos/exynos_drm_dsi.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index ec673223d6b7..9d10a89d28f1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1428,7 +1428,8 @@ static int exynos_dsi_attach(struct drm_bridge *bridge, { struct exynos_dsi *dsi = bridge_to_dsi(bridge); - return drm_bridge_attach(bridge->encoder, dsi->out_bridge, NULL, flags); + return drm_bridge_attach(bridge->encoder, dsi->out_bridge, bridge, + flags); } static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = { @@ -1474,7 +1475,10 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host, drm_bridge_add(&dsi->bridge); - drm_bridge_attach(encoder, &dsi->bridge, NULL, 0); + drm_bridge_attach(encoder, &dsi->bridge, + list_first_entry_or_null(&encoder->bridge_chain, + struct drm_bridge, + chain_node), 0); /* * This is a temporary solution and should be made by more generic way. @@ -1709,6 +1713,7 @@ static int exynos_dsi_probe(struct platform_device *pdev) dsi->bridge.funcs = &exynos_dsi_bridge_funcs; dsi->bridge.of_node = dev->of_node; dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; + dsi->bridge.pre_enable_prev_first = true; ret = component_add(dev, &exynos_dsi_component_ops); if (ret)