From patchwork Wed Dec 14 12:58:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2558 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 61F1C3F0FB for ; Wed, 14 Dec 2022 14:00:25 +0100 (CET) Received: by mail-pl1-f198.google.com with SMTP id i4-20020a17090332c400b0018f82951826sf2505436plr.20 for ; Wed, 14 Dec 2022 05:00:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1671022824; cv=pass; d=google.com; s=arc-20160816; b=J7XjgFbluT6DHeAIMqYFdQpEfQZqjoIhlNgKHW5ctBTgqN+OVUzAChSQ30dQPNEOtP fKtY78SOo4arj58dNFeQ1vI0ejjWdWGzJFZy4x4F272a0xomTL4CfkiHnMjYyzSL5lyN i0zc5Y7YVoOpNlnljK51jShRgr928n3+ox3wUtQs5DvDATPvf6YB4D9NnLXlYv+zvPsG 45cStNpcok+As1gbNk8GHZrGi5wKqxkwbC6iicCqE9Jgfr2/BE05RiBuBlMeD7R5MeP3 zj0Ua17KQsPIKkdfNjL1jvrHiwWUeZyIy6OCcAenHcWD2xACJPp5h3JT3aoQ7yYtGEc5 dZnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=misUVeIm+4jO9J4JjuxKO5/BRayuKKTDUL6bHlVxKkU=; b=0ESJhJBnHDpDyozcUmBpjQv8BWUWi78agRq1pFFxgkrOgA78uJXTWkYnep1sdrDs7Q ZNM3hyuxq/APAHLqzwV4hev2tOuIuXDNuVSmnq7u+oqoXmTagc4xPCZjfgGiwcWZNpua x1K/1gkqiUCoVHynlYsCmn5IDhT8qMCm/qs6Z4rkeRE9vSI66xlLVhBYIy0rKf/mBAcS cT6eagIE9grwHI2/L0oJ2x8VM33rCYEh5qjpWvcvy+MFmoTTKu2gIY+P+gAn72bPOYvP hSCwQcllwvD5tW4RChnilwZgOvJbi8bZgfBXso0u1wAoZmFLmBHj78LZhJcAVRFuSqVB YuzA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rsn53jOg; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=misUVeIm+4jO9J4JjuxKO5/BRayuKKTDUL6bHlVxKkU=; b=fVVBN9oewqkjT0GB6mgR1achOhZbyAoeogIuqtDzzKEGUkGkGtTf0VVqV0E45KWAH7 56KLk25ckRbZ490OUNQeCiQALU62+gquK3v/HN25q2zhig0Eg6XwYwJrBoqVroYmjfnz sfBufF8Lq7GZr49r9Kckgm0aWPXsJCGFunzSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=misUVeIm+4jO9J4JjuxKO5/BRayuKKTDUL6bHlVxKkU=; b=rVPxPXVLGygaySilMeaeC3DDJBJA9ACMFpdE2p2ThWHjFDrTaYkPXGBRXFV6FP0Y9t lkqDEDG6i46qNsbsBGyonWOAJ5TMF0voFZr8gurvQI1pUuVbN453Gnht2rGm0eznhq4m 6Jtq43wk2K1Id94PAM1yR1IcXRztupZkHMREgPWLxg5fsZu+VQ33wM0O35KQ/NxdpJFH 3cKJbH5N+oMWL9sr/kNv6amgEPTynnoHks2XnHcrwjeDsMZbvrrm2jO1X/MpOJORLP4H EM8asy/bItWg1611O2PZM3bSvAa9RSZcMiZkC7DxEJ9ODbzIxWMjYOEYUvUUfOcgTjJd 9i2w== X-Gm-Message-State: ANoB5pnKrZSvEoFG6f9Z45jS2kTSDPvEsfV9g/9va6G50VRD5gzz0nVo ZFK6X+t94Vowob+skUD7BJskvaw4 X-Google-Smtp-Source: AA0mqf7XH9HcBDu87QmnL5OQz9btIcvzOL/tnbODk7nHQ+T4dhRBqmUkiM3ZLuI4TMQX4ok08bUQAw== X-Received: by 2002:a17:902:70c8:b0:189:d37f:d97 with SMTP id l8-20020a17090270c800b00189d37f0d97mr20920521plt.72.1671022824070; Wed, 14 Dec 2022 05:00:24 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:7894:b0:178:5938:29de with SMTP id q20-20020a170902789400b00178593829dels22269045pll.2.-pod-prod-gmail; Wed, 14 Dec 2022 05:00:23 -0800 (PST) X-Received: by 2002:a17:902:7d85:b0:18f:a5b6:54f9 with SMTP id a5-20020a1709027d8500b0018fa5b654f9mr10911464plm.11.1671022821590; Wed, 14 Dec 2022 05:00:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671022821; cv=none; d=google.com; s=arc-20160816; b=KJW6UwD3EV5ylngHCBwSQOXVIc5AqmDiIk9hPtB79cVQxFnMAU5SHx5hn2FTUjUTSL GfP99Xuqc7zzSaiBaNH4KxSyrR2niFZ4gPtcZSfg1sKolcwi3ERyT03p3A/ciw6jsnQG bPuTQeC9TgpaQDP9rDCBtDRaSKLD8bSQ1w3pANl1tLmFzZIAeUGl/EgPqk1PFVcaTrcS T7rW07kxyjvJF+eAistG/Be6VTkCrzC8bXv0m4lajKCkkH7To7b92RrcdmP1jbXMbN2W jkKS1LSPAHnS0WAN1IvDMUVZ/r8E+jSBPisTiujo9MUFnU5sBJfIDWrkdqyIV+OTYxBb E/qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=+fY/W1lN+Ci+ECm9hkCI93VoUxar0STDOgEhzXF/A8s=; b=eTgzFCwPdI1lqGrz7dn7CyS8Z3RJfdXGLSnQiiYjYHz8il90qd+XUeiBmz0MzEGTt3 z9qtxRjrOSNE57H3Oi3pX3Wj1rd6Mtw/QyCAuq5gF//VwOY+DVZejDqRKF13RKV3uVug Iz6+kYM/lf0UzPJazkg7FcNQLA/p9Z1bLbb+pP6r4/Yj1mbtFkKcKsCvEysWCkgpsFQK wUHcaZb/oc+xnP4OmpTXPJzRzSW4aQqIDHz+ZzHid4xQumlg0EKF0BnelZZ0XTmJXRNP jyVN5oKq/wxRD4UEItUIb+R4kNTRtNshCnRPLN9Q2tKKHk1mg3Ho7KBBiyKfMFnIYslz MFJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rsn53jOg; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id q22-20020a170902789600b00189d4f80a11sor1507918pll.28.2022.12.14.05.00.21 for (Google Transport Security); Wed, 14 Dec 2022 05:00:21 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:903:328e:b0:189:dfae:f9c2 with SMTP id jh14-20020a170903328e00b00189dfaef9c2mr24293927plb.23.1671022821194; Wed, 14 Dec 2022 05:00:21 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:5e03:faf:846e:352d]) by smtp.gmail.com with ESMTPSA id ix17-20020a170902f81100b001895f7c8a71sm1838651plb.97.2022.12.14.05.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 05:00:20 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v10 07/18] drm: exynos: dsi: Introduce hw_type platform data Date: Wed, 14 Dec 2022 18:28:56 +0530 Message-Id: <20221214125907.376148-8-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221214125907.376148-1-jagan@amarulasolutions.com> References: <20221214125907.376148-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=rsn53jOg; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like Exynos, i.MX8M Mini/Nano/Plus. Add hw_type enum via platform_data so that accessing the different controller data between various platforms becomes easy and meaningful. Suggested-by: Marek Szyprowski Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf --- Changes for v10: - split from previous series patch "drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge" - update enum type names drivers/gpu/drm/exynos/exynos_drm_dsi.c | 84 ++++++++++++++++++++----- 1 file changed, 69 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 7a845badb1b2..fdaf514b39f2 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -254,6 +254,16 @@ struct exynos_dsi_transfer { #define DSIM_STATE_CMD_LPM BIT(2) #define DSIM_STATE_VIDOUT_AVAILABLE BIT(3) +enum exynos_dsi_type { + DSIM_TYPE_EXYNOS3250, + DSIM_TYPE_EXYNOS4210, + DSIM_TYPE_EXYNOS5410, + DSIM_TYPE_EXYNOS5422, + DSIM_TYPE_EXYNOS5433, + + DSIM_TYPE_COUNT, +}; + struct exynos_dsi_driver_data { const unsigned int *reg_ofs; unsigned int plltmr_reg; @@ -267,6 +277,10 @@ struct exynos_dsi_driver_data { const unsigned int *reg_values; }; +struct exynos_dsi_plat_data { + enum exynos_dsi_type hw_type; +}; + struct exynos_dsi { struct drm_encoder encoder; struct mipi_dsi_host dsi_host; @@ -297,6 +311,7 @@ struct exynos_dsi { struct list_head transfer_list; const struct exynos_dsi_driver_data *driver_data; + const struct exynos_dsi_plat_data *plat_data; }; #define host_to_dsi(host) container_of(host, struct exynos_dsi, dsi_host) @@ -524,18 +539,13 @@ static const struct exynos_dsi_driver_data exynos5422_dsi_driver_data = { .reg_values = exynos5422_reg_values, }; -static const struct of_device_id exynos_dsi_of_match[] = { - { .compatible = "samsung,exynos3250-mipi-dsi", - .data = &exynos3_dsi_driver_data }, - { .compatible = "samsung,exynos4210-mipi-dsi", - .data = &exynos4_dsi_driver_data }, - { .compatible = "samsung,exynos5410-mipi-dsi", - .data = &exynos5_dsi_driver_data }, - { .compatible = "samsung,exynos5422-mipi-dsi", - .data = &exynos5422_dsi_driver_data }, - { .compatible = "samsung,exynos5433-mipi-dsi", - .data = &exynos5433_dsi_driver_data }, - { } +static const struct exynos_dsi_driver_data * +exynos_dsi_types[DSIM_TYPE_COUNT] = { + [DSIM_TYPE_EXYNOS3250] = &exynos3_dsi_driver_data, + [DSIM_TYPE_EXYNOS4210] = &exynos4_dsi_driver_data, + [DSIM_TYPE_EXYNOS5410] = &exynos5_dsi_driver_data, + [DSIM_TYPE_EXYNOS5422] = &exynos5422_dsi_driver_data, + [DSIM_TYPE_EXYNOS5433] = &exynos5433_dsi_driver_data, }; static void exynos_dsi_wait_for_reset(struct exynos_dsi *dsi) @@ -1468,8 +1478,6 @@ static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = { .attach = exynos_dsi_attach, }; -MODULE_DEVICE_TABLE(of, exynos_dsi_of_match); - static int exynos_dsi_host_attach(struct mipi_dsi_host *host, struct mipi_dsi_device *device) { @@ -1659,7 +1667,8 @@ static int exynos_dsi_probe(struct platform_device *pdev) dsi->dsi_host.dev = dev; dsi->dev = dev; - dsi->driver_data = of_device_get_match_data(dev); + dsi->plat_data = of_device_get_match_data(dev); + dsi->driver_data = exynos_dsi_types[dsi->plat_data->hw_type]; dsi->supplies[0].supply = "vddcore"; dsi->supplies[1].supply = "vddio"; @@ -1817,6 +1826,51 @@ static const struct dev_pm_ops exynos_dsi_pm_ops = { pm_runtime_force_resume) }; +static const struct exynos_dsi_plat_data exynos3250_dsi_pdata = { + .hw_type = DSIM_TYPE_EXYNOS3250, +}; + +static const struct exynos_dsi_plat_data exynos4210_dsi_pdata = { + .hw_type = DSIM_TYPE_EXYNOS4210, +}; + +static const struct exynos_dsi_plat_data exynos5410_dsi_pdata = { + .hw_type = DSIM_TYPE_EXYNOS5410, +}; + +static const struct exynos_dsi_plat_data exynos5422_dsi_pdata = { + .hw_type = DSIM_TYPE_EXYNOS5422, +}; + +static const struct exynos_dsi_plat_data exynos5433_dsi_pdata = { + .hw_type = DSIM_TYPE_EXYNOS5433, +}; + +static const struct of_device_id exynos_dsi_of_match[] = { + { + .compatible = "samsung,exynos3250-mipi-dsi", + .data = &exynos3250_dsi_pdata, + }, + { + .compatible = "samsung,exynos4210-mipi-dsi", + .data = &exynos4210_dsi_pdata, + }, + { + .compatible = "samsung,exynos5410-mipi-dsi", + .data = &exynos5410_dsi_pdata, + }, + { + .compatible = "samsung,exynos5422-mipi-dsi", + .data = &exynos5422_dsi_pdata, + }, + { + .compatible = "samsung,exynos5433-mipi-dsi", + .data = &exynos5433_dsi_pdata, + }, + { /* sentinel. */ } +}; +MODULE_DEVICE_TABLE(of, exynos_dsi_of_match); + struct platform_driver dsi_driver = { .probe = exynos_dsi_probe, .remove = exynos_dsi_remove,