From patchwork Wed Dec 14 12:58:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2561 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 63DCA3F0FB for ; Wed, 14 Dec 2022 14:00:46 +0100 (CET) Received: by mail-pl1-f200.google.com with SMTP id z10-20020a170902ccca00b001898329db72sf2498756ple.21 for ; Wed, 14 Dec 2022 05:00:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1671022845; cv=pass; d=google.com; s=arc-20160816; b=pHwBIKD9GtjJQhL6PR+/7GoN0FFN4911FLf0hlzIMzavnwV9hYt3a4etJpn7l0PQZH FfnR8Oc+h0xJDPGLzaCPxIkJ94W99Xrv4X0wZjkAREwZKo2DdA4I7Y3fAdVXJZyRRnG7 miD4ZTj6Kgaq6DLbUaSe5hSrolFO5FLhH/zk7uvwSDOJO3i2EX5r7nTxEOc77l2RNNGX L7qFA2CfycfZ6u/yDsCfNNkqAtZnGMzAHIo/x7wJCsGbOICkswDSfhIfOTqma9UuBuwY cVjrFa4vvBc7itRWdw3ifPcm0sIzXym6ROVN+q/D1qO20oGDocE2H8q1k1VJWcneoKQ8 berw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=+j2d6XSAyqZqO+Q7SJqFFMDAQrBqE4IXHYbilOYe2eE=; b=ld8hIH2ntvympm8NLJ40K36a/0kmqPbkE5bpBp6wmfzJbq+8ZitiZB39Glz+5xBMF9 qLxr6hgZF21sT+mtQvNc4JuokEx2gGzaDCnIVkoxgcrZHbbPkdehV/WUGD0PSiAGyHLi ree8A512Fm58G7fu2B87Gu7q1ZIuw4NjEFT6DMuO6vL0RDKlcF/tD5eHCbfj9jyI/qqv xV5pcnfzXAyfUjrXsB3+SVRs4PvYPz6OcKNwKg+inlFPSZItF21/pzsLqmWgx08T2c3B msFQukNOLzgnjETXHCtEA3+PcbHnO/w2K9HkDmB2z9HjFaaeMzX1z+FGd5V2AJsJ2FjD bivQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=QYfGH67R; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+j2d6XSAyqZqO+Q7SJqFFMDAQrBqE4IXHYbilOYe2eE=; b=Z5f5aH9JGoQ75FhRhR9T0KITF1CHPK8s/8cPQdIRIFumGyXlUknS7KZzKHxRDjK58X dDu9/l0pbkkHZfV8bvRjkOTU5hfKG7X4bssZpg4yQ2hqqOSqV+bRpCyK4fIV14Y+eBrX VwRfr2H1GvH7UYliEWbQgowluZDVE5024WM7E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+j2d6XSAyqZqO+Q7SJqFFMDAQrBqE4IXHYbilOYe2eE=; b=BVrSA7+ztfzEUGAbfmY6gMHRrrgBqougVQdTvew3ckQDtd6aTYow+Er/M95gncMZCH 4ljq7DcA9uFgw+/8EcRV8auKNQZGbpwFfoSbhs/Zsn2AV+hvgtlxMuZ8DA0m9dGrTnww rVquTMXAYKNYjDgW+k+87BFxRXFoxc4fcGb8dkoWG8+yOVaDxAaABrkMzdsoEiseFUel WeGvWWqUmxJGFR1q1SoXyokVQYivkULa5zmXsCFrZRLTp/sg3UXVBgDYxfhGIus6zk1C Z0gYx71L2GZlVIj3NPuG3KC3g98JtSu6tFmkcWYB000oqdpCJluPhdRSeqRVQ+yEwY/Q vpEg== X-Gm-Message-State: ANoB5pls06hgKWhyHUefSj0jc+V6B9XI45og4QFep6MxYAg4Ov7MSrJQ XjLOxF8g9UGMZcJzk+H9O3OXFV+m X-Google-Smtp-Source: AA0mqf500xtQrY0DrGacvaAs1oGH+sC+ZeB2ezpZnEpeNVS3GL4NfN7iW0KJAbUTWRB2Kzj7Wt54iw== X-Received: by 2002:a17:902:f2c9:b0:18f:aca2:4748 with SMTP id h9-20020a170902f2c900b0018faca24748mr716588plc.135.1671022845178; Wed, 14 Dec 2022 05:00:45 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:f609:b0:188:b504:8ce4 with SMTP id n9-20020a170902f60900b00188b5048ce4ls22243009plg.7.-pod-prod-gmail; Wed, 14 Dec 2022 05:00:44 -0800 (PST) X-Received: by 2002:a17:903:2448:b0:189:f277:3830 with SMTP id l8-20020a170903244800b00189f2773830mr36846333pls.68.1671022844232; Wed, 14 Dec 2022 05:00:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671022844; cv=none; d=google.com; s=arc-20160816; b=W5eOEX8NNE7orU28Yrb7OlZvur7A7WPli+8+Xyh81Ecj0DXrcGdBCyfh+Aj94Wgfow Iv7ODUn982vGgqm+aSk7GdJdCG6jEUBkJrk+5iVkrF8tcwZkaBd68QtoeYuE+pF/GKgH e8ZoL3WUvOwn5HXuJSZmejsOIG/DMM6r05PvwfmsA4NYDJDIxr9GLuQ7/UcrKb6tLJ1t fVKi6zKkdYYljFZU0mpEO5GzqZScpVBKRahCmnYF6OTbw/Bwgjf97HGmVOpcXwfJKmFI kE1AK6lZ/CKfPWURkLmWX+L6a0ynLG9AjrDFFZhm1IUxT7Jcq7fOZjSvg9LTGFokN3u2 QXLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=aE+Kf4GZG5cBJgW4Glr+nCZ/Jxj375yDCGwPDOZtAag=; b=YL10iWo9iiJK7XEgYbyfRkKrrAhqldpkZelkofiA1PWUZgasuNDbstiSJoOoLomh0p USQ2uJRnYiwWceZHhMn/nlGzKvLAbv14tb+v1alR8IAHEUgwG9wRmgqSxu8PSo+quC4g iPo4EeCzRbOrBcShuK02nmY+7p3N32Jns9IRSQ6/8q4QixxF0vmc6r3RGbtlG7RGdAkP q8/Hr8PlTwXto7qdKB5WWkMRQqkYGwZTFYYfp0wsK+PWdXtOJra3HosUjadP0lyGI3V+ I2Nt0ECszvQxxY9NMYxVV/RmIja19Hg4RAp33fsufJnWTKMrnVBZdoycgfylzv4kwqTa hQ9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=QYfGH67R; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id i4-20020a17090332c400b001733c2e2283sor1466576plr.174.2022.12.14.05.00.44 for (Google Transport Security); Wed, 14 Dec 2022 05:00:44 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:7d93:b0:189:666a:8d78 with SMTP id a19-20020a1709027d9300b00189666a8d78mr23375559plm.4.1671022843876; Wed, 14 Dec 2022 05:00:43 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:5e03:faf:846e:352d]) by smtp.gmail.com with ESMTPSA id ix17-20020a170902f81100b001895f7c8a71sm1838651plb.97.2022.12.14.05.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 05:00:43 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v10 10/18] drm: exynos: dsi: Add input_bus_flags Date: Wed, 14 Dec 2022 18:28:59 +0530 Message-Id: <20221214125907.376148-11-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221214125907.376148-1-jagan@amarulasolutions.com> References: <20221214125907.376148-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=QYfGH67R; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting the i.MX8M Mini/Nano DSI host to add additional Data Enable signal active low (DE_LOW). This makes the valid data transfer on each horizontal line. So, add additional bus flags DE_LOW setting via input_bus_flags for i.MX8M Mini/Nano platforms. Suggested-by: Marek Vasut Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf --- Changes for v10, v9: - none Changes for v8: - add DE_LOW for i.MX8M Mini/Nano platforms. Changes for v7, v6: - none Changes for v5: - rebased based on updated bridge changes Changes for v4 - v1: - none drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 12a40576f937..36820a7b5884 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1692,6 +1692,10 @@ static const struct component_ops exynos_dsi_component_ops = { .unbind = exynos_dsi_unbind, }; +static const struct drm_bridge_timings dsim_bridge_timings_de_low = { + .input_bus_flags = DRM_BUS_FLAG_DE_LOW, +}; + static int exynos_dsi_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -1778,6 +1782,10 @@ static int exynos_dsi_probe(struct platform_device *pdev) dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; dsi->bridge.pre_enable_prev_first = true; + /* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */ + if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM) + dsi->bridge.timings = &dsim_bridge_timings_de_low; + ret = component_add(dev, &exynos_dsi_component_ops); if (ret) goto err_disable_runtime;