From patchwork Wed Dec 14 12:59:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2567 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6598F3F0FB for ; Wed, 14 Dec 2022 14:01:33 +0100 (CET) Received: by mail-pl1-f197.google.com with SMTP id k18-20020a170902c41200b001896d523dc8sf2486476plk.19 for ; Wed, 14 Dec 2022 05:01:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1671022892; cv=pass; d=google.com; s=arc-20160816; b=a6utU4DotMaY0p9L6g8lwMELAhQpM1liDpKnKyDWmVu+sEcn8SYhYVuv7Loa6/supP 5+ZFxl3VxBoWaFji6i3uGLyg/JPTvGCdeAtU4ZPMomgiraMXIOotGST0RW8a83QGpBn8 Val4f4X1iGVydvMxV23y8LVRRLuWYmdrlmYIqm97TBgXdl+OAs048FHbi1HikhGEhVtc /clYFFeDl0r4WkKM8FN7ym6ly1sqcKXXzZJ/tsQEszeOmChiIMlfR8/gF17eAnyKOiyb iasmLwFZ71q4lahpucsOijXT6ZFbxu9LFDtY7SNMFExtR4cH0+yRDGjWveU3SAPe5Pad byyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=wqzgSk2yAwaD4JwY08h7POSFv74VgmyKqxtSsc8PQ7A=; b=Oq8XEVr4jBNAEYSn4BRMEbNqUpEj6t5Iyn4LqNdQuJo0g43FUsyz/+tIe1dvL5WxJK gO5F+N0wMEEzOit7IBH3G6dmAYjO9rIU/DlpUdy8kwu690iOfaQkURdFfTo2/UJCtJRs n5uQX1OGl68iWgEyRKrLR8wMEvNKARWmX60iwZkNkqNKMuGA2iHHMJoN2lW6DP6EvGpG okDuZiQ2vJMZuOrUdUP0hTFoSSLrbCU7tgv33xGOmvIlMllQ21g2/IV+nGJbGd0lneVV xDs8go96cKoc9jsDUd2JVcpu/x4pEZqMtr9yBpQU2JYmMucbH9LeR5n5UAFjmQxARadZ sTMw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WosNmGC0; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wqzgSk2yAwaD4JwY08h7POSFv74VgmyKqxtSsc8PQ7A=; b=cp8E+pbPosE2Z/MFHYbKDazxzqa3/RMf2tibj/N3BKOauS+jHrgsT7tMPjSOYSN/ky VqGfY2IoGVWuC7MAX0V9HPni8V+LwKD8R7dmQxqgs0ZHWkKzNF6iwKVcW1/3vt5hizfo 3mfa+l+O39NpKNSMNz/0iCdwKbmA+kvaWZ7Xs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wqzgSk2yAwaD4JwY08h7POSFv74VgmyKqxtSsc8PQ7A=; b=pLpbNcLcnLnaG18jErENOyG72+BvrixYPaMIv3NFfQK7jhXU8KGDKrE/6MJSGEgvTE kxYTuEGw/PobNmobNyC9vyAPXG+qfnGHT9bLO+hM5FN7Td8Rv+RjXO8bYqHFE0UU+bii tKXfIMLuNnICgB6xvkBG1OqxK48omm9/dANxDOFD62zwEW+/BCMFyBAshckcTUvH4It/ p0i3scbFznVcxN/YerQ0TnR48nCx/Fq1HPM7xWL5xKvLvrRUZj3DgMuntY4CWLj8mRh2 k6iLV5HxwhslWu8Ld4SidtIVrwSf3zQuomyDmQdyxrb0tJBNQzuRatYJwMvMEo3+tPdC 2zEw== X-Gm-Message-State: ANoB5pmtsm4S6U7yyo0EFu6EDYeZNpPAyhVFvA7in894tJKPOf2zLYzr BgyywTUgIpyA3ginaAQls4sEhAO4 X-Google-Smtp-Source: AA0mqf4YVhptieDdhzC3PO1dCbUY8xl4QWiPtoUmFqzyP8gXP7J8cnB5VU3Xoq8gchjJnKz0dxOdsQ== X-Received: by 2002:a17:902:7b8d:b0:189:b0a3:cf55 with SMTP id w13-20020a1709027b8d00b00189b0a3cf55mr37564081pll.71.1671022891954; Wed, 14 Dec 2022 05:01:31 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:c454:b0:178:35a3:84d9 with SMTP id m20-20020a170902c45400b0017835a384d9ls22237968plm.10.-pod-prod-gmail; Wed, 14 Dec 2022 05:01:31 -0800 (PST) X-Received: by 2002:a17:902:ccc4:b0:189:3544:2527 with SMTP id z4-20020a170902ccc400b0018935442527mr26195764ple.37.1671022890857; Wed, 14 Dec 2022 05:01:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671022890; cv=none; d=google.com; s=arc-20160816; b=ToWrtFMpfW+ZqwgpG45cC1aIn1vWFWx2J/ylN3qQpc+Xcn8JTV3pOVwZ19bvMtpIdH yBidZvpu7u0XkTm09KHdpYJvlbZqNtFLbYcS6L01Aj3v5zggPpHOAVA8gOg4YfSy5LuP BDrjsZJ6PWBqSNPmtDIZ1hit9ySwtIu0sUsZa6IQ/nEENw07Jp93gT2G5qmsqZgmOcrd RZJePDId0cwMX+jTyBey5ZdSeNSJitt6WxwZ0UN3g8CZfD9C510H/wlNT59HGMG0MLlg em8W5xyPvS1NaovHzWnr8R2Kwqf7Hp/juBtp1OwDhaJJg9Y6vXGehxkIf/Fslpl4y6Jh XnHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=p8xP8kij82wDybS5wtGDKLPcaFcgrKocGAGJAKH6qlA=; b=VeC7W/2GY1Wq+9+0ETusp4AeUcMadss2mMMyTHhOYxVF1neQKp7NAW/Q7qD8aP0wdG 8SpCuypxhl7cAVthp2eQtDXbezR7h5hpUfXfV7atpbvScP5cyMnB6hkwXPJSWNWJV4h5 +D+sY4PtKP9R35sRD76laiS8P9UIp66XV0ByQ3Kd0gE/4mdAm2+Wt7ZALP/DdfSaCh+A I1nBBQa6FjTTMy4VZNlzZCf9XTiqLL+diNUaPCAUVdkwaet/lJW8AdBqu5TX3fmGRNUC FrNpVdaBL/Dyqh4axeh8N24/+PPa+8Kaf9Yan8RbYg1eWCaUOaF+bySRuGDw1cClNn1j b5kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WosNmGC0; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id t8-20020a170902e84800b00189ae5cf929sor1556291plg.16.2022.12.14.05.01.30 for (Google Transport Security); Wed, 14 Dec 2022 05:01:30 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:8347:b0:189:4bf4:2cfc with SMTP id z7-20020a170902834700b001894bf42cfcmr24468372pln.31.1671022890553; Wed, 14 Dec 2022 05:01:30 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a809:5e03:faf:846e:352d]) by smtp.gmail.com with ESMTPSA id ix17-20020a170902f81100b001895f7c8a71sm1838651plb.97.2022.12.14.05.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 05:01:29 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki , Laurent Pinchart Subject: [PATCH v10 16/18] drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support Date: Wed, 14 Dec 2022 18:29:05 +0530 Message-Id: <20221214125907.376148-17-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221214125907.376148-1-jagan@amarulasolutions.com> References: <20221214125907.376148-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WosNmGC0; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Samsung MIPI DSIM master can also be found in i.MX8M Mini/Nano SoC. Add compatible and associated driver_data for it. Reviewed-by: Laurent Pinchart Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf Acked-by: Robert Foss --- Changes for v10, v9: - none Changed for v8: - fix and update the comment Changes for v7, v6: - none Changes for v3: - enable DSIM_QUIRK_FIXUP_SYNC_POL quirk Changes for v5: - [mszyprow] rebased and adjusted to the new driver initialization - drop quirk Changes for v4: - none Changes for v3: - enable DSIM_QUIRK_FIXUP_SYNC_POL quirk Changes for v2: - collect Laurent r-b Changes for v1: - none drivers/gpu/drm/bridge/samsung-dsim.c | 44 +++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index dd27935081a3..b14efb6fca91 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -376,6 +376,24 @@ static const unsigned int exynos5433_reg_values[] = { [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0c), }; +static const unsigned int imx8mm_dsim_reg_values[] = { + [RESET_TYPE] = DSIM_SWRST, + [PLL_TIMER] = 500, + [STOP_STATE_CNT] = 0xf, + [PHYCTRL_ULPS_EXIT] = 0, + [PHYCTRL_VREG_LP] = 0, + [PHYCTRL_SLEW_UP] = 0, + [PHYTIMING_LPX] = DSIM_PHYTIMING_LPX(0x06), + [PHYTIMING_HS_EXIT] = DSIM_PHYTIMING_HS_EXIT(0x0b), + [PHYTIMING_CLK_PREPARE] = DSIM_PHYTIMING1_CLK_PREPARE(0x07), + [PHYTIMING_CLK_ZERO] = DSIM_PHYTIMING1_CLK_ZERO(0x26), + [PHYTIMING_CLK_POST] = DSIM_PHYTIMING1_CLK_POST(0x0d), + [PHYTIMING_CLK_TRAIL] = DSIM_PHYTIMING1_CLK_TRAIL(0x08), + [PHYTIMING_HS_PREPARE] = DSIM_PHYTIMING2_HS_PREPARE(0x08), + [PHYTIMING_HS_ZERO] = DSIM_PHYTIMING2_HS_ZERO(0x0d), + [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0b), +}; + static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = { .reg_ofs = exynos_reg_ofs, .plltmr_reg = 0x50, @@ -437,6 +455,22 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = { .reg_values = exynos5422_reg_values, }; +static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = { + .reg_ofs = exynos5433_reg_ofs, + .plltmr_reg = 0xa0, + .has_clklane_stop = 1, + .num_clks = 2, + .max_freq = 2100, + .wait_for_reset = 0, + .num_bits_resol = 12, + /* + * Unlike Exynos, PLL_P(PMS_P) offset 14 is used in i.MX8M Mini/Nano/Plus + * downstream driver - drivers/gpu/drm/bridge/sec-dsim.c + */ + .pll_p_offset = 14, + .reg_values = imx8mm_dsim_reg_values, +}; + static const struct samsung_dsim_driver_data * samsung_dsim_types[DSIM_TYPE_COUNT] = { [DSIM_TYPE_EXYNOS3250] = &exynos3_dsi_driver_data, @@ -444,6 +478,7 @@ samsung_dsim_types[DSIM_TYPE_COUNT] = { [DSIM_TYPE_EXYNOS5410] = &exynos5_dsi_driver_data, [DSIM_TYPE_EXYNOS5422] = &exynos5422_dsi_driver_data, [DSIM_TYPE_EXYNOS5433] = &exynos5433_dsi_driver_data, + [DSIM_TYPE_IMX8MM] = &imx8mm_dsi_driver_data, }; static inline struct samsung_dsim *host_to_dsi(struct mipi_dsi_host *h) @@ -1793,7 +1828,16 @@ const struct dev_pm_ops samsung_dsim_pm_ops = { }; EXPORT_SYMBOL_GPL(samsung_dsim_pm_ops); +static const struct samsung_dsim_plat_data samsung_dsim_imx8mm_pdata = { + .hw_type = DSIM_TYPE_IMX8MM, + .host_ops = &generic_dsim_host_ops, +}; + static const struct of_device_id samsung_dsim_of_match[] = { + { + .compatible = "fsl,imx8mm-mipi-dsim", + .data = &samsung_dsim_imx8mm_pdata, + }, { /* sentinel. */ } }; MODULE_DEVICE_TABLE(of, samsung_dsim_of_match);