From patchwork Sat Jan 7 16:48:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2612 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id AFE773F0CC for ; Sat, 7 Jan 2023 17:48:14 +0100 (CET) Received: by mail-ej1-f69.google.com with SMTP id ne1-20020a1709077b8100b007c198bb8c0esf2921095ejc.8 for ; Sat, 07 Jan 2023 08:48:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673110094; cv=pass; d=google.com; s=arc-20160816; b=0x3L7XbgQsIoxWBxdvpamMi6X//SVuFrJ2wohADsaZcbYY6PKPZMxYDGTjdPeD9vY0 oT7APVTSTTCmtwlyNDmPqV4qojHa1Lo0Bx9tICezVXtMTxUlHwRNwGfbPIRePIzAzXyJ jdg8MEpfwOSed+zFm0XD8O8BkY1MkhssADBrFYlOH9RgFF6zr3sL7Z8veljPGjbSUU1e obIrL19mwi0/q9j/i7Qx2t6td2mfeTN2DR+TLldYTogS6YC8Yh2GYQGTx5+nFsgSGsLi tKBkz9xepPIATkBO/Gs068PU+rYNocK9rvcnU5u8Idna7WLIJwa1AuTYc7CVw0nAXmhk 5wGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=Cwr5VPe3U2lzfISEvtJyBN4vxuKmY97iTkDMPREa96w=; b=czjuEMTFAn6hX8b4dGzw2xuYuKWMEVfMvZSJkPL8op5Kq5MboQ6o7mDOCkFiWc/uam Qzt/pkGi7LbBTGjJrOcpvn2cOUQ/Vsh6/0aJMOAPtUw99ani10wG8r3e52sPCEpZiS08 hO0iG+mkHr6p+Of/5u+Hbf2yz5u8N4TD3cHgGsu8AKmqlU5GyFdTUL7htNUNgKWYxVpH m97YhxS0yDJSUAsWVZEJndJUXO0Q9Pe63XtmF5B8t4+NGZuLAzEJtM7aGt5VqjDqNmYw uHCNgsJ+VuHtn6zrtBNNyBPubk4R2xVtMPAL9TNvd8ssJFMsKpXKBy0+/qCzb/pxhDJT 1X4g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=a9ye8VYW; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=Cwr5VPe3U2lzfISEvtJyBN4vxuKmY97iTkDMPREa96w=; b=CwHuExBrXW4rB8b3BT7ov5z4R+W1zwGUN6sNm6DodSVFocb4Xg6XrvbKS5JU4tTBYZ WQUVyeVFQUo8vulaNuaS/kfFVVEcuG9Qd2C0uGUbFKQBfm4m0ypGUmNG1Ek9Gu6Et5w4 xPBEWH2ZPqz3V5+QP26ZjkV2fHXZijQ4IH4+0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cwr5VPe3U2lzfISEvtJyBN4vxuKmY97iTkDMPREa96w=; b=kG4nAoiAohaYyF7vrwlIQWMJB/gL9VATf9Q6aRs+NgzCN2dj+IVdHPX16WBhAuIFSb DkCGm73zt5D8cARnQEzAoQbPvlfSjYjTF6J+SGDupaGhn1xt7KfM4odFbldKHXw7Nc0V P92CYzOXhFW0EH+yfr8RZ1r9GxCEaFBEC5R/Pyc6vAOWECWXaiqC3IHbbEpwINnUdsDw noWvlDuNH1bt4a0JfDnMy2op0mv463q37lGwDsf7qa7cG5srH+EsufGw4JV9w4/KaQ3J rWgCPC/zXW0ZDSm9GurKM1kY/GrBriBlKfzDk1sfYISf986Uxo8hEZFWjvoLHDW8C5on XQ7g== X-Gm-Message-State: AFqh2kp8LUVSnBBLvUSKS5X53NgCCtggv73caCvBx5h5tIFj3nfBwfh6 FIaUHaCsKuhXPMylpZlfM4FzevhX X-Google-Smtp-Source: AMrXdXsrr+QXXefJTzxC+moF0jxqThnGf4XDVebHtjMsRWN4Xtf+gQhNCqH7R68XXnpPozmyaBTs0A== X-Received: by 2002:a05:6402:2411:b0:482:74a:c3e6 with SMTP id t17-20020a056402241100b00482074ac3e6mr7050440eda.378.1673110094419; Sat, 07 Jan 2023 08:48:14 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:907:2115:b0:78d:e7b8:d105 with SMTP id qn21-20020a170907211500b0078de7b8d105ls907417ejb.8.-pod-prod-gmail; Sat, 07 Jan 2023 08:48:13 -0800 (PST) X-Received: by 2002:a17:907:cbc8:b0:7c1:ed:171c with SMTP id vk8-20020a170907cbc800b007c100ed171cmr57173602ejc.26.1673110093275; Sat, 07 Jan 2023 08:48:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673110093; cv=none; d=google.com; s=arc-20160816; b=yIoBVo7ls7TtV0O58C3DZvrFxCeXMkbC9w8313Ug/RdAevd0j5BduGCXkZHodAJY3g BOoWpjZFcNXWU9rtb8M6B19MmovDS8hdb+wStF79ybuZSD1iOsjEICFj/TNQk1xpMGqy r3FBY7F4CcA5cg/Ds3GzRDsJ9H4KyEQT/X2MZLUIRWlUqPVQGN+J0Z8gzSpY6eGlNFg/ wRtaenkCO10ER1K4GRPVa/LHEmRf744B5xs90HsvbnzxnU7ozmDWl5BHxU0RBYV7hjzU IIBMsNbU8wszlI9KDQHFmZbhVJSREXW14s6TIQq0OvBAwrCW6qwV0sp3OGvvZunWr48P n+xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=R5gPc7lS0CaQGjirp7Q/X9iJ7rZ0Ppug9YAC7bxw1Yo=; b=p7XUIkyELBoA7jruYKzL9h/v+aJKXT6023INdKSdH+JQgqpXQAUTvEW+quzZUfeYVh VbzmNmXKbij77NuwF/uTE1tzGtHAQDGUwEJpngv1nOw1H3TNWsevbNAByhA3vlYZHvj0 PozOePJbvxcQQCLyZNXWljjoGWsolpq1untDZhTwkfkO8pDj3oM1NDhdeuLFpkgP5CLU JyKwkUd/pxnYtSbhxtiAEzPOCBGLA6TgRyiF842mbRq2IH1gQFnH+u2+Ma7cNuaLsUyq 2HauFVBZirGlCyXGy9qWpWJQ7bgc5iOGND1x0F8tBhP5DyFZZViqBxDGz6cXSgcuhkSs RHGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=a9ye8VYW; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ta12-20020a1709078c0c00b007ec2dce8b01sor1925569ejc.3.2023.01.07.08.48.13 for (Google Transport Security); Sat, 07 Jan 2023 08:48:13 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:907:7da4:b0:78d:f455:b5dc with SMTP id oz36-20020a1709077da400b0078df455b5dcmr61919244ejc.28.1673110093087; Sat, 07 Jan 2023 08:48:13 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-180-23-57.retail.telecomitalia.it. [80.180.23.57]) by smtp.gmail.com with ESMTPSA id el14-20020a056402360e00b00458b41d9460sm1569862edb.92.2023.01.07.08.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Jan 2023 08:48:12 -0800 (PST) From: Dario Binacchi To: u-boot@lists.denx.de Cc: Dario Binacchi , Mattijs Korpershoek , Michael Trimarchi , Lukasz Majewski , Marek Vasut , linux-amarula@amarulasolutions.com Subject: [PATCH v3] usb: gadget: fastboot: detach usb just before rebooting Date: Sat, 7 Jan 2023 17:48:07 +0100 Message-Id: <20230107164807.3597020-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=a9ye8VYW; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The patch fixes the following error when updating a BSH SMM S2 board: 3:72>Start Cmd:FB[-t 8000]: ucmd nand write ${loadaddr} nanddtb ${filesize} 3:72>Okay (0.023s) 3:72>Start Cmd:FB: reboot 3:72>Fail Bulk(R):LIBUSB_ERROR_IO(0s) The "fastboot reboot" command detaches the USB when it still needs to be used. So let's detach the USB just before the reset. CC: Mattijs Korpershoek Fixes: 5f7e01e9d5d800 ("usb: gadget: fastboot: detach usb on reboot commands") Suggested-by: Michael Trimarchi Co-developed-by: Mattijs Korpershoek Signed-off-by: Mattijs Korpershoek Signed-off-by: Dario Binacchi --- Changes in v3: - Replace do_exit_on_complete() with g_dnl_unregister(). - Add 'Co-developed-by' tag. Changes in v2: - Add 'Suggested-by' tag. drivers/usb/gadget/f_fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c index 07b1681c8a9a..f4311328a2da 100644 --- a/drivers/usb/gadget/f_fastboot.c +++ b/drivers/usb/gadget/f_fastboot.c @@ -421,6 +421,7 @@ static int fastboot_tx_write_str(const char *buffer) static void compl_do_reset(struct usb_ep *ep, struct usb_request *req) { + g_dnl_unregister(); do_reset(NULL, 0, 0, NULL); } @@ -544,7 +545,6 @@ static void rx_handler_command(struct usb_ep *ep, struct usb_request *req) case FASTBOOT_COMMAND_REBOOT_FASTBOOTD: case FASTBOOT_COMMAND_REBOOT_RECOVERY: fastboot_func->in_req->complete = compl_do_reset; - g_dnl_trigger_detach(); break; #if CONFIG_IS_ENABLED(FASTBOOT_UUU_SUPPORT) case FASTBOOT_COMMAND_ACMD: