From patchwork Sun Jan 8 16:17:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2613 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 943343F075 for ; Sun, 8 Jan 2023 17:17:49 +0100 (CET) Received: by mail-pj1-f72.google.com with SMTP id om16-20020a17090b3a9000b002216006cbffsf5958317pjb.3 for ; Sun, 08 Jan 2023 08:17:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673194668; cv=pass; d=google.com; s=arc-20160816; b=WRHAugy++yDVSS3z9FC+JhAt+b9JUWsTw9czOgTlde1SbmmRptgN8kQyS+g0gCJ9y6 M0/mZOwBylgVLn6YBF3fGJV3Rm2i83z3pYTt5Bo2K/vLPfSOfNbZy+waL01eA6dlY8Tc EtWD0ZoH1UvhnyRkFilvakfA9uvFzCsQMVMkHwStCq/jwC8KuU1WS3KCPhHIp7mHqYEJ 4JOh4CYBTJVKRRAmURzmssS+V+oyRsCb66DI+2/p18fVDSPsf+gT9zAohRaGXpCPivoz Z4bLFQDD+NFvNooIOSHUIVeDljbu4bbA8prN1FpL5sNheQnqEImAoLEw/W3L7QwTtM9c PLSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=hyJ/J3v2uEHKSUtUGSbZ+xmGYR1hRLDod0DRDTJa7R8=; b=S15yru2bHK9LKP+gM8VBnOLR9QgykJiugfP/z+OKOoQAJertqv2ElMZTY4EoJTy00B +hhONEgXyByg/LFIoj6V2P4/JghK7xRIcPYC8XoWabRrDohYbEm01Sleo3eqIkqkiB0E IqCqzqL+keRoHGj/pEqkeH3g47eQ7c6Wev4hMaXeAYwJOaaHp08jUcnPcSYpQrujVI22 7TJspYsCx33aKsSuNDkDWCMaw55uhktHxdRp6osLB4EpW6OPsJchPcUMnxVrXkLvydv7 /O0B9zid50Gn1lHjojngVy+0CzlCYAvFCziSsd1zHnlkp7TszKoXLKe6s5FIB/8hBWdL R0XA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=gyymas+Y; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=hyJ/J3v2uEHKSUtUGSbZ+xmGYR1hRLDod0DRDTJa7R8=; b=bf6rCW/49sb0vhbr7DV8nCnxOhHEzzLxVRdkFrj0iFUSvaxGX8It2oGbP/6qHTUgZk INpuGouFib9Bub4t78pckslp5TTnnIEKOpZ/gvZ0l8bEVh7d3PMPOF1RvLbP+PwkERjf s9Ua/QMDvig8o6vd7cVUnki9o3mGdgXdJ1qO0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hyJ/J3v2uEHKSUtUGSbZ+xmGYR1hRLDod0DRDTJa7R8=; b=yfVtMP1Gg8xbc7E5uPtVnUwk1Osqj3lKw+H6C4mK+qsS+9d+K4hIEYPzEw3ODz+hOg UxlRrVVkTbkckyFI5N9iYtl0JR1ZXJVxTsGsS7ghRps0JjKfPgXz5cU4gK1MG2Lqh/+L 8mlZMcyt0tjabW9L7pSc2bU/D9xyAMifLSXn5OdUF/jjP+V/sbYUsDbg6A9mzQOyyCHi KqZZJCus4NUPlGt1nfikIUuuT/WhxLT6QeCNn6SrHenMiFSmHlbbPQ89xHID6CIzKDNX zn43LFhLY4niKXSgh0KtlNAqOKTUbY2nhXLMVzZM7h+QmgBBfL57eapRet6bwL8pR7GG UGGg== X-Gm-Message-State: AFqh2kr9RU6+x4Hd5ZoYmzYkdBDzptJ+XAqlYLwsBTxod0emoinejNC9 Xg0+oUnCKK9eJUwCQvekIQZ6ziUd X-Google-Smtp-Source: AMrXdXsnKZ0F8/sk6KWsNQw94IMlHiTAT8Dodwcl9LXnHj8qQ2DNOM8CnvO1ekChb+4+6sKB21sKtw== X-Received: by 2002:a17:90a:fa9:b0:225:bf53:e476 with SMTP id 38-20020a17090a0fa900b00225bf53e476mr4214315pjz.104.1673194668196; Sun, 08 Jan 2023 08:17:48 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:b214:b0:178:5938:29de with SMTP id t20-20020a170902b21400b00178593829dels3688285plr.2.-pod-prod-gmail; Sun, 08 Jan 2023 08:17:47 -0800 (PST) X-Received: by 2002:a17:902:ccc1:b0:189:5ff5:eb92 with SMTP id z1-20020a170902ccc100b001895ff5eb92mr81430241ple.39.1673194667257; Sun, 08 Jan 2023 08:17:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673194667; cv=none; d=google.com; s=arc-20160816; b=y9H/lTwr7pWlBLhQBut863EfGh9IGg7cF/a9ZlfSPdscZFfiFBqAsyjiTASkkBdlmN BRwDIdiLEVX146kVwrnTWvZ2LHx/zkH4lOotTFicpbwxb7j6ra3SIuYNUDoMqoWylfBV HcGVlgNtSVUm65LYeS38SU1+MMDYJaIAFDSZurO9C7VO9GNYlANA+IgmSPsB1XKYlS85 ngMq4J4bZX0P93k8UqevkVEJ+iYfVrGSDawtSoljmaDmUI7B7NQZJXBIoqXTt0ZlRLDA Cy2cEuUkRySmg2vK/3XdGYLJrmoZlg8LLtLFiH0X9qZncb77kqRdVQtESn0gEGkIpv2I ki1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=/n2KAR1PU+C7MlpQzvrMpsLN7XNMseGEF8OoAgxuTM8=; b=R8Ly5Po9d7RM1FiRCTitj39ftsiPd6Hhqri2EM6Ze/NvU8zQ7F0WZsNWQqCGjoYCRF Qcw9+M12L4RYr1dSpyQfyPTeuzH8SFVPERBJvlOLSnrSgmArOx2Oi8m+/G0uVO5xsnbc ubq8xWi5mYLk+zjOArMu0PwAVJMgansNMKhYq+OthjdGVdvR3UVbraOY6nAtbmZULf/Q Udw0pfzGbO9Zhu1ADjoXNnegHQ498Gck2mh/k5senoa6oUAFOXugpTqka85ZVarm0wWU WYC/f7YC5VTc5Mp0UDpOFxDUy2z1OwyQG1h6yqT9WOcX5Zaaf4MO10BbapinnSM/3L3G itVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=gyymas+Y; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a9-20020a170902ee8900b001925284c1f1sor2790920pld.156.2023.01.08.08.17.47 for (Google Transport Security); Sun, 08 Jan 2023 08:17:47 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:903:1358:b0:193:d0f:5d68 with SMTP id jl24-20020a170903135800b001930d0f5d68mr9068051plb.25.1673194666834; Sun, 08 Jan 2023 08:17:46 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:3640:1796:9817:626f]) by smtp.gmail.com with ESMTPSA id w13-20020a170902ca0d00b00178b77b7e71sm4351976pld.188.2023.01.08.08.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 08:17:46 -0800 (PST) From: Jagan Teki To: Kever Yang , Philipp Tomsich , Simon Glass , Tom Rini Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com, Jagan Teki , Quentin Schulz Subject: [PATCH v2] board: rockchip: Fix binman_init failure on EVB-RK3568 Date: Sun, 8 Jan 2023 21:47:34 +0530 Message-Id: <20230108161734.50094-1-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=gyymas+Y; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , For some newer SoCs like RK3568, the Rockchip has not released any DDR drivers yet so idbloader needs to create manually using DDR binaries offered by rkbin. This indeed no requirement to enable TPL in the U-Boot source code. If we mark TPL disabled and mark BINMAN enabled by default then there would be an issue of binman_init failure during board relocation. This is true as binman failed to find the top-level node like u-boot-tpl here. Here is the boot issue observed in Radxa-CM3 RK3566 board, U-Boot 2023.01-rc4-00057-gac2505d463-dirty (Jan 04 2023 - 23:44:18 +0530) Model: Radxa Compute Module 3(CM3) IO Board DRAM: 2 GiB binman_init failed:-2 initcall sequence 000000007ffd2008 failed at call 0000000000a18cac (err=-2) ### ERROR ### Please RESET the board ### This might be fixed via binman node in rockchip-u-boot.dtsi however disable BINMAN_FDT for evb-rk3568 defconfig for now as we are at the end of the release cycle. Fixes: 05713d570762 ("rockchip: generate u-boot-rockchip.bin with binman for ARM64 boards") Cc: Quentin Schulz Signed-off-by: Jagan Teki Reviewed-by: Kever Yang --- Changes for v2: - disable BINMAN_FDT in defconfig instead disabling BINMAN in ARCH_ROCKCHIP configs/evb-rk3568_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/evb-rk3568_defconfig b/configs/evb-rk3568_defconfig index db3acf5be5..e799690578 100644 --- a/configs/evb-rk3568_defconfig +++ b/configs/evb-rk3568_defconfig @@ -64,4 +64,5 @@ CONFIG_DM_RESET=y CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYSRESET=y +# CONFIG_BINMAN_FDT is not set CONFIG_ERRNO_STR=y