From patchwork Mon Jan 23 12:23:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2641 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 336D43F039 for ; Mon, 23 Jan 2023 13:24:22 +0100 (CET) Received: by mail-pl1-f198.google.com with SMTP id u15-20020a170902a60f00b00194d7d89168sf5991760plq.10 for ; Mon, 23 Jan 2023 04:24:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674476661; cv=pass; d=google.com; s=arc-20160816; b=PTeLDgNrp5ofRaiMV0/DE3x7kUDye/kIacpXrTcqlJ6rcXtRW9WJPzZIYWbebTRsPo xgyAA7++25snYyMmQSLZSNiWibXC5w0cwHRQJh8uZV+rrXOGqzY8Jo4EIr7SKNeiUqLx a0AyEsh9pXpDaZ6Sh4iWYQbOBgO6LElN6TImp2Pi9CjLOUSdNNaNOllW0lYdllN6DAl7 8wGDIO0kZv4w4myE+1H66VULAxi1pW64/xtHi1+8T72dWXZ6hOfduEIFZtBix93C+Dzz 99c6adG96kBuIJmoZeDc3xETpdA/Q8/dwIX52fbaC6ypg7+JyxA2P5AKlyaAE3GvN0cB QvZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=XqSpdrri+fiCeYn6ib5UNY9VKQ9PiJqW/JTVZ4J7k5A=; b=jVB3aUOPzt02UEZOwzKFkbOT3WMQ7ADi5kCjwKgsLfK77NcnIdy2YC0pWuwnoG96et fR2RKGQsJbEWgWk99/irlggob76rlNmVpyVaT1ssCIOV7je9Dct6kwtlb4MZtM14Zv2i OdS7OMFR0e24Y0pXse7gz2aFixCXXHCWS9CfFWWnyKZG0lZRm4sDsphGzfmXzv9/1LL+ aCC4Kx4qaIDzyvBdymxnNIXxbdipZMI2Qxo+5IMA1o0gzq74CAfmKqumo3C7h8PWTVPw RLi/Dmw3fRcZtEFsE+7KwwzWUSzJ6z8c5UjpyebK/Y08C8K3woKTmVRnldc/PRy9s0Mr YNzQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=I4JqfJ1d; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=XqSpdrri+fiCeYn6ib5UNY9VKQ9PiJqW/JTVZ4J7k5A=; b=rXMKrlFBc1x53TaPMyJjnZDq/o1A9R/SXSOEGD4AHu8cZvouAgDu6f1BeYkDMQJZgr WSL/Bm0QRJMJSy9xiGSicuQm7bq8iRtAn8AQJ1XHWTFfQcgIlZgLjziDCeW52sgcIdEg /+i13WtzsiP3XoicP5tirlwB6F4bDtE1VgRag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XqSpdrri+fiCeYn6ib5UNY9VKQ9PiJqW/JTVZ4J7k5A=; b=14GCGUiptu4ZORcZGsMujrTIBB8MJgyiIxDcW/lkShlj4TA7MLU54xLHiTpqfH9QiY Kp2e0cCqAtLN0auE1uI4gvGU1vFZWRLt2wcHnXPJWogeAyZx/888hklI409X6NYoIbqs zdCEo/CnNOWmPhnDphJ0k1O+kIQ+AHlvoRiqSzt1nckGARHiFoLNxTWiyOYusSNcHcdt p4d8XksneZajS37/D4TYJ/URxySR/MbEqxUso7KXdJguTjUZiqlAHuDAppA08NoSyZed 3rnDB9J4xnXjO62nmg+TJ2dAl0wpTL/Roe4EcHqkPZw+SWHCaeuBqmiHckISNAiuMBll IXew== X-Gm-Message-State: AFqh2kpdSqQh8fshKvQXJTEl26pXlATj5Lio1wlG/MYWO/KMfs7+baA/ cJ+wyubHb3iQUnVOt+Wcu5gT4Rvy X-Google-Smtp-Source: AMrXdXvlk7+AuDWcxK4zP5yA8IiRf6RxsFaBNV/QhuOfdzv7vG7eZ2Ug/GFPAC2yN8E3jHREyH7Qww== X-Received: by 2002:a63:4a5b:0:b0:477:1a2:390e with SMTP id j27-20020a634a5b000000b0047701a2390emr2553998pgl.83.1674476660811; Mon, 23 Jan 2023 04:24:20 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:d34a:b0:178:5938:29de with SMTP id l10-20020a170902d34a00b00178593829dels12750649plk.2.-pod-prod-gmail; Mon, 23 Jan 2023 04:24:20 -0800 (PST) X-Received: by 2002:a17:903:200a:b0:194:60c3:48bc with SMTP id s10-20020a170903200a00b0019460c348bcmr21945885pla.27.1674476659969; Mon, 23 Jan 2023 04:24:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674476659; cv=none; d=google.com; s=arc-20160816; b=dNFLcATALd2NQZ7bc20U/3ZLGyajp7vSAZ6nLN61axQPySEP+nB5VAZgC9cdP9WrjG kweI8ZqQTKFATyG35FlS7VLT+YEefMOs2c4CLaK7JizR9o4+wjPH+kPSOGNed+da3Rke MBb/7ZWxwodcpknJErkbDtJXLqJZ8GYyj9swdVHLD3GeJ3VQJhxqaAeA/D3EuHDACaG6 QEaiE3SPbWDUFWDf5uFYBnnkTAbn8Im+EC+6RioDkDgfv41HdSEkc64FemlT7ZfYMkGa BNljmehRYAarJQQ2NtBAznTpfqSQ7w7RgwzzDv0QzDNDYToKPY64wpDbjfxJ4hY2SKyt hESA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=U9Y+6AYElVzmPLEEE0cyqelpoYne/+Yj3ASyLzLLBEM=; b=BBLGUEjiDh7pEKg1VOuJMt5zt+FA7DbzT9G66gFDc1/BBLgPmep+NwgSoF+uyfIepE JsVUu8pa81hg0pxmcGMJoegZfZjEAZs/Fnzdi2D50BdwRIuitTp/3+ql0stkzsAVKlnd dPUEB2ZAmUEqRZrH4SstbxQlq1PCmNfnlI20Ij5rvK6vJ01wt2P3hnTYz9g+qB/QEpQk DtK0jBWaS9ucfG/KzzR1TFoTc26f8OOfZINo3AVWC81Kh5nQ2ApU9+vO97KMrktiCSDE 42fd+8mte/f40mTDZQg55oqmH/o1Fhg/6d3ezXAicOCUluMT3s0Nc95krjj9jRbDrbmE c6kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=I4JqfJ1d; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id u11-20020a17090282cb00b00189bf5e03a6sor626427plz.77.2023.01.23.04.24.19 for (Google Transport Security); Mon, 23 Jan 2023 04:24:19 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:903:1c7:b0:194:ddea:2ebf with SMTP id e7-20020a17090301c700b00194ddea2ebfmr17540876plh.17.1674476659631; Mon, 23 Jan 2023 04:24:19 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:2279:f361:f93b:7971]) by smtp.gmail.com with ESMTPSA id w10-20020a170902e88a00b001960806728asm1291811plg.88.2023.01.23.04.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 04:24:18 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v11 06/18] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset Date: Mon, 23 Jan 2023 17:53:07 +0530 Message-Id: <20230123122319.261341-7-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230123122319.261341-1-jagan@amarulasolutions.com> References: <20230123122319.261341-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=I4JqfJ1d; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like PLL PMS_P offset value varies between platforms that have Samsung DSIM IP. However, there is no clear evidence for it as both Exynos and i.MX 8M Mini Application Processor Reference Manual is still referring the PMS_P offset as 13. The offset 13 is not working for i.MX8M Mini SoCs but the downstream NXP sec-dsim.c driver is using offset 14 for i.MX8M Mini SoC platforms [1] [2]. PMS_P value set in sec_mipi_dsim_check_pll_out using PLLCTRL_SET_P() with offset 13 and then an additional offset of one bit added in sec_mipi_dsim_config_pll via PLLCTRL_SET_PMS(). Not sure whether it is reference manual documentation or something else but this patch trusts the downstream code and handle PLL_P offset via platform driver data so-that imx8mm driver data shall use pll_p_offset to 14. Similar to Mini the i.MX8M Nano/Plus also has P=14, unlike Exynos. [1] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n210 [2] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n211 Reviewed-by: Marek Vasut Signed-off-by: Frieder Schrempf Signed-off-by: Jagan Teki --- Changes for v11, v10, v9: - none Changes for v8: - updated commit message for 8M Nano/Plus Changes for v7, v6: - none Changes for v5: - updated clear commit message Changes for v4, v3, v2: - none Changes for v1: - updated commit message - add downstream driver link drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 5918d31127aa..7a845badb1b2 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -194,7 +194,7 @@ /* DSIM_PLLCTRL */ #define DSIM_FREQ_BAND(x) ((x) << 24) #define DSIM_PLL_EN (1 << 23) -#define DSIM_PLL_P(x) ((x) << 13) +#define DSIM_PLL_P(x, offset) ((x) << (offset)) #define DSIM_PLL_M(x) ((x) << 4) #define DSIM_PLL_S(x) ((x) << 1) @@ -263,6 +263,7 @@ struct exynos_dsi_driver_data { unsigned int max_freq; unsigned int wait_for_reset; unsigned int num_bits_resol; + unsigned int pll_p_offset; const unsigned int *reg_values; }; @@ -471,6 +472,7 @@ static const struct exynos_dsi_driver_data exynos3_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -483,6 +485,7 @@ static const struct exynos_dsi_driver_data exynos4_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -493,6 +496,7 @@ static const struct exynos_dsi_driver_data exynos5_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -504,6 +508,7 @@ static const struct exynos_dsi_driver_data exynos5433_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 0, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5433_reg_values, }; @@ -515,6 +520,7 @@ static const struct exynos_dsi_driver_data exynos5422_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 1, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5422_reg_values, }; @@ -628,7 +634,8 @@ static unsigned long exynos_dsi_set_pll(struct exynos_dsi *dsi, writel(driver_data->reg_values[PLL_TIMER], dsi->reg_base + driver_data->plltmr_reg); - reg = DSIM_PLL_EN | DSIM_PLL_P(p) | DSIM_PLL_M(m) | DSIM_PLL_S(s); + reg = DSIM_PLL_EN | DSIM_PLL_P(p, driver_data->pll_p_offset) | + DSIM_PLL_M(m) | DSIM_PLL_S(s); if (driver_data->has_freqband) { static const unsigned long freq_bands[] = {