From patchwork Mon Jan 23 12:23:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2644 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id D2CF13F039 for ; Mon, 23 Jan 2023 13:24:43 +0100 (CET) Received: by mail-pl1-f200.google.com with SMTP id i16-20020a17090332d000b00194a7b146b2sf7149878plr.20 for ; Mon, 23 Jan 2023 04:24:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674476682; cv=pass; d=google.com; s=arc-20160816; b=S3s1LPUbH9+dU2Ta6AP2STkDeRdCSnv+NUGsFcHjbkGW+GQnoAEUjrG/J4MPH+QO3B Nf1tjgXnI1NvnwTxwZ5Ofl/jNsIFaisTLLd8Af2D/mkdCOJUZzjFPGI36Ia8KjQZnP2s 5iswGYneC3hKHw8f6cG16NLEGUpdfPU8WI0wzk3/A+S0SUcYDUv0VCGTIDlM82XJHKZP BURW5NIgdPrcmotcPFciZptUEz9k4X41NxJPMFnyBs2PU19GEBzDj5bGNJPZjPoH999Z KUcKsc19vy11LicQK5uzDtODG5s/E/siAIwDCSlyqflxfFY8RiRPASXaJdJk6hWakttq ozyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=/r+Rp44y/rADMooKmX9HI+58ggoF1KouygHlGrmsMAI=; b=JaLAiVNlOReVVKVot34k6NAwQBYXVr5xdkQfdEn9ttRp40chTJmM8cCX0o97b1wW4h jE+1gj9u3aGAD6Sdqpndp4r14lTqoQMp8utyKf7kktZpOBbQBF3JgU+HybyxuIjyrsx3 vE+1Jrgk8wx0itexHnsixGkQn/IuJWtWOoNqX7SJsVMRUtHaKwEgAWC1IQroQzLw5dnk 4WhDM6KItdEW1p6wpky6fXrJ4JnnF7RAB0xnc9BJD6CCFkvLeoAy6ru0/jhnVUEJFVwh xvLyCRTjzb2rzyvHXp6JN12PYbrUWlwtAWHGs/Oi86cxN99CEvEqp++YVqrUuyAj2ed3 ErsA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=LHsaZXrF; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/r+Rp44y/rADMooKmX9HI+58ggoF1KouygHlGrmsMAI=; b=Aoo3CS7CVPuQT9SCa7nb/tTQEF5ge1iAJJHUYTgQzgCaOoOws3ZYq0hTxbMbpt90WX ey0/wAzvPIzl8xgLfHOveT4EQpqM9owe4hEh9LtnH+eREVojmJyyo8W5FfHbytQvB0gr KVdTJLI2ow/oRFZqVLVA+IH5f2Nue9cCkM+AE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/r+Rp44y/rADMooKmX9HI+58ggoF1KouygHlGrmsMAI=; b=lMKq+Vexo40wZ+wrSRfCssSeHcEuVgAh3uI+qUKikMGai+FitOM8WybSu78gUkYIYZ 0OPzemOUnjKBRQJttEOuGR18T7AcNywgtMfyqaPJ9fCaAjLn+331jwN/3SDWzxTzcQ1B phmZ8oEg8O4hioJ3x7QLeztxeysizCGCyVqgeGmCGYex0nHcScCSnc7H6RsgicyDKT6n HtpatDT059N45ViSEswxPjPDKIr2CJkqsHFgyubb0H9mFRbhdRcT//RNYB3Clj5s7yLS ugFMg3bmTTDPBqwNXHVIHsfH5DnuG0i52LrJq9cTby/rURCcptmq1nwL4g3xhmaaaNqI Yt7w== X-Gm-Message-State: AFqh2ko+woR762oGQ2NUWikzldb5FnqYmVwjoGvgHiX8pCyDjzAQamAz unuYXsFphIBq91bJHHgLyPUs5hWU X-Google-Smtp-Source: AMrXdXuyr99Ajmo2X4zE6nIlH1OhsdPJ80dG+k4uA9ncFfhJ7w/QWi07VgSASdMqRH8TafNkAWIikg== X-Received: by 2002:a05:6a00:15d5:b0:58e:61e:fe3 with SMTP id o21-20020a056a0015d500b0058e061e0fe3mr1685606pfu.46.1674476682611; Mon, 23 Jan 2023 04:24:42 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:d34a:b0:178:5938:29de with SMTP id l10-20020a170902d34a00b00178593829dels12751496plk.2.-pod-prod-gmail; Mon, 23 Jan 2023 04:24:42 -0800 (PST) X-Received: by 2002:a17:902:ce08:b0:193:3594:82e4 with SMTP id k8-20020a170902ce0800b00193359482e4mr28855684plg.18.1674476681729; Mon, 23 Jan 2023 04:24:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674476681; cv=none; d=google.com; s=arc-20160816; b=iVQMX2d+TYfNFaCHdHxbE1dekl3pM1pJ7+mSgosL4WeRLi1s795mCA0Tx35aqXiIlC 3u/WBveS2X/ggErhea1Z61DrOiRUXaM4LK8de8XcD+YrZi+ENcigCF4mVFYpbeNRVyXl fkvM7bsqcxEjPTbW+vCmtO43GkLlZTr2Raj1n/3mcvofPrcPJBy5VCVV3BzOZ8dIal/7 LjRcPFMX63TCGNhjzh7q+t4hr88BI7LcxpDHhQpNNs+f+BsOZQaO1d0gKxVm5Xi2adeV nlaZMXra4HH0McT7DHYMtSs/s0ZgORf53snV+3CvxxMwLnuY0DKOYmGVJboURxtCE4Ki JIdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ZmqEZ1iXO1eGhLfnNAeBU9ZBQZ2NXFn8ddY5s0UykPQ=; b=UPXo5Dy0RSWijJQeqh213T4mODJXV9N8PbBjOKG38ts8BJdekW4PsirYequm9/Btl5 pEpnrPgejwatyTQnD26YLmYg6lCfOJx8mSKGTOAC44t/aOO4SwHKO3yHxYjlbCyC+ILz /9FXSAjlc6zGfpnsLYaD8HWlCCF5pOtUBiRtQLynu8pUPzbaW/L2EhjhouGR7C4dX47e zU1cxYVV/4EtIgQtDITBmSBXzshd5++YhsSGHvJQvzez5tXKK6g7lswGQT8aXGyfR1c3 Bjn+VBSsQEPIV5+wuWKq3MX01yCIiMB4q5XScT5OhB5asEycFR06ZlTUaSpfwuJhggxv Fnsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=LHsaZXrF; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 12-20020a170902ee4c00b00195fc76aef8sor1843924plo.50.2023.01.23.04.24.41 for (Google Transport Security); Mon, 23 Jan 2023 04:24:41 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:e892:b0:194:d2c7:ea46 with SMTP id w18-20020a170902e89200b00194d2c7ea46mr19308910plg.68.1674476681355; Mon, 23 Jan 2023 04:24:41 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:2279:f361:f93b:7971]) by smtp.gmail.com with ESMTPSA id w10-20020a170902e88a00b001960806728asm1291811plg.88.2023.01.23.04.24.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 04:24:40 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v11 09/18] drm: exynos: dsi: Add atomic check Date: Mon, 23 Jan 2023 17:53:10 +0530 Message-Id: <20230123122319.261341-10-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230123122319.261341-1-jagan@amarulasolutions.com> References: <20230123122319.261341-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=LHsaZXrF; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like an explicit fixing up of mode_flags is required for DSIM IP present in i.MX8M Mini/Nano SoCs. At least the LCDIF + DSIM needs active low sync polarities in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work properly. On the other hand the i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020 says. "13.6.3.5.2 RGB interface Vsync, Hsync, and VDEN are active high signals." i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 3.6.3.5.2 RGB interface i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 13.6.2.7.2 RGB interface both claim "Vsync, Hsync, and VDEN are active high signals.", the LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. No clear evidence about whether it can be documentation issues or something, so added proper comments on the code. Comments are suggested by Marek Vasut. Reviewed-by: Frieder Schrempf Signed-off-by: Jagan Teki --- Changes for v11: - collect RB from Frieder - fix commit message Changes for v10, v9: - none Changes for v8: - update the comments about sync signals polarities - added clear commit message by including i.MX8M Nano details Changes for v7: - fix the hw_type checking logic Changes for v6: - none Changes for v5: - rebase based new bridge changes [mszyprow] - remove DSIM_QUIRK_FIXUP_SYNC_POL - add hw_type check for sync polarities change. Changes for v4: - none Changes for v3: - add DSIM_QUIRK_FIXUP_SYNC_POL to handle mode_flasg fixup Changes for v2: - none Changes for v1: - fix mode flags in atomic_check instead of mode_fixup drivers/gpu/drm/exynos/exynos_drm_dsi.c | 28 +++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index d4a976d86f08..d8958838ab7b 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -263,6 +263,7 @@ enum exynos_dsi_type { DSIM_TYPE_EXYNOS5410, DSIM_TYPE_EXYNOS5422, DSIM_TYPE_EXYNOS5433, + DSIM_TYPE_IMX8MM, DSIM_TYPE_COUNT, }; @@ -1465,6 +1466,32 @@ static void exynos_dsi_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +static int exynos_dsi_atomic_check(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state) +{ + struct exynos_dsi *dsi = bridge_to_dsi(bridge); + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; + + /* + * The i.MX8M Mini/Nano glue logic between LCDIF and DSIM + * inverts HS/VS/DE sync signals polarity, therefore, while + * i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 + * 13.6.3.5.2 RGB interface + * i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 + * 13.6.2.7.2 RGB interface + * both claim "Vsync, Hsync, and VDEN are active high signals.", the + * LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. + */ + if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM) { + adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); + adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); + } + + return 0; +} + static void exynos_dsi_mode_set(struct drm_bridge *bridge, const struct drm_display_mode *mode, const struct drm_display_mode *adjusted_mode) @@ -1487,6 +1514,7 @@ static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_check = exynos_dsi_atomic_check, .atomic_pre_enable = exynos_dsi_atomic_pre_enable, .atomic_enable = exynos_dsi_atomic_enable, .atomic_disable = exynos_dsi_atomic_disable,