From patchwork Mon Jan 23 12:23:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2645 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8F2EF3F039 for ; Mon, 23 Jan 2023 13:24:51 +0100 (CET) Received: by mail-pg1-f198.google.com with SMTP id y187-20020a638ac4000000b004cf52d8bb9bsf5377400pgd.21 for ; Mon, 23 Jan 2023 04:24:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674476690; cv=pass; d=google.com; s=arc-20160816; b=hqPmgyc4G9Z63dHx81mIz+gcHSjoIT0/e1A6f17DUG9cKFsPO499enQmd37xoMkotM H8l6da2c5l2mvthqOZP4yKBUtwIBCOB/ypdX8j2cBbQKybf1rgq411A8VADnqPmOh7RL p2MEzJ5i90TzhfzGmMQWiFgbquaeWOiMGWTeO5sSq5P7W1JC93i+gqvrsvv14thgOxPo DdqHsUAHW9ecnK1tudtU8e9L2IJdprpSHkqKdVzm8/Aqtp6l12zpOlSRyi//4t5LM+3a 1lhz2mAKGuWbWG+zQrSfCz96qRVyY6OX/Y/p7fDaRM7MLpbsHYrFNFyPTEHngFOspnqD 9g+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=TOHScWrBcXF2/h4rNTxkI6FzDK25kXGkvOvwcpOnPX8=; b=gYhZZUyCqlxx95HRYR7TO7ywDIdZqpi54uHJf81zKaPdQDMxpcDuhYaXSFEFM2vNfR sEgzc80hSEEPDlR5bOL44ae9BCv8h/UBEyui76C1jJleys1AE1ujnXqryxKeZSyd+/rF IVeLH7xNZdtVXxTCujco8nqQqnjVPR4dGdwAizBRtYJrriyrsq9mJD2qKO09j4TTqu+D uhxzg0Rbd5Xq+rUElwF0hOP/I6IOP7I6BWzMW5iMt6kwW627hvKksdeKzwnVIZRj6HuW 9r7THFFiKHEyKlQEbPnslf5vc1hOQfjz3654ZUag/rOTnLS1jD03uWd8Tdm6i6+6sAjf tvuw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nLSc4UWw; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=TOHScWrBcXF2/h4rNTxkI6FzDK25kXGkvOvwcpOnPX8=; b=EoSz0QJsnvET8FhhGsRhvc67HsXqUeEQFjJSWi8gREmT5ekfIRzn89CXsPbOwFikxz h7youhDk7QcktGgVYbLk1UCHojxgJKlcPGZYQjQMsn85rs/dhSZG8T+rNh3FlsOGBEMd 8Iw9KVvuO/b/Z/2cUOKkC0JSDcI6p0nxTLtV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TOHScWrBcXF2/h4rNTxkI6FzDK25kXGkvOvwcpOnPX8=; b=iH7Xdy8t0Wyz2eRxfgA3nIaAh6BU/kgNOjjONR6CxNUCZLWNFJyHZIXPdB0RBjziC8 9O9OitH/6K1PQCkdmvP2+5+P0ks8tQurogXz5g3QVj37VHZKCwwn155/9fyyam5W2tVj TrYjWi9iYz06hgUp14M1y58i6GcR6lKY+C5JKYhCcMwmz+AoyIUiQDaN/P+8krZhnkfl /YpEDgUOstnZfHTBzK6VSUrPXLym/VKPDdpwn6oURQzd1PuFG2OR/9HxMza5lw5fhnlj 4/rmeuZqJJipqbJMn/OX/FnlHgg//KslT/VKwNK3rpJYd37t9T/s6RvnGn0BlrjHf+XC GpdA== X-Gm-Message-State: AFqh2krf+1tigPt8P3414qi04AL8x38vnEcylL0dhjE9FRCWUiVONrO1 SIYqBzlOnDq9OnSPa98GnFWiPSIr X-Google-Smtp-Source: AMrXdXtEgaDAkh6XjmebvG8+89SKd9PpaxBkQ8d+S9iR62Gyxx7BDCL6ri3jj2ywseYgk0G8KUxsnw== X-Received: by 2002:a17:90a:7d05:b0:229:1cb8:8f1c with SMTP id g5-20020a17090a7d0500b002291cb88f1cmr2470289pjl.65.1674476690278; Mon, 23 Jan 2023 04:24:50 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:903:1343:b0:192:4b3b:ba41 with SMTP id jl3-20020a170903134300b001924b3bba41ls12707379plb.8.-pod-prod-gmail; Mon, 23 Jan 2023 04:24:49 -0800 (PST) X-Received: by 2002:a17:902:d4c3:b0:194:d7d1:4c10 with SMTP id o3-20020a170902d4c300b00194d7d14c10mr15986689plg.66.1674476689414; Mon, 23 Jan 2023 04:24:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674476689; cv=none; d=google.com; s=arc-20160816; b=hyIAHphqfoYJZBPFg9yLwDSUqwtKpnKaYll1vI7jurBfPGIx2KxrGouc8lxHKj7BD+ o1s8jxo5DeDP37TwcI/t8jqpxmuJ28/fxDXb3LKSA69v5lsv8KwFN5bwFy0A+8iD6nZx MLFI8bXNDrJL1K5Iqa3e+7lt6enbYpH42VuPd9JHCBn/i2xuBG7SyXhRtY4F50U5vZg7 fpk6Iyk6AVkv1JCdLSpz3TvbK74IhCrzvaLE1ygnV17ralU4XxgHLhErNMzFwm4yJ8cd wMO1c6d3mm7ok/norcFdnXXedWIbapwTRlLFChD4DEgdLVZNt82mkdoKVotzfkwQJx8U zc2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=cD1qAiqhfd1q1+yXxcnzmuelB54aAtoGJRwcpOhnRjA=; b=QpsqZtlgmis/IpoCWnYrm5yI63WGFTSJt4vk9rJSSU+iMdCtJ8ouWp4mfYQUx65N7r rdMZZDCOWPNHERGCiKswyV8/k3xoqjgMSV0kfWqtEpDA82whRc5fII2rskbJWzyXNUL0 xqxCg5x8hR9wp4Qvh1KZh8GZEh0JvSQfjA4wQ8gKdr3m3Zgt7EQwPpcLExtrrgEJE9pr 3LVA9oGlwedzRCR2DIzc0LipT+WE5pKHr0wHM9D9QrCON1Z4jTfaTh44NPUNcRV+sLCA ROBOE3OAyRzoGxf53LW+/EnrQeS+qhdUsJCyilxNrZ1UQirnF4uWxuiSKid4ZazU91zQ Qs9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nLSc4UWw; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id c8-20020a170903234800b001890052b48asor1676079plh.87.2023.01.23.04.24.49 for (Google Transport Security); Mon, 23 Jan 2023 04:24:49 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:e5d2:b0:191:3808:14b0 with SMTP id u18-20020a170902e5d200b00191380814b0mr33659343plf.4.1674476689065; Mon, 23 Jan 2023 04:24:49 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:2279:f361:f93b:7971]) by smtp.gmail.com with ESMTPSA id w10-20020a170902e88a00b001960806728asm1291811plg.88.2023.01.23.04.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 04:24:48 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v11 10/18] drm: exynos: dsi: Add input_bus_flags Date: Mon, 23 Jan 2023 17:53:11 +0530 Message-Id: <20230123122319.261341-11-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230123122319.261341-1-jagan@amarulasolutions.com> References: <20230123122319.261341-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nLSc4UWw; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting the i.MX8M Mini/Nano DSI host to add additional Data Enable signal active low (DE_LOW). This makes the valid data transfer on each horizontal line. So, add additional bus flags DE_LOW setting via input_bus_flags for i.MX8M Mini/Nano platforms. Reviewed-by: Frieder Schrempf Suggested-by: Marek Vasut Signed-off-by: Jagan Teki --- Changes for v11: - collect RB from Frieder Changes for v10, v9: - none Changes for v8: - add DE_LOW for i.MX8M Mini/Nano platforms. Changes for v7, v6: - none Changes for v5: - rebased based on updated bridge changes Changes for v4 - v1: - none drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index d8958838ab7b..5518d92c8455 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1691,6 +1691,10 @@ static const struct component_ops exynos_dsi_component_ops = { .unbind = exynos_dsi_unbind, }; +static const struct drm_bridge_timings dsim_bridge_timings_de_low = { + .input_bus_flags = DRM_BUS_FLAG_DE_LOW, +}; + static int exynos_dsi_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -1777,6 +1781,10 @@ static int exynos_dsi_probe(struct platform_device *pdev) dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; dsi->bridge.pre_enable_prev_first = true; + /* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */ + if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM) + dsi->bridge.timings = &dsim_bridge_timings_de_low; + ret = component_add(dev, &exynos_dsi_component_ops); if (ret) goto err_disable_runtime;