From patchwork Mon Jan 23 12:23:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2648 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id AABAE3F039 for ; Mon, 23 Jan 2023 13:25:13 +0100 (CET) Received: by mail-pf1-f200.google.com with SMTP id 74-20020a62184d000000b0058b9f769609sf5210119pfy.3 for ; Mon, 23 Jan 2023 04:25:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674476712; cv=pass; d=google.com; s=arc-20160816; b=SOJzCUVm4LOiuLnw6FhrwxDUarCUy4VTWEKYGpwuSEE6ESNmOsgRbl2hEGCzq43rLC Wb9iISSxsbtf+yEgHmmkGg10+aEH7XltTdYPwqQ2FZRxcRWsjna6Fo9h9vW6IIitonuS Agc+hPpu9k1ht+kWwDDtd1It/vE3HQuB1JoBd2Wre3ZIkd+UFcmLEeFHoa/KD2TZF9Us x/stXz8WpVEwfAEHCILEjMzpi7c2SxfoeeDZfotIoC26I+TiN5L/HdsmafcrfAx2uGaE SNtyzmmZE/+gSyP2o0q5csvkp0lH6GEHVntCXRZTbvnSx9VXLcmBQq4VZK+692KsgQKe Z5GA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=yjUjd/+zZiBR1jYnWcbv0DNt0lGn7PKBS3ru7C4XiLQ=; b=p76ST8jj0XRAzRYZR3A3+Rc3pf0oMa8wwUk9bPjjlBgXNoDw2BZrIxYByl1EBV4Yx9 BpquuRh9MlCBuOpWTx7+hA3ebHhRyLjTVY8tcLrZQIAKHE4jUtOiViH4lJcvJMrwAfeb 4Dk5Nz89BQHvIxgkUHgHAeOD52wu9VzzDe9dV9ZYoEUF0DGRIbCip/niP4WuMuSi9y0G f3BfEOzMxl0XPY5NYZjCatYNfL31kTLJXTO7atUI6u/BQqCobqXN4BBlCMJ4+ZrLpC7g XcaiJnXMnJrrw8e6YYI5emcD0tUVOi1/bzlwBEDwaiZRlEctC1rjJNELUyniALxvCmwh 6eyw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=kZ23uLBa; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=yjUjd/+zZiBR1jYnWcbv0DNt0lGn7PKBS3ru7C4XiLQ=; b=d4d8bIGOZi/TukMMPKRkjya2cg/EFlf3HzZMYEmxc6WXDJEzpXAT/yGZ9BIUtNM9jR Jg4Py6D+KDwZFnxI8NrmD+HDDjIIUclPmhD+BbtehFztRMeQOht3CElUpCQI8nJd2hjN uztSHSK/0Udlb2y6+2o2Yavn7fn/SedcPj3NI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yjUjd/+zZiBR1jYnWcbv0DNt0lGn7PKBS3ru7C4XiLQ=; b=Zz1s9OrLcKhX0Q6VJqdqhU87ddqNQFLDy7UsQPyQFrXekgR2pfhU/a6vkj/6I9M4zV Xqs2dtlCdzcPQDTVWanth5nHO8xEyKU3DUm4MmrmdKNQms+wGgd4MOmayctnmUfsJZKs pXA0DRtHyXmYwNuI4JAwN+oYRz24eZuIu7Vj6O7nl5VmOuVXKZlpFZQrL4qlaQGzVe0B 4KONXU3JqwG3cz/Cbh0y+GvFgxQ6GKNhPCC13RVCJ1x3HNU9a1+CtMnzYp5dhbTA3BeH M+8DWgjJmYA0upe0+9V0kBfujACfcI7Dxc6darErCRDQhrll910XPYFilyK4og+JHWr3 rWQg== X-Gm-Message-State: AFqh2kpizY3mBxNFKJbFJSC/88j9++BHkgXr3+4PxFVJNEKfvYzPyV/b 9bGEZ8sprJTFyhP2xKHw3ExzUVo0 X-Google-Smtp-Source: AMrXdXuHFbaMhOD7qCYN32XYwXVcsQUcJKm9BOB6kiKdn7vR0zhW4RxGwIThK+bj1aYTct/6rai+ag== X-Received: by 2002:a17:90a:9911:b0:22b:bc69:fbc4 with SMTP id b17-20020a17090a991100b0022bbc69fbc4mr1284293pjp.141.1674476712361; Mon, 23 Jan 2023 04:25:12 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:8a81:b0:229:24a8:b4c9 with SMTP id x1-20020a17090a8a8100b0022924a8b4c9ls12940129pjn.1.-pod-control-gmail; Mon, 23 Jan 2023 04:25:11 -0800 (PST) X-Received: by 2002:a17:902:8c94:b0:193:ab5:39c7 with SMTP id t20-20020a1709028c9400b001930ab539c7mr24753505plo.11.1674476711473; Mon, 23 Jan 2023 04:25:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674476711; cv=none; d=google.com; s=arc-20160816; b=f9HPfMAy1gkP9IjLd9oosl2cJBJeED6HFKNEIUYV2fwBFSkK7fpbeIcJXrSXcBuG1O ZHW5JDJq23LoRDkvgySB+RiOlmF/aGhJFTdQlFl0TlrHQ1bYKx4K2Cwt0MdxE9J6/94i LkXS0dByuacZ0HcN7WxfVD8pIt5Yi4rltXcZTwde/iDFEeBzneI1pCMhR8L+85I35YBc c5RgcEVHtbY1XARe50gzzpF7IW1SNoVFslqPsgSk61zDfaa8MELLoe4LqOqta6qKO5MS jVHR7VDjq9dwW+vy3Cx/2InIsybaOziAgCvTU5ynuVeC8BGT10iFoqfbv/Nd59c5nVAw 9cfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=F6pfGP8F/CZnmySkaMhl1te7xx0K6up+05928JeSO18=; b=q2oEQqrpeyh1yOtUEx5i+snfpAIx8a7iTjtfmPTxyaPRmeBOE9fArnRKFh5FiJaQdf DnZL3uStnZ64jbrJOQi6xOJJqLPCV0nE2KMMAYS9bk0/Hv/mkxMegBHCJ4cpBrCgn5mv ywwPHSKRn8B3zb4wVtMnrhI4rSJsyozv9BTKux6DFQJdWc5se5E+5DyOFNmIcfw+NRx5 nOvn+o/NeijoIiwj42gqoUrSe6aBudnitVCL4a21ccmer0PcQA6HQN72k73EoMwIzuZK ViLzNjdqCMDwGlaMDAvVJs8tAvdZp/N4SEMUxpcCXbH5MQtLt9jMPLHuB+NL9L6P+G8B xH2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=kZ23uLBa; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id o18-20020a170902779200b001949e879626sor8423775pll.75.2023.01.23.04.25.11 for (Google Transport Security); Mon, 23 Jan 2023 04:25:11 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6a21:3982:b0:af:f1d1:6f7f with SMTP id ad2-20020a056a21398200b000aff1d16f7fmr27734000pzc.31.1674476711141; Mon, 23 Jan 2023 04:25:11 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:2279:f361:f93b:7971]) by smtp.gmail.com with ESMTPSA id w10-20020a170902e88a00b001960806728asm1291811plg.88.2023.01.23.04.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 04:25:10 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v11 13/18] drm: exynos: dsi: Add Exynos based host irq hooks Date: Mon, 23 Jan 2023 17:53:14 +0530 Message-Id: <20230123122319.261341-14-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230123122319.261341-1-jagan@amarulasolutions.com> References: <20230123122319.261341-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=kZ23uLBa; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Enable and disable of te_gpio's are Exynos platform specific irq handling, so add the exynos based irq operations and hook them for exynos plat_data. Signed-off-by: Jagan Teki --- Changes for v11: - none Changes for v10: - split from previous series patch "drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge" drivers/gpu/drm/exynos/exynos_drm_dsi.c | 55 +++++++++++++++++++++---- 1 file changed, 47 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index fc7f00ab01b4..5e672209ed5f 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -290,9 +290,15 @@ struct exynos_dsim_host_ops { int (*detach)(struct exynos_dsi *dsim, struct mipi_dsi_device *device); }; +struct exynos_dsim_irq_ops { + void (*enable)(struct exynos_dsi *dsim); + void (*disable)(struct exynos_dsi *dsim); +}; + struct exynos_dsi_plat_data { enum exynos_dsi_type hw_type; const struct exynos_dsim_host_ops *host_ops; + const struct exynos_dsim_irq_ops *irq_ops; }; struct exynos_dsi { @@ -307,7 +313,6 @@ struct exynos_dsi { struct clk **clks; struct regulator_bulk_data supplies[2]; int irq; - struct gpio_desc *te_gpio; u32 pll_clk_rate; u32 burst_clk_rate; @@ -331,6 +336,7 @@ struct exynos_dsi { struct exynos_dsi_enc { struct drm_encoder encoder; + struct gpio_desc *te_gpio; }; #define host_to_dsi(host) container_of(host, struct exynos_dsi, dsi_host) @@ -1344,18 +1350,38 @@ static irqreturn_t exynos_dsi_te_irq_handler(int irq, void *dev_id) return IRQ_HANDLED; } -static void exynos_dsi_enable_irq(struct exynos_dsi *dsi) +static void _exynos_dsi_enable_irq(struct exynos_dsi *dsim) { - enable_irq(dsi->irq); + struct _exynos_dsi *dsi = dsim->priv; if (dsi->te_gpio) enable_irq(gpiod_to_irq(dsi->te_gpio)); } -static void exynos_dsi_disable_irq(struct exynos_dsi *dsi) +static void _exynos_dsi_disable_irq(struct exynos_dsi *dsim) { + struct _exynos_dsi *dsi = dsim->priv; + if (dsi->te_gpio) disable_irq(gpiod_to_irq(dsi->te_gpio)); +} + +static void exynos_dsi_enable_irq(struct exynos_dsi *dsi) +{ + const struct exynos_dsi_plat_data *pdata = dsi->plat_data; + + enable_irq(dsi->irq); + + if (pdata->irq_ops && pdata->irq_ops->enable) + pdata->irq_ops->enable(dsi); +} + +static void exynos_dsi_disable_irq(struct exynos_dsi *dsi) +{ + const struct exynos_dsi_plat_data *pdata = dsi->plat_data; + + if (pdata->irq_ops && pdata->irq_ops->disable) + pdata->irq_ops->disable(dsi); disable_irq(dsi->irq); } @@ -1384,9 +1410,10 @@ static int exynos_dsi_init(struct exynos_dsi *dsi) return 0; } -static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi, +static int exynos_dsi_register_te_irq(struct exynos_dsi *dsim, struct device *panel) { + struct _exynos_dsi *dsi = dsim->priv; int ret; int te_gpio_irq; @@ -1394,7 +1421,7 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi, if (!dsi->te_gpio) { return 0; } else if (IS_ERR(dsi->te_gpio)) { - dev_err(dsi->dev, "gpio request failed with %ld\n", + dev_err(dsim->dev, "gpio request failed with %ld\n", PTR_ERR(dsi->te_gpio)); return PTR_ERR(dsi->te_gpio); } @@ -1404,7 +1431,7 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi, ret = request_threaded_irq(te_gpio_irq, exynos_dsi_te_irq_handler, NULL, IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN, "TE", dsi); if (ret) { - dev_err(dsi->dev, "request interrupt failed with %d\n", ret); + dev_err(dsim->dev, "request interrupt failed with %d\n", ret); gpiod_put(dsi->te_gpio); return ret; } @@ -1412,8 +1439,10 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi, return 0; } -static void exynos_dsi_unregister_te_irq(struct exynos_dsi *dsi) +static void exynos_dsi_unregister_te_irq(struct exynos_dsi *dsim) { + struct _exynos_dsi *dsi = dsim->priv; + if (dsi->te_gpio) { free_irq(gpiod_to_irq(dsi->te_gpio), dsi); gpiod_put(dsi->te_gpio); @@ -2033,6 +2062,11 @@ static const struct dev_pm_ops exynos_dsi_pm_ops = { pm_runtime_force_resume) }; +static const struct exynos_dsim_irq_ops exynos_dsi_irq_ops = { + .enable = _exynos_dsi_enable_irq, + .disable = _exynos_dsi_disable_irq, +}; + static const struct exynos_dsim_host_ops exynos_dsi_host_ops = { .register_host = exynos_dsi_register_host, .unregister_host = exynos_dsi_unregister_host, @@ -2043,26 +2077,31 @@ static const struct exynos_dsim_host_ops exynos_dsi_host_ops = { static const struct exynos_dsi_plat_data exynos3250_dsi_pdata = { .hw_type = DSIM_TYPE_EXYNOS3250, .host_ops = &exynos_dsi_host_ops, + .irq_ops = &exynos_dsi_irq_ops, }; static const struct exynos_dsi_plat_data exynos4210_dsi_pdata = { .hw_type = DSIM_TYPE_EXYNOS4210, .host_ops = &exynos_dsi_host_ops, + .irq_ops = &exynos_dsi_irq_ops, }; static const struct exynos_dsi_plat_data exynos5410_dsi_pdata = { .hw_type = DSIM_TYPE_EXYNOS5410, .host_ops = &exynos_dsi_host_ops, + .irq_ops = &exynos_dsi_irq_ops, }; static const struct exynos_dsi_plat_data exynos5422_dsi_pdata = { .hw_type = DSIM_TYPE_EXYNOS5422, .host_ops = &exynos_dsi_host_ops, + .irq_ops = &exynos_dsi_irq_ops, }; static const struct exynos_dsi_plat_data exynos5433_dsi_pdata = { .hw_type = DSIM_TYPE_EXYNOS5433, .host_ops = &exynos_dsi_host_ops, + .irq_ops = &exynos_dsi_irq_ops, }; static const struct of_device_id exynos_dsi_of_match[] = {