From patchwork Mon Jan 23 15:12:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2660 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id E4BC63F039 for ; Mon, 23 Jan 2023 16:13:15 +0100 (CET) Received: by mail-pl1-f199.google.com with SMTP id z10-20020a170902ccca00b001898329db72sf7358549ple.21 for ; Mon, 23 Jan 2023 07:13:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674486794; cv=pass; d=google.com; s=arc-20160816; b=rndHBfLSxDusRsQ/Qz4GQKCdHJAqugxoHB+KzJM568rrAIIQ/cLyihjNQHA+9AxLeh dFsvtBPZwf8mEGqw+yJJLA/wJ2+hEzga/yu7aBIOkFhQQTdVjJCzH2SAuOS2uPvm+Ozy vwxZoJlimy1FBbHo3D7jp/3gnGShiYgK7EfHuX4mB1/H1nsNQZeIHuMmUGmBEFskgGA0 SIJm6v0lbm05SrJe59T34X3GZtYKpgMegEtn5pI4EXNobe0CTgvHOhJ2/EXtq4JsKvL0 Di4tig2XjZOtCnXKkNDAb6WhyCsUbR0iNu4Bp7TrAVyMYbHk7JUNoSFngLozQ3XSLdEC ANfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=XqSpdrri+fiCeYn6ib5UNY9VKQ9PiJqW/JTVZ4J7k5A=; b=hNEnOCdBEDWdH7glTcfcnafO+ajFoDl+Fn7ELXsvVzzgY/RRUYGk/9HrRfNZqb5P7s kAr4/gndgVQFbJc1RvK/2+NxiikekHGyMfrgEQ7BCbIjh2Z3Xekh/y/LN5o18gaiHXpw LbfC9DFSfOGIiw0x0ALkE3bYcThsJljHekcz0iIyZyPU/snc4DoEwgSb/bSAhMMMVbGm 2D9SStWFcDs0DgLJGQex3MeWOVAAGyXN1/UXKGpiPdujc2lI4K/ZPruwMjrwV051dYso GTpSq77YGJ0iq/hjcc/S6FM34+nhyzp7K+9dX1a9smrYWLy2NEAwOY4SMj2MJ9yEMW7h Eeug== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=RzKYLDoY; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=XqSpdrri+fiCeYn6ib5UNY9VKQ9PiJqW/JTVZ4J7k5A=; b=UifQjjfqpkGzG5GOFuMlYa0+eeS6xomhYnlk9Duji/FMGDm2Khi7dXznbcg5IbuNIo OLoyalGyNgOUUnH33oA+7UU488kwU4RvLjYveZIGHTNebKc0T3yQga7mq6f3nSiHVJ8Q 9472sk5yls4UESM3FzxqFccWBbuC9bSytrmjA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XqSpdrri+fiCeYn6ib5UNY9VKQ9PiJqW/JTVZ4J7k5A=; b=mU0c6U512qROfl7C0fsHxbiySOEEoAIohJ86E75zJPBMiwvsOEWcLDM15FLikwXwfn FvPTuuJqtjkiv3SeZgE0ZQS5mtJ7h3M6QRwTBfZIWG+Fmx9ADswuYhoqcGUZy9J0I9Id V5k20FeeO5NCGGw7FSjYwEgOngapjKuB2hSua+LZjLmlk+UeRaDhoIwNsrOkxQ0vtpNa E0Qd2mhJnq7lqdCKSuG4A1VAW6vhnIog3bywckU5tdbWDBZAJ8Gs6kvJxz4j9s7z7gW6 DI+mYdHKI6xPZHWzJfjgtCtYMWxTffEi6WgHokl9AspMKEi0vUYh8UtMtXBoTHpHBx7i SNOA== X-Gm-Message-State: AFqh2krxc/sNj7FZTaMuq19LPCLz+vbsSNRLfprz3PXWPR8qhPr+DObD HTKqDGr456QEGnwt/xZT4lGqwoUV X-Google-Smtp-Source: AMrXdXuOjq2B1eV+hEezyISC48W7LjRB9vKtz+ByMGe++DO5ucGg93NeTy7ieLgMqhyXbWkfay6YPA== X-Received: by 2002:a17:90b:11d6:b0:22b:bcc8:4eba with SMTP id gv22-20020a17090b11d600b0022bbcc84ebamr1343447pjb.243.1674486794653; Mon, 23 Jan 2023 07:13:14 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:8a90:b0:22b:b854:cc44 with SMTP id x16-20020a17090a8a9000b0022bb854cc44ls2396427pjn.0.-pod-preprod-gmail; Mon, 23 Jan 2023 07:13:14 -0800 (PST) X-Received: by 2002:a17:903:244f:b0:194:6400:cd37 with SMTP id l15-20020a170903244f00b001946400cd37mr35116581pls.14.1674486793732; Mon, 23 Jan 2023 07:13:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674486793; cv=none; d=google.com; s=arc-20160816; b=Z9PKHfB8B/Jv9tfqCKZOIPPlte3P+DXN5etVv3t2eMLFM2K1mc82BKkMkZ8HDEIsf5 H9GUkLxDLWMbktTuniCAE2qIdyjFN963QRNvMK+nNPpO8nA061Vq/dGMqYdLGDMa62O3 vKpEk2SFofAGNYVInyARUAGlOxEgpnMaqWdYhXRUcK5GDUq0rP4SS7pCw6yI6RRAnHue cmcGT3o2gr45Q+HLXj5g1HnuZFWKs3d2em4eY7783BGZpqmpUC1hajoaf2BC+r1jGMzO 1+cWzxODBATH5AhevsdBHp3AuM6IayQtThbbgDjOPH9JRf9ByhXlJnTuZ4vdv8+uyKMc nWlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=U9Y+6AYElVzmPLEEE0cyqelpoYne/+Yj3ASyLzLLBEM=; b=HlDDIaizTgz0z/+UePnuOHqgLLyykQXTcBaexnb4mx0rjrDYSDrpiDhmcfLLVos9fb 5+g6skZKy9RuD9U6/oeWIXze3dK3lIZCBi8Yf3QukSk469GmlVmZIii6yjk9uzB3fqkj kLR71zNhymo8xnJuhJ1oI4S1ckF1BbHJ0YZUArxMARL72pDHfW6xTOXDbre7LZcmLpYP UN+1s/caTX/HJaytjkmFaSKomKzBvkOI8/WBZYsPpHOloxLPqH+iWCk9M0Z11n5uLDEL 83px4C1mX5we6d0AP1nGwv6yyJ0TsfIVD2ONUhJ1PRlTeorY/Ur56HMtf4guePRane5b rxOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=RzKYLDoY; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id y17-20020a17090322d100b0019606b11723sor974524plg.29.2023.01.23.07.13.13 for (Google Transport Security); Mon, 23 Jan 2023 07:13:13 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:9688:b0:192:55ab:88fe with SMTP id n8-20020a170902968800b0019255ab88femr24360923plp.56.1674486793408; Mon, 23 Jan 2023 07:13:13 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:2279:f361:f93b:7971]) by smtp.gmail.com with ESMTPSA id d5-20020a170903230500b001754fa42065sm19207111plh.143.2023.01.23.07.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 07:13:12 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [RESEND PATCH v11 06/18] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset Date: Mon, 23 Jan 2023 20:42:00 +0530 Message-Id: <20230123151212.269082-7-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230123151212.269082-1-jagan@amarulasolutions.com> References: <20230123151212.269082-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=RzKYLDoY; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like PLL PMS_P offset value varies between platforms that have Samsung DSIM IP. However, there is no clear evidence for it as both Exynos and i.MX 8M Mini Application Processor Reference Manual is still referring the PMS_P offset as 13. The offset 13 is not working for i.MX8M Mini SoCs but the downstream NXP sec-dsim.c driver is using offset 14 for i.MX8M Mini SoC platforms [1] [2]. PMS_P value set in sec_mipi_dsim_check_pll_out using PLLCTRL_SET_P() with offset 13 and then an additional offset of one bit added in sec_mipi_dsim_config_pll via PLLCTRL_SET_PMS(). Not sure whether it is reference manual documentation or something else but this patch trusts the downstream code and handle PLL_P offset via platform driver data so-that imx8mm driver data shall use pll_p_offset to 14. Similar to Mini the i.MX8M Nano/Plus also has P=14, unlike Exynos. [1] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n210 [2] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/gpu/drm/bridge/sec-dsim.c?h=imx_5.4.47_2.2.0#n211 Reviewed-by: Marek Vasut Signed-off-by: Frieder Schrempf Signed-off-by: Jagan Teki --- Changes for v11, v10, v9: - none Changes for v8: - updated commit message for 8M Nano/Plus Changes for v7, v6: - none Changes for v5: - updated clear commit message Changes for v4, v3, v2: - none Changes for v1: - updated commit message - add downstream driver link drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 5918d31127aa..7a845badb1b2 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -194,7 +194,7 @@ /* DSIM_PLLCTRL */ #define DSIM_FREQ_BAND(x) ((x) << 24) #define DSIM_PLL_EN (1 << 23) -#define DSIM_PLL_P(x) ((x) << 13) +#define DSIM_PLL_P(x, offset) ((x) << (offset)) #define DSIM_PLL_M(x) ((x) << 4) #define DSIM_PLL_S(x) ((x) << 1) @@ -263,6 +263,7 @@ struct exynos_dsi_driver_data { unsigned int max_freq; unsigned int wait_for_reset; unsigned int num_bits_resol; + unsigned int pll_p_offset; const unsigned int *reg_values; }; @@ -471,6 +472,7 @@ static const struct exynos_dsi_driver_data exynos3_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -483,6 +485,7 @@ static const struct exynos_dsi_driver_data exynos4_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -493,6 +496,7 @@ static const struct exynos_dsi_driver_data exynos5_dsi_driver_data = { .max_freq = 1000, .wait_for_reset = 1, .num_bits_resol = 11, + .pll_p_offset = 13, .reg_values = reg_values, }; @@ -504,6 +508,7 @@ static const struct exynos_dsi_driver_data exynos5433_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 0, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5433_reg_values, }; @@ -515,6 +520,7 @@ static const struct exynos_dsi_driver_data exynos5422_dsi_driver_data = { .max_freq = 1500, .wait_for_reset = 1, .num_bits_resol = 12, + .pll_p_offset = 13, .reg_values = exynos5422_reg_values, }; @@ -628,7 +634,8 @@ static unsigned long exynos_dsi_set_pll(struct exynos_dsi *dsi, writel(driver_data->reg_values[PLL_TIMER], dsi->reg_base + driver_data->plltmr_reg); - reg = DSIM_PLL_EN | DSIM_PLL_P(p) | DSIM_PLL_M(m) | DSIM_PLL_S(s); + reg = DSIM_PLL_EN | DSIM_PLL_P(p, driver_data->pll_p_offset) | + DSIM_PLL_M(m) | DSIM_PLL_S(s); if (driver_data->has_freqband) { static const unsigned long freq_bands[] = {