From patchwork Mon Jan 23 15:12:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2664 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6E1ED3F039 for ; Mon, 23 Jan 2023 16:13:44 +0100 (CET) Received: by mail-pf1-f197.google.com with SMTP id u3-20020a056a00124300b0056d4ab0c7cbsf5375783pfi.7 for ; Mon, 23 Jan 2023 07:13:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674486823; cv=pass; d=google.com; s=arc-20160816; b=xMJ/9chyqKnO5R8Dd4kNeT9GFisnm5ZMLCVmxxi5hAnFteRg3K3mPR9YMjyOsoBOgq 9uff2nrRqH0axZPxu16HMR8rbiRin4yA/QA9AUE7F9hAMZUiDuzWBXHoQA2aTk2lE1/x 4BxN+5F3SA3QrHE+LRn5DeaaXcVKVgbyMh7XUnpNrHCVqWf8ccE94UGH0cUV5vaH+cWV y5f4wI2pgnP5UqwM7DQJDX/jxSJH5B99XTDY7Dj/u5LqAZ8LRNYZw3HSul11IhZyOLIe CL6oTnVrPgCJNqmFD+28wl+5ptfdx88LJ73RK370IQSalQr7sRshviA0GNLY6UR6QgmA cZkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=TOHScWrBcXF2/h4rNTxkI6FzDK25kXGkvOvwcpOnPX8=; b=Ok5gh7D6zfr/qLUTp5iTfMNDpnbn9oyddqH9Bs5/ESeufYnKNOWOfnlI3fguDo6kHr INm3e2rYttzu9+OI4s9nXidBi77joIe9MCFQpPT3uwvOdgANdIiQ/2Ghty0AQRlM9Gjm EWrDuD/Nstnwuia/ZpLddGt2MYFNSaw0hXPE1gk1cegD5iW3rZtGPYi+T/ALpHQYzKJY Uaehi9cYJaB+SsxaiMVZkhyfOfTzxPs3qOOIeffxymmD+XJ/BKhOKLxnZqjQaF5J2Z9r xR/yeFiaIrSjFsEBiGvL6bUMFnqtf4Z/KmN0qiwAWg7/N7Fdif3vk7Ufh72L786JZ27T NILA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Y9rWx+WX; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=TOHScWrBcXF2/h4rNTxkI6FzDK25kXGkvOvwcpOnPX8=; b=J2TJsprDju4Hpun/GGj2bmFO+1XofvG/L+3mw4t1nCAYNtB7zvnud2+4jc+x3NMQPI CQPhpGQAwGcIAov9fyE2wxcV2i5cBr7ry/zma+HosZmoixwdTfT/BbDRXGCquIC/ccpI YUWic1XIr2wRKc3CpU1vvhOSF/C1uMg1nxkew= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TOHScWrBcXF2/h4rNTxkI6FzDK25kXGkvOvwcpOnPX8=; b=xNaL6/nEFb8qi8Nc9yqMbKOFbPBsa4OV9ORwLOAgKscgDLHl29ofFrFu4Thg4Ifm7+ +Sf5YIWQRUnOM6EcJlbDbf3PFeJIpn2CsFprH/FzcgycqAW1wpJ6OW9VO1Y8RwW8Cv4b Gr2JffjcXjgR2H3TXqaXyUvfLIhMnjLgL+FgqyhoGs3mQa1chi2SDX8uJqA9FjeYrqcd U9804oiE8Opzw1bnOv7v7Et0QO9AFVy2LsVSE5GTiIEaff/RC6lBwLpx/SocHa9oz7GV YJcFwGIsJX7BthQgqKfoRRfyVCVODP0uLn5jIuhsiuWcJbTcggeMxwgVUffNT0fjBpuW w63Q== X-Gm-Message-State: AO0yUKXMq2nKJWfauKXX4O9fxhtnTurU8TIwD0awUdiEXMHR1OKraHCF w/lXQJBSbVB9uErBEm0UyAobSuTd X-Google-Smtp-Source: AK7set/r3NOMFvHJc4NG6hzzW6cfEyMq2ozNGbIJwlNpnJmtrcDRQyBXw0sEN9LbSbu2yDB561alIQ== X-Received: by 2002:a17:90a:e394:b0:22b:e5c5:7e46 with SMTP id b20-20020a17090ae39400b0022be5c57e46mr23091pjz.26.1674486823209; Mon, 23 Jan 2023 07:13:43 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:eb8b:b0:186:9fc5:6c01 with SMTP id q11-20020a170902eb8b00b001869fc56c01ls13112165plg.6.-pod-prod-gmail; Mon, 23 Jan 2023 07:13:42 -0800 (PST) X-Received: by 2002:a17:902:8f82:b0:194:5116:c3e1 with SMTP id z2-20020a1709028f8200b001945116c3e1mr23108533plo.24.1674486822369; Mon, 23 Jan 2023 07:13:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674486822; cv=none; d=google.com; s=arc-20160816; b=tMKl5xwS5PZ8QpZFZyOslsbqKyuRq55eDYn+x9kY886p807vf2vsPERZsOX9lgEQKn RIvhCleHpu/msyaXpL4ke2PBTa19nGFQ/oM0LeSKKpOWn4wDPnYJr4qWfCPrmcQ1yX/7 g/a1ptfxaGtZdJQvQ93VaZzEsfOhPyUA3MLGJOg3g3FEaTFBupk5Lo0w6Kf06tOcR1E3 08trHwYYFIxJcAayxyPYyQCcn8zdVIC3eobR34WVjTuQ3vRDm0t/+nOc7xvOF1hBbXD5 cDyy/zA1dzZsyJElmPFlMHbZd7SmJGv5TN8d8RoRJmGX8fALr3NnTLFyVKE4uqHkFYmt WTXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=cD1qAiqhfd1q1+yXxcnzmuelB54aAtoGJRwcpOhnRjA=; b=s7AdOmqLbxE/EulpIr7mO4zGZ+981z2AiB7TLHkNCq+ZyIQVVx0XKdAH0I+ITqCQNZ r/V2anD34YSU6Zf9GpCHjsJNiYByOSX4F36lnZ0rh9uRM2w7IqCcdWHSpEIp8OZ9aJUj rGQXjoxowkn6HOhP7XDZ6/Jn8G5vzE6ceRWF8i12cZCKrErad/633EqzYuqLru8qKOTm P4afcCcrO+FR315p3OBHd5oDBfJYHt/lmhnxNlI8X9/Iosx0CzUsNJP5mKIwkYqjbnk4 IlmPw+V/Flt2AnpHuK2ITYPATUj0kxR9xQsPjWPvzWla6tXoQJkFkp8ZOhRm5nR4DXwC xn8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Y9rWx+WX; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id y21-20020a170902e19500b00194a0ec46b2sor8825256pla.151.2023.01.23.07.13.42 for (Google Transport Security); Mon, 23 Jan 2023 07:13:42 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:eccf:b0:194:dd88:ea13 with SMTP id a15-20020a170902eccf00b00194dd88ea13mr18887694plh.55.1674486822037; Mon, 23 Jan 2023 07:13:42 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:2279:f361:f93b:7971]) by smtp.gmail.com with ESMTPSA id d5-20020a170903230500b001754fa42065sm19207111plh.143.2023.01.23.07.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 07:13:41 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [RESEND PATCH v11 10/18] drm: exynos: dsi: Add input_bus_flags Date: Mon, 23 Jan 2023 20:42:04 +0530 Message-Id: <20230123151212.269082-11-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230123151212.269082-1-jagan@amarulasolutions.com> References: <20230123151212.269082-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Y9rWx+WX; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting the i.MX8M Mini/Nano DSI host to add additional Data Enable signal active low (DE_LOW). This makes the valid data transfer on each horizontal line. So, add additional bus flags DE_LOW setting via input_bus_flags for i.MX8M Mini/Nano platforms. Reviewed-by: Frieder Schrempf Suggested-by: Marek Vasut Signed-off-by: Jagan Teki Reviewed-by: Marek Vasut --- Changes for v11: - collect RB from Frieder Changes for v10, v9: - none Changes for v8: - add DE_LOW for i.MX8M Mini/Nano platforms. Changes for v7, v6: - none Changes for v5: - rebased based on updated bridge changes Changes for v4 - v1: - none drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index d8958838ab7b..5518d92c8455 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1691,6 +1691,10 @@ static const struct component_ops exynos_dsi_component_ops = { .unbind = exynos_dsi_unbind, }; +static const struct drm_bridge_timings dsim_bridge_timings_de_low = { + .input_bus_flags = DRM_BUS_FLAG_DE_LOW, +}; + static int exynos_dsi_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -1777,6 +1781,10 @@ static int exynos_dsi_probe(struct platform_device *pdev) dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; dsi->bridge.pre_enable_prev_first = true; + /* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */ + if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM) + dsi->bridge.timings = &dsim_bridge_timings_de_low; + ret = component_add(dev, &exynos_dsi_component_ops); if (ret) goto err_disable_runtime;