From patchwork Mon Jan 23 15:12:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2670 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 359E73F039 for ; Mon, 23 Jan 2023 16:14:28 +0100 (CET) Received: by mail-pg1-f197.google.com with SMTP id y187-20020a638ac4000000b004cf52d8bb9bsf5584078pgd.21 for ; Mon, 23 Jan 2023 07:14:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674486867; cv=pass; d=google.com; s=arc-20160816; b=TVndttM4okAgNrQVkW8OjKX1bAqoCVWIywQC+EZALxw3vRQUHyfmTNT5OwraepPuwC zaatfnv1ux08/sSg1fKAoYv5y1vBy0Sq9NURqomLVufFA/i3NtF16UBGqVW9JsGvBgRm rB4NWBIGT7qPYtSgEw48Cg1jqWPIHBLWQb2aPc91gWhT//zl/X0Pfycu1hyIDXBkiMnj hBqtKdzFTuRxl0RqM2ZHoIxoScWUCIpf1v91q9qfdfJzrrpwi6W//eCyEHsLj9yUnRU+ sTDsjTyC96ma6OtdHyvsj26sgDiEHyBVKMcOWUAoDtWnj0FsHMkn/AGVbWpKgE/TlHYM rxRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ki+ymlUkiv3rWsecJtzXYcofuAqfv7Cj34AArlO7dB4=; b=paEV9iScek1HUn8KLxcxrAbrapRaPMOBKKB9YbPLVvBPNUCtWTwBilDsDynx5nNbND TnLKWagADZOe50xtiD7KlnA+lXh0LZmK3Hp+/wifWeRwaY5T+lbOILqQUx71ECbEfk6T YcWvwrZtFY/t5zL9wXH74I7cQo79wKcQ65SQ48905QXEhwZ1n8yMC10m4GuNAzq+pI8y XMJicYdQDi7tUPjqZl4iicYh3S5s0KYOHvTWbKz80p2yt98paHxuikxA3XI8FZm3hdlA KiiAXVcwDmyfrP7mAyYwvEI0oljscoO1j+xkOyqIm8eI6H53KueI5lStpmObs/g2nSfk CjGg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hyXbhprL; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ki+ymlUkiv3rWsecJtzXYcofuAqfv7Cj34AArlO7dB4=; b=b94EAF1/36T1gRoJx2DcLiOFAZpcpy3UlCKeIme6tNmkMUj7brFf/TGNTJGmKke8gR A4fKZOh2tc+Gg5u0YEYHRcBxkrvv3Vw0Gc9C3mnXwyKanZRyI7BrgsmjvlP5pCktKgJQ Xh65mY9VImg83ejyfQ4gG0uMTdDbtGZBajlCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ki+ymlUkiv3rWsecJtzXYcofuAqfv7Cj34AArlO7dB4=; b=TbVrL50E4Bl3jQ7nV7uL4uoIapGQpibSowJxGb15kMFpMCKp2SvUPW6g2cN3UhfMD+ je1BXtHbiAx1uXGKI8hKoV/AOKuPC8VtyOcGWEzFRZC4fsa11VTK2XZBSPQNABbwMzxU YniQVne5ULhEYK7eXfG6VIG2qdq0LzKEx9n0DHDJaA/gcE5/KTgTFnjRoEBtAYZJ3ZoX JyGYZjGLijCOSCgU0U4geHpv0sxHEUA7I+5aW4jLCI1hBl30q77IRTXc9lk2adi1GFWf 44GA3P56B67qQXC4JAvyPP8xAdeg8y0alnRSSkPTDec5N6ObcO4WP0NYKSLRCd+kVrqW FG+Q== X-Gm-Message-State: AFqh2krLEk5I7onYoMaBdSJwNgJbA/Hslico8gdmH3OrQAZiKcx1VNSD QQNKl1smLaQMxtnKZo75OuYKPEzS X-Google-Smtp-Source: AMrXdXtVQWCQomQhLRoI9tOx0gt/GjNht8n33O9NGGieFtEM2kVE506cSjjnfU7u89RSCt28IxuStA== X-Received: by 2002:a63:5c5d:0:b0:48e:3356:d9f3 with SMTP id n29-20020a635c5d000000b0048e3356d9f3mr2565497pgm.209.1674486866968; Mon, 23 Jan 2023 07:14:26 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:fd96:b0:214:246b:918a with SMTP id cx22-20020a17090afd9600b00214246b918als9648082pjb.2.-pod-canary-gmail; Mon, 23 Jan 2023 07:14:26 -0800 (PST) X-Received: by 2002:a17:902:8a8a:b0:191:13f2:173a with SMTP id p10-20020a1709028a8a00b0019113f2173amr23245868plo.36.1674486866170; Mon, 23 Jan 2023 07:14:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674486866; cv=none; d=google.com; s=arc-20160816; b=RVhCmO6AmBObByknP24nnTdMFXEgiXDxxmfLkVqOrhSxY+mYocJvyAS8Ll+3QgdRGy 4agEjxxbHuFRHZB9Z4YCQECsiptQRunaorYkMuLIyyyTo9rpWPvUN7MqY7a/6vh22Xos mCV8iecs/NTJporTN9TTU6Hr3WcVZr185g/H5mqmDBBxrFAUqNa+AAvEnZG6OSc5P4tg Xq37A9dHQgQ66k3Lb9gWTXoMc0ITK3iHuZVwIoBnlnhH8HrGLYj7g60iSiCyOKtrJHGW 6vnRy1G+keaZa8vT/3x3qCRr+yudGwb+cJ2DLDFkf8M/f4D48nEzA7c4ASWMuzCMmJ/S k1KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ajKvhWNKzqFT7LDd16sT+3C5isIu7jIMPTIpzFlW67I=; b=FM2qV3HjDe1wamEH/+WCtb9DLTcmsVuzNUCviK7suZvRxpL8KPOGWExH4BvaLZJgD+ ZX7dEiZ99aefoSlEre0SedOD0JOtryN0ep9ZpC0CUys2mXUQ9N1KQTZus2CkFRuOvGoj 3heBUJlq4BKl9BgUG32wk4AjIap9ymiLKlbYb9VLJnToSCUUvfe+Kf2NIsA89arUFB3R xtAYKGX8ildlB5JDNVAoGYlowU9V1rbZ9Nx4/z6n8MJOQezWiFsA79TsaYRjS3MILb47 UMw9YjGEf336WGP82hPMClwW6zpEFc98gB4nKxc9F2s5RdfrR994fqkOg8Eav4O4gBxb +b+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hyXbhprL; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id n16-20020a170902969000b0019606cec0acsor946594plp.33.2023.01.23.07.14.26 for (Google Transport Security); Mon, 23 Jan 2023 07:14:26 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:c10d:b0:191:309a:d752 with SMTP id 13-20020a170902c10d00b00191309ad752mr27222610pli.47.1674486865824; Mon, 23 Jan 2023 07:14:25 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:2279:f361:f93b:7971]) by smtp.gmail.com with ESMTPSA id d5-20020a170903230500b001754fa42065sm19207111plh.143.2023.01.23.07.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 07:14:25 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki , Laurent Pinchart Subject: [RESEND PATCH v11 16/18] drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support Date: Mon, 23 Jan 2023 20:42:10 +0530 Message-Id: <20230123151212.269082-17-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230123151212.269082-1-jagan@amarulasolutions.com> References: <20230123151212.269082-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hyXbhprL; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Samsung MIPI DSIM master can also be found in i.MX8M Mini/Nano SoC. Add compatible and associated driver_data for it. Reviewed-by: Frieder Schrempf Acked-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki Reviewed-by: Marek Vasut --- Changes for v11: - collect RB from Frieder - collect ACK from Robert Changes for v10, v9: - none Changed for v8: - fix and update the comment Changes for v7, v6: - none Changes for v3: - enable DSIM_QUIRK_FIXUP_SYNC_POL quirk Changes for v5: - [mszyprow] rebased and adjusted to the new driver initialization - drop quirk Changes for v4: - none Changes for v3: - enable DSIM_QUIRK_FIXUP_SYNC_POL quirk Changes for v2: - collect Laurent r-b Changes for v1: - none drivers/gpu/drm/bridge/samsung-dsim.c | 44 +++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 645071745760..18645c8eaba1 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -376,6 +376,24 @@ static const unsigned int exynos5433_reg_values[] = { [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0c), }; +static const unsigned int imx8mm_dsim_reg_values[] = { + [RESET_TYPE] = DSIM_SWRST, + [PLL_TIMER] = 500, + [STOP_STATE_CNT] = 0xf, + [PHYCTRL_ULPS_EXIT] = 0, + [PHYCTRL_VREG_LP] = 0, + [PHYCTRL_SLEW_UP] = 0, + [PHYTIMING_LPX] = DSIM_PHYTIMING_LPX(0x06), + [PHYTIMING_HS_EXIT] = DSIM_PHYTIMING_HS_EXIT(0x0b), + [PHYTIMING_CLK_PREPARE] = DSIM_PHYTIMING1_CLK_PREPARE(0x07), + [PHYTIMING_CLK_ZERO] = DSIM_PHYTIMING1_CLK_ZERO(0x26), + [PHYTIMING_CLK_POST] = DSIM_PHYTIMING1_CLK_POST(0x0d), + [PHYTIMING_CLK_TRAIL] = DSIM_PHYTIMING1_CLK_TRAIL(0x08), + [PHYTIMING_HS_PREPARE] = DSIM_PHYTIMING2_HS_PREPARE(0x08), + [PHYTIMING_HS_ZERO] = DSIM_PHYTIMING2_HS_ZERO(0x0d), + [PHYTIMING_HS_TRAIL] = DSIM_PHYTIMING2_HS_TRAIL(0x0b), +}; + static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = { .reg_ofs = exynos_reg_ofs, .plltmr_reg = 0x50, @@ -437,6 +455,22 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = { .reg_values = exynos5422_reg_values, }; +static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = { + .reg_ofs = exynos5433_reg_ofs, + .plltmr_reg = 0xa0, + .has_clklane_stop = 1, + .num_clks = 2, + .max_freq = 2100, + .wait_for_reset = 0, + .num_bits_resol = 12, + /* + * Unlike Exynos, PLL_P(PMS_P) offset 14 is used in i.MX8M Mini/Nano/Plus + * downstream driver - drivers/gpu/drm/bridge/sec-dsim.c + */ + .pll_p_offset = 14, + .reg_values = imx8mm_dsim_reg_values, +}; + static const struct samsung_dsim_driver_data * samsung_dsim_types[DSIM_TYPE_COUNT] = { [DSIM_TYPE_EXYNOS3250] = &exynos3_dsi_driver_data, @@ -444,6 +478,7 @@ samsung_dsim_types[DSIM_TYPE_COUNT] = { [DSIM_TYPE_EXYNOS5410] = &exynos5_dsi_driver_data, [DSIM_TYPE_EXYNOS5422] = &exynos5422_dsi_driver_data, [DSIM_TYPE_EXYNOS5433] = &exynos5433_dsi_driver_data, + [DSIM_TYPE_IMX8MM] = &imx8mm_dsi_driver_data, }; static inline struct samsung_dsim *host_to_dsi(struct mipi_dsi_host *h) @@ -1794,7 +1829,16 @@ const struct dev_pm_ops samsung_dsim_pm_ops = { }; EXPORT_SYMBOL_GPL(samsung_dsim_pm_ops); +static const struct samsung_dsim_plat_data samsung_dsim_imx8mm_pdata = { + .hw_type = DSIM_TYPE_IMX8MM, + .host_ops = &generic_dsim_host_ops, +}; + static const struct of_device_id samsung_dsim_of_match[] = { + { + .compatible = "fsl,imx8mm-mipi-dsim", + .data = &samsung_dsim_imx8mm_pdata, + }, { /* sentinel. */ } }; MODULE_DEVICE_TABLE(of, samsung_dsim_of_match);