From patchwork Thu Jan 26 14:44:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2682 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id E55C93F046 for ; Thu, 26 Jan 2023 15:46:33 +0100 (CET) Received: by mail-pf1-f198.google.com with SMTP id by10-20020a056a00400a00b005918acc2e44sf1005699pfb.9 for ; Thu, 26 Jan 2023 06:46:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674744392; cv=pass; d=google.com; s=arc-20160816; b=q3s8eLNyiRn3HrpWtjoCR/nZB797la2bLnUFyzt1QWiCfRpDqYdzEvgvuK0ffkG0K/ gu3oxJ76yNRmQ2rRENJY+CAxb2kn2fzkTCqQ19Pcyb/9gCq6bm5Db1KYKZJRsDg2ooIU ZBXXXqO1Ty8jPu45vqVan/PXOyWNi2iuc9ByspwriKbZjRbndrECc6Z4lz1PrV4oYs7j WtwrXolpFn3liSIcJ1AmSFN/wJPF15L3EzPlI6v8EeLQb+bMxBpSRNQm8BeIn83prPFF rbyojdvmD9+dpP+w9lsw8d6htWMyWN0X0Uh+Jmw7gxHgISQZR2HIgcZQg1T8USL3fppN Ofpg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=/9CdbAJbMNadqhkbeC1H7uavuwUysT3HfPYG4h2uESo=; b=UxcjYhRNUtNwCVouVIO6ajfelDiCaHZIeAjyu9DyzLJhhvx+UHq5xMeJ8kZhWTd3OH u68UweStVLuAlpFp6lMQ26XhIkw3J7fAMoDCTY7Gf79rzjlybnVlej7x0UDiPg8lSj12 XD71MD+WkfmBjgd4LDH7QeSXm8kxyZEsJYqbAo4PxJArnS/TInJy475tmQD1R4C/ed/N RoWTibfW+M792Dx1zStjCgAUOQ2hK/bBZnlqf+TuIO6Qu2qAnfu47gIoux9SJAGpcD3z 4wU5AJWXg1rYJbxKgFPTHubCk9Z+5Cfz+plmQ1l/T1NZL831lh3D67CL3nMNyvZd7X0c S0TQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nnNSrk9X; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/9CdbAJbMNadqhkbeC1H7uavuwUysT3HfPYG4h2uESo=; b=ie6wYT82BR6COddUWuo25b798mA3rfS3MjztFma85uXuL4STbT0zgj0GvwDuBBqjen uNXco6LhgC8gnfzSIIxZEE/K+pxKzYR2wG92N7a+1NNeDqdIXtfkogNBqp24JMQtizJ0 Xp5OcAKuRlXQdvfsQDayvAFMHTMhJDPhAVmxg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/9CdbAJbMNadqhkbeC1H7uavuwUysT3HfPYG4h2uESo=; b=tmlk/agGOodLD6NM5uPLy+hx5ew464B+R21JoUf8rwgtVi5agWn5mXdXWBOwyqFkx/ 4/3FmbfmfiWzeLipvzQXRXRlywpH9sOF8+hs9XonCBnvUDvaluzMJoBlR4OtzhwJoW1s mKjnkV4N+8CJONSagWcyaL5aAfJjgkYensm5PTVPEnAHMqDQzRfEMHWnK+720Pxy5Qnv Wujrv0mmQGqTsICZXa0fmVaRhGsHf9ezzAhvjLBaWyz/xF32lOOQ3uOsElwGPlKh3rd/ Vs8lHsoAUuERjw1nRQjnYXI5uTCVJeI99IL8VE/SEhof97NBeWYIpQdOSGdVP9FBso5P vgOA== X-Gm-Message-State: AFqh2kokp0cpDj9TJwAhe58bQjQl+TT/DaXe4cwoF1FGESuH9o3OHXEb SztNUs77qDTBwTAwwkUxvD+RsZ0G X-Google-Smtp-Source: AMrXdXtJJuljWsrvAswY+aDhS3YzMPIIK2bidCIQwZErGDSc5WvbZSntrBXrBKsWCrCMH9SxYthG4A== X-Received: by 2002:a17:902:8304:b0:194:6253:d685 with SMTP id bd4-20020a170902830400b001946253d685mr3994171plb.3.1674744392730; Thu, 26 Jan 2023 06:46:32 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:903:2cc:b0:194:6afa:c3 with SMTP id s12-20020a17090302cc00b001946afa00c3ls2368753plk.4.-pod-prod-gmail; Thu, 26 Jan 2023 06:46:32 -0800 (PST) X-Received: by 2002:a17:902:8d94:b0:192:d9dd:167d with SMTP id v20-20020a1709028d9400b00192d9dd167dmr31932876plo.43.1674744391883; Thu, 26 Jan 2023 06:46:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674744391; cv=none; d=google.com; s=arc-20160816; b=0wdf2eEkA3/vkVB0ZOksbji5geNSUAsZ5PXftNuDHllnWGBkpGdIA0U4W3JxBX+hhq 5gmNWxbsnFZ26T2VDdy3c9I8hWasU1GYHGenNNGwwWOiyewH0+0mRZeVkOaQwVDPx9oA nbCZBFy5NhITKLhGlyHdvNk5LDcfBnvu1Ht2wbTciF4oYFxyPR3K9haPXZxF0xFcSzHi dQyAQHh9gBz0/6WTGWzJPvgCCPCI+Iyp9UhMu1UJjd5azHQmsKxALMTMn5kcVVkrtnWL iLGe+IO4aEW/i7YeXLGVP8RzTTGIBQsbzrkHya81cJ+Hf/BhhV69D4LhZF0vOD7Oh6lu gIaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=c4Zt0Fx4HYrC+EA7BQu40bK0DS9Q1S4wdUAYAMr7AkA=; b=FZ01oAh4JioBmZ/DN90yCQK6CdQGedoepL5Bm1KSZT1x1cLt1HOuCMBdNv91fww6sS L8AS0mEqxNTBICHB+XzJ0oPGcMs4UJ4gNgQvinogrksKhnY841wLoHGoJEIo7cdGA+MY KXSvmthOz+eEUjV3w/Y4qUH08qDY/yEGoaGwcimi0qp04UHK7/tseYgPue+P49bxVBs+ wpklQyAjTOUCqUYrx8h4e98heEadrs1b6Z/YA16pFayk8jU8rFZt80y4RVF2BeqyK7tU i0XYzbrqk61KOYZxR91eQWKJ9cav2iD5sjoNp2KMiy2KQk84/a1yK2xlD3wfMBY0bjBN V6TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nnNSrk9X; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id z1-20020a170903018100b00190ec3cd503sor709426plg.64.2023.01.26.06.46.31 for (Google Transport Security); Thu, 26 Jan 2023 06:46:31 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6a20:ce49:b0:bb:9aee:f6d3 with SMTP id id9-20020a056a20ce4900b000bb9aeef6d3mr10489096pzb.46.1674744391517; Thu, 26 Jan 2023 06:46:31 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a238:3cb1:2156:ef87:8af5]) by smtp.gmail.com with ESMTPSA id d197-20020a6336ce000000b0042988a04bfdsm823660pga.9.2023.01.26.06.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 06:46:30 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Robert Foss , Laurent Pinchart , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v12 09/18] drm: exynos: dsi: Add atomic check Date: Thu, 26 Jan 2023 20:14:18 +0530 Message-Id: <20230126144427.607098-10-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230126144427.607098-1-jagan@amarulasolutions.com> References: <20230126144427.607098-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nnNSrk9X; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like an explicit fixing up of mode_flags is required for DSIM IP present in i.MX8M Mini/Nano SoCs. At least the LCDIF + DSIM needs active low sync polarities in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work properly. On the other hand the i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020 says. "13.6.3.5.2 RGB interface Vsync, Hsync, and VDEN are active high signals." i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 3.6.3.5.2 RGB interface i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 13.6.2.7.2 RGB interface both claim "Vsync, Hsync, and VDEN are active high signals.", the LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. No clear evidence about whether it can be documentation issues or something, so added proper comments on the code. Comments are suggested by Marek Vasut. Reviewed-by: Marek Vasut Reviewed-by: Frieder Schrempf Signed-off-by: Jagan Teki --- Changes for v12: - collect RB from Marek Changes for v11: - collect RB from Frieder - fix commit message Changes for v10, v9: - none Changes for v8: - update the comments about sync signals polarities - added clear commit message by including i.MX8M Nano details Changes for v7: - fix the hw_type checking logic Changes for v6: - none Changes for v5: - rebase based new bridge changes [mszyprow] - remove DSIM_QUIRK_FIXUP_SYNC_POL - add hw_type check for sync polarities change. Changes for v4: - none Changes for v3: - add DSIM_QUIRK_FIXUP_SYNC_POL to handle mode_flasg fixup Changes for v2: - none Changes for v1: - fix mode flags in atomic_check instead of mode_fixup drivers/gpu/drm/exynos/exynos_drm_dsi.c | 28 +++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index d4a976d86f08..d8958838ab7b 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -263,6 +263,7 @@ enum exynos_dsi_type { DSIM_TYPE_EXYNOS5410, DSIM_TYPE_EXYNOS5422, DSIM_TYPE_EXYNOS5433, + DSIM_TYPE_IMX8MM, DSIM_TYPE_COUNT, }; @@ -1465,6 +1466,32 @@ static void exynos_dsi_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +static int exynos_dsi_atomic_check(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state) +{ + struct exynos_dsi *dsi = bridge_to_dsi(bridge); + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; + + /* + * The i.MX8M Mini/Nano glue logic between LCDIF and DSIM + * inverts HS/VS/DE sync signals polarity, therefore, while + * i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 + * 13.6.3.5.2 RGB interface + * i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 + * 13.6.2.7.2 RGB interface + * both claim "Vsync, Hsync, and VDEN are active high signals.", the + * LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. + */ + if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM) { + adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); + adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); + } + + return 0; +} + static void exynos_dsi_mode_set(struct drm_bridge *bridge, const struct drm_display_mode *mode, const struct drm_display_mode *adjusted_mode) @@ -1487,6 +1514,7 @@ static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_check = exynos_dsi_atomic_check, .atomic_pre_enable = exynos_dsi_atomic_pre_enable, .atomic_enable = exynos_dsi_atomic_enable, .atomic_disable = exynos_dsi_atomic_disable,