From patchwork Thu Jan 26 14:44:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2683 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 53C8A3F046 for ; Thu, 26 Jan 2023 15:46:47 +0100 (CET) Received: by mail-pj1-f71.google.com with SMTP id pv1-20020a17090b3c8100b0022c1ab71110sf1478921pjb.7 for ; Thu, 26 Jan 2023 06:46:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674744406; cv=pass; d=google.com; s=arc-20160816; b=utn5eV60ktFlcMBKCF6MgZXdOuv3ukx4JTwKOV+24/OEl8m1wq5BDd4IegNaLlEFb0 N21vcYjKwTj1jPYjnKqztE/r534/XQJYwjhnCWFBhnS9WRMzCXthxvg142t07lYONgj6 mVu5+vRpKAzfRb/AgvokF4w3E/sWm52iNMknQlS9gA9HaC/Mmy+4xjaEnNgrGtUNPyB4 WuvnC4skP3XZqZUItyN6k1OYtcxCwk/FKoTeuvHGa+74ako8+yu15AaMrNPNXzW8HdyV 3XVI4J89Wc8T62baBttHlAplvg7ECT7brb/x+URxNn72sKasjnKG5UPPCUcEsZPusqvj tw7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=EWwKHQD4VCCeY9gsS2y1rEUzrn6YS0W+wN9KeMLW0oc=; b=lRGdlRi0oaF/MjqOEjNLxLqo0Yf2431V4c5+NykPctMP50JYp0I5MoHMIsArrE62ZA Y8SK5tzJunfrdrjzg97S30VZlmzSAUYXmfMylLcEAiQC6yE0vE7mvdJotZA9mE0kmNA0 bzaerGO/iSbY5WreRvaJiJ74VHMDQn77wgpw6U9qDAAVC7WkmknSGgu7T/Ed9Rq7w6AS IKDp0WkKe40OB9QiU66+cI41UI8tNy7c/yIS/B6mgi3HKQUou8LlKzpzRzLwbX0OPdbQ Uc8qn6M1R8+D6GRInDKUDFBa/Ukh22Gc9ot2qtVQIcLZQUa4paWGNgx6MzzxgazRA7ov 6hZw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=J5r6PKry; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EWwKHQD4VCCeY9gsS2y1rEUzrn6YS0W+wN9KeMLW0oc=; b=c2r20fya/h1jsnw5Zh69EQNeFfhTH4/ryXIvqVLR0QNNwuYbbzuszwPjWf5umDxgbX HuwYFkZ6XxBcwDF2R3FGRUKjYF/zD35bpNLYKd3JOUaRcCtgf/YTpDD+OiVJBLP3S/HG TOHjWgqD55O3n9sN8SlpqrAutKvKRYvReLu44= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EWwKHQD4VCCeY9gsS2y1rEUzrn6YS0W+wN9KeMLW0oc=; b=A4I67nfP6bw6b8hc+tBzZNbbrhN/TxlbfYcS1radKEWBReKWmFv6oWnbCO7fDe2vIF oPQ7en3MWTV5tF3eqAoVU6bB1v+DGM+sgZTBqd2e9C7gGEG49LCMgNuRQipOLBru5c+9 OSakhxwDgYvtDC4NrqO+b+LoJFvXJcq6OYcYN3GqqgWF6ZFSaco1/i4EX9d1BkN72SpR o7obGl4gYwPDd0j8qaNAFLSbDNSWgp5X/VtDPsbmoYmWeQ5ixC8+e4NZiemuNHNfx6Ly sNPQtpY2S13OEdpvLND4hK4AX6gdTHr+IKMt9fS79PS1MGwqFMsYd03s4P3cxvgaNB1i N6sA== X-Gm-Message-State: AO0yUKXr3n/MVX60/oM86VA9D7bqCQ6kvs4T69WL2r5uAx23L1BwbtOQ KWTB48BWNWySePgMCNNOWvlGtDBo X-Google-Smtp-Source: AK7set/1qtzV7Sv+7C+Gy59cTtboGmQ5Ebh6v+Q3pVrRJvuopt1a5YETkQ4pY0uTbshhYzgH4r0eYQ== X-Received: by 2002:a63:440e:0:b0:4d7:fc60:7ec0 with SMTP id r14-20020a63440e000000b004d7fc607ec0mr1344729pga.107.1674744406152; Thu, 26 Jan 2023 06:46:46 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:d80e:b0:22b:eeb8:fd6a with SMTP id a14-20020a17090ad80e00b0022beeb8fd6als2663332pjv.1.-pod-control-gmail; Thu, 26 Jan 2023 06:46:45 -0800 (PST) X-Received: by 2002:a17:902:da8d:b0:194:7a42:2d33 with SMTP id j13-20020a170902da8d00b001947a422d33mr45694045plx.28.1674744405385; Thu, 26 Jan 2023 06:46:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674744405; cv=none; d=google.com; s=arc-20160816; b=RmIxKu63GQS/XcUxMVIhT6chA5VKDvqkAheTYOIPO0V0bxfWb3NRUw3n3yLvas3gzc Gm7yYsb7hqp0zoRlEjow4NTWi1y+Y9JQvZh+SGxz22MnWFZPv+JIfUrPmROg1IzYEdx3 JLQWpuoTxkN5ODrz9embn+bHFRUqAQf6DVtu8uGCZF0OL91DhWKEd+zw1Ks8QGHlsUhW NLC+eb4Sl7Ki/fHigm0+b8ofArwvZPlAMnCz2ncVnlKCXCCUOtIvH++VL7xhnJyePKLj 1jM2iNf79kOyK2zsXCS6LPsIXamztXNWoZTdIfQlcNFREcckZTYnymV2hNuQzinSHrNG hLVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=CCVYG25W1pHQNxSfAOiHmaNQidizxzXKd6AiL4XAwms=; b=ebi3W/95QnomyfozJ/1+faV2Hm9yyJyMxoNs7iemIYf0JpmRZU+6L044XMGaefVDIa G5AO/oJBLnLKLnWRET3aSF0WSIeyWBBP4AmBknSJdlgIY7W6q7mHmex1zZE3xCOpOcVd JNlAXFGvPycfEPhBSqL2ReYfhWkcvHYdT4Q70ySm10VOGJuxXprK74GFXIQ+FRAxVeP8 gNWUDVBqAF5YCtCLRmbrwQuDAvfiREemBW4U8BzPh94uBTikl/WkQWFicnh8B2NPLs1V QVCipeJF8XKuF6uyacgqScwIZ0U6CQmUFzzZdvfr8qgtiawYzmLfhkntL1hMnT4f6g8u +tLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=J5r6PKry; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id r10-20020a170902c60a00b001962546f9f2sor668021plr.170.2023.01.26.06.46.45 for (Google Transport Security); Thu, 26 Jan 2023 06:46:45 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6a20:3942:b0:b8:50fd:fd1a with SMTP id r2-20020a056a20394200b000b850fdfd1amr50376881pzg.19.1674744405018; Thu, 26 Jan 2023 06:46:45 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a238:3cb1:2156:ef87:8af5]) by smtp.gmail.com with ESMTPSA id d197-20020a6336ce000000b0042988a04bfdsm823660pga.9.2023.01.26.06.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 06:46:44 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Robert Foss , Laurent Pinchart , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v12 10/18] drm: exynos: dsi: Add input_bus_flags Date: Thu, 26 Jan 2023 20:14:19 +0530 Message-Id: <20230126144427.607098-11-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230126144427.607098-1-jagan@amarulasolutions.com> References: <20230126144427.607098-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=J5r6PKry; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting the i.MX8M Mini/Nano DSI host to add additional Data Enable signal active low (DE_LOW). This makes the valid data transfer on each horizontal line. So, add additional bus flags DE_LOW setting via input_bus_flags for i.MX8M Mini/Nano platforms. Reviewed-by: Marek Vasut Reviewed-by: Frieder Schrempf Suggested-by: Marek Vasut Signed-off-by: Jagan Teki --- Changes for v12: - collect RB from Marek Changes for v11: - collect RB from Frieder Changes for v10, v9: - none Changes for v8: - add DE_LOW for i.MX8M Mini/Nano platforms. Changes for v7, v6: - none Changes for v5: - rebased based on updated bridge changes Changes for v4 - v1: - none drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index d8958838ab7b..5518d92c8455 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1691,6 +1691,10 @@ static const struct component_ops exynos_dsi_component_ops = { .unbind = exynos_dsi_unbind, }; +static const struct drm_bridge_timings dsim_bridge_timings_de_low = { + .input_bus_flags = DRM_BUS_FLAG_DE_LOW, +}; + static int exynos_dsi_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -1777,6 +1781,10 @@ static int exynos_dsi_probe(struct platform_device *pdev) dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; dsi->bridge.pre_enable_prev_first = true; + /* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */ + if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM) + dsi->bridge.timings = &dsim_bridge_timings_de_low; + ret = component_add(dev, &exynos_dsi_component_ops); if (ret) goto err_disable_runtime;