From patchwork Thu Jan 26 14:44:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2684 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id EDAC03F046 for ; Thu, 26 Jan 2023 15:46:59 +0100 (CET) Received: by mail-pf1-f200.google.com with SMTP id v23-20020aa78097000000b005748c087db1sf1013322pff.2 for ; Thu, 26 Jan 2023 06:46:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674744418; cv=pass; d=google.com; s=arc-20160816; b=fg+bQf5FHSRqDtukYqUASBipkIgyA0jXmcMJ/tbyVlv2NekvNUbqD3PYyp1iLa0TwI R/6PuXmi5Lyd+DrFX0OYwMRFV2qL+N6KHDDILgI+OuQZ19zuWnchR9E0PPocZdi0dMyU B2TbBlc8DQfD52gM8B/6qolk0WCphhw6GLDzzF6WjB7yC5jiAWdZHzLlPC8ZfJr3v8Be VY2APA0foZJc1tN0VeJhLODGnZr+cRCpmoy8Y4hzceqP3FEsPJMrOEPzxLHP1OYuSkgs 4Ub4uwCdFkG9X79vqp66bpknIqKQLAn6g2zv2zQKvjp7IJNNUIZqYlSwLS/pfHd2EP0M sHKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=VRfJ3AY5ZJrcXLPgwbzKzSe5853vsRvzf0BW25tftRw=; b=0FlkdV3kC3a+lB0M/0hyL7bPwIA2uwBxExtwFAjeAa0m1YRBKZoqn1rTDA+rA2b5Vm RXYg7tkwhGqqAG/B6oJfDwtBJ5wJSGk1jzxq9h2bSLHxyfN+ggrUH2R3gScS4xLBWUjo kMzI8ulsYkbFPebLBVAZCyztws9GsHv+N0B4RGRX3u73RLsUnnJvLyTvlLavs9cmtFUj sghKGmTVQ02K2kHiaBVth8QBLc5UotZEDfuTOKDIl9iPjbY5D3wXHuqMzOrrDKDC3y5y cJScR0Oh8djgtoeQwrARTjviDFHQdCH3Dg7lyP2ArRtUOAND7WKLrfPZDa9tvihqGfA/ +YFw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=jw5dG3mm; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=VRfJ3AY5ZJrcXLPgwbzKzSe5853vsRvzf0BW25tftRw=; b=Dbh8/X5ng407acZTCexmPpUZOsyN5LMEkFvwU+4TIZcAFLJnSAcuEiwCoNiuAUR/e4 sUf6kP5Aq4UuY9OkBUiS3ygAU7e4ngFYHRtjUg4XHkTEGCn4HQNOEQBgj8GfBD3RopuW +1YerDKhLWFVap/V0T+Jhimeg9BkNdMNejnYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VRfJ3AY5ZJrcXLPgwbzKzSe5853vsRvzf0BW25tftRw=; b=xz94RbK9iqG3sk/d/sJrRz2S4lJz3bwHbTF8apZu/ceu6j6Dfdvolnn1jW4/1uvPRE i5RRpkI9tEAQ4V3hL34JNIj8UXy6OOaotVUBEqoIzeecWz2vKQR7N1Tk1PiGN0eXHkWN KvqjWZ8HYK7Knqxj0BkJi17lanZwQi7JfRalJ8X18D4YLnoqvFZDkLaZxBMBuWovQRym A1XWwy1N7V898dshZ2zusqmf0p1bpbiuyc9FM36urZGMbvdG/dZ2aJqkVqWQHB8N+aoX ChuLnkhy5Y1IswBmB6wm/nKSbokyroC3DiiSToGELDSdSLe/tBNw5FyJVdJoQGN9qkDF YMiA== X-Gm-Message-State: AFqh2kriKxwHKRjhmWjd8kfUTy6jmVMJIda8i0/cWnh4mIR1CQ7GnHVC Qbhr86qRIJoR2g/RUNl7E7Ghu+iI X-Google-Smtp-Source: AMrXdXsdIqPbGuBjhixK8Bap5AoRxRHWen+mdeQQf7YF/wF4UoKq9ViEFdmiMfXHjU7UuGOFBcww3g== X-Received: by 2002:aa7:910c:0:b0:58d:bb12:2da5 with SMTP id 12-20020aa7910c000000b0058dbb122da5mr3924477pfh.27.1674744418677; Thu, 26 Jan 2023 06:46:58 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90a:cf09:b0:210:6f33:e22d with SMTP id h9-20020a17090acf0900b002106f33e22dls2644630pju.2.-pod-control-gmail; Thu, 26 Jan 2023 06:46:58 -0800 (PST) X-Received: by 2002:a17:902:9b8b:b0:194:812b:6737 with SMTP id y11-20020a1709029b8b00b00194812b6737mr36975420plp.23.1674744417799; Thu, 26 Jan 2023 06:46:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674744417; cv=none; d=google.com; s=arc-20160816; b=MTRupPj6HIAMQkj22Of6G/6Ph13itp5GniUXEVx1JrvC+AgemLRCE7nVQqRxwgGj8c apeWR7h7zVMQM78pA8SPn05saLoLWjVDwBZZ+QeY8ASWfU6elmwqQqQ9EozZR2JwpkA4 xZ1ekeBueuQocccFjvI/FkcuT7ANexNnud/AsB2k3BFmGAQGsd5i82CpVIJlstE/cCHI XCao+rSAaAhTN6H5lTNzDv2+HoCJcdsv0ntiuTyxe+qw5+FCvQpst1amCup8cC5tUhs+ /WX1OVsVXnSl2dZVXwYEsvH62ekX52ORMxuol5jG9IdxniAmxMa/GTPy1X+R4/s0vS35 Pp0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=FIzwHk3KlOuotRd1vtFiT01NZHo9fUxqS1kmRS+uxAM=; b=hZIDZ4WOG8UmT3opOXnctgRel5EaJu19z2X+trcwBBG/+GRII5eOTvwc9CeMD4lNiO KO0nVGeko8edvN0bWqOZxlx/TiyoBorS+P9i8B4iMK7UerxDmB33TMwBeyKPA/JvZi5k F1gU1PblvlCIU/L2RiW9cLNevoqvzYZK516LTC07hdadnv7AmC/4mHzQ5yGnsNguF8iV plQ4rGibqAzdyXt+oD7CpLa/Lr7dw+CAEC++aJ927XtPQT6aon43lVH4/kpmO/UIrlfo 24LYqFCbx02QD4bLJWiBj3+bd3ErJ2KA5VAT+wjAe+S0UpA5vJlrtyyaczEonQONy1+4 kd4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=jw5dG3mm; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id i11-20020a170902c94b00b00194c43382fasor732659pla.142.2023.01.26.06.46.57 for (Google Transport Security); Thu, 26 Jan 2023 06:46:57 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:90b:4a4f:b0:22c:4e1:94f with SMTP id lb15-20020a17090b4a4f00b0022c04e1094fmr6906913pjb.13.1674744417491; Thu, 26 Jan 2023 06:46:57 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a238:3cb1:2156:ef87:8af5]) by smtp.gmail.com with ESMTPSA id d197-20020a6336ce000000b0042988a04bfdsm823660pga.9.2023.01.26.06.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 06:46:57 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Robert Foss , Laurent Pinchart , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v12 11/18] drm: exynos: dsi: Add atomic_get_input_bus_fmts Date: Thu, 26 Jan 2023 20:14:20 +0530 Message-Id: <20230126144427.607098-12-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230126144427.607098-1-jagan@amarulasolutions.com> References: <20230126144427.607098-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=jw5dG3mm; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Finding the right input bus format throughout the pipeline is hard so add atomic_get_input_bus_fmts callback and initialize with the proper input format from list of supported output formats. This format can be used in pipeline for negotiating bus format between the DSI-end of this bridge and the other component closer to pipeline components. List of Pixel formats are taken from, AN13573 i.MX 8/RT MIPI DSI/CSI-2, Rev. 0, 21 March 2022 3.7.4 Pixel formats Table 14. DSI pixel packing formats Reviewed-by: Frieder Schrempf Tested-by: Marek Szyprowski Signed-off-by: Jagan Teki Reviewed-by: Marek Vasut --- Changes for v12: - update the logic suggested by Marek Changes for v11: - collect RB from Frieder - drop extra line Changes for v10: - none Changes for v9: - added MEDIA_BUS_FMT_FIXED - return MEDIA_BUS_FMT_RGB888_1X24 output_fmt if supported output_fmt list is unsupported. - added MEDIA_BUS_FMT_YUYV10_1X20, MEDIA_BUS_FMT_YUYV12_1X24 Changes for v8: - added pixel formats supported by NXP AN13573 i.MX 8/RT MIPI DSI/CSI-2 Changes for v7 - v4: - none Changes for v3: - include media-bus-format.h Changes for v2: - none Changes for v1: - new patch drivers/gpu/drm/exynos/exynos_drm_dsi.c | 62 +++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 5518d92c8455..9459c138d0e0 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -1466,6 +1467,66 @@ static void exynos_dsi_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +/* + * This pixel output formats list referenced from, + * AN13573 i.MX 8/RT MIPI DSI/CSI-2, Rev. 0, 21 March 2022 + * 3.7.4 Pixel formats + * Table 14. DSI pixel packing formats + */ +static const u32 exynos_dsi_pixel_output_fmts[] = { + MEDIA_BUS_FMT_YUYV10_1X20, + MEDIA_BUS_FMT_YUYV12_1X24, + MEDIA_BUS_FMT_UYVY8_1X16, + MEDIA_BUS_FMT_RGB101010_1X30, + MEDIA_BUS_FMT_RGB121212_1X36, + MEDIA_BUS_FMT_RGB565_1X16, + MEDIA_BUS_FMT_RGB666_1X18, + MEDIA_BUS_FMT_RGB888_1X24, +}; + +static bool exynos_dsi_pixel_output_fmt_supported(u32 fmt) +{ + int i; + + if (fmt == MEDIA_BUS_FMT_FIXED) + return false; + + for (i = 0; i < ARRAY_SIZE(exynos_dsi_pixel_output_fmts); i++) { + if (exynos_dsi_pixel_output_fmts[i] == fmt) + return true; + } + + return false; +} + +static u32 * +exynos_dsi_atomic_get_input_bus_fmts(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state, + u32 output_fmt, + unsigned int *num_input_fmts) +{ + u32 *input_fmts; + + input_fmts = kmalloc(sizeof(*input_fmts), GFP_KERNEL); + if (!input_fmts) + return NULL; + + if (!exynos_dsi_pixel_output_fmt_supported(output_fmt)) + /* + * Some bridge/display drivers are still not able to pass the + * correct format, so handle those pipelines by falling back + * to the default format till the supported formats finalized. + */ + output_fmt = MEDIA_BUS_FMT_RGB888_1X24; + + input_fmts[0] = output_fmt; + *num_input_fmts = 1; + + return input_fmts; +} + static int exynos_dsi_atomic_check(struct drm_bridge *bridge, struct drm_bridge_state *bridge_state, struct drm_crtc_state *crtc_state, @@ -1514,6 +1575,7 @@ static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_get_input_bus_fmts = exynos_dsi_atomic_get_input_bus_fmts, .atomic_check = exynos_dsi_atomic_check, .atomic_pre_enable = exynos_dsi_atomic_pre_enable, .atomic_enable = exynos_dsi_atomic_enable,