From patchwork Thu Feb 9 14:30:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2709 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id CDD5F3F046 for ; Thu, 9 Feb 2023 15:32:04 +0100 (CET) Received: by mail-pg1-f198.google.com with SMTP id c15-20020a63ea0f000000b004fb3ed8a500sf1174715pgi.10 for ; Thu, 09 Feb 2023 06:32:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1675953123; cv=pass; d=google.com; s=arc-20160816; b=nM+dFxMPsQY3sQIxPjjijs82Fk96tmoduI7Vn4vx0yZ3M9w28J5lz4Z8JiP86uW3y3 Z9JhlIEJuB81eh4nDjiJ//W2s4v5dupAMjbtpE+V5XnWm9p6qzs5mtlI1LJWK9Md+0Fn YZ0z8aNtjtZRy5GJlnafpoLlwI2bccawInGq3ts4u3RJFdXPP5pqBvzmw3ljnGIhlIZ6 jSQld+o7jlJqMEIAlXdibh3ftnhjGJbCLailDrLKIuftVFH2RtSaTDJe3r6WdKZ7YYT6 sqSrFDcUOty2w2sVeYa1d2jqMN6x/B2ocxu5HTW54SsMp3kTXIzykvC+VKk/5QSpVOS8 g8+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=+lA4b4PVAP/uOG6DV17X1XxcmFmzkKAWs97iobKbuTw=; b=bqo79IEM43dzLcuWMbtKlq49hfp1syqrtCSaDqIJGvcJ3Qv8ZPjyrqiezzjsYHZMhf fk0YgwqgpJOcT90p4WnAD/3mZNaYWS4St9x6/m9zCkHu2SMU6vGzE33/nQdagXVsWiaR vw0guJWqx+BoWG5oWEUBnD+Udc5Yq4u0mmT6SuC7FibgAMwRHejhKytbbImt5OXeX4qm 01s8ZcXnEW/9c/l/e84LiQwFiRC5Tvsr94ZwsgWrD5LgWy96LwOWWHgDeig0SO+Y14Cp FMZg5SG2SzXKPzwEQXPpsJ0qOQoGA7AphsmpZd/wjC7sl9lNv014JquOaGZzXlg4iFX3 APvA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=M1IE8IQm; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+lA4b4PVAP/uOG6DV17X1XxcmFmzkKAWs97iobKbuTw=; b=jsE/unrBf4blFEiD+chXcZeleCC+r/us5N8v7dY6mRUy2fnnlEjxWJ+bUwzIXgCNem UTyO35Uvlnbz1NuivOUZ/PBvQcjm1VtF4nqbA66p1GmWkLvBuNsLp5Hm9VBKQV9sg7t6 aiIkr4rrlDs4ZttuG5D/7FNdJRPSdlQ86hZhI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+lA4b4PVAP/uOG6DV17X1XxcmFmzkKAWs97iobKbuTw=; b=Zz2FnGxvxydIxmu4qnU1x5w2uvng+/DSjt+5uIcmxLirDhCYTRGHYfXbXR30ZHKVZn ulwRCEvii6Q3UIYGar/oAthlIuCUIok8l0qcqcKrsSFFnzTOwY111FAJ2eIG6bycQruv t+Foe/KYmPl3S14sh00xzicrr56bTSOupdT6J26G1wtVWUkD7UD5gVCmNWf8ntu3YVmT Hi3n6/luWtwjQc1cSts8NWi+iRS5lMDFjVfpsM8eBypO7reZqadMjDR1QR9lfSxZlmiF bOkjzKtPzXf4HLhNEf7FGN7SCBa++f0M/ORe7BdFJZruJjiLd994vHE4PuxVIE8aT8O6 Bpcg== X-Gm-Message-State: AO0yUKUvbeXTMDuoo6YKAmSVGSl1Rf45RfNVUqQABvzBVDReaS8zMSHY PQ3V6qSdtxSshx5jkbr1vRGMTuU4KNaOIA== X-Google-Smtp-Source: AK7set/0WYbHvQKoy43VrB6nTa2dLAcYDpGPhDRQJhOV8ioZR8UfqKWO13qCi82kYG7gNdqaezeIDg== X-Received: by 2002:a17:90a:4685:b0:22c:491d:e483 with SMTP id z5-20020a17090a468500b0022c491de483mr1602413pjf.33.1675953123488; Thu, 09 Feb 2023 06:32:03 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90b:1011:b0:214:246b:918a with SMTP id gm17-20020a17090b101100b00214246b918als5897649pjb.2.-pod-canary-gmail; Thu, 09 Feb 2023 06:32:02 -0800 (PST) X-Received: by 2002:a17:903:244f:b0:199:30a6:376c with SMTP id l15-20020a170903244f00b0019930a6376cmr11766461pls.68.1675953122589; Thu, 09 Feb 2023 06:32:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675953122; cv=none; d=google.com; s=arc-20160816; b=LfUQrMyNQ2nqAfO3YOesIjQSr4xRGBiuj9VTCYYWDhphlq2ayBNXtYFOO5FKlSC4mN H4B5LrKkitdSPRD1I3hU3YM26f7nxsrVyBj3q3IVX/Lg8BuCTxh7fOxsIvErMqWA6aAI Y0UhH5+RB1fJuqMPjvUH/18GDBVBuBpOH4U09ba6eiDGolVIrbaZYxbUJ+m77gwp06JB u8fPLL0cIzv6btoVKO0G3ByCI+AorKngMOFXpxmtqNfvbLPNiGGBcH5BbO1T54B1pRBa LYfHVJasNN6Qpg0Dz9Bj2l/QR8vJH/ghTzhXtK0JtN0K9NUTMstXgrwPHdwXzZg3uiie rplA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=2bEh6OLiZLSsblqZCcW3j0yP0wFtvY9DVsT5+AnVvSw=; b=kUhAKm8yO3pyqAxT9zMMquXKAXyD2WT/1mICucwyavSF4gpKP/hgUgMmQrkComVW/X lg2DnfUPEiqSxRfiHcldh+nDqn5M3XWOB8kdEzijaYfEBGg5MAcJ4WR/KxN+1dvAl4/U /fb+rk9HQE+pD6vzht01j/Yfhh37mQmQ2v9Ioz9ca6h+zjCZTISxRTYj9NCznPhKGEky U2yskQ95e52KzZrjPkH+mbHAm9nRO2je7Z7mmEgni8zke8kFTUDO1JtXRfS1aLKuAZeT dbM2WbxtZD1r4gm2RDvJBfBJAUT/pynKoIYT0WqMr8FbnRcyCqFxNZhlkdLz/ZStUAuJ /3tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=M1IE8IQm; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id w1-20020a1709026f0100b00192dea2eceesor917803plk.166.2023.02.09.06.32.02 for (Google Transport Security); Thu, 09 Feb 2023 06:32:02 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6a20:840d:b0:bf:6cd3:954a with SMTP id c13-20020a056a20840d00b000bf6cd3954amr15962308pzd.42.1675953122247; Thu, 09 Feb 2023 06:32:02 -0800 (PST) Received: from localhost.localdomain ([183.83.141.79]) by smtp.gmail.com with ESMTPSA id j7-20020aa783c7000000b005938bd2bfd3sm1501226pfn.120.2023.02.09.06.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 06:32:01 -0800 (PST) From: Jagan Teki To: Kever Yang , Philipp Tomsich , Simon Glass Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com, Jagan Teki , Manoj Sai Subject: [PATCH v3 5/7] phy: rockchip: inno-usb2: Add support #address_cells = 2 Date: Thu, 9 Feb 2023 20:00:58 +0530 Message-Id: <20230209143100.113376-5-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230209143100.113376-1-jagan@amarulasolutions.com> References: <20230209143100.113376-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=M1IE8IQm; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , New Rockchip devices have the usb phy nodes as standalone devices. These nodes have register nodes with #address_cells = 2, but only use 32 bit addresses. Adjust the driver to check if the returned address is "0", and adjust the index in that case. Derived and adjusted the similar change from linux-next with below commit <9c19c531dc98> ("phy: phy-rockchip-inno-usb2: support #address_cells = 2") Co-developed-by: Manoj Sai Signed-off-by: Manoj Sai Signed-off-by: Jagan Teki --- Changes for v3: - new patch drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index b32a498ea7..a01148db22 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -179,12 +179,21 @@ static int rockchip_usb2phy_probe(struct udevice *dev) if (IS_ERR(priv->reg_base)) return PTR_ERR(priv->reg_base); - ret = ofnode_read_u32(dev_ofnode(dev), "reg", ®); + ret = ofnode_read_u32_index(dev_ofnode(dev), "reg", 0, ®); if (ret) { dev_err(dev, "failed to read reg property (ret = %d)\n", ret); return ret; } + /* support address_cells=2 */ + if (reg == 0) { + if (ofnode_read_u32_index(dev_ofnode(dev), "reg", 1, ®)) { + dev_err(dev, "%s must have reg[1]\n", + ofnode_get_name(dev_ofnode(dev))); + return -EINVAL; + } + } + phy_cfgs = (const struct rockchip_usb2phy_cfg *) dev_get_driver_data(dev); if (!phy_cfgs)