[v4,09/12] arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates

Message ID 20230217115845.75303-10-jagan@amarulasolutions.com
State New
Headers show
Series
  • rockchip: Add Radxa CM3 support
Related show

Commit Message

Jagan Teki Feb. 17, 2023, 11:58 a.m. UTC
From: Jagan Teki <jagan@edgeble.ai>

combphy1 is failing to probe due to unhandled assigned-clocks and
assigned-clocks-rates.

=> usb start
starting USB...
Bus usb@fd000000: Failed to get PHY1 for usb@fd000000
Port not available.
Bus usb@fd800000: USB EHCI 1.00

There is no real requirement for them in U-Boot to handle, hence
mark them as deleted-properties for the  probe to success

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/dts/rk356x-u-boot.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Kever Yang Feb. 21, 2023, 9:32 a.m. UTC | #1
On 2023/2/17 19:58, Jagan Teki wrote:
> From: Jagan Teki <jagan@edgeble.ai>
>
> combphy1 is failing to probe due to unhandled assigned-clocks and
> assigned-clocks-rates.
>
> => usb start
> starting USB...
> Bus usb@fd000000: Failed to get PHY1 for usb@fd000000
> Port not available.
> Bus usb@fd800000: USB EHCI 1.00
>
> There is no real requirement for them in U-Boot to handle, hence
> mark them as deleted-properties for the  probe to success
>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk356x-u-boot.dtsi | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi
> index ccb8db0001..4e2d059fcf 100644
> --- a/arch/arm/dts/rk356x-u-boot.dtsi
> +++ b/arch/arm/dts/rk356x-u-boot.dtsi
> @@ -22,6 +22,11 @@
>   	};
>   };
>   
> +&combphy1 {
> +	/delete-property/ assigned-clocks;
> +	/delete-property/ assigned-clock-rates;
> +};
> +
>   &cru {
>   	u-boot,dm-pre-reloc;
>   	status = "okay";

Patch

diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi
index ccb8db0001..4e2d059fcf 100644
--- a/arch/arm/dts/rk356x-u-boot.dtsi
+++ b/arch/arm/dts/rk356x-u-boot.dtsi
@@ -22,6 +22,11 @@ 
 	};
 };
 
+&combphy1 {
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-rates;
+};
+
 &cru {
 	u-boot,dm-pre-reloc;
 	status = "okay";