From patchwork Fri Mar 3 14:51:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2771 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id F172744AA6 for ; Fri, 3 Mar 2023 15:52:59 +0100 (CET) Received: by mail-pl1-f200.google.com with SMTP id m9-20020a170902db0900b0019ea0e227e4sf32173plx.6 for ; Fri, 03 Mar 2023 06:52:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1677855178; cv=pass; d=google.com; s=arc-20160816; b=g0OTqHX6H7BxJhCKRt69VF1vOMIkX11qtNqiba9jVvzNUGYdCz4A8q8PMTREf6sL6W 0Lwun/lon3JIrV1RXd2KIkdh/LtrCTpaJZA4+/bmw/6SIYZ9G5qfDg4k2+fO1WY/F7Oo Sci/epTdCwpH8kEf+ECGd4CSmBoqR4v3jbnLM1d/2ceZfDKhRgPcXEry7eqJURq4Vpun hwhRD7/g+FStt36xQsb9aqmS+fOVoKqD3UnYcQFkX7byRO9skLA8J9V0X5ZHKMg4o2DH lYwu/ZXJ1mxlFCXjCLRS6DvYo+vyEQtcvaf2ft7wWQSFSg9csQnOEliTjdlQcQmry8QV bxqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=KcwRPHodLDSj1JEX9luATO5s2KrQNrovBpjoEOsUqkk=; b=0TYefVh7DcA8sST1yPOjwv/1P82j8XF6LA2+PTK4tYVRIFvF2NrVDJOb+pMQzPCN2k piX92cKqOvARfPCA/5l+wM4YoIYy5ddSvKXh1koS/cX1yBqMPMjJjpsdObOZHhBxGzz6 KhjiWQ9/9fN42x4q/20Q5mYasl9hE04c8XmyWcYbnF2XA66r213rikSxAXUJsKLaaJSh KDS3hZdpoBz8cptIDfJXXyS8MbF5dJ7sZgmhjZr9BVAwHjqOSA46uM0yCqenoVLWfPGa iADDs58uNKXqxxjQDolgY5hV0UmI9WGwUU1US+p/KSWZ/kduLOQtIkxsRf8yt5rZA5n3 QYoQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=cbJxdKLy; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1677855178; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KcwRPHodLDSj1JEX9luATO5s2KrQNrovBpjoEOsUqkk=; b=QsNerUxeyLYfM2PAb+jP98DvrHHzzfNNHAOMI0xHVnJ3+HY81tpwyqVo5PVDTlCVLd 3xGco/JoGqMZYxJHZLNDvH9fBZQzNbxoFwb66T5+47Brk9tE00pFqnxTQULzCKxXzsNA XonAi94mPWfd09NvP8Ly1Cw413ydammNESxlE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677855178; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KcwRPHodLDSj1JEX9luATO5s2KrQNrovBpjoEOsUqkk=; b=hhkjv4CREN/vbW+VY2K8eWTKUAdj0+UMpPu2p4CPWXC79QH4qZ6YtvKJWOIC2CbTnA rDGLNLsX9lHlVhyrpyicyVLkacUDi7Ca/wawi8dWjXXqWyAwta1tovgl1cu0inGyG8F2 mMaDao22UkLVVJVPZOjTyFeu7PJDogn2mAKuEennZyLvevL8HtXVVqRAcN64D1WgqRxU IyDoiN0uqqg66qkCFisnTRS52ov8/htQ7dPssfcK09CBKjoEEDH/ankwaAVfnsqzrFEk KT+zWnCQXEBuiKXzXM/o2YIdW47abPU5FJCqaGxkAEspdaSJ3bYc3E6KExtG5iiOjT+6 aoZg== X-Gm-Message-State: AO0yUKWrhPxpi44ifuXaa5B8iT+oS7nvJ/UqVMNXT+oGVcQWHsNScXCs t49ek46oBdZR86FLXlt1OtMhaIXN X-Google-Smtp-Source: AK7set+XWPQn7WbLw/5ee1PaA7Hf2dGG9VEfTzk/bg86LWKmHF/IIVO1kao2xcdZQIZ7Nqa6cuKq4Q== X-Received: by 2002:a62:828e:0:b0:593:da6f:fb1c with SMTP id w136-20020a62828e000000b00593da6ffb1cmr1015011pfd.4.1677855178657; Fri, 03 Mar 2023 06:52:58 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:90b:3890:b0:237:7ef0:5b8 with SMTP id mu16-20020a17090b389000b002377ef005b8ls6512043pjb.3.-pod-canary-gmail; Fri, 03 Mar 2023 06:52:58 -0800 (PST) X-Received: by 2002:a17:902:ea02:b0:19d:2a3:f017 with SMTP id s2-20020a170902ea0200b0019d02a3f017mr2403658plg.62.1677855177652; Fri, 03 Mar 2023 06:52:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677855177; cv=none; d=google.com; s=arc-20160816; b=P3sIS3rxBGciunzXWIjX45/8fjmjggAC3S5ZVCAbK90ClmTvoAL+5unP26qOJMXZ6D e9dduGBKqM/hKImNxTtCMsfWdHAGGpvZ3aHFDdjQXxg8caNNG7xfum5enhD3kQrKm22f 4+1kjad+ZJ+y3/kanBDeG3rwMAzSMZt+jKktvM2a/kS9VXEU+tRgthCxvW3tSmKVTC6z oBql5pS7sqk6ERS9BF6afLeErHE2j32MCZALUccEwMMTmZJN1wuNK9E1jYnAD4aaj3bE kDrQvjsMaUiCfcspbVyYgp3Y4YXSndeWO35NMg/V0M02yBgWacex03pie+CF7VY0rDVp 2zRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GpBHKg2Gosb5BLI0oOYz0OdhN4+kHsJSwAsQE5BDZyI=; b=IGPAMTkxApA42FUvof+8r4FQ19sR32n45ItVJdxlT/w35KMxWru2HkhIMv9Y+2ALRD UMsLHQzbPBbdjvJSvoCJK9GP7QCJo8AxRVeuwCR+Sy78JK/eVYgUbP29kByMCGpnKX5/ Scq0TsJLv80zjZ3bof8Qg4kwrWLb0wTS+yrk/LAdto28JFnT5v65AJ3bnP9RJ+7wZHFH qJ1V+pYsEWBQ2Oz8NzBPYlt98U5Eg8myTKc1jLyEPATyjKEnIpjQFcZxTMUFGu3DmByM MSJngHZ0R+nWXeTM5+KwoeGsdsSex4WQwowlqY8dZZ5QvUbOiAWdKuGa8sCrTr7NZ39L 5t/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=cbJxdKLy; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id p5-20020a170902780500b0019a7a239ea7sor1172619pll.71.2023.03.03.06.52.57 for (Google Transport Security); Fri, 03 Mar 2023 06:52:57 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a05:6a20:c510:b0:cc:5917:c4ec with SMTP id gm16-20020a056a20c51000b000cc5917c4ecmr1900370pzb.23.1677855177350; Fri, 03 Mar 2023 06:52:57 -0800 (PST) Received: from localhost.localdomain ([183.83.137.89]) by smtp.gmail.com with ESMTPSA id z4-20020a63e544000000b00502fd70b0bdsm1660856pgj.52.2023.03.03.06.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 06:52:56 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Neil Armstrong , Marek Vasut , Maxime Ripard Cc: Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-amarula , Jagan Teki Subject: [PATCH v15 08/16] drm: exynos: dsi: Add input_bus_flags Date: Fri, 3 Mar 2023 20:21:30 +0530 Message-Id: <20230303145138.29233-9-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230303145138.29233-1-jagan@amarulasolutions.com> References: <20230303145138.29233-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=cbJxdKLy; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting the i.MX8M Mini/Nano DSI host to add additional Data Enable signal active low (DE_LOW). This makes the valid data transfer on each horizontal line. So, add additional bus flags DE_LOW setting via input_bus_flags for i.MX8M Mini/Nano platforms. Reviewed-by: Marek Vasut Reviewed-by: Frieder Schrempf Suggested-by: Marek Vasut Signed-off-by: Jagan Teki --- Changes for v15, v13: - none Changes for v12: - collect RB from Marek Changes for v11: - collect RB from Frieder Changes for v10, v9: - none Changes for v8: - add DE_LOW for i.MX8M Mini/Nano platforms. Changes for v7, v6: - none Changes for v5: - rebased based on updated bridge changes Changes for v4 - v1: - none drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 796480e4a18b..5d971b607e1a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1736,6 +1736,10 @@ static const struct component_ops exynos_dsi_component_ops = { .unbind = exynos_dsi_unbind, }; +static const struct drm_bridge_timings dsim_bridge_timings_de_low = { + .input_bus_flags = DRM_BUS_FLAG_DE_LOW, +}; + static int exynos_dsi_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -1822,6 +1826,10 @@ static int exynos_dsi_probe(struct platform_device *pdev) dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; dsi->bridge.pre_enable_prev_first = true; + /* DE_LOW: i.MX8M Mini/Nano LCDIF-DSIM glue logic inverts HS/VS/DE */ + if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM) + dsi->bridge.timings = &dsim_bridge_timings_de_low; + ret = component_add(dev, &exynos_dsi_component_ops); if (ret) goto err_disable_runtime;