From patchwork Wed Mar 8 16:39:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 2787 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 7935C414B5 for ; Wed, 8 Mar 2023 17:41:01 +0100 (CET) Received: by mail-pf1-f199.google.com with SMTP id n17-20020a056a000d5100b005e5e662a4ccsf9106765pfv.4 for ; Wed, 08 Mar 2023 08:41:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1678293660; cv=pass; d=google.com; s=arc-20160816; b=gyamlQ6FWqox0IUFkswDtEhyh6UMmzrDEbgOC6KuFym4BRAkQXjwXkmlIbrFkyBSwG A7V/PLtBCc3HRWGHu990MaK5kQgk/dEAOVOWNZvpsayU3aiLIKzZ9ydmyrlOnc1g6tJy BCi7dabz4DgfLO1ADDUCB5byrGKi8XUDge9PdN4b87kfpDPQdVCbuFu9yUe4Vg15/t4t 2EdTjMnd5A3t1lYKSfDUMetuLoMvR+kNTLEm7YLRwG6YYoTh66Lt/G74jSFUhQ8MAumE Eb0k9kvnJgErketymZgVDuNpnPlpRgeEZU0A8ZnONdOu/VRRXHceoLXPAQMt0K5xPNeA 1xhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=BTcWeJYBdFrJjKCrI0IqOJBHavPqbyYvSuMV+LCGjKw=; b=NvXk7M4T1MjDf1TzehsZfkKbsBukhjt5JPS0M2Oay+/P58JZ95Lc+ra3HGTV+IKudX i/vmXmTK46Y3wfdADn73YT6/6spm83gPlXfTYP9C/WISb6fXQD1TrlE3P8+9XbQPbdGg XL61wbqyIVePHMs1HQY/uo0EX0k5te3V0WcUaakY6uTcrrTPcn9rPqiy0y4N7WLxWWHP Pbtl1h1AFF8PYOHgQVzaal8BoiTGN9N2OUmt7ji6rju6K/HgbzrnwCeZsnS8gd1+voE2 YFpn5dgEotb0XKY3cHT4o1qgeu0XvYhnCDe/4vHHgWJp3EWjbs0EffZegidepdUIUZ/W e5CQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=qvZ2QewJ; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1678293660; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=BTcWeJYBdFrJjKCrI0IqOJBHavPqbyYvSuMV+LCGjKw=; b=l3vk4c44BxeTmIRm6CM1UVZlnI41AOZWljFKF8u9yRCkUkXwsM+IuO4peC7qO2gGgl 0qzc8XPOTQs+2POREuv2RVgVzBeAdrpljspoa/eAR42A51/yH89mg48KOQc876ZJZMbB Li/lYY++WnQYPOKvBNWrEiBMJfU1uI+0Mp/F8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678293660; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BTcWeJYBdFrJjKCrI0IqOJBHavPqbyYvSuMV+LCGjKw=; b=p+7GQHU0PSb44jyAK///7VfeFLB3JHuKDdxr0riu+ajL2mg/Al+rDQ1aNOVUnCOLUK +SZDjGflrJpsuMmxQAEO7fFxxQDAcW6qUW0dzADjrb+PYT6SJD/DF9wv1RR5yXQYt5yP A7kpQ8i77uKaT9052TUNrwzJ7PRHtMMFQspk1HrE76LgW8bLWDtnN6LbloB9CcjiiT87 EK8B8ld/z16Dn1Z+7Bclj+5RD6ZaJJJKEEqhYgNNAycDpG2CPe0OOof2d4fPKeCGqarW mz5LYUQvPqUY/PhNmjBvj85veip/n3U+e+vc3p+1IOt8MtswwgGdDrR/ixI8gH4tGe2Q MveA== X-Gm-Message-State: AO0yUKWrC3WCwKIP8RKWNkYhU1qf4g0VfrURW7C5STS6GqezeaYEKQ2v Kbw+OMKVf3c8W7R568B+2sxyK5+r X-Google-Smtp-Source: AK7set9Crr8PYinFl8ZzvOlunZ7X2cxzLsXaaT9Rlo7lDWjmPJ/WpG1gzlhQ7+8oGWu5KxCLf7JQgg== X-Received: by 2002:a17:903:449:b0:19a:87dd:9206 with SMTP id iw9-20020a170903044900b0019a87dd9206mr7199722plb.0.1678293660219; Wed, 08 Mar 2023 08:41:00 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a17:902:f7c2:b0:19c:b41a:3d75 with SMTP id h2-20020a170902f7c200b0019cb41a3d75ls16359295plw.7.-pod-prod-gmail; Wed, 08 Mar 2023 08:40:59 -0800 (PST) X-Received: by 2002:a17:902:e54f:b0:19d:d14:d48a with SMTP id n15-20020a170902e54f00b0019d0d14d48amr22581037plf.3.1678293659291; Wed, 08 Mar 2023 08:40:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678293659; cv=none; d=google.com; s=arc-20160816; b=obFDoWDiW6XDmgAztZtWzG5jm9LrOeHULsSIneYaB17+0UagCsrTKEDB1l9CiJx6SS 9UmaOHk5szYzazvOiy4pxuTYgoNBW3TMwJDNMtJNpraMcNyZO70AvjhwdusroGGmcZRB Bd96kI/KU5IPeGmj0QyQfKw7UAqfmJkDMlFdki9LNnk+Eqil0JFdaDXTsolv0BimNkcQ 2Kp/17f9nEgCW9wiWR2+/20uGapITxrTThJq8RkCT+2BxyUIEB9+Lvt94msPHy7Vg0D7 lJuV58HkvVZntthiTPeX9Zp11pEjzCgRU00Kf6R/JRGPofNmws8jIdgK14ehUPh9BCcB +1QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=aOdTRCNR5Lf/ceaTUFSrm5IHZuRCLptqla9LZq74Fpo=; b=u/H1sWelQeu8HwRxIilmfXtNs2INAbKbEFSLuh441op7oXww1amtOYFRXjy0JX2nV1 1U+ToJrcFFyQL09+4f/RU6zU9pvCyuhW13rXcqBQuJw6KrAPzkF1JKtPPjDBeUzbfU76 i7N15Zoj2fKYmUsaJbh14gfLJseMD13qf334HzgVMawZ7sttjE68e6935F63Dm7Puj2D 1s9kJCTzGHKNgT+ORVnH1d7d8V0JWQ+FN8sz9PUfQhOaGB4/LR8WnZw2iGKfAVLzu60W 7/eJbsLZe7riiNIPKPwOSz/o4ZaTdhvOpBaye0oIGVe4L+iVpC5kPXBb+BnSfR36eVq/ 5pjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=qvZ2QewJ; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ij9-20020a170902ab4900b0019c911e1dfasor5924921plb.48.2023.03.08.08.40.59 for (Google Transport Security); Wed, 08 Mar 2023 08:40:59 -0800 (PST) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:902:778f:b0:19e:6760:305b with SMTP id o15-20020a170902778f00b0019e6760305bmr15440925pll.47.1678293659004; Wed, 08 Mar 2023 08:40:59 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a8a1:b545:91cc:80b2:f9fe]) by smtp.gmail.com with ESMTPSA id kq3-20020a170903284300b0019b9a075f1fsm10046540plb.80.2023.03.08.08.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 08:40:58 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Neil Armstrong , Marek Vasut , Maxime Ripard Cc: Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-amarula , Jagan Teki Subject: [PATCH v16 07/16] drm: exynos: dsi: Add atomic check Date: Wed, 8 Mar 2023 22:09:44 +0530 Message-Id: <20230308163953.28506-8-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230308163953.28506-1-jagan@amarulasolutions.com> References: <20230308163953.28506-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=qvZ2QewJ; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Look like an explicit fixing up of mode_flags is required for DSIM IP present in i.MX8M Mini/Nano SoCs. At least the LCDIF + DSIM needs active low sync polarities in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work properly. On the other hand the i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020 says. "13.6.3.5.2 RGB interface Vsync, Hsync, and VDEN are active high signals." i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 3.6.3.5.2 RGB interface i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 13.6.2.7.2 RGB interface both claim "Vsync, Hsync, and VDEN are active high signals.", the LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. No clear evidence about whether it can be documentation issues or something, so added proper comments on the code. Comments are suggested by Marek Vasut. Tested-by: Marek Szyprowski Reviewed-by: Marek Vasut Reviewed-by: Frieder Schrempf Signed-off-by: Jagan Teki --- Changes for v16: - collect TB from Marek S Changes for v15, v13: - none Changes for v12: - collect RB from Marek Changes for v11: - collect RB from Frieder - fix commit message Changes for v10, v9: - none Changes for v8: - update the comments about sync signals polarities - added clear commit message by including i.MX8M Nano details Changes for v7: - fix the hw_type checking logic Changes for v6: - none Changes for v5: - rebase based new bridge changes [mszyprow] - remove DSIM_QUIRK_FIXUP_SYNC_POL - add hw_type check for sync polarities change. Changes for v4: - none Changes for v3: - add DSIM_QUIRK_FIXUP_SYNC_POL to handle mode_flasg fixup Changes for v2: - none Changes for v1: - fix mode flags in atomic_check instead of mode_fixup drivers/gpu/drm/exynos/exynos_drm_dsi.c | 28 +++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index eb33c2bcac16..df4d95ae8aad 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -263,6 +263,7 @@ enum exynos_dsi_type { DSIM_TYPE_EXYNOS5410, DSIM_TYPE_EXYNOS5422, DSIM_TYPE_EXYNOS5433, + DSIM_TYPE_IMX8MM, DSIM_TYPE_COUNT, }; @@ -1465,6 +1466,32 @@ static void exynos_dsi_atomic_post_disable(struct drm_bridge *bridge, pm_runtime_put_sync(dsi->dev); } +static int exynos_dsi_atomic_check(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state) +{ + struct exynos_dsi *dsi = bridge_to_dsi(bridge); + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; + + /* + * The i.MX8M Mini/Nano glue logic between LCDIF and DSIM + * inverts HS/VS/DE sync signals polarity, therefore, while + * i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 + * 13.6.3.5.2 RGB interface + * i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 + * 13.6.2.7.2 RGB interface + * both claim "Vsync, Hsync, and VDEN are active high signals.", the + * LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. + */ + if (dsi->plat_data->hw_type == DSIM_TYPE_IMX8MM) { + adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); + adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); + } + + return 0; +} + static void exynos_dsi_mode_set(struct drm_bridge *bridge, const struct drm_display_mode *mode, const struct drm_display_mode *adjusted_mode) @@ -1487,6 +1514,7 @@ static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_check = exynos_dsi_atomic_check, .atomic_pre_enable = exynos_dsi_atomic_pre_enable, .atomic_enable = exynos_dsi_atomic_enable, .atomic_disable = exynos_dsi_atomic_disable,