From patchwork Sun Apr 2 20:09:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 2847 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6F4DA3F330 for ; Sun, 2 Apr 2023 22:10:22 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id k14-20020a508ace000000b005024a8cef5csf27156291edk.22 for ; Sun, 02 Apr 2023 13:10:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1680466222; cv=pass; d=google.com; s=arc-20160816; b=Q3XDY2KF3ZKyRtc3qgb5sO0lVcPPe1Sy87AsyeYLRHCZWSakelD3zjPBZeSxHHmdvh vqXRTDD6dz+/Uj8zkxKnpOLu4mtK2cEB6ctOxMDA9t6h+aViUYDHjAmK5SLxEQ6Zk70l 0oNzX6bRvQ8tbNyCXMMxQ0qpK0BW+AjijkAMqMbBY/hn9l7rAHaOFMtUjaJCdOcbx0jJ q2QT5cs2Ww0mO4Y+KmEIAOgWTg2Hxh9oa0uFDlpbyZ1JVjJ4sP1UHSpLy051g/4dJ9Oi 4ch4nwQRkSUmmL8U7JRGnXVgPftm04qcbZHoQ4r2y/hXMBFizsd/59fLkOmYvbu/64zL gqdw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=TypkBXEpN/Qi0dPDOjifdURsqyo87ormhD0UIWazweo=; b=M3vrovs6jB0BRXde3M2UPK5PjHvkUTNv2P4npJvj7Fa7C/I4ttejs2x3iurT85EmJL Meiy5GDUqr/k1ktdkNifLU5SHUggQ/VOVHjDn5rrLzmnLE3/EsyimhygkKpp171RLA0p U18Xo4b+Rg1ii65cnnhct2DVnkd27zSyyW4vHf09RmQVkaFc3v56+RF44VE15edAN7P2 hQV8EjPbiR9Ohhkm+SxtzqReYAdm0rPYqtOQxUVWrZX4rkF7w1Z0Fh/D2Dz0TafUtfwG EReJ303xScFV0Hmw+ZCPNAVY8rkQwQS6XHmD7xoAKyx2t5QXLMkMLR+upYYAB+6cEyw7 Jq1g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=O3nYWp+w; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1680466222; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=TypkBXEpN/Qi0dPDOjifdURsqyo87ormhD0UIWazweo=; b=RyjjL4A54XKxsoPwU+lQW1QVrjbq4vVI9g3Cq6G05u/xxyH6w2BghVdGVYyLZDsjdG LUwCzerumtkVrgLRhm8IBsroMdjCpmKY1E5GpKDnLGgOFakgpeo7g+OovJOlkMCBnbex wTh31VYHTGWMgMm7BsIGLrBIk/kxNZLrW8Gak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680466222; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TypkBXEpN/Qi0dPDOjifdURsqyo87ormhD0UIWazweo=; b=nV54TMpVoRCbpaSVowoBAB0zOV8K75WPzwsFV4pVOekLi3uiNeAMERTsUhmS4+dsy2 RWI855P4uZnei1WuTDlUOXkTNMyw9OnYiM59ix74SzY5i9abH6fRZRHa4ywt0bNkBCA0 vwJU+ZS5KY0EmOmGdb9gUpUgbEkRKEnBN3NhnEMbW1poL9Jpofh89o8eCr6cbImVVsVr IROeQJukzOClD2TvYAgvb/85ipFsmVILaDJg+jhTGQJ6EiXcANnOuEvoHLdlwRUvPN7o +EM2DUhuFVl5mkCRVqYe3tw8LZ/ZVEgJ5VeZZ0QMbvmw2EucwVzk7sFREF8bfENVHFgi ypBQ== X-Gm-Message-State: AAQBX9esLxW7xno/JzR+4nE8FtwS8o48xy3KCPqsyzPEX4WgUesev3vj txU000yoCGvdspdH6wTdCUb7L8+4 X-Google-Smtp-Source: AKy350YJNFpHvRgtf1ZpmQgBSDO4ktFYnGcIB5FQBWGnKryVcvKII3qLzCSLPkntVuI3mIIbfjctFw== X-Received: by 2002:a50:f692:0:b0:4fc:fc86:5f76 with SMTP id d18-20020a50f692000000b004fcfc865f76mr16921898edn.6.1680466222284; Sun, 02 Apr 2023 13:10:22 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:36e:b0:502:9d37:a300 with SMTP id s14-20020a056402036e00b005029d37a300ls1107808edw.0.-pod-prod-gmail; Sun, 02 Apr 2023 13:10:21 -0700 (PDT) X-Received: by 2002:a05:6402:1641:b0:4fb:953d:c3d0 with SMTP id s1-20020a056402164100b004fb953dc3d0mr30613991edx.20.1680466220787; Sun, 02 Apr 2023 13:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680466220; cv=none; d=google.com; s=arc-20160816; b=SDLGwoRFBV0s67oX0qDPvPdjnCvOH8ke8pEYqf0tnRfsSFRU7ya6746XtYkAzszX07 eWTX/MEX8MCzy1vf7iScWvs0tgHBcNFGcxanRTO9ZhfHffzH6yovhrZSCjU0SqDM+uKY wcyLpaU32KWLVirRzqwjZfp6p7mu06svIdXwwSpFKHZgZDQcx3WfvXSBrPei+Y4TncHk 12+eUWvjzR0s0G4PbRnNbn2ZWXcbZDFlW92lECwEwukBOh4Vaz9vZDfXH7V7s+KcrGF8 i/oJ9fVv8Hg6Dh0BUBrnF7Is8QRRZKsHhdSCgP6Mq6rF+3i/iFFWY4y6EwPA4ku8Vmrs o4iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AFjm9UZOr4B7pRsXgqjvbVyzqWT97tUm8W06JvPbgKQ=; b=Ky1NSmaU57tIl5e2svVUcgRH8CvhH9C0LBSPboZA7ywz5o19PLzy7Jo/c+q1k9j9E1 B12oQ17RN3fosUvHSY0rvP0cy2nHb1Fs9x7GpBmW70nk0oKXQSLpaEkYxN/RBdpj0xV+ sgKkAGYG+T8IP8DxxcnJhpI3daKPh+ouJV2sX74pyiaR91FctEIPAqzk/P/vmBcJ/Ymd pTgmX9b64wjmYU39/fZeC3Clan/NLhhIHjAmRH1/zbTDxLbovf2jTiFzS7TBP5HrqLSI ccmS+b+bwe9XLyBXuOao5lZcwF5wNtYSTjrACS3ckcBR4QNos+Ajcm8I/jHzSP1A6rPO iedA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=O3nYWp+w; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id k20-20020a1709061c1400b0093994122ec9sor4117394ejg.132.2023.04.02.13.10.20 for (Google Transport Security); Sun, 02 Apr 2023 13:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:907:84a:b0:947:87a2:31d7 with SMTP id ww10-20020a170907084a00b0094787a231d7mr13489859ejb.33.1680466220561; Sun, 02 Apr 2023 13:10:20 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-248-31-153.retail.telecomitalia.it. [95.248.31.153]) by smtp.gmail.com with ESMTPSA id gl18-20020a170906e0d200b00924d38bbdc0sm3553127ejb.105.2023.04.02.13.10.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 13:10:20 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Jonathan Cameron , Oliver Graute , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Wolfram Sang , linux-input@vger.kernel.org Subject: [PATCH 6/9] Input: edt-ft5x06 - don't print error messages with dev_dbg() Date: Sun, 2 Apr 2023 22:09:48 +0200 Message-Id: <20230402200951.1032513-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20230402200951.1032513-1-dario.binacchi@amarulasolutions.com> References: <20230402200951.1032513-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=O3nYWp+w; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , In some parts of the code, error messages were improperly printed with dev_dbg() calls. In those cases, dev_dbg() has been replaced with dev_err(). Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/edt-ft5x06.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 7d82f412ab15..89958881fca1 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -783,7 +783,7 @@ static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file, error = edt_ft5x06_register_write(tsdata, 0x08, 0x01); if (error) { - dev_dbg(&client->dev, + dev_err(&client->dev, "failed to write 0x08 register, error %d\n", error); goto out; } @@ -797,13 +797,13 @@ static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file, if (val < 0) { error = val; - dev_dbg(&client->dev, + dev_err(&client->dev, "failed to read 0x08 register, error %d\n", error); goto out; } if (retries == 0) { - dev_dbg(&client->dev, + dev_err(&client->dev, "timed out waiting for register to settle\n"); error = -ETIMEDOUT; goto out;