From patchwork Sat Nov 11 10:41:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 3005 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id BA11D3F057 for ; Sat, 11 Nov 2023 11:42:48 +0100 (CET) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-543f1c6dcaesf2047506a12.1 for ; Sat, 11 Nov 2023 02:42:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1699699368; cv=pass; d=google.com; s=arc-20160816; b=VZ5iFgRzsa9S+GivUobyzZbm/IRsaHeP1n4rDvmvRg9kLZIJOWfbafQt6Rz4gUJef4 ScQ1UM3wbsbNBBqw3rx/3rFGiXtUV9IV54w5m+NirSkHgHmxCy5PCqYRrp3s81mo2TPA N5WB4yHr7fVbRpbIIX86ryaWtDhEqS3ThKRj8gJ83eGhrBuKAsMO56Yx1LBC9g0ptM4V kwMVYsHpfjs3x0RMTDQWQvwXBGPtv5O3nIDNYaeu8EYAGnNJjp08RG3tX/l90nj/uEF/ 1ipEbhtcW0RMazwTWGuGYIity7A2bjNDI8JObkzMMcEGRZRSPkQsnTXZ2mNBNgubPEsQ QeRw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=8ncvB88PTqHONTD/YGcq98AY9oQgPnEd/6rge7dcvpo=; fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=; b=Wdf/I6nvn+WI066lHx0d5JIoRbA41ieU8q3CjY0mSHKNCGhApllAcgUBAE8gCPEjZu 9KmSdXxBLLDGVi1YWTh0r0C0mRK1iwQPt4vu5c/R5vN8eRvFiO/Ae0t4ahmFEDI1XmHp XQCBgDxQMuIYU03VsG3M9IHa3h3LADuVAw41tSOszrfKap26ga2vQQnYCJNrqsQzuv+0 1OzxplyQ12DwOyAMfYB1UsLokVDCw+PCnUOiW1D9dbDozMespaExyfbeCXYfO2joTPyC mGpOnTO6WH7sqV4fXUCVFtm0JAdfGnBQ6HFyQkdEm5MPmsypgVC7AJyT2rgdK6bdnZCK aFGQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=a0S4AlS6; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1699699368; x=1700304168; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8ncvB88PTqHONTD/YGcq98AY9oQgPnEd/6rge7dcvpo=; b=U3n9TSnR5ilaBzaOqX4u/LjgJghfDt/ygcS25GkfquzLKfTusp/oVWWTqZxkWTN38l BdNQonPLFOsHGjVVdvBgim1Tk5cHXt8zu0tBmcB13Y9RnbZXRYzGFwRSC2kxa0i3PQj0 NXjkZASNKxeh8/6HCbY1SWAEZM379YFMfvfNc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699699368; x=1700304168; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8ncvB88PTqHONTD/YGcq98AY9oQgPnEd/6rge7dcvpo=; b=ExojP/VavHEfPr/ZZym2CtOtgQC7LP3ElWoYB5Evj45x8AS0/shogYxHKjBJmLNmlm CFbRdhHVjmFCituWR9iT+um3fk6C0QgpKhMpGKiX5SpCcxt0EhVz2DH5QWr9ekbMleOo f5Qiyu02eE1XZlNu9rMRJ3YXkg3z1K4chxQYyc99PyUcyWnIrHVbf60nr7HJJv1RbHK9 7T3t487ThrKrYbER2/n08Gvnj9AyK7UxaBmW76Fb50UGe8NdikI4o5P5AlHHj2vOmEAT 0EOwVdnvH1bYBIeH8zj9a9QB0CKbkWQCgBadMrvb0ryJbzihwUCpvnqOa8LGjlS7YfOA kjBw== X-Gm-Message-State: AOJu0YyhBIjzyfsI+dtxQua5gIyomiM3P08E2PUnEALOPc6546+BUEOg BrzinBDt9NV4xGUMm9uiIcDa8LFm3D3PAAWc X-Google-Smtp-Source: AGHT+IGIOD7xY1w0NRplhQm2g1HgAA+1QSku8RdafRBaPtg3jFrk9UuWEK1z5KLRopdG56199icI7w== X-Received: by 2002:a05:6402:12cd:b0:543:6678:5559 with SMTP id k13-20020a05640212cd00b0054366785559mr1282480edx.27.1699699368568; Sat, 11 Nov 2023 02:42:48 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:5156:b0:534:7b4a:8d91 with SMTP id n22-20020a056402515600b005347b4a8d91ls50594edd.2.-pod-prod-06-eu; Sat, 11 Nov 2023 02:42:47 -0800 (PST) X-Received: by 2002:a17:906:4a84:b0:9e3:859a:52ae with SMTP id x4-20020a1709064a8400b009e3859a52aemr1028108eju.28.1699699367185; Sat, 11 Nov 2023 02:42:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699699367; cv=none; d=google.com; s=arc-20160816; b=hHWcY2yGX+wFLmaAOYqg+yDflEUzL7nVTKX0FC9TeXbQbRtuEj3i9UnZ4epTW26idt QHJ0lXlEarbJt5w7rh7J53bKGDzKnAqe9zB/g6DWzIc/R7zy4k9s7EoQ5VjlWuDX742u XTTCh3UCiiwVHSwLPSRag28UhYamJ8Q1jaEFW4DnKPR2MelPCi3OdI8HfstFy/wpLZ+N HtipoB/Xb0lJSiVyAZH59CHosBHbixYsZ+AxszvBmmh17OMs+fru5I4DDON6xfhg4keB vWvA8IWLX80CSA4pnAwP8dxBQi3bRqVKvjgS5c3Nk+vYh+5q84Rx3DmeV1S7DPPGF9BD FUxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=uXZvMG+ePha/xCPPyQSZcW7mIHQVo6pfDhdFQ8Ys4tc=; fh=CRQFspQ+XVmz3jTpDmawxjgq3paXQGVEDP+3Wpr+FXU=; b=cHit70rAa5q7L3PXFXgkLp6z6D7/1yzhjnU6cbXzTICimbYhHiQNBEgLTgU5v7qds0 vakSSTi1oVFW2qg0zWVNYQoj5lGVfr97shif8IFeixvGQ+041BGinz+cNNWPmEKD2cao BkoHo7U/jM1d/ZS1IEXC/2MzzvzEje4AnCwc84TM+NQF7Nn8BNVCTD4tuNJYkVr6uwBT bSpgrYKzuaX0NfUTki3SY2fMR4ZOQ+zQTXA4ohRM5TQJrjb6eY+AK2HeEyUISEAYjx5F 8TmuPvV5jLSfnczCEdtaZoH2xuDQYxR+4kUHag7/mO+qIUAChUafvR7j3bWE8tX2KcU1 VXng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=a0S4AlS6; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 21-20020a170906225500b009ddfc78027dsor273982ejr.3.2023.11.11.02.42.47 for (Google Transport Security); Sat, 11 Nov 2023 02:42:47 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a17:906:fa9b:b0:9dd:6664:1a3a with SMTP id lt27-20020a170906fa9b00b009dd66641a3amr1013488ejb.51.1699699366905; Sat, 11 Nov 2023 02:42:46 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-20-97-182.retail.telecomitalia.it. [79.20.97.182]) by smtp.gmail.com with ESMTPSA id ga33-20020a1709070c2100b0099e12a49c8fsm872183ejc.173.2023.11.11.02.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Nov 2023 02:42:46 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Fabio Estevam , Helge Deller , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org Subject: [PATCH 08/10] fbdev: imxfb: Fix style warnings relating to printk() Date: Sat, 11 Nov 2023 11:41:57 +0100 Message-ID: <20231111104225.136512-9-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com> References: <20231111104225.136512-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=a0S4AlS6; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Resolve the following warning reported by checkpatch: WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... This made it necessary to move the 'fbi->pdev = pdev' setting to the beginning of the driver's probing. Signed-off-by: Dario Binacchi --- drivers/video/fbdev/imxfb.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index ad293dc44dbb..a0172ff75c46 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -414,8 +414,8 @@ static int imxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) if (--pcr > PCR_PCD_MASK) { pcr = PCR_PCD_MASK; - printk(KERN_WARNING "Must limit pixel clock to %luHz\n", - lcd_clk / pcr); + dev_warn(&fbi->pdev->dev, "Must limit pixel clock to %luHz\n", + lcd_clk / pcr); } switch (var->bits_per_pixel) { @@ -628,28 +628,28 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf #if DEBUG_VAR if (var->xres < 16 || var->xres > 1024) - printk(KERN_ERR "%s: invalid xres %d\n", + dev_err(&fbi->pdev->dev, "%s: invalid xres %d\n", info->fix.id, var->xres); if (var->hsync_len < 1 || var->hsync_len > 64) - printk(KERN_ERR "%s: invalid hsync_len %d\n", + dev_err(&fbi->pdev->dev, "%s: invalid hsync_len %d\n", info->fix.id, var->hsync_len); if (var->left_margin < left_margin_low || var->left_margin > 255) - printk(KERN_ERR "%s: invalid left_margin %d\n", + dev_err(&fbi->pdev->dev, "%s: invalid left_margin %d\n", info->fix.id, var->left_margin); if (var->right_margin < 1 || var->right_margin > 255) - printk(KERN_ERR "%s: invalid right_margin %d\n", + dev_err(&fbi->pdev->dev, "%s: invalid right_margin %d\n", info->fix.id, var->right_margin); if (var->yres < 1 || var->yres > ymax_mask) - printk(KERN_ERR "%s: invalid yres %d\n", + dev_err(&fbi->pdev->dev, "%s: invalid yres %d\n", info->fix.id, var->yres); if (var->vsync_len > 100) - printk(KERN_ERR "%s: invalid vsync_len %d\n", + dev_err(&fbi->pdev->dev, "%s: invalid vsync_len %d\n", info->fix.id, var->vsync_len); if (var->upper_margin > 63) - printk(KERN_ERR "%s: invalid upper_margin %d\n", + dev_err(&fbi->pdev->dev, "%s: invalid upper_margin %d\n", info->fix.id, var->upper_margin); if (var->lower_margin > 255) - printk(KERN_ERR "%s: invalid lower_margin %d\n", + dev_err(&fbi->pdev->dev, "%s: invalid lower_margin %d\n", info->fix.id, var->lower_margin); #endif @@ -701,6 +701,7 @@ static int imxfb_init_fbinfo(struct platform_device *pdev) memset(fbi, 0, sizeof(struct imxfb_info)); + fbi->pdev = pdev; fbi->devtype = pdev->id_entry->driver_data; strscpy(info->fix.id, IMX_NAME, sizeof(info->fix.id)); @@ -1044,7 +1045,6 @@ static int imxfb_probe(struct platform_device *pdev) lcd->props.max_contrast = 0xff; imxfb_enable_controller(fbi); - fbi->pdev = pdev; return 0;