From patchwork Tue Jul 2 10:26:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Trimarchi X-Patchwork-Id: 3146 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 8D6E941733 for ; Tue, 2 Jul 2024 12:26:24 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-57d24c8f338sf991583a12.3 for ; Tue, 02 Jul 2024 03:26:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1719915984; cv=pass; d=google.com; s=arc-20160816; b=sBYMsJ6sDXNKzj0G9p1ZpPCD3tBVB/nZgnsW2Rj15Z4AhxtLPZvxmY8crviKkf9UN7 ArfyBK64vAaGRCAjstwwSWbw35odCU84BHgr3nGS8sjN0ND8/E7lTR0X9mMUjNk3Ha1B vjsr+LUywzzPZkt6Ht6VW2CLMCbFidq6TmQkz5Gi4hEHiy3R1MHWh0Q9PHe9mWm3yaXo 02I1m5UzTMMVMfdMr3subOikRGVEUcyr1cJxBQnTz9uvwgPv2dGqTI2I7HQSNoCuTKmn bJt6QEmSat34PZmwhfU0+DemLcPkK5f3/bChbh4SrmvWmNnA8RiqxeWTZZPgRn0u1tj8 iJrw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=sS+TvoSOuPqmkXStl33CK+HNzzAQm9hMUrpDzdh/+XA=; fh=UGT8vsaA2/QHtQCP+9kZVKlmZ91mVbhSrTS7W6ZxnCg=; b=DwnE78I67VLp/SCZmQxC9YZo9IdfUkU/LdBqUEZ2nYfnrGPP52Hj8riTkPI5FAiFCy pgLHmrucNxtVhOc20WMZUf9akXS+cs29TP3FCxM/2bgOyGt7+bzFscJymQOx42VzU0QY ymtLrwCmprITfWMXc9gAoeKkLsaJiHRQPkEw3c7bOZTs5I/vv2xCDHtTAeQsIaLpwmDX wqP/BS8cZNnBwBySo9IBa2Fh1C62Z8SPS7QSe4aEPdTtOOZ9NRI5S4uKAcXQSVTCaa8Z MnritHQm211pR/+Xfcn/dNXPcucmspnNMIKZXNYh4dFl3ax+RROuCxiLGJd9x6ysmY4U vPoQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=pXpNkf1q; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1719915984; x=1720520784; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=sS+TvoSOuPqmkXStl33CK+HNzzAQm9hMUrpDzdh/+XA=; b=KRIXml/+AVDCBTB00KhzyE5jkCtzYojaw1Py/4ezHOzlGC84eAqogCMk82X7QWPWp6 yyVCWzPupRlAmYws4zhk1SyI3unToE2G4a4Ur+wzcpgGUMilHUXpMZabwzZrmOEErCIS k7bQB9saRnWFxiMLojw6A+fQrAwyt/2R5ge7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719915984; x=1720520784; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sS+TvoSOuPqmkXStl33CK+HNzzAQm9hMUrpDzdh/+XA=; b=qRC6maHWI72kBMXoRO4m3zzDfsFJNdBWLsiIQK+GGgUn7UoSA0QawvW0ubLZ0v29pH XlNrAetVdWjwhgJ9cbLRuhFBZsewjeAY0Xzah/QvP1mbUvoguss9iExSKilcmw2w3aus PR+ko7c61VP28Qsy8Sdbr1wPyqHpoOIXNFFr4vlm2KMfLyyzRSyQytrI8M1E9/csKTTr gaq5E82SmNoHY4e6rqGzQPVvSMQL7BmExOVTkjRO15EzLsCcUQQ9IUT2g5Ga4+s7XRbC Jhx8EuKB1CHQlWqBqxcFewetuqGX1O2nZoXaFgSX6jzaOUHoCL/0Gmf5bURfZ2pGD9B0 /8SQ== X-Forwarded-Encrypted: i=2; AJvYcCWA/SI48Q7bnwNNr4T/5CnAmnmpFFckX3etA/Fznn9K3vzRyPr++y1TVzAIq7CXhgZZU6Jjr7Q2QLkd0jVaMJxOMYlOcKRQI3ZzTzeu7UGnsgLL5LINX4p7BZDGJw== X-Gm-Message-State: AOJu0Ywbx9YwXnyPC/vgrfDae9hW5d350dJTyQPXRMArZPXkq0delIWg CZy7tIc2MGeCg/tq+Ojyn4k6G5dAH0s3+jcECLNZtueixoi8BNnD1PQywduIUwS41A== X-Google-Smtp-Source: AGHT+IGA2ciMxq+JtXQdDiDdVlIXTY78LnmJKMXw3oafBMSMtjt7G3+gS6blOfJcOFz9mUMy7eY8FQ== X-Received: by 2002:a05:6402:3585:b0:57c:610a:6e7f with SMTP id 4fb4d7f45d1cf-5879f0cd78emr6507593a12.11.1719915984046; Tue, 02 Jul 2024 03:26:24 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:95c:b0:58b:fffc:bc33 with SMTP id 4fb4d7f45d1cf-58bfffcbd4bls145433a12.1.-pod-prod-04-eu; Tue, 02 Jul 2024 03:26:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX7ZC3P8ExL22J1PnqJW3gQwkLcKXr8AIga8AHDdsEjp7pUNcVj5Dkv/rnrs3jt4CYLSVwoXzvorX8HEAoOiFJZh2DXs/ECzYxLd2apKqArPHyJ X-Received: by 2002:a17:906:178f:b0:a72:7fea:5800 with SMTP id a640c23a62f3a-a75144b785dmr479559066b.63.1719915982207; Tue, 02 Jul 2024 03:26:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1719915982; cv=none; d=google.com; s=arc-20160816; b=tUN2uuKDEVE0U9vujUTR76h2IwmKmI13KtqwUmGc+szKpiHdBurQxyLXUNWufylCm7 ox7VwgTSrqX/KAp0WrzOIU+8vG8lNxJjqRBZu5uqSTGJoeFJAsyBYIqFTZ0581OSxeBC BpuP0323O9uJFfAR45mhSHC93mwBD4TzelA3EKM8Hzqre4NbabVbRZ7JETFrTt3lOGKB BE2Li0DM7b9FT1aEnX+L4kL1V9kjeP/4EAosOqmPRpWq4ji/WxudMOaPJfNPdP03PKNT aVnVW02TKsnsr1gpMQXNOB7JKewcsrB3s2x659U4D187Z/pa73IouONaH1Q5jXwjTI56 XbkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=5cqSYj+CjsXbHNn2F7LbkjKwjHh71ZZUgZg1g4T2Q38=; fh=/GFrJH5Hq0zit29GN0rES6sioNhQh+0aYXF+ZiuDolY=; b=XgPboKP2bGcXAolnQOHtGpj+R/BAVO4lXZ9nBnkHOdEXmNeUjGhfI7t06CWdixhVR2 suEcLb25fvRzG945aRKIfq9TvguC4wdp0zOLs5xKO0uByPpg/xPNaCwVTz8ghxLi0VCx uh+rezEXFkx/I0TjenNaDRME1p+Bj2XygpViMXY8x/WWwdiTIwRFncEoufGKg7c/j8Se cyVYGhZf0hPyCPdSKbMxvWfK17qDkEZIC5zBR4URLMLErCAsq+sjt9yG/gm+DvjTYNnM +C///4oFZg6c9QDPoEPgUKJwM/rFG4jFDDg+L7byk/5flX3b0ChuihFW7kqIQTePsORi Bisg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=pXpNkf1q; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-a729d6dfa4asor292760766b.0.2024.07.02.03.26.22 for (Google Transport Security); Tue, 02 Jul 2024 03:26:22 -0700 (PDT) Received-SPF: pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCUSlIEL43MJ73Zqy9a9pCB5oCgeR51PSeooAdDc4SMrMy3Jj/Ms9N4tmGWvqQyt0apiEk0s2BiC61FkepCkj2wz03yy5zZn/v31bB2TjkXsxSTh X-Received: by 2002:a17:906:1b10:b0:a72:8f73:a95a with SMTP id a640c23a62f3a-a75144b8824mr471498266b.65.1719915981680; Tue, 02 Jul 2024 03:26:21 -0700 (PDT) Received: from panicking.. ([2001:b07:6474:ebbf:8e6e:944f:275e:2a97]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ae84b3d8sm391253066b.121.2024.07.02.03.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 03:26:21 -0700 (PDT) From: Michael Trimarchi To: Lukasz Majewski , Sean Anderson Cc: Tom Rini , linux-amarula@amarulasolutions.com, u-boot@lists.denx.de, Dario Binacchi , Michael Trimarchi Subject: [PATCH 1/2] clk: imx: Fix wrong flags assignment clk-composite-8m Date: Tue, 2 Jul 2024 12:26:17 +0200 Message-ID: <20240702102618.466652-1-michael@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Original-Sender: michael@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=pXpNkf1q; spf=pass (google.com: domain of michael@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=michael@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The mux flags (u8), div flags (u8), and gate flags (u8) are not the clk flags (unsigned long). They have different meanings Signed-off-by: Michael Trimarchi --- drivers/clk/imx/clk-composite-8m.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-composite-8m.c index 494156751da..560d74aac80 100644 --- a/drivers/clk/imx/clk-composite-8m.c +++ b/drivers/clk/imx/clk-composite-8m.c @@ -135,7 +135,6 @@ struct clk *imx8m_clk_composite_flags(const char *name, mux->shift = PCG_PCS_SHIFT; mux->mask = PCG_PCS_MASK; mux->num_parents = num_parents; - mux->flags = flags; mux->parent_names = parent_names; div = kzalloc(sizeof(*div), GFP_KERNEL); @@ -145,7 +144,7 @@ struct clk *imx8m_clk_composite_flags(const char *name, div->reg = reg; div->shift = PCG_PREDIV_SHIFT; div->width = PCG_PREDIV_WIDTH; - div->flags = CLK_DIVIDER_ROUND_CLOSEST | flags; + div->flags = CLK_DIVIDER_ROUND_CLOSEST; gate = kzalloc(sizeof(*gate), GFP_KERNEL); if (!gate) @@ -153,7 +152,6 @@ struct clk *imx8m_clk_composite_flags(const char *name, gate->reg = reg; gate->bit_idx = PCG_CGC_SHIFT; - gate->flags = flags; clk = clk_register_composite(NULL, name, parent_names, num_parents,