From patchwork Sat Aug 24 10:36:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 3334 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 64A9340D72 for ; Sat, 24 Aug 2024 12:36:44 +0200 (CEST) Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2f3fc9d8c00sf27917031fa.3 for ; Sat, 24 Aug 2024 03:36:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1724495803; cv=pass; d=google.com; s=arc-20240605; b=lr66Xj+UIy93DDmygelE2BXdG0oQaxUiEEnm2RaeSr1o17Pu67Pnr4Tjv47aTXwD9f tIrxxe+9QXC3285C+fouVTYVxal27zmNjPcRMbYUeF7It2tUdPk/uUQaeU287m7qPlSC yKqzFIS1j09SElQxytnFw9Kq32d6jIffts+EVtoQV+IMo5jKa3d/bBoPjPuyoOQaia6s 5zvJgNlpRBiVlAkaX8eE2GvPaFGE9F+oZckJBHJC+Q956rOGXwp5xsa5wUThi1nciGqT KJo5v155+cKAPs6MSsDdrA894NI8I2tZDmYxoz0E15F3sASQfd2j8m3Ef6jIuQkxp7F8 XdxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=ojZMDDNPBtzPLJou13KtBb0RqEeRH4W9pxxPLmWE1QY=; fh=LpN7bodEI0hJDg3rV1pjZ20yB3tKzbB/yyfx/Kpm5Ww=; b=axWRVBcvWlINR5YBT2uccgptacNdJ57sP4gW78YG+8Out54dKG9yiCpriSrul3fEg8 jARPayeOA744/H4osrDvD8E+37gW4BsaHROVjgK0sbb2SwnmEEYOUyTK+rASjy15anrF a5oq5sa59wU4be4KCtacYAS4Zdfy4q7u4p2ImJgxg+O8YfdVXksi8gJ2dLKIPAKV9RZB 25j/09MoI1+q+g35eolI/bWdNawngomPW1StTVZzJcKBIYW3aWAgIBdZDaD2raOioEzj 5iCBJp7q+2yR3ITHFOt0yBk3sM+nLxWroFiTYlkWyKqkiJjS9/p10C77ZIGX1NHvzOP8 gI2g==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KgsInBsD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1724495803; x=1725100603; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=ojZMDDNPBtzPLJou13KtBb0RqEeRH4W9pxxPLmWE1QY=; b=OGtOz82cuD9/tFVh6qOU2E7OVh1o9juhIGLxJvhjmZ2YgQnIXHLwreKHiP6K2DBQcb p2FPlcWUt2jzKxWTI2CvN5jCejkm5yP08LTKhuQsFHdx75ibUQ0xVDQpfy/JQWWZ6gSC Ro9vyQJru1E5dbXgONcOF3JHlo2dGRSMAUPmg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724495803; x=1725100603; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ojZMDDNPBtzPLJou13KtBb0RqEeRH4W9pxxPLmWE1QY=; b=h39fX1TW87dkc3sx37GaIFj++NWjG682GE3Fbhm1YtVhwoxC1wRiqzMJ08o9mQNwSX CMeOm9SgTxHAhqT38GuMldzIk4BqKNYC1ixAMAR0xuQQ+fxepkXDG5lZN7z56ZmjSmpA +FJAUX/nWsJjJLVy/ZkUDI25PyLg5JhtEpKLbvvvT37y1+Z79+TMSx+wPOauKeiNvRFo GBv4dd5e/mvpzyVhlN88HWYKCJLC282OihKsXGZAt1dS5B8h7HCWNr4O3BuKPs8k0f0X HuW7BZSxUasxVijk18ySFnuec9zNC5/W4C77a/+AYTTE1FseAiunWs2WiwkIaGkkUaP5 hsDg== X-Forwarded-Encrypted: i=2; AJvYcCX8szwKQG1c3VfPdN93c+oMyyX0Om4w1Uxqa4mFnV+R7xHI5+LeqbgzhkTydTwgmuVeUUPKS/1C76P0mzP+@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YyOH81FY8TZ0DF9M82+WENiaWh3Ik1YK5SjLbfpKONBgLEOY054 hgsTuEDbneFmfCXIFeNiQ1Xh6hrY6Qcc/LupiyPoFPmfds7BlZh82kGGIceHTFPk3Q== X-Google-Smtp-Source: AGHT+IHqwulhRkoKNgTGwLuxlWvNtHzVOTW4GJzm2SuIk5bzSC8tTewxo69TwhS0LW1rU4HFm5e/Cw== X-Received: by 2002:a05:6512:3188:b0:52e:7656:a0f4 with SMTP id 2adb3069b0e04-534387bb456mr3809702e87.41.1724495803328; Sat, 24 Aug 2024 03:36:43 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6512:b84:b0:533:4879:b9cb with SMTP id 2adb3069b0e04-5334e12251dls143205e87.2.-pod-prod-02-eu; Sat, 24 Aug 2024 03:36:42 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVfjZtcMVOqh9s65iTSEGzKuFAAniG04w817od3UXKYFmiPXxRMZYgLnATdf6aE/rvzzL54ti7RlZ2nx66/@amarulasolutions.com X-Received: by 2002:a05:6512:220f:b0:530:e323:b1db with SMTP id 2adb3069b0e04-534387be990mr3175607e87.59.1724495801502; Sat, 24 Aug 2024 03:36:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1724495801; cv=none; d=google.com; s=arc-20160816; b=wQ6cF+FoBUto2rW18VBOJtGDxyiwtmLA1vFloW7cZfY4jDl6HFyHGYQQIW7e33cSnX 8NXY50JyQTi183ItStoDEk4kc0YInD8GPXBlIF0QPe2BoH3t8GLu+pNDtwi6v5Qcy8FY F8KHWLwJdDRyHyyqhf3v4WQ4enQRBvUlG+jQOyBNoNNLVy//pxD+Pof3RjyMniwFxVs5 lG4ubPhZ5QEGJqVCAtLNvWJjsaNHkxoeocw2f4DqXDc+56+z2PcBvYoQe+JaCdC2qSOY nVvCGuQGhaXwTvwsj52HDx4crCmu+yhpxMc4lyEHlFXh6Hgqmabq7B+hVeSx6NbIIqay hGNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=SWNRg6t+eLXu/bemjcsoAj7cKLvdNka83lM2gp1Ry20=; fh=Q2FuAKgOQogmp/wmE0sSHGTFWmI8JGqlHwM3u1PIjSs=; b=uIb62oruuIch1mkwaFjDx3hRytG2XqLcljDmpNYsFqWNnLzUO8MWETurPTkYxeAdfw 2GzjpvLaFM25EdLJpxQgosm5nzAj/JJBL5jQi0l9y1+898W8+xEbL9BIhIjJuelNLvff 19GFXfPmiRzs3sUfpjxwdP0mrlvfkIrR3sfSYe+GSoih2WNIPWTLDErhgfuYg+R2BB2S v26/LYGlQQMtQhSDtDPaTKtuNj0QddWOj4CMyU6mW2LdMaHqGmD3vrJR1DsduGCw5jIz bvJ8lVmb2e+zfz44zNdWrtK55R90HOXQjWVopnWn/EK60gVkXfILYC+vUXd1SCTcMhsC BJEw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KgsInBsD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-a868f2a1ef7sor190288666b.6.2024.08.24.03.36.41 for (Google Transport Security); Sat, 24 Aug 2024 03:36:41 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCXbpUJWBJd5Y4UJdFT320S3kZ4EEX+afw1NP3qh2+uZBRM1E2/HEjt69HBdpFIvnBb/smbfNSfrFBkM/KS/@amarulasolutions.com X-Received: by 2002:a17:907:e269:b0:a86:6858:8a8f with SMTP id a640c23a62f3a-a86a519cb57mr380520066b.26.1724495800987; Sat, 24 Aug 2024 03:36:40 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-25-99-149.retail.telecomitalia.it. [79.25.99.149]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f4378e4sm381883866b.109.2024.08.24.03.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Aug 2024 03:36:40 -0700 (PDT) From: Dario Binacchi To: buildroot@buildroot.org Cc: "Yann E . MORIN" , linux-amarula@amarulasolutions.com, Dario Binacchi Subject: [PATCH RFC 1/2] package/pkg-download: set BR_NO_CHECK_HASH_FOR properly Date: Sat, 24 Aug 2024 12:36:33 +0200 Message-ID: <20240824103634.1955431-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KgsInBsD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The hash check failure highlighted by test [1] reveals that BR_NO_CHECK_HASH_FOR in package/pkg-download.mk is not correctly set when the BR2_DOWNLOAD_FORCE_CHECK_HASHES option is enabled. The test output shows that an attempt is made to perform a hash check on the enterprise-numbers.txt file even though the ipmitool package has excluded it from such verification: ... IPMITOOL_EXTRA_DOWNLOADS += $(IPMITOOL_PEN_REG_URI) BR_NO_CHECK_HASH_FOR += $(notdir $(IPMITOOL_PEN_REG_URI)) ... The setting of BR_NO_CHECK_HASH_FOR used by support/download/dl-wrapper cannot be overridden by BR2_DOWNLOAD_FORCE_CHECK_HASHES because it represents an exception that is required even when forcing hash checks on all packages. Applying this patch shows that in the specific test, the hash check is performed for ipmitool-1_8_19.tar.gz but not for enterprise-numbers.txt [1] http://autobuild.buildroot.org/results/5ae5ee948d99679cd50d1115a7d46f4368347b4f Signed-off-by: Dario Binacchi --- package/pkg-download.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-download.mk b/package/pkg-download.mk index ca01ff67a59e..a41bd9d4c0ad 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -118,7 +118,7 @@ define DOWNLOAD $(Q)$(DOWNLOAD_SET_UMASK) $(EXTRA_ENV) \ $($(PKG)_DL_ENV) \ TAR="$(TAR)" \ - BR_NO_CHECK_HASH_FOR="$(if $(BR2_DOWNLOAD_FORCE_CHECK_HASHES),,$(BR_NO_CHECK_HASH_FOR))" \ + BR_NO_CHECK_HASH_FOR="$(BR_NO_CHECK_HASH_FOR)" \ flock $($(PKG)_DL_DIR)/.lock $(DL_WRAPPER) \ -c '$($(PKG)_DL_VERSION)' \ -d '$($(PKG)_DL_DIR)' \