[1/8] Kconfig: Update CONFIG_BROKEN help text

Message ID 20190428204801.9578-2-jagan@amarulasolutions.com
State New
Headers show
Series
  • [1/8] Kconfig: Update CONFIG_BROKEN help text
Related show

Commit Message

Jagan Teki April 28, 2019, 8:47 p.m. UTC
Add bool text to describe what configurations is this for.

Update help text to describe the example use-case configs
which comes under CONFIG_BROKEN, they are
- legacy driver that would need dm conversion.
- legacy driver that doesn't have proper update since
  from the releases.

Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 Kconfig | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Heinrich Schuchardt April 29, 2019, 5:56 a.m. UTC | #1
On 4/28/19 10:47 PM, Jagan Teki wrote:
> Add bool text to describe what configurations is this for.
>
> Update help text to describe the example use-case configs
> which comes under CONFIG_BROKEN, they are
> - legacy driver that would need dm conversion.
> - legacy driver that doesn't have proper update since
>    from the releases.
>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>   Kconfig | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Kconfig b/Kconfig
> index 7a5491bd67..eb3c2d04d3 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -15,11 +15,16 @@ source "arch/Kconfig"
>   menu "General setup"
>
>   config BROKEN
> -	bool
> +	bool "Broken configuration"
>   	help
>   	  This option cannot be enabled. It is used as dependency
>   	  for broken and incomplete features.
>
> +	  These broken configurations may comes under,

Thanks for adding clarification. I suggest to rewrite it as:

This dependency is assigned to

- legacy drivers requiring driver model conversion
- legacy drivers lacking maintenance

Best regards

Heinrich

> +	  - legacy driver that would need dm conversion.
> +	  - legacy driver that doesn't have proper update since
> +	    from the releases.
> +
>   config LOCALVERSION
>   	string "Local version - append to U-Boot release"
>   	help
>

Patch

diff --git a/Kconfig b/Kconfig
index 7a5491bd67..eb3c2d04d3 100644
--- a/Kconfig
+++ b/Kconfig
@@ -15,11 +15,16 @@  source "arch/Kconfig"
 menu "General setup"
 
 config BROKEN
-	bool
+	bool "Broken configuration"
 	help
 	  This option cannot be enabled. It is used as dependency
 	  for broken and incomplete features.
 
+	  These broken configurations may comes under,
+	  - legacy driver that would need dm conversion.
+	  - legacy driver that doesn't have proper update since
+	    from the releases.
+
 config LOCALVERSION
 	string "Local version - append to U-Boot release"
 	help