From patchwork Mon Sep 23 05:46:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 3517 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 2F6253F1CD for ; Mon, 23 Sep 2024 07:46:38 +0200 (CEST) Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5c3c398b511sf3444607a12.2 for ; Sun, 22 Sep 2024 22:46:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1727070398; cv=pass; d=google.com; s=arc-20240605; b=WD7hkmOx3d2Kg93bRs/mrPtW6rifh8gcSnOng/9n4bk49wDUpktxzJbRxtoMUlcgVD nMrSponXQLJjkg8TJQe3QXaPZIO/OM90CIRbcL3cnGAplrBv359elKbqWDCySQSJcPFl S995KOjr39cYoqncODLSycTVrXUjOWy2v1sLEd5NWeuLHLDJBewyH6CDAID4TXhT1FZ7 xNLRB0Auigm58QAoIH+lUv+4O9JWuvzMP3GvMh0iO1rhWgaZw62w7Cx9TG+YJ2+QopUH SrkswPmd6KQ7XP7Yfgd+NBHOViIQ9NKQLjG7QRFeDRT/6qUjRGB8Iwe261gx0x2Z1EwC NvSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=bAgW3tT4SWQmXstF5N4q2rb38LPWYAqRAMc2AYGZPP4=; fh=j9vzDPrOnbtrQpX1pBdXyaktXmlUF44kNdXCp5x1Kuo=; b=HYNmUiRbmdT/Xysl0XOthlCsdg/FZ3d0PvlTGDLb9p04X4g5/ns/MkWn3wb5vZucwS n/uaeITcjpQrmHJRY9KQ79oRjKzn8FJ+puYk6ZyY4orH+wZO2FphiHHYAZSzyV9R2d4c O7TcgZWMql2nv24UpVArd5ndLLLIAzM5kekQ4ou2KLI4nRhz4uROrUUZF8DpOtem+VTq 936NFc+XYkysvnZ159UQcjknUh+GDEOEQQyisrlG3Hr/QgD/50VxTTvSY8EtYaoeOpLc pT2+5VUN4HxmthqoGxoAm+0cOtLlEDVxvCcJ/VkiI+y3YybwV2NeS//uCagYzdf6I5KZ c1dg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="b9UT/9Ua"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1727070398; x=1727675198; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=bAgW3tT4SWQmXstF5N4q2rb38LPWYAqRAMc2AYGZPP4=; b=ApA33iYr89Qibn4QDqMQtyMkAoHWNKCeOmuoboDz0I6SYE1zDVQwHALR6Jz9T7Cluh 2hQ7E+8dR8BX4QchfD19RJJt0Uy7H3/f4/4iv4MPrebXqFzIu53iKmiGUfwzCW+Q0TZ7 WiBHBkpZ24VslXl4uDCaeP/qFIgcTgIwRXya8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727070398; x=1727675198; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bAgW3tT4SWQmXstF5N4q2rb38LPWYAqRAMc2AYGZPP4=; b=KPYhkVV6IM0t2aep831qrcCyM4X2ocVpCiTsU/thyODxe7QBhbaGPEw1rILdwPld4P sxZqlSMkFaNgpKXrJgkjYXz79DmqErzAX7SOsITU9qPNfCJJDXpDjCnepfC3wFVqrvTD aNLcfrssPcpV+SQox+Wvtn5SLgS7t9qs6DgoMFS0OkJ/cqIPJNx6kuGQrNTf8H26L3hL x9O+oEWc6oIGSAwiYtNF+EP7jv+A4TT8vTJ2nqMjfJDWsI8Krm59YeBh5p2JO+s07rml WJ3XFpfS1h0PVfoIa5GKhUn5+cJQQ13CEmAZSlFV/k3jn+/T2KkLtbqIRyfdJsQ5uRyQ n3IA== X-Forwarded-Encrypted: i=2; AJvYcCWOB/LJsBMVzgHbqvyMPV++DSs97K+7ibytrLVctpwKNAkKEhz9M4DG+aQgOR5+dS/zoOPLnksblHrcvpVh@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yxkt2vej9WcJOldM/iQjDi9/QOLvisuzPqMG0uNYn8+gPPyw8vB ZsNc4SQI8FCu5+B7iRUIItM/695Pah2OO7U4hbDrdXvs8Ok8iy2GqTbfywhDpvARZQ== X-Google-Smtp-Source: AGHT+IFMpe2S6AXs49ZCdL4bGyK+uUwB87wKTsg5DpNIya9KXZ0u3Aub9dX6UAVCAdrjfHLzZ2j5Hw== X-Received: by 2002:a05:6402:321b:b0:5c4:6568:735f with SMTP id 4fb4d7f45d1cf-5c4656873b0mr11634173a12.25.1727070397603; Sun, 22 Sep 2024 22:46:37 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a50:eb05:0:b0:5c4:651d:a54c with SMTP id 4fb4d7f45d1cf-5c4651da6bals1475877a12.0.-pod-prod-08-eu; Sun, 22 Sep 2024 22:46:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWclM/9kvFXIxHqRovAzqJI835Yu+87i1/5wcKgcwpvi5JpPhT8ZLW0Vbs/px6hVkTcKJBtEqXRq8pq0d/x@amarulasolutions.com X-Received: by 2002:a17:907:e660:b0:a8a:66b6:58d with SMTP id a640c23a62f3a-a90d5804884mr1246830666b.41.1727070395963; Sun, 22 Sep 2024 22:46:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727070395; cv=none; d=google.com; s=arc-20160816; b=pR6Sfup2PEj6v+eZs5hJ23Olpi8X/Gm27t/w9CiAFfjzYVdSeuF+DLBpudM+Sm6hxi +ANDI6EMfGlVjEZh+dWONihOXlSniHzmUX/XNXA/fC0eIA+/jddYGO0tog3yF1ufwnF0 XzsYl3bpdHBMI1y0b52FtyylQWDfLoh88n0ONDUNeHz4bZ8aOJddnAq175DN1TKrJ/Qk rUsRX5BMwpBlkbeXqvQ/5QIsV/WPTkJOHL1FckJXh1CpSnBkAv1reotESeB3L+GXooc5 glG5ncdVeRJWDNuVigvx0PSIWvdb2I7f8EBuG99afOsQEMyVhCR3CgxxY5L6MFv3ESKm bVow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=uC0NinD4RAR+J93t1HtcJ+2f1Uv5sU6KbDnUAU/qnrE=; fh=AzUqeoeccaZGGzlgR7TWaAWQxzjqeFVjS2RQUob61KU=; b=qPBWY45XgSgWem0XfTkKi+2VPFrnlwWczYQ81ST9+y3IqZuGp3NZKC2yiV/XOMZW20 hXmvqW3yKBVYprTFYbVADXxe2TSdfkJ9sqc/MhkhAwa88Jb0p/KOQWoGL2P/bnrbTy8o cizfbibhLKeqHrOZycquW09inWGoWYsMQakbTJ359vppgWwCDvhpc/SBLHI7WuZdGUwt NxuXdwWdsw7cgfh6R1Mgm+FCNF2AIpxcAxUeoLztw03P0jhqdb+Y2J+/lKLYip0il4Mh t2t2l8fYsvbO4+7RtjRlBjE/5Pk6tWbj4PdYu7EBOb8dBeTqPBchEjm6Jc33JfhRh5c1 LZPQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="b9UT/9Ua"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-a9060f40088sor753025866b.0.2024.09.22.22.46.35 for (Google Transport Security); Sun, 22 Sep 2024 22:46:35 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCVGWkHR6b7u0HVbaCKLWnIje3ipmCTKg61yde4ABPyT+kRt8dXkQo5VX0caBUBflwMvQcfNCVgmOQkYt1yJ@amarulasolutions.com X-Received: by 2002:a17:906:d247:b0:a86:ab84:7fc1 with SMTP id a640c23a62f3a-a90d580486cmr1036885466b.50.1727070395521; Sun, 22 Sep 2024 22:46:35 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-20-102-52.retail.telecomitalia.it. [79.20.102.52]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90612b39a2sm1157706566b.106.2024.09.22.22.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Sep 2024 22:46:34 -0700 (PDT) From: Dario Binacchi To: buildroot@buildroot.org Cc: Petr Vorel , linux-amarula@amarulasolutions.com, Baruch Siach , Dario Binacchi Subject: [PATCH v3 1/2] package/iproute2: fix building error using designated initializers Date: Mon, 23 Sep 2024 07:46:25 +0200 Message-ID: <20240923054626.2911036-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="b9UT/9Ua"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch fixes the following error: arpd.c:442:17: error: initialization of 'int' from 'void *' makes integer from pointer without a cast [-Wint-conversion] 442 | NULL, 0, The analysis of socket.h [1] containing the msghdr structure shows that it has been modified with the addition of padding fields, which cause the compilation error: struct msghdr { void *msg_name; socklen_t msg_namelen; struct iovec *msg_iov; #if __LONG_MAX > 0x7fffffff && __BYTE_ORDER == __BIG_ENDIAN int __pad1; #endif int msg_iovlen; #if __LONG_MAX > 0x7fffffff && __BYTE_ORDER == __LITTLE_ENDIAN int __pad1; #endif void *msg_control; #if __LONG_MAX > 0x7fffffff && __BYTE_ORDER == __BIG_ENDIAN int __pad2; #endif socklen_t msg_controllen; #if __LONG_MAX > 0x7fffffff && __BYTE_ORDER == __LITTLE_ENDIAN int __pad2; #endif int msg_flags; }; The use of designated initializers allows the issue to be fixed. [1] iproute2/host/mips64-buildroot-linux-musl/sysroot/usr/include/sys/socket.h Fixes: - http://autobuild.buildroot.org/results/e4cdfa38ae9578992f1c0ff5c4edae3cc0836e3c Signed-off-by: Dario Binacchi --- No changes since v1 ...ted-initializers-for-msghdr-structur.patch | 70 +++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 package/iproute2/0003-arpd-use-designated-initializers-for-msghdr-structur.patch diff --git a/package/iproute2/0003-arpd-use-designated-initializers-for-msghdr-structur.patch b/package/iproute2/0003-arpd-use-designated-initializers-for-msghdr-structur.patch new file mode 100644 index 000000000000..f8b9f7d08877 --- /dev/null +++ b/package/iproute2/0003-arpd-use-designated-initializers-for-msghdr-structur.patch @@ -0,0 +1,70 @@ +From 13cea6bb5e4f08f534fa4b04b5fc4ea0c8a2467b Mon Sep 17 00:00:00 2001 +From: Dario Binacchi +Date: Wed, 18 Sep 2024 14:22:34 +0200 +Subject: [PATCH] arpd: use designated initializers for msghdr structure + +This patch fixes the following error: + +arpd.c:442:17: error: initialization of 'int' from 'void *' makes integer from pointer without a cast [-Wint-conversion] + 442 | NULL, 0, + +raised by Buildroot autobuilder [1]. + +In the case in question, the analysis of socket.h [2] containing the +msghdr structure shows that it has been modified with the addition of +padding fields, which cause the compilation error. The use of designated +initializers allows the issue to be fixed. + +struct msghdr { + void *msg_name; + socklen_t msg_namelen; + struct iovec *msg_iov; +#if __LONG_MAX > 0x7fffffff && __BYTE_ORDER == __BIG_ENDIAN + int __pad1; +#endif + int msg_iovlen; +#if __LONG_MAX > 0x7fffffff && __BYTE_ORDER == __LITTLE_ENDIAN + int __pad1; +#endif + void *msg_control; +#if __LONG_MAX > 0x7fffffff && __BYTE_ORDER == __BIG_ENDIAN + int __pad2; +#endif + socklen_t msg_controllen; +#if __LONG_MAX > 0x7fffffff && __BYTE_ORDER == __LITTLE_ENDIAN + int __pad2; +#endif + int msg_flags; +}; + +[1] http://autobuild.buildroot.org/results/e4cdfa38ae9578992f1c0ff5c4edae3cc0836e3c/ +[2] iproute2/host/mips64-buildroot-linux-musl/sysroot/usr/include/sys/socket.h + +Signed-off-by: Dario Binacchi +Upstream: https://lore.kernel.org/netdev/20240919132454.7394-1-dario.binacchi@amarulasolutions.com/T/#mac98a56b7ce0235a6e2b97afe8aa8565de4c926d +--- + misc/arpd.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/misc/arpd.c b/misc/arpd.c +index e77ef53928a2..b4935c23eebb 100644 +--- a/misc/arpd.c ++++ b/misc/arpd.c +@@ -437,10 +437,10 @@ static void get_kern_msg(void) + struct iovec iov; + char buf[8192]; + struct msghdr msg = { +- (void *)&nladdr, sizeof(nladdr), +- &iov, 1, +- NULL, 0, +- 0 ++ .msg_name = &nladdr, .msg_namelen = sizeof(nladdr), ++ .msg_iov = &iov, .msg_iovlen = 1, ++ .msg_control = (void *)NULL, .msg_controllen = 0, ++ .msg_flags = 0 + }; + + iov.iov_base = buf; +-- +2.43.0 +