From patchwork Mon Oct 28 10:25:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 3597 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 51EDD3F338 for ; Mon, 28 Oct 2024 11:26:22 +0100 (CET) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5c94ccfb210sf3049848a12.1 for ; Mon, 28 Oct 2024 03:26:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1730111182; cv=pass; d=google.com; s=arc-20240605; b=SrRL5Yyz8aAdOEfBMNuA3AuRnjOtsghe1BSTBLO0XKFGCFD7c00y3PfI0SduEpsroG TG52Be4Gs9YicrULpgP93fQwsPDgRpeC4rOnMv6/dMidlHW8z4lRD2sb6S4sf1z8N30B Z+RWNvluA7EFshGVWojJpDgyPakKMPpEcyeo3fCA+zSElQn3Ys5aaieFZPKNjZi+ihjt NaH/aV3DagfTsrJCD9E+L1ljzVa3skPM1wofK4Ny4Ak30asfwhsw1sYEr1JCrpcsQz8u yEIqlvK5syIFFPObgj9YSu4XDHiH1d9+TWa2OpbEvxIqEx8l9qc44ubxPNCEuim0v4te uyIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=zOD+XKFa4so8bYEryC/DA2N3C2Mf46G32G+KOwOZBtU=; fh=/ndRdYFUnv0rvbq+fJVvwVvQLocVC5/So0Sxmd4hxwM=; b=BnP7MXhG+2AkNe+gfxdfs9AnnTAQEyzRfJvC5AGK1L+RgL/ysw2YNm7sHm3kgT6yVp 9p4wo5njaH3a+0SyfYNbJaAwPNN+wHEGPgpxoClpD6foYoFuClhi3m6E2RqxRIy1u3wv Zdjioz042b+FMAAh8FkZqpJ1TGZPDNS5Gxf1sXRTw82tjlAJjVB8ONGwReNy3H/6itJH h6UKuW+l/l2/+j7+R/5tY1tf4QPqDwbwwuAgJipDeCdlKC+xQPMCZqgoO5/l84WzbiX/ cTc/KbItGhhp2gyJFrz3Bo26FZA0LCl4+H1dRh0RIXjurZh/J3Y69IPkMnMIEj6CbFxs YfPg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Fm5tVav8; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1730111182; x=1730715982; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zOD+XKFa4so8bYEryC/DA2N3C2Mf46G32G+KOwOZBtU=; b=ZCawvVwfk3CCS6ypSjkQ3PbbZYeojt4VmTLussoEyDXW0TK/RPTfsFl+29O4GFpHrl HqP2kx1uhQsN8Jc6QTM1vw5JO7aEr6zJ1mWpW7RoUaMYp78CWuT3jqorVBRtCqkkvKFK yAuyyEB7X1Le4jFgfjy79CF1Mc2i/k2vn/coM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730111182; x=1730715982; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zOD+XKFa4so8bYEryC/DA2N3C2Mf46G32G+KOwOZBtU=; b=CGVNG157HJJuQFyZoyqLgwtLP6b3SXFaw7ACiynatBqtDm1c913To9YsnU9Z2pf3Um PstfYPl+2fzKWGhJM25/SYzfS+bGC0amO1BQ9dn/0bvsZubu9Exq8YLY2NQY43c/6pGW L6vr0VcFhZJWKeYb1yF/BEVM7qq1X6vbp/UYmQaHwSssQUraRzJHPwmHPY1ki5t6O37k 7Eg2B2If3wbFA2dmpD3RgdbUw+r++mraUE6dCQ4nba4ciBeGlGzbWGlEfGk/IOnV1zf+ kFSFhsPFEo+thHKGvDS3DYYk2iMX3GYViVZmzD9devZNzao1XEnlv6tOavm2pIAI9ibP +qDQ== X-Forwarded-Encrypted: i=2; AJvYcCUgsyzYA/XuzQxDVt15ebY76Mw0lmy1eLCM2EEvDZqDqrObI5kK6H5auhHXVKFkxckKLaP9czenWT9p+IEW@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yzl36B1MbhEcnAUQxU4Xjb1XJ1SiyUsrLDKuZqysdoTK8WNnvpY K+YaR48sEiOM/2DkSXxk9RtTOly4bMLCetBBaCY9o0w7BKKzSGjOmKqkR/Fwd6o1/g== X-Google-Smtp-Source: AGHT+IHqZIDxBK+0+w0ShGGGUNSH9YaL1lHtdpUQMfpvW6/dh9qWzw1KxJHJC31nck6hWCJUOTjj3w== X-Received: by 2002:a05:6402:13c7:b0:5c9:547d:99 with SMTP id 4fb4d7f45d1cf-5cbbf889742mr6667676a12.2.1730111181820; Mon, 28 Oct 2024 03:26:21 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:aa7:de15:0:b0:5cb:b8f6:d067 with SMTP id 4fb4d7f45d1cf-5cbb8f6d68dls64518a12.0.-pod-prod-08-eu; Mon, 28 Oct 2024 03:26:20 -0700 (PDT) X-Received: by 2002:a17:906:6a0e:b0:a9a:7f37:2b62 with SMTP id a640c23a62f3a-a9de6167b7emr838544066b.49.1730111180213; Mon, 28 Oct 2024 03:26:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1730111180; cv=none; d=google.com; s=arc-20240605; b=cmVS/x4u1YBoGf5zPCf4HKFc9+SxYiBbc6vD4pd8z7k08FGiTc3rRocpdjRL/nOQ4c udz9qDlZ3r5GFwc7T06eItbEPie5l4EpmUF/WfoS1VbjIgJ2OQkBqpRV7D2ZKflOYHNX X1KcUDml9FMncyjt+1qdptlpfbeUGVPJr2byATuMPFOYeEgGD2yAiCwiAxg2ABFD7iXk Wlne0nNUAGBmo4ClIwJxxxwvBUqlUPViZUmCCFY2MOunkBRXMah8C8zF3rDp4Nup25Ox cWsmuJ2AVQ6ixYsR4NwVTK/gx1C3K3dRidFxxJzNtIbsngmvDpBmmWjOUBAeOZrIti3F La7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=OXDPpN57LGyZzaHcm0JxAGhhGbbwxVltmDt3enjDY8Q=; fh=rV8VPXjxg+ksLKkkXkMtZg7CUZ5W2QvSbq7RG32ecb8=; b=iWddybGuvDYfKsHnXDlNZr84qsAMVqt6Pjp8k5lCYrREqREPL/CJwkvXzBkbO+WJcA 2GwhqJq9jWPtRJzxmSzTDgPdDruv7nglUiOYLVK5lC1Po9AEXpwCvUH42IqAXtUhTinm rfq+jsYi9irBu+spvwtLt7DVamlMJzrHxrFqy5/8FMTbxgsLPVEGHQ6Kyh3aVIP4Vr6V eat85sKPBuGsIqubSelnN/qlzP5eVLCZUAMS8qimbNdb/5SPrhZ3e5A4igUWsGaD5SXv SMg0bXqWDijIefqbJvhhECq+MiMGbV+aeuw7XjDqRNhxlM6OJ8jZITO659R/j1Z4axJL +jAQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Fm5tVav8; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-a9b1d442cdfsor250549866b.3.2024.10.28.03.26.20 for (Google Transport Security); Mon, 28 Oct 2024 03:26:20 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:907:72c2:b0:a99:f67c:2314 with SMTP id a640c23a62f3a-a9de5ee34d7mr848368866b.35.1730111178897; Mon, 28 Oct 2024 03:26:18 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com ([2.196.41.121]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1f297b04sm363613966b.134.2024.10.28.03.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 03:26:18 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Michael Trimarchi , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [RFC PATCH 06/10] drm/panel: synaptics-r63353: don't re-activate the panel if already setup Date: Mon, 28 Oct 2024 11:25:29 +0100 Message-ID: <20241028102559.1451383-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241028102559.1451383-1-dario.binacchi@amarulasolutions.com> References: <20241028102559.1451383-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Fm5tVav8; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The patch does not re-execute the hardware initialization/activation procedure for the panel if it is already operational. This feature is crucial when supporting the simple framebuffer, as the controller has already been initialized by the bootloader. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- drivers/gpu/drm/panel/panel-synaptics-r63353.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c index 169c629746c7..93e3ed545b34 100644 --- a/drivers/gpu/drm/panel/panel-synaptics-r63353.c +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c @@ -258,6 +258,8 @@ static int r63353_panel_probe(struct mipi_dsi_device *dsi) int ret = 0; struct device *dev = &dsi->dev; struct r63353_panel *panel; + bool initialized; + enum gpiod_flags rflags; panel = devm_kzalloc(&dsi->dev, sizeof(*panel), GFP_KERNEL); if (!panel) @@ -282,7 +284,9 @@ static int r63353_panel_probe(struct mipi_dsi_device *dsi) if (IS_ERR(panel->avdd)) return PTR_ERR(panel->avdd); - panel->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + initialized = of_property_read_bool(dev->of_node, "syna,boot-on"); + rflags = initialized ? GPIOD_ASIS : GPIOD_OUT_LOW; + panel->reset_gpio = devm_gpiod_get(dev, "reset", rflags); if (IS_ERR(panel->reset_gpio)) { dev_err(dev, "failed to get RESET GPIO\n"); return PTR_ERR(panel->reset_gpio); @@ -297,6 +301,10 @@ static int r63353_panel_probe(struct mipi_dsi_device *dsi) return ret; drm_panel_add(&panel->base); + if (initialized) { + r63353_panel_power_on(panel); + panel->base.prepared = true; + } ret = mipi_dsi_attach(dsi); if (ret < 0) {