From patchwork Tue Oct 29 11:45:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 3614 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 0E0CC3F380 for ; Tue, 29 Oct 2024 12:46:39 +0100 (CET) Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2fb6261384asf37674371fa.0 for ; Tue, 29 Oct 2024 04:46:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1730202398; cv=pass; d=google.com; s=arc-20240605; b=BUHJOYuV/cYfvmzsS7S1w1/5z2U5aoC5Qvr7dzcjdszHrvpWXBO3tihZvNWdtynwDI 7pTjqTpEXAiNYATnJ3YqLI2fSB9OCOXegn36y/AIBzSy8wR/n4poUGnEaabrzPtppK4D hGDeVk/wIxXns7jZyhEEwYsVsm6rJr2fWl268MBovxQ22K58QyCpSrNeegpp1iDW+FC3 pGEiFEH4B3WVwewWJ0YzKfaeGp5h6yyyU6Hwu9oduix6jHSjz1h9avOwVMEzotj2IeKD MhBp0zoH2f2JxK5nQhxLnPVgcevh0ZoVhsDkGPl4CMzbpoHWNzqqV4JeBHgPyZrJdLsv Y6HA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=pBqcR74t88TkOcrBKCSZZrPxiIj2zvFwFkHe0eEMBvI=; fh=3RKczPTWVJdhiOZw3GPIut/lrrq63i63H2NqqauekY0=; b=k9PoOESHN4ZtC4xFmdo2jVj7s0RLhxrCOBrDuKQGl9TkTbUohFa7ybSUp5oQ+rOo8u v5xJOhSlivI0nI4dmCFa9aryeFndj7DiOBh5L8thHP9AItJu+4XfHJDVu3TzR3pDApy6 guUg2YasySUIToedvFn2DMyafqCnxTdzrr4byD5hLtf7/bf3i1owwbn12Eo0ma1GW6o1 RxiL+tCcoIOgGifkzLbE3luKTQ8IqpJHQ6xHjdgo98pteuxom9aWtp8zmKLLR7gLUcaz YHWowXtQSg90LfqVBtRkMdDpnw56npB3ngtgubol7Cb3PWw9rSLb0FiwxbQLt5kwdkUS FRGg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=CquXmnG3; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1730202398; x=1730807198; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=pBqcR74t88TkOcrBKCSZZrPxiIj2zvFwFkHe0eEMBvI=; b=Ba3SXnh9r2p6id/1QZPf+mUiG1OkkZ8h6qCQaifoYXGANSz9a6YJQcju7JZhewa6q1 luezkAKVSFl1TKOIMxLAds2GayeRfVbGZCFO0QqQIJ6g9S18j2aFZXTSoW44BfaB8zJ5 80vD7hKsUOSJAb/pLJgkjxQGSdAF1DMECJ7DM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730202398; x=1730807198; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pBqcR74t88TkOcrBKCSZZrPxiIj2zvFwFkHe0eEMBvI=; b=MQdQpbTpAwq9aGofY+5IhY3wYMMwd+VD3OU8el6olX8q4PNPns3RGYgsUv8AMS3JW0 urmRXXvzFcSrxc47qGOB5rmKMhNTKROQ9IfJjXkX7Dj7o7bAlXJ+tCgScZ9RDm8bPRU+ CgvYZB4mXA92LpdEK8rhqYt0RY8J/JoRCglec+xAXx7jkDFWgr93qQVEHwOE6X5lnQ8Z zubvZc/g4Z/EpEYFgkcmSwiX0xLUeeIkZ/4jbrdeqyWIsLy73ZSA6YvCCFiZNBQLakto cmS5+aPhYE/UeMOtlw0dEFSb0NaMRyfRyD+CB1FnLHyL0jJee2TUEPBY85OhPfkj4ZsI +Atw== X-Forwarded-Encrypted: i=2; AJvYcCUlfHdash58DoWs8znkK0KigY0L6OHjy66A/hI34FruXmLCQjeCwKy+LU0jJVrZ6JGe/v8hpiIx9V1DZbzg@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yyo7g00OuqyDsDxUxC2U3ybu9VpfolTW7Xc+UduGoohcKsPIR6x RQwzvrL2b0GC5QeaL3tZdEN4/8XQoyvYfNVaK9SPgETlnCfZyUPNd5yTJDFaO5DX2w== X-Google-Smtp-Source: AGHT+IHKWjbeUj+8KOUpJym3M2YDeH+Q2mc0nyCoLIbpRnbGcoZH0O1EZTAOp50AiT2T+N3NBHVFZw== X-Received: by 2002:a2e:bc15:0:b0:2fb:4c5c:3f7d with SMTP id 38308e7fff4ca-2fcbdf5ea97mr46751991fa.5.1730202398411; Tue, 29 Oct 2024 04:46:38 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a05:6402:34ca:b0:5c8:9f3e:a9e1 with SMTP id 4fb4d7f45d1cf-5cb9987a697ls103411a12.0.-pod-prod-01-eu; Tue, 29 Oct 2024 04:46:37 -0700 (PDT) X-Received: by 2002:a17:907:7f8d:b0:a9a:29a9:70bb with SMTP id a640c23a62f3a-a9de5ce021amr1140141866b.14.1730202396987; Tue, 29 Oct 2024 04:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1730202396; cv=none; d=google.com; s=arc-20240605; b=ZtWLfElt41ZdVwTXe9jolU3apDBXH8cjrlJgBYc+PQxnNvsxDRromfnJN3GHctS76i qdOcdwlNQjMWuLNEJxKvwGtUIzi+TgV+mKInOnFrTpDyCMHrfrY5Jbt8FHf98rDynnRy q5aq9IRhhgdFqzeu2lcrCWwzQAj6PsxVbduQZLqVkUB66CUkeWm0wXa9FUuVgFcEz0OT eQ38Iqm29LSf4QElyoCpvCpTPtjANWq+sfS63d2x4yi969fNeD8fe3q3pe/8/ZSZEbLA TYOkW1/LOrKbtnZ3UaC8cpo+iyAHa6yv3HoQv+zk/CavRbi2wJWclpDyocLdiJ9Y0Fe1 CLYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=+TS+cafYkOpOnfMipNar/zvOqT/SxcL5voxlp49ONDY=; fh=ljoFiwPup6gC9YG4NMWOEWNdgUd1CKjWIIwpUvYy39c=; b=LP3lPraosk0AkQgue4WX3UIFffD6KbEkWvCVxgnBsY611cVHgoK/jh3/k0jpU6dW+D +QcnEVly3ZSjlY999WLgbo4SxQ2GM9XUfxsysSZL1aJPssxQc3aYELbWRhX+Sp9NdKJW /4C0ZZDJkr5F0yXHoH4cJE0xhllztoY9sOr90MxbmjMWzQ96JQzmJaQVBzRNmZOv5d7m P8kYUngZz4fmXa/asbwaxLaOQPXbCbOBA+XzNaFrCAyhBrLVqhUBAcKbhZXHqsicQ8uR wESC5xbenzamwMrRa1oNxa2EWmZXZyhQzOys/Ndhn57WMyFc1dtZQ4ddSa+ZORF9Zxu9 ZtQA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=CquXmnG3; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-a9b1f27d174sor376834566b.15.2024.10.29.04.46.36 for (Google Transport Security); Tue, 29 Oct 2024 04:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Received: by 2002:a17:906:4fcc:b0:a9a:3dc0:8911 with SMTP id a640c23a62f3a-a9de5ce1801mr1152393966b.16.1730202396546; Tue, 29 Oct 2024 04:46:36 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.41.207]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cbb6297a09sm3869301a12.21.2024.10.29.04.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 04:46:35 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Marc Kleine-Budde , Vincent Mailhol , linux-can@vger.kernel.org Subject: [RFC PATCH v3 5/6] can: netlink: extend stats to the error types (ack, CRC, form, ...) Date: Tue, 29 Oct 2024 12:45:29 +0100 Message-ID: <20241029114622.2989827-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241029114622.2989827-1-dario.binacchi@amarulasolutions.com> References: <20241029114622.2989827-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=CquXmnG3; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The CAN bus protocol specifies 5 CAN error types: - Bit Error [Transmitter] - Bit Stuffing Error [Receiver] - Form Error [Receiver] - ACK Error (Acknowledgment) [Transmitter] - CRC Error (Cyclic Redundancy Check) [Receiver] The patch also adds the corresponding counters to the statistics. Since each device/driver can determine which of these errors has occurred, why not export this information along with the more general counters? Signed-off-by: Dario Binacchi --- (no changes since v1) include/uapi/linux/can/netlink.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/uapi/linux/can/netlink.h b/include/uapi/linux/can/netlink.h index 02ec32d69474..8b33549e7e19 100644 --- a/include/uapi/linux/can/netlink.h +++ b/include/uapi/linux/can/netlink.h @@ -114,6 +114,12 @@ struct can_device_stats { __u32 bus_off; /* Changes to bus off state */ __u32 arbitration_lost; /* Arbitration lost errors */ __u32 restarts; /* CAN controller re-starts */ + __u32 bit_error; /* Bit error */ + __u32 stuff_error; /* Bit stuffing error */ + __u32 form_error; /* form error */ + __u32 ack_error; /* ack error */ + __u32 crc_error; /* CRC error */ + __u32 pad; }; /*