From patchwork Thu Feb 13 18:09:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 3846 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id C5CB63F14A for ; Thu, 13 Feb 2025 19:09:26 +0100 (CET) Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5de623ada8csf989518a12.2 for ; Thu, 13 Feb 2025 10:09:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1739470166; cv=pass; d=google.com; s=arc-20240605; b=fcymybCzcUueT8zSnlCzfePdtQhP7EJ0Fkx95TGDoVfsolxiIMbzItUMFTZo1Q8VFK eh6Y0l3ScXujWueNirFf66mGSp7kO3ZHt9L5xcf0ArarN7Ze3OpZ6Kk95xaNmavXKg8w 3H46xB3y9tch/0SbOcT5RSEEArCzSy/XMJt9B8bxF1e17n3ezDpqo8P0EsgOvjU+P6jc h6LIk770ayZpotz40nGvRSoRWYZxjQ6BqOXs4tTbdHK3h/iMrqVllC2Wp74PtUUmyUeC q0kuGb3DxuFUnsUnMgFrv4+/bgin941tNgA6I+jmIcppkZWzWxWqA4vdJ2tQGgOhADK1 HJdw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:message-id:date:subject:cc:to :from:dkim-signature; bh=/IHLEMESs2OVqUrIN31X7JdH9JSeWBHaMI9mGXj3ULs=; fh=ytNoBd1QL16MJ+wczwOXAHhMne3hZP4YkpFdiU0e18Y=; b=Jgl5I0R6p2naRxphdjZnkBCnO+YtAGSZG4wfc+vo7D/fGEcxYqanIyYb0OlAT7D53X +vG0bd2sLWYNij7Z12AL6GzYMI+3x0YdC6XKpE8qxC9FMw0MsFW+iyrxHUueR4exqzGJ k2XIXJLkE8coNLOw45ca3tV9owA1CwCwll61gZwnRqbNyw6xHTXzJo7SwUMTENIejstn 1aYwtYE3yIRwLpq/S3LCAZdjq7+vKACqZ3sW+KHilfAmtKH1WoasmaE5Vncs9pTufuXq 9A8Yfii9cxkSflkNNwpSzLUxMC8vXpn5DY+67MRdf+gS4a+uQMvE792uSApOFACwGj59 xrzg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KYn2eziV; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1739470166; x=1740074966; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=/IHLEMESs2OVqUrIN31X7JdH9JSeWBHaMI9mGXj3ULs=; b=XbRK5lGvbzTvkqqIUgYCUgd41hbYbn9puv+DcPkzOG3HFzv9mohXr9smiymzImfKpM JbW0EhAb/ZQY/uB+27X3dwvF60y+5L3e8qwqbL+dMsmOxzv8YtdB9DZelgDSU6A1nHu1 x7KaaDvfHRtRf0M8ssHZr++0uVXxEtDmXBn34= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739470166; x=1740074966; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/IHLEMESs2OVqUrIN31X7JdH9JSeWBHaMI9mGXj3ULs=; b=CniCW4GlnVosu0Omz+IvtOGor7FEbBdPk7tbHCfem8YVh3F8jIobDHoE2WUymeaCUP umuT55c3ruo3RRvOdn4w+dNb56ddfjlcpw6ULrVNgl4eGeY9VfHlf3G9CzO8RuUCfN0M eGbRTLdIkxlNcPgevAwNAcnU80cCa6WwwA36R5PUeQEAFoFfbQp9WFDOI9EMY52/9HYA 6k1CLSpihnTMuPjAic/NiSDWoqpDAbJmE+YgUobJzzveh04SIt/kC0ZBZZkY4JVP5Vwf /fb5eLguLdzBhEeBt7AD1dBmPKhp4BrQn5ydhbVhvkF/xRcZYr69iNqJOKWBR9rCpkzQ GXwQ== X-Forwarded-Encrypted: i=2; AJvYcCWhmUGBCGFWE2VZAET/6i91XmoMT1/llQmJ5PG+Usf6d3fnRgq2S7UAQGKu9i/P2ANH7OkUDPN949pItmq5@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YxuBuMc0RBhOdlcBdCJvHNelGpMiudTnTIhn/YH4kFg6E5kjXqN gpykmC6aca/h0i8pf2veYeQv06+9kSag67b9uE8tTnkHWvZ9iblE9ZZ7/d4LFustTGAKT74U0Q= = X-Google-Smtp-Source: AGHT+IF33QFM/BtdI9C+JC1bQ9v+2x3FOG9ddD7ouc+Z0kcpORs+FeLG3Yf+xuoRjdm940416SWPww== X-Received: by 2002:a05:6402:510f:b0:5de:5cea:869e with SMTP id 4fb4d7f45d1cf-5deade0125emr7309112a12.32.1739470166179; Thu, 13 Feb 2025 10:09:26 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com; h=Adn5yVGwvfQkFytjey6Wz/ImdwzCowkkMZHfDGQosPZ1ZV7OsA== Received: by 2002:aa7:d349:0:b0:5dc:de5:3e0d with SMTP id 4fb4d7f45d1cf-5dec993d248ls852763a12.1.-pod-prod-02-eu; Thu, 13 Feb 2025 10:09:24 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXXFOrkg1YC7COK7aSjVVSU2B1lE+YHkMLaW/bC3zRUkUIUMrQpCJBsM0Zg+rrVFYVwcg/GnoegQWK3K8PF@amarulasolutions.com X-Received: by 2002:a17:907:9415:b0:ab7:4641:a72d with SMTP id a640c23a62f3a-ab7f34adbcbmr741887266b.51.1739470164080; Thu, 13 Feb 2025 10:09:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739470164; cv=none; d=google.com; s=arc-20240605; b=ZxSsHJMCSB/EeOWNs11C+G8h5kROX7IYPeghhRtwNUHyrofXuJy+JQqf0nO25BOmES GZhLbYpbQF+RVPeYmEAeJ8QPyalQQgRfRHy/OXy5K9Hoj6ZPDQlGfqm6t1O3ewnLsIU4 7D8TIydFMPB0cYUi9YClUdTlU+evv1mySzgK2rcTJ6XgOpgoi4a7ofxN5YVdE2nTBvAA 1d1WfDrfWhZocjoIBZOZ2l2194uZoeNJ8Ul6NvbJ8VatXC8e/EFLw0WG6/Kiq3VFcnb1 EbWtaQMwkTah+UV7W2+X/16kRlyI/mhMnoQba8ctN/NxLaID15yRUEII5UIdyIgV63L/ eDEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=ciO2mQcPbeuuAAsRq37LuKrcZfYR3+ce4TZB9J6PeMg=; fh=YLH0wxMY7V4pZ84Y518fulRFJDoYclFhNVXOo2VCzFk=; b=FeteI+7p+g9o2LmpsKcBPoOQ2D63reyrB8xBjHSouR9ruUvkvmTC5bEo8AQejFPKdU 8CTitWiiKfrHamVZIuKPL5bljC3XfaYS4FfYZAZQfBF6XOsBzPLS3Nk3vzlaqcyu+Ceq Qp9/l4PvKXxT3Z9AF4clWuuDxSADtzZ6SZzJqaWkwh5M/NXCbSTK1YW7PUgC5c3Y55r2 5cwuUrkI3jOBH7ATVPyn49t4+5y8sBIJE6XXQRN5m7jsCawd4gDmKUnq43gUFxmNfhzw LS7AMmLV/n1SL1D0yeLpY1D2R1KjF1yJ/tX7h9NN0rzb3fjQ1CNmJYBBAR7nAEExbTiH 8yHQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KYn2eziV; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-aba53397f31sor101279766b.13.2025.02.13.10.09.23 for (Google Transport Security); Thu, 13 Feb 2025 10:09:24 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCWLyb4Spd9fKETHa8yO3JYjCsaB5DSFgTrdAKX4QY4bijScArrVewoTmv6N2xbst8eiioBZLcZXErhDIxzF@amarulasolutions.com X-Gm-Gg: ASbGncugcN30mom0kO9XbMSp0qxvfA6gU7y9qNYDIak/rf95+F4Q9Qeuc07IIoI/o3s Yj2+xM1+SrisIMMXfEkygY3q7m9ZyLqzpcTaBG7f+xHFc7xsjhQb0QpfXaYW9AmCrrjs1yEoG9F GYbDXTf5U7L+7WzvD6ahcP/TT2V3mqho5UnjTj31s0sUbzYPJfLrej/88CD+8eYAEJJLAPQI7CH konswZ1qgLFe216CnIG+phUubxrRwfUmflrmPA2LmoYPPbly0K3M0M3vv0gdgYmyZkrTjnk8qIl cQIQkElz/9RRDlxc6UfAXLgIrrapfZfRKVTFppyHIYJw99KODKavQ4CiRpM= X-Received: by 2002:a17:907:9719:b0:ab7:e811:de86 with SMTP id a640c23a62f3a-ab7f33a39d3mr780597966b.13.1739470160972; Thu, 13 Feb 2025 10:09:20 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.. ([176.200.207.55]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aba53376756sm175345866b.115.2025.02.13.10.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 10:09:19 -0800 (PST) From: Dario Binacchi To: buildroot@buildroot.org Cc: Niklas Cassel , linux-amarula@amarulasolutions.com, Dario Binacchi , Julien Olivain , Peter Korsgaard Subject: [RFC PATCH v2 1/1] package/pkg-download: don't export the download command variables Date: Thu, 13 Feb 2025 19:09:08 +0100 Message-ID: <20250213180908.3963679-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KYn2eziV; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Exporting the download variables can cause unfortunate name clashes, as occurred with the SCP variable used by Binman for compiling U-Boot [1]. Do not globally export the package download commands anymore; instead, pass them to the dl-wrapper environment. [1] https://lore.kernel.org/buildroot/a023971c7c8bfa4826a9a8721500c7ff@free.fr/T/ Cc: Julien Olivain Suggested-by: Peter Korsgaard Signed-off-by: Dario Binacchi --- Changes v1 -> v2: - Drop the -C option package/pkg-download.mk | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/package/pkg-download.mk b/package/pkg-download.mk index ca01ff67a59e..20173805c60e 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -7,16 +7,6 @@ # ################################################################################ -# Download method commands -export CURL := $(call qstrip,$(BR2_CURL)) -export WGET := $(call qstrip,$(BR2_WGET)) -export SVN := $(call qstrip,$(BR2_SVN)) -export CVS := $(call qstrip,$(BR2_CVS)) -export BZR := $(call qstrip,$(BR2_BZR)) -export GIT := $(call qstrip,$(BR2_GIT)) -export HG := $(call qstrip,$(BR2_HG)) -export SCP := $(call qstrip,$(BR2_SCP)) -export SFTP := $(call qstrip,$(BR2_SFTP)) export LOCALFILES := $(call qstrip,$(BR2_LOCALFILES)) # Version of the format of the archives we generate in the corresponding @@ -118,6 +108,15 @@ define DOWNLOAD $(Q)$(DOWNLOAD_SET_UMASK) $(EXTRA_ENV) \ $($(PKG)_DL_ENV) \ TAR="$(TAR)" \ + CURL="$(call qstrip,$(BR2_CURL))" \ + WGET="$(call qstrip,$(BR2_WGET))" \ + SVN="$(call qstrip,$(BR2_SVN))" \ + CVS="$(call qstrip,$(BR2_CVS))" \ + BZR="$(call qstrip,$(BR2_BZR))" \ + GIT="$(call qstrip,$(BR2_GIT))" \ + HG="$(call qstrip,$(BR2_HG))" \ + SCP="$(call qstrip,$(BR2_SCP))" \ + SFTP="$(call qstrip,$(BR2_SFTP))" \ BR_NO_CHECK_HASH_FOR="$(if $(BR2_DOWNLOAD_FORCE_CHECK_HASHES),,$(BR_NO_CHECK_HASH_FOR))" \ flock $($(PKG)_DL_DIR)/.lock $(DL_WRAPPER) \ -c '$($(PKG)_DL_VERSION)' \