From patchwork Wed May 8 14:42:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 402 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 6840B3F066 for ; Wed, 8 May 2019 16:43:14 +0200 (CEST) Received: by mail-pl1-f197.google.com with SMTP id y9sf1890203plt.11 for ; Wed, 08 May 2019 07:43:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1557326593; cv=pass; d=google.com; s=arc-20160816; b=BjPKirFr91SRa7fNh/y+6sIeBKb5q3zv+HzOJ0eaia9EZ6gD+9e+Wq3uzXIGBbQDXw GFZ3Dmu9XAiollgn1QcYqxNy0oXvcFdvnXLbywn1LWs2POvuA2wR2fUiBMR5Lb365ng5 SR75Pfk+TDA7C8+3BqN8SlXCLLsRp22g0qGZVBCYHjP80eBP8GokBwBcmPpQV4/0k7hn DzDETvyiwrDftMMgmbqnQsKhvYiX6raRET2b2ebFssXUKd/eVlwJ9ElTob26tZES8qMz tkLlFIgfOLrVuU1zQ0Zm4NjRMZlL36v1v9ur0sSxSw37bWROWrSjtKg1Nkcu8QJnt2Zu PQMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=5HN0uxu1RCfiDph/f8dSBdpUZWs/IQTiJu6wtgoYckY=; b=Ag9RbQImu/zM5ccLmQqKJYqPHUpnDHIbRVT6/sdRZwonU2VZ+QWYox3qf1jswVIob5 1n++DE+lXx0cDQJvCLp3gRE6+ZZqBh8Xm1dfbATfRW6hmRcircp4mlEHLSOX2+ta/cUY MorneUYGuSPI/N3QgI8LX6FHMd7S7+zPiGZLzkPZHq0WWsQjShaXVzKnLgXuDSuLYlYP O1WzpCSyZh4MxF/d0FsZPHn+MniqGJzVhdJtSd9D99VRPIabfyB6GAWzoNfHD8E7ehiG gid615DBulPo79YwEnFOLEDtWt5kG1EWy1YITU5Q2cacYrehjoqJuf5emnmpVoQq/+uL PIeA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GTLKG6n6; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=5HN0uxu1RCfiDph/f8dSBdpUZWs/IQTiJu6wtgoYckY=; b=j/EB2ltH8bb73JOplorY0IaDwHUne0O8vx8UTuE6xO0mPNMlQcbpeIuMZpYytP8jy0 /qX4YhPntKnzi8fGCS0/IKjTDflEHGACyehonSA9r9Na8mM8W8C0kvcIvAMq046cgG98 SnjAF7e8KORpETmepeSO6iA/iCT0cByuoo/eY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=5HN0uxu1RCfiDph/f8dSBdpUZWs/IQTiJu6wtgoYckY=; b=B1xd91DJiswPnsEXHE2VLZgpusrkCX/RNSUQXlZoXSBoDcb+LoekJbdAWHwdL1NMII Du4lRhAu5o8+l2siJ+15AemSE2WJx+DNhaRJb/eYeYTM4PJgntfOjGIgoVOHu9f7IJMH QsTch7TDd9T0T4X9OzlaG6PDhsIW7HeZbzVrJcJIN2x4/smcIufAMjlAPYhjQnJ2gDh3 05IZMP4MrKz1z/IIS3xYIa5q57+V4geBdkjG4r3ufRIu3w3EslmcKNv7LbKlYCUmNj39 jKNkHwjtI2bAOVP3brcir5EQl0zbWZs6NkHNfZjrDzQnLqY8BR8WvEPwcTy7L0SW5+In q7pg== X-Gm-Message-State: APjAAAXIHzmqyqqh512b/78LtP2XKgohVrZ/Uopwn/qPxJshM5TNiw5w MbPcDKv1CdIk8l3aArxVZy+iuv61 X-Google-Smtp-Source: APXvYqzh8zaI/9gpIrpVCa8C+mJM6Bj0QmOxZD5vx1ScBYWCVsYhWXg6nv8Ao4pSXSJ4v4shK2CLvA== X-Received: by 2002:a65:480c:: with SMTP id h12mr46319087pgs.266.1557326593219; Wed, 08 May 2019 07:43:13 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:a62:130a:: with SMTP id b10ls2007971pfj.14.gmail; Wed, 08 May 2019 07:43:12 -0700 (PDT) X-Received: by 2002:a62:6444:: with SMTP id y65mr41228119pfb.148.1557326592828; Wed, 08 May 2019 07:43:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557326592; cv=none; d=google.com; s=arc-20160816; b=JLJfTK2lcA9SOq1ISRgUzXuGfW63xFFRrirDca8oq4eKNMqi6QDkftyqbDR/paWCkk ad9xs791kKGozi+UmWsf9hKRdWDPBYAy7qTw+htcFrz5TUSb83Cp+RvLnXQIQYE0Sjs6 g+4ZMIG/Yy0rsatEUGauW2Xf+gmCxMrUAQezGSyTnWQkXeAGcIzfBN9bkn/hj8A4WN0x bIBkjn39XEucJMfqxgZNIoYlscaeJ7LgT8z+gFEO23gpYJE0OAvu2oddXf4J3cS21xrb hfFkdbKr5FEsDS8xqhwnMlwr60jFMr8uVQea7eeYhUHFpUKywkl1IpE/tB5uAEZCddn3 hHnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=qMdqWGAiNPcJ3MLJrizvgww7TeegVpny6bBtAZYbZq0=; b=CNuwtx5n9eaKYSTb7yRtc844iAe0Vbo7bZmubrXe0u3RcANMSi925P3MCHuO0K2j+B oH2441IESgwFpV8JIPExkCLOHzLCj/0TdtE6QMKrAtpnXi+sYhaHBVnA1qXBKtjMbHuc jtdxivqQnhq+GLMotLhTs5PYo8eoHvnObXZm3RHxi9Rb9Nj3/anp1W+jIYIFBL5qaEG5 scKbi3jI+K8w1ySN5lBqzDtm1jtXzenarq6uRTSgo8rlGBNB2WdVl4Co4m6oXOAKegWO 8kuxlNQ/CBaJy64KWUEf2hyf+IP5enm10Xc35ObeFkfHn+pBxM04dhmsFLldthIo8Q5U AbCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GTLKG6n6; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u1sor13883978pgq.63.2019.05.08.07.43.12 for (Google Transport Security); Wed, 08 May 2019 07:43:12 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:a65:478a:: with SMTP id e10mr47545829pgs.310.1557326592540; Wed, 08 May 2019 07:43:12 -0700 (PDT) Received: from localhost.localdomain ([183.82.225.185]) by smtp.gmail.com with ESMTPSA id p7sm20864307pgn.64.2019.05.08.07.43.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 May 2019 07:43:11 -0700 (PDT) From: Jagan Teki To: u-boot@lists.denx.de, Tom Rini Cc: linux-amarula@amarulasolutions.com, Jagan Teki , Anup Patel , Rick Chen , Paul Walmsley Subject: [PATCH 3/3] serial: sifive: Change include order Date: Wed, 8 May 2019 20:12:52 +0530 Message-Id: <20190508144252.31001-3-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190508144252.31001-1-jagan@amarulasolutions.com> References: <20190508144252.31001-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GTLKG6n6; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Like clk_get_by_index, there is requirement for clk_get_by_index_nodev. In this case to make common code functionalities for dev and nodev, clk_get_by_index is trying to get the index of clock by passing ofnode instead of actual dev like current gpio uclass does. In these scenarios with current order of include files the serial_sifive driver is unable to find CONFIG_ENV_SIZE. In file included from arch/riscv/include/asm/u-boot.h:23:0, from include/dm/of.h:10, from include/dm/ofnode.h:12, from include/clk.h:11, from drivers/serial/serial_sifive.c:6: include/environment.h:145:19: error: 'CONFIG_ENV_SIZE' undeclared here (not in a function); did you mean 'CONFIG_CMD_XIMG'? #define ENV_SIZE (CONFIG_ENV_SIZE - ENV_HEADER_SIZE) So, fix consists of changing the order of include files in serial_sifive.c to include first common.h file. Cc: Anup Patel Cc: Rick Chen Cc: Paul Walmsley Signed-off-by: Jagan Teki Reviewed-by: Bin Meng --- drivers/serial/serial_sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index 537bc7a975..fdfef69aaa 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -3,8 +3,8 @@ * Copyright (C) 2018 Anup Patel */ -#include #include +#include #include #include #include