From patchwork Thu May 15 13:12:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4025 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 782483F97E for ; Thu, 15 May 2025 15:12:58 +0200 (CEST) Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a35989e5b2sf332093f8f.2 for ; Thu, 15 May 2025 06:12:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1747314778; cv=pass; d=google.com; s=arc-20240605; b=bnZNbRic53m0pznOoCCShJ+Gv//vtM7WDUajN3rypVo0z61AdmKKl7VZWuNNXXhuAC syFnIQFU3EtMYJ7P0K9YFHDCDMpLYVfhkdl34IncsKQpqYLaCEfo07JfQaGtf8IBMHUU Uz5xVjwbQdUHl3RlvvuZw9Jcq81xxYVZty+RMvJu4CUMh4b5+aWrvijDRgq41FLaLqBG KUqtYrMKmg8sd0Kal/XHVo9RP1hlgWbdGnDQHyB9C4HoBkEKVRoHLURx0vAOnCchXBlE oHPYMCnYw2VZB0lon92EM0N07wUlIuDjlZ9IilbButUz68EkY0NydVjCk4nnm6zjee3o EmEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=blBuXJGOI0VT0ldNuxhVoWFRHCYfoKFpC5CrMWiUADQ=; fh=2x8nAE1fz3suFy6A3tYBXmWeSWDK853xY/+rwY/xQ3M=; b=UAEM4eJ4hyYnOXZq0efJaao9VLe9M+qTDmm2Xb8J8SDMl/suV/E8zREDFTW5lV7Akx No3lNdD6P9zeScjqNOVWSWSRtmybcLuiLEN6Y49ZVh5jJ8S2qtextGyaDmoN+EcpploB d5S+W89ZiCX88IOG5q9Tob86HxGbk6u3BTiBqUC7Q/XEjXGSwarTJL4POcWTCAc4Gx19 DOJLnRZdjZgr9rQzX5A0Bwhs16ECSXToEvwl+/66tyy1QUVViJDBGdzGlNRKREQdydXr U/r6G+3i3gsRyGEuS2xVVninPqJm1rxuHbxNURbR1ldG9VM/5mSxk08QqhUgG+iVx3gZ +lVQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="QIgPuV/A"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1747314778; x=1747919578; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=blBuXJGOI0VT0ldNuxhVoWFRHCYfoKFpC5CrMWiUADQ=; b=rNiFPUV4tlAjLci8diEz7shjlBumVvQCRW9hIGdNy+5bzoiNZG063VMjvrVVuypyEn Zt/9KZqNlBB3Dq0iEsmBNW6gRALfHw85w6dfSRl9g0B3Q+B4CwTMjERxIHG/PgMJnUyd 0qMZfwJIfyq9J4O8abDiFUutG/QHYq6nSgbzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747314778; x=1747919578; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=blBuXJGOI0VT0ldNuxhVoWFRHCYfoKFpC5CrMWiUADQ=; b=oFVGtbghxlWqiQ3GvY/Zjw8E1+2/EYD6RrbLLEOXw/lBGSX7Rh53zHIannrEysN1K6 4O1A0olCGfF+SGsLWmIcJbt3cTynvfI5z2wdhs6I4TB7nMCCRd5HsL/TaNWfwKAdh4ZL ZsRvLa5yLBEQToDMCMgj4bH+VRB1oSYws/dHlC9O2VM/WPxGThOrHsdJ2MN6p44wf84Y ncUpC/JnInbBpDN2fFF1HMJ5vYX7g8B7n1+eGJtf/4J8szALdLoUzGHisFoznJc4L5bV n3SSk9AvVGDD6VB8lf0n0cqvPInawuo1z0wypIdqjIgbfuyhyY94S7PKVala8qYalH7b sCZA== X-Forwarded-Encrypted: i=2; AJvYcCWttuN/XxDYIiO+m/Sboo5UemH03BZT6BEFsmnS9zn6jXBGxM48DhQh9ffFjHHXNlpmeSt3BTKZ/kOJdlnV@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwV98S9N9KuU4659ujiq192j/Lv1+1sTJWaAk69k2HpMmmhQLPg yUvBKqeWN66UxYA+3xK1mymMfH8oRLGFgHZkhGrLRB3zxz8t3iwsqslZUKfpoii4dg== X-Google-Smtp-Source: AGHT+IFzi3k6gJv7bS71TRw/aRJOKIL899mAgKFtoTejVSr5NM6/T7mzbbOkJEE+0+k9fBTQMEJwbA== X-Received: by 2002:a05:6000:401f:b0:3a3:5c05:69c with SMTP id ffacd0b85a97d-3a35c0507f3mr771233f8f.45.1747314777301; Thu, 15 May 2025 06:12:57 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AVT/gBGXDmhnjMQuKyegJeT8FulQ/ZkWZtHLDLKDigkMkbNoxQ== Received: by 2002:a05:6000:401e:b0:3a0:92c4:91cc with SMTP id ffacd0b85a97d-3a351352188ls460280f8f.0.-pod-prod-09-eu; Thu, 15 May 2025 06:12:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXF/H0gAKQHe8fl58+JdpR5fidal77Xv/E5QR6ttIFbDAMmFolW76lPTYuPWTp++e4K5D+2ICBG1HKr9f5x@amarulasolutions.com X-Received: by 2002:a05:6000:40cc:b0:3a0:b1f7:c1da with SMTP id ffacd0b85a97d-3a349922585mr7319391f8f.46.1747314775094; Thu, 15 May 2025 06:12:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1747314775; cv=none; d=google.com; s=arc-20240605; b=PBaH47vFvY0Gf2bJAfsQaSAMLM8na3jfnP4W6pMmS0Llk+MeUayf/zLXAZR74hjDiQ tUH7j6eXBuo5fscOnT8QN/TRKHRQ9bi5Y9OIZOJeVC+HsCKB6z6wcNGyH8DZXYfv08Rq JVBv3yzx+fxuAlpNRbZp9KbP29qQnG8Djori0XWBlDGgdYQRjiH+cvoBilQTSH1CRK/k wB6jEMg4Ct5nhuYYFdqtD3n746Okjwdy2URdx0uNbPHf4wDaiQhni9i4U3v2T9QreH2y SVunHCj/+K+l4JX1KT104NzGDYxYNWNKnuKQHGS2KQKDH2vw4js1NoFOyTK2Htq5hW23 XVqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=g0PUck3BMWPfWUBq2621uRDOXcGLVjyN47c/ykxnPHc=; fh=9jrrqHy95XXdZ6HtBqDavf45flYroZwEOpG3gPARKAk=; b=h4GnzroHyjk69V5ONOXzU0/CsB0SbDvKqjKw9tliE32rwnEUUCvvK1cwKVe7QUfBNt Pf7mQ/GYWEDFwBgzR79eF13JMnt6Hs5cK8y4KmaHGWvOgTpSRtBSoGpl6pVaHArd4YwW SWLcGI/M6QIcDGmPhGk3IlnoysGdBZM9M5m3JNf/u8ZFuahpD9TnCtXHIauFsaVbQa8i KyL1B07q408nKEr1AtL0QhlX+NDMpLMsTaSWp1FBlOATvX1302lCsl0/lV6fmDqIqFOx B/Y2MZULBdgfHfwIWK0b4lJ08t/MpM+4zFDqfXvvuSYGH3l2+3VC2n72Ds0tS0L9oOnn 5Y9g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="QIgPuV/A"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-3a1f5aba755sor7158117f8f.4.2025.05.15.06.12.55 for (Google Transport Security); Thu, 15 May 2025 06:12:55 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCWjj6ffvY//OK/UngMoLm0DRqShkjB9alvlcG51Wo2ptsmVzmCtkePoKe5MkCAoua8D7V8tV3IKV8GGbwMW@amarulasolutions.com X-Gm-Gg: ASbGncvG4AIBUQNQPYLVHhj5JkuwBU3YSxWuFzo7JhKQGRseK28zO5m3Q+vb0vA3356 nneCpW1lkKU7b4hPbcW20V2VsBvOsx9d42sQw3Ilq8n45BUDt3+R7RulzY1WEtHtwaWEawPvMcV I84ScEc8ZDMXgl7cH9ilfsA4OeEdyl1hPQVx2jiYEEFnu60Hab0PWe8II8hzHsqSP9Nrnwst+GI HqxaLvwWqySHwuPERuVG66zFuIbTejl2FeF2YXqzLwSB1GOBaMh7Zfu9JvNaOE8K7fvejJxXakE ek/hit8iH8NxydRyReAQhCEFAVPXSVX72PdavEdIAESHAaH4ShIyjQyKOrWZ9KML0Zsmt6tGDKp e8T1EV6uTPZXU0lYqP8mIlAdpTnAB0RlQodvryHILWj8= X-Received: by 2002:a05:6000:430d:b0:3a3:40d2:8499 with SMTP id ffacd0b85a97d-3a3499516dbmr5987824f8f.58.1747314774653; Thu, 15 May 2025 06:12:54 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.client.m3-hotspots.de ([46.189.28.43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm65516825e9.35.2025.05.15.06.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 May 2025 06:12:54 -0700 (PDT) From: Dario Binacchi To: u-boot@lists.denx.de Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com, Dario Binacchi , Adam Ford , Fabio Estevam , "NXP i.MX U-Boot Team" , Peng Fan , Stefano Babic , Tom Rini Subject: [RFC PATCH 3/3] serial: mxc: restore booting for imx8mn_bsh_smm_s2 Date: Thu, 15 May 2025 15:12:42 +0200 Message-ID: <20250515131246.784206-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250515131246.784206-1-dario.binacchi@amarulasolutions.com> References: <20250515131246.784206-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="QIgPuV/A"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The commit dda454e933c6 ("serial: mxc: Support bulk enabling clocks") breaks the booting of the BSH SMM S2 board. Restore proper booting of the board even in case of failure of either clk_get_bulk() or clk_enable_bulk(). Fixes: dda454e933c6 ("serial: mxc: Support bulk enabling clocks") Signed-off-by: Dario Binacchi --- drivers/serial/serial_mxc.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c index 28f4435d01dd..b09a5fe0f7a4 100644 --- a/drivers/serial/serial_mxc.c +++ b/drivers/serial/serial_mxc.c @@ -310,22 +310,31 @@ int mxc_serial_setbrg(struct udevice *dev, int baudrate) return 0; } -static int mxc_serial_probe(struct udevice *dev) +#if CONFIG_IS_ENABLED(CLK_CCF) +static void mxc_serial_enable_clk_bulk(struct udevice *dev) { struct mxc_serial_plat *plat = dev_get_plat(dev); -#if CONFIG_IS_ENABLED(CLK_CCF) int ret; ret = clk_get_bulk(dev, &plat->clks); if (ret) - return ret; + return; - ret = clk_enable_bulk(&plat->clks); - if (ret) - return ret; + clk_enable_bulk(&plat->clks); +} +#else +static mxc_serial_enable_clk_bulk(struct udevice *dev) +{ +} #endif - _mxc_serial_init(plat->reg, plat->use_dte); +static int mxc_serial_probe(struct udevice *dev) +{ + struct mxc_serial_plat *plat = dev_get_plat(dev); + + mxc_serial_enable_clk_bulk(dev); + + _mxc_serial_init(plat->reg, plat->use_dte); return 0; }