From patchwork Thu May 15 14:55:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4032 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 94B813F049 for ; Thu, 15 May 2025 16:56:00 +0200 (CEST) Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d209dc2d3sf6305865e9.3 for ; Thu, 15 May 2025 07:56:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1747320960; cv=pass; d=google.com; s=arc-20240605; b=SZy3ibpcIHxVcL7iGkyUh343RTTO/YI9kGvRhGFtECENsistMMV+N+hOHMLkzsyf1j uSobSucj4k1zea75WK99j6xismtzhrJw7IYgZbHHoL8jRA9CtUZaGxpnAOsVo3LahKLG 2hJ93ymmHEOHU/s5j8gg9RIvON+7EvKr9doLHtbBOSF5Ppxm24woEupWUp11GESVu7s+ ZKtF2Iasn+dYeEgOvNu/ohF9LBcklTnIIallZxnZj8LN/TnV+M2TvYN2F1X+nSfZ4l5B 3YXRegpJcJr4vjyaCFoP9oL4MpK3HhgWhRVw2RxFoz+i37pJPb6nMPJj0P/lF+72vG3w aghg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=QHpB37bHvzh2dF1hBHzh8+1vQ1VbHbKNNGVfOkgEUTc=; fh=tHB7/NopCM2NXVGta2J5xLyJiXdOJI5BQKuXAJJ/Vms=; b=lxYWJTIeu7D1K1g7zS+bJj03jB9X3ZR6jZjP3aJ2lT8OCsJ4f3DinhsZsNfgIA+H3q tpGkvXgmWpFlPUUHvK8wstgQmbIZK2fmTwRsCFzXEtXqDuDtA465F+/omdgdBOZZAE1K Xe1V7f1ODfq+xnVwqcnqdDTGzhUOVjDw89nPhadDviUFE2+WzL6F+G1nQcFAl68NCJGg X4DkXVCMuBLTBfyaWDNfIuD3I6Jw2ZVa1IqX2Abjtoyn3OsvNSDLBkOal6KT05cmJ8wU puXPlVC/fIxYVSSCQQn3Cc7gt5avj9rQYqQZcjQRPoQmZ7G6eIxurP+b7Z3nsWQVPAQT thmw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=p1eGZXVD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1747320960; x=1747925760; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=QHpB37bHvzh2dF1hBHzh8+1vQ1VbHbKNNGVfOkgEUTc=; b=gqe2qnXIe3sJsLfIHlbF7txmbrj0mCj3/DYwuwcWzviTtRqAkk5vw5XsyB72T0RSZ6 Kn/LQb6RZTZPgX6XGJnH9fnthkS3PlKJr2TaJtJkFn5d0GpaFsIcXdHYBpUU7ww5UCOY ZDs7zJ+DSQnmPrDLgHONVimLYpZin9dftFvpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747320960; x=1747925760; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QHpB37bHvzh2dF1hBHzh8+1vQ1VbHbKNNGVfOkgEUTc=; b=JuKJRUOyXZrJmR98EXR7GLykAJ0IMUToPUAcx638/cdT3KgznF/8I+CMiaRmUHf90r ecXc/IEeBy1v/eeP4c3qA/fLAYQ+JH6OPabRbi5AMDWkrsiU7LkiAM8kXxmcnSdya0ib sF1syR3HofND7dx+MoYwDSg0t7AA7qOGyFpGlDevSJmpXF0sNPjVfShs9HJtT8hSwhx1 kYxomAyTAVb34piPTsgKJZSOMbx6vX/15GOM8YL2HytHWhZu86kaJ8+eHgCcALi0Ka94 NweBbLGQ2AiZUod7y2FdHgXmUjEPBbkWsJukdcUXjFV1z4YrJL+Rv1CLIEeaWeECtPU6 FmRA== X-Forwarded-Encrypted: i=2; AJvYcCURU9jv8T2wYMXWa6dU6w5wGIdHbvJ8gcn9i3JbssoNfPY1MdWhnzFNbHV2BTuD6864yeFdthy1D4e+K3Kv@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YxOcoDDeontQgDFL8qVP8eTHMJzxbBs/KzGHZtsAkS+ERx8azaw sSfylat8ZsZ4TxI6nB1wejf6PePhXIK+Q+/GVl/9vsG615QiRxcb1eEmXpvk2Y0iTA== X-Google-Smtp-Source: AGHT+IHvGWnaXwUVsefVVG37j2Z2FU03vS2q3B6GC+4O4cfcqj76WM0ZGyXoWS8IQt6pnOIttlZGqA== X-Received: by 2002:a05:600c:1c14:b0:442:dc6e:b9a6 with SMTP id 5b1f17b1804b1-442f210f6b6mr78524875e9.17.1747320960068; Thu, 15 May 2025 07:56:00 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AVT/gBEJLtDdFu1OGnkL0uqgbOkk7BcSI0edxbjwaAqNiZINKw== Received: by 2002:a05:600c:500d:b0:43c:f009:43c2 with SMTP id 5b1f17b1804b1-442f85f7ffdls5923675e9.0.-pod-prod-03-eu; Thu, 15 May 2025 07:55:58 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUHgwS14oXodX4WcDvNsFpx3tu0XCm7dsYRbPSU11s8LDdvGCkDvUDZJjBbcvWjRQI3m+tDF77XJOLy7vpx@amarulasolutions.com X-Received: by 2002:a05:600c:1c89:b0:442:d9f2:ded8 with SMTP id 5b1f17b1804b1-442f210f764mr83812785e9.15.1747320957975; Thu, 15 May 2025 07:55:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1747320957; cv=none; d=google.com; s=arc-20240605; b=YpNBjI8TBD4RLFgWHnUdF6Xj8R2gfwPXwF3mnkayyuzMm1uyRikuiDa/1Db+zw0O1U 2lwJNaqLQe2ZUG21R9XC3evnnGnM65hDV16+ew0bF4mq+pnQeBCOzFdfp5AZQv+KZxkS ibyKgMTXFAczDYzi2miLaIwSfBWskkWkyFyszy4thcGSRhs7775gp04dhVmlTHIjqjm1 Ek2M/6OlXsf6UXpYXKv+We1NrM+BDPaCzc1HjiV9+7sDNC4o8KA1HXHwYlcKn2vjYJWt s09nkiK283QeF7FMysgKnsRdwfmStSuFG1O2cOFSENknpqTYTlL5jow0iE2Nnxx8WxFN sFtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=vCeQwed33O8/cupvpVNiSMnnjyWuZD/E8lM3+ypML7M=; fh=GBtYBUnQ1HfeyCbgDD0r3y26DHeniV6rQCJy8H3Ih+I=; b=O5tIwUeGIhwLuiTE33eF+3T0m5m1lKkZX0cfzR0T64TOS8g3YiVYhtDzWgSyf/Z1ZO sixLWGv68D7yMdpn8nc6o4akxKV4eWkCwUKsi/6H1722RtWHHsNhCqdEgy4hv+0TrehP uiL53jKddguDuDeITxnfybjeD4xZjeBCYZ4LGRDOWe62kwIAqA56uQGy9UBQMVmVEWJ/ n+7/+GZnzZG4FTPYYbf4kl+mLxslABySF+uLYPGt4+HyvUDMvR9pE1BlMhFxPY5nzRlF AZJvzKj6yVvq2VUAQcd534LfzbpJIAganGJyfPdR1/nbmh4DUU/+d0eHZVPANV/3uGXK GmKQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=p1eGZXVD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-442d67d7b47sor47873875e9.1.2025.05.15.07.55.57 for (Google Transport Security); Thu, 15 May 2025 07:55:57 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCVWtt+CBFKVNtNoJ3NFBL7Yk4dMjr6fLUoLYN5phgsC8mrnX+s3Qzh9tZtSzGWXkRROrHZHeHXZWYmZKGPE@amarulasolutions.com X-Gm-Gg: ASbGnctisfznpiZiKmdWmOstn3+WGItAY9evwsFv2mfvnHljWDu9W5foJl8cRetuRNg qH2jdeBT/7oozl6vZ5qK7KLbN8Xo2eulc6sKM+dTtK7Kypbak++DEPaC0WSXrLG+J8TINIHNXzu 0ZmJTavLfZSIKlwmLQen3ciQdDQRICEFynk57APwvzOkfQWPnBOgMR4gSsF2eynvb2bqLKUYMFK Ug4TBRMMflB+DslQetQn2DlTlzknTg6GApwgqkI+fvfXGVGyGKv+UAvCu3IJ88HWDTNiJC551ug SQHV5UOniY8TTAixJF6ZutGgEHBYiVzQb+EHzM8r4hP8bpoPUI/6cuf7kAgRJzdFYqfBclEFD3j Q8rNwVdG0QD3dyvKps0x7M/Fv8cU5/Y3mg9j4ZZ+fqRg= X-Received: by 2002:a05:600c:4ecf:b0:441:d4e8:76c6 with SMTP id 5b1f17b1804b1-442f217a414mr90465715e9.30.1747320957570; Thu, 15 May 2025 07:55:57 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.client.m3-hotspots.de ([46.189.28.43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f3369138sm77030235e9.8.2025.05.15.07.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 May 2025 07:55:57 -0700 (PDT) From: Dario Binacchi To: u-boot@lists.denx.de Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com, Dario Binacchi , Adam Ford , Fabio Estevam , "NXP i.MX U-Boot Team" , Peng Fan , Stefano Babic , Tom Rini Subject: [RFC PATCH v2 4/4] serial: mxc: restore booting for imx8mn_bsh_smm_s2 Date: Thu, 15 May 2025 16:55:37 +0200 Message-ID: <20250515145541.886857-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250515145541.886857-1-dario.binacchi@amarulasolutions.com> References: <20250515145541.886857-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=p1eGZXVD; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The commit dda454e933c6 ("serial: mxc: Support bulk enabling clocks") breaks the booting of the BSH SMM S2 board. Restore proper booting of the board even in case of failure of either clk_get_bulk() or clk_enable_bulk(). Fixes: dda454e933c6 ("serial: mxc: Support bulk enabling clocks") Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/serial/serial_mxc.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c index 28f4435d01dd..b09a5fe0f7a4 100644 --- a/drivers/serial/serial_mxc.c +++ b/drivers/serial/serial_mxc.c @@ -310,22 +310,31 @@ int mxc_serial_setbrg(struct udevice *dev, int baudrate) return 0; } -static int mxc_serial_probe(struct udevice *dev) +#if CONFIG_IS_ENABLED(CLK_CCF) +static void mxc_serial_enable_clk_bulk(struct udevice *dev) { struct mxc_serial_plat *plat = dev_get_plat(dev); -#if CONFIG_IS_ENABLED(CLK_CCF) int ret; ret = clk_get_bulk(dev, &plat->clks); if (ret) - return ret; + return; - ret = clk_enable_bulk(&plat->clks); - if (ret) - return ret; + clk_enable_bulk(&plat->clks); +} +#else +static mxc_serial_enable_clk_bulk(struct udevice *dev) +{ +} #endif - _mxc_serial_init(plat->reg, plat->use_dte); +static int mxc_serial_probe(struct udevice *dev) +{ + struct mxc_serial_plat *plat = dev_get_plat(dev); + + mxc_serial_enable_clk_bulk(dev); + + _mxc_serial_init(plat->reg, plat->use_dte); return 0; }