From patchwork Mon May 20 09:03:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 418 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B199C3F36B for ; Mon, 20 May 2019 11:07:19 +0200 (CEST) Received: by mail-pf1-f199.google.com with SMTP id f1sf9563182pfb.0 for ; Mon, 20 May 2019 02:07:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1558343238; cv=pass; d=google.com; s=arc-20160816; b=gy7cTwcG7lk/Na5nGTAEaqHpfN/2t4QWvd20gkbdBahxB3Cuzb0xM/HL10FXKBIQqy AJAersmvVp7ObItVJLWNNw5ZCBmyuNeZwv50uQKriH1Af4NddU4fZJdctVR4IQtMI7vg OpeO5yJT/WU4tAnAyMQ0R6TAQQREMtnJVxO4Eu3lCko+GJ9KVJOcXLzuKNBNziQ2g1SQ DydSvJXKvIzkByJA1T71I+HQug6/rkKJ2gRQGb2ZjqKH/rvj94p8HA6ENhTRVqeEgaLX C2hbW4079LjxC2aGHLVMdTC9NcOkP7tEWQMpj/jP6V3m+De84skQjOj/+xg1xAJ8XYUL 2ULQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=r1tyu9pxAoBbi8VR2AG7BH4EBr7G2bl4TyUGbJx6ivA=; b=I6npsGykJOl4X6VIIlUDSPub5xj2cDgJVTqpyrqoPAWei5yJKLOng6BxWZ/Yf9NYNc aJWWqA6Sc/otYO74g9s7KAl1GpMcqd97YoAJgNe2o8KEPjOTcZlp0njfCnc7p1szumVD IonlDP2HwpySlrPxIWvO5SwqKK71uRmCNX+SFioCb/bzIkOXFj702iEYFn2zpnyNOH1f +6SDEJZOWVIKVii+LVtLAefQLOXcH+4NK3xRb7t6ZR/NsFmD3Q49/Usaqt85DQbA9jrR LNBVUvqlnkCDFp7a0Ei5pzRwWLChYBgiT4K/jVbsmmRWD4Etl/HkdyMB3SpaewFtFcfP +XaA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WCUUST4d; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=r1tyu9pxAoBbi8VR2AG7BH4EBr7G2bl4TyUGbJx6ivA=; b=DUFT3DYS9+KKlb5aC7bKEL0f+naZUjfvQwEzvDyZ3LvQckQ0aJLqF7CGhiDT2iNMat vrzXCBJJT8aCk4lG8tvq3WBEZoQgVsKPXdsAAo+A76gCVu1Kyt9AVB/S5L4OWMa9Tiwg WW5au9+5SICOfz3gIalSIOVKy7fxFSigiryuY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-unsubscribe; bh=r1tyu9pxAoBbi8VR2AG7BH4EBr7G2bl4TyUGbJx6ivA=; b=UrqrJHfVPSbBaFFpVh6YooPuV6w1ReuLsk3vVHX33u2WkVuSaM43eipE+jyJBxVKbY IrWNUfAVkw0J2j1zjChBnkfgXu0As2Go+w3toMt3zdS+/Y5cp2pmhsG7265oouWont4y W7vexQCXa68hCKFKuZEXR42niaTOtzANv/mFxcxUoFQOwORVf6aNTgp11FZYGUaAlaNG SgH4jjoy/wufsN7hmyA/yKk1KACxoFKWqMG4INTw7Yb+bDNz9DYLwYSTO2hOZ5uU+4Fv nQ9HHEGpovTK3kkTmxLeth3oUrdRIgqrzroRujb/1pId7FkElGRP1+jdGt+EmZfYQQ9X 5ojQ== X-Gm-Message-State: APjAAAXUUJ2oQ0uEzduYfg6X7esGQgZYESiVPJcWxbnkWAxC0f7H/Bry kEZCG6iKmn3vf2oFHiDnPpVz8OVF X-Google-Smtp-Source: APXvYqw0nOyBJwABt2wue8J+YsUhQtBlCbIQhEguc385nKo8de/EZDp+AB4qTm3RXd0zCglbajzeIw== X-Received: by 2002:a17:902:3fa5:: with SMTP id a34mr47112939pld.297.1558343238218; Mon, 20 May 2019 02:07:18 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com Received: by 2002:aa7:8085:: with SMTP id v5ls5084001pff.5.gmail; Mon, 20 May 2019 02:07:17 -0700 (PDT) X-Received: by 2002:a63:295:: with SMTP id 143mr73964686pgc.279.1558343237830; Mon, 20 May 2019 02:07:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558343237; cv=none; d=google.com; s=arc-20160816; b=jDTErnJ4Ds7fxtteIYM5H5Chn8pCcBt/AuUnw7YoJhfHPI3qtfvfc9jzavHahCBYRp gySb19LMxvlw3FXNs5ZKzm2gWC2yO2SSfUXFMdJ42ssvs+o8b4QR9vyFvxKBXNykkFNL vxs3XHvJdnE4JVeCNUwhPwcX6w3mWKzE4qGjpR7Xph3klU6NR2/jFj9qXF5lA2JzceIq AuJ7sNgtDjEDAckhGV197yobKn4SCFf/e9bvLpE6dIGwj6vKAPVW0XTA0R58HecJ3N5t qjQ5KblRJXFSoDCPiR+WwnQ3cGH4+mOubwL9MdYUnyPcvQFXyI0OkA4mIAVjOxpOsY5L irnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=f8TMcXIdAGJzNv/R9JRXO6fjRcOJSJIXQUyqy5meT6c=; b=XPqKpT0kHEYjpJkwsOGNyUcYlJScc/hobmwHhvWCH10wPfEPr91DmfH2gz6Hai1QeB 479deAl9U6Kh6nnWHv02Xc7lWq+TbdWp4NT/daJYRWaolotY5B3MLFNBxsCiAtvrUvJZ MP0+bL4WWvhWDeM5Eirs1m7BkwVu7pkxYLaj0Mz5FFehWfLomml30wk5hJaK7ETyPsuL 2q2nl/fp3OXE8oq3SSAVtU86xnUagDd6Jij5gI+KLd76Ol2AYc5WRBKJShDn/sYjUQEl cvhfTl30+9l4qMCDVyu+Di6CtkNl/ig0SFvp64XQrfP8BJGuXx4Mv6G8+kQDCAeU8mRA Jc6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WCUUST4d; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id f85sor18363427pfh.10.2019.05.20.02.07.17 for (Google Transport Security); Mon, 20 May 2019 02:07:17 -0700 (PDT) Received-SPF: pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; X-Received: by 2002:aa7:93c6:: with SMTP id y6mr25628819pff.0.1558343237216; Mon, 20 May 2019 02:07:17 -0700 (PDT) Received: from localhost.localdomain ([183.82.227.193]) by smtp.gmail.com with ESMTPSA id d15sm51671614pfm.186.2019.05.20.02.07.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 02:07:16 -0700 (PDT) From: Jagan Teki To: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: bshah@mykolab.com, Vasily Khoruzhick , powerpan@qq.com, michael@amarulasolutions.com, linux-amarula@amarulasolutions.com, linux-sunxi@googlegroups.com, Jagan Teki Subject: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits Date: Mon, 20 May 2019 14:33:08 +0530 Message-Id: <20190520090318.27570-2-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190520090318.27570-1-jagan@amarulasolutions.com> References: <20190520090318.27570-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: jagan@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WCUUST4d; spf=pass (google.com: domain of jagan@amarulasolutions.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jagan@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , According to "DRM kernel-internal display mode structure" in include/drm/drm_modes.h the current driver is trying to include sync timings along with front porch value while checking and computing drq set bits in non-burst mode. mode->hsync_end - mode->hdisplay => horizontal front porch + sync With adding additional sync timings, the dsi controller leads to wrong drq set bits for "bananapi,s070wv20-ct16" panel which indeed trigger panel flip_done timed out as: WARNING: CPU: 0 PID: 31 at drivers/gpu/drm/drm_atomic_helper.c:1429 drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 [CRTC:46:crtc-0] vblank wait timed out Modules linked in: CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted 5.1.0-next-20190514-00026-g01f0c75b902d-dirty #13 Hardware name: Allwinner sun8i Family Workqueue: events deferred_probe_work_func [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0x84/0x98) [] (dump_stack) from [] (__warn+0xfc/0x114) [] (__warn) from [] (warn_slowpath_fmt+0x44/0x68) [] (warn_slowpath_fmt) from [] (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) [] (drm_atomic_helper_wait_for_vblanks.part.1) from [] (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) [] (drm_atomic_helper_commit_tail_rpm) from [] (commit_tail+0x40/0x6c) [] (commit_tail) from [] (drm_atomic_helper_commit+0xbc/0x128) [] (drm_atomic_helper_commit) from [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) [] (restore_fbdev_mode_atomic) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x30/0x54) [] (drm_fb_helper_set_par) from [] (fbcon_init+0x560/0x5ac) [] (fbcon_init) from [] (visual_init+0xbc/0x104) [] (visual_init) from [] (do_bind_con_driver+0x1b0/0x390) [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c4) [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) [] (do_fbcon_takeover) from [] (notifier_call_chain+0x44/0x84) [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x48/0x60) [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x18/0x20) [] (blocking_notifier_call_chain) from [] (register_framebuffer+0x1e0/0x2f8) [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_fbdev_client_hotplug+0xe8/0x1b8) [] (drm_fbdev_client_hotplug) from [] (drm_fbdev_generic_setup+0x88/0x118) [] (drm_fbdev_generic_setup) from [] (sun4i_drv_bind+0x128/0x160) [] (sun4i_drv_bind) from [] (try_to_bring_up_master+0x164/0x1a0) [] (try_to_bring_up_master) from [] (__component_add+0x94/0x140) [] (__component_add) from [] (sun6i_dsi_probe+0x144/0x234) [] (sun6i_dsi_probe) from [] (platform_drv_probe+0x48/0x9c) [] (platform_drv_probe) from [] (really_probe+0x1dc/0x2c8) [] (really_probe) from [] (driver_probe_device+0x60/0x160) [] (driver_probe_device) from [] (bus_for_each_drv+0x74/0xb8) [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x13c) [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) [] (deferred_probe_work_func) from [] (process_one_work+0x204/0x420) [] (process_one_work) from [] (worker_thread+0x274/0x5a0) [] (worker_thread) from [] (kthread+0x11c/0x14c) [] (kthread) from [] (ret_from_fork+0x14/0x2c) Exception stack(0xde539fb0 to 0xde539ff8) 9fa0: 00000000 00000000 00000000 00000000 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ---[ end trace b57eb1e5c64c6b8b ]--- random: fast init done [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CRTC:46:crtc-0] flip_done timed out [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CONNECTOR:48:DSI-1] flip_done timed out [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [PLANE:30:plane-0] flip_done timed out But according to Allwinner A33, A64 BSP code [1] [3] the TCON DRQ for non-burst DSI mode can be computed based on "horizontal front porch" value only (no sync timings included). Detailed evidence for drq set bits based on A33 BSP [1] [2] => panel->lcd_ht - panel->lcd_x - panel->lcd_hbp - 20 => (tt->hor_front_porch + lcdp->panel_info.lcd_hbp + lcdp->panel_info.lcd_x) - panel->lcd_x - panel->lcd_hbp - 20 => tt->hor_front_porch - 20 Which is mode->hsync_start - mode->hdisplay as per "DRM kernel-internal display mode structure" in include/drm/drm_modes.h So, This patch update the DRQ set bits to use front porch value. [3] https://github.com/BPI-SINOVOIP/BPI-M64-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c#L774 [2] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L2031 [1] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/lowlevel_sun8iw5/de_dsi.c#L851 Tested-by: Merlijn Wajer Signed-off-by: Jagan Teki --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index a9ed87956f6d..c5bec0096b7c 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -436,9 +436,9 @@ static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi, SUN6I_DSI_BURST_LINE_SYNC_POINT(SUN6I_DSI_SYNC_POINT)); val = SUN6I_DSI_TCON_DRQ_ENABLE_MODE; - } else if ((mode->hsync_end - mode->hdisplay) > 20) { + } else if ((mode->hsync_start - mode->hdisplay) > 20) { /* Maaaaaagic */ - u16 drq = (mode->hsync_end - mode->hdisplay) - 20; + u16 drq = (mode->hsync_start - mode->hdisplay) - 20; drq *= mipi_dsi_pixel_format_to_bpp(device->format); drq /= 32;