From patchwork Tue Jul 22 10:36:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4221 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A1FDB3F18B for ; Tue, 22 Jul 2025 12:37:21 +0200 (CEST) Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-606ae00e924sf564981a12.2 for ; Tue, 22 Jul 2025 03:37:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1753180641; cv=pass; d=google.com; s=arc-20240605; b=Q0SHZre9O5EdJ9dwHEvf8PixxxWF+fm+vxH7p/jgvS82JcCD8CE/hTnL8I2fK1+nQH u+mU52dawpCtcol4TlW1DXtPpPB/uMA9YJUfxkx2JONjONYsIwHFEHgof2ZeY/ArF3Sr uIbo1b0uhroxzUP2dQSBIdNG4C5bYDomKIUhjFrUxbGnYhEhQOsqe/JbOlVVAbVlv3tF H6/SIeNmlg7L3ZIPcBS5ngf9egFjBNzuUfL07h413LepL0oBg+oBujQONEI85S0q810H gt13KjWMFO0s0UYuJWVQN6zGisl9rEJs07hi5LU8q5PoAuhlnIOlpgFV+shkfIgkvA03 T6mw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; fh=wWaEzdzul6cTzCAnLCNbel5cfik8DBpAuG6CJwVPnxI=; b=QilJW4JAIjF+v40/VLr5nLrgEGCl5lFucgYNEY0hscYo8e+zBRNMQOmLhAGTeXi7HY m+5dKdd7J21/syzAQkZVgNqzbo3Uu1liQAUDPkZuytzRVC7j/VVRWzXIFBJeO0DIk271 17A+K2wg6mzokzMXlNoUj0VxZrDmAFQP81rIUE2dhvu7JoKxArjySnU+yzz+536Msto2 02YX4Pg1ZyQADak2LBV/4ehE1euAFDK4bNAEiLQ7YBgIOuMB6sUr5A4bCJvI/H1ArwSt WOqanT0ydZh+TCK+Zmmngphwu/59wx98R/8u/x29/Ixl0gCmsI/Aj5aLUOMN0vL31m3s 3/Tg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MYUKn22w; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1753180641; x=1753785441; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; b=rIs6eOB2/polMKDes9sa8VHKHbY9Z5C1OeuZqFbnW860OR+m7GicXCKjA3+eZKNKTS 7UoJEbKoLp19g635tnKr+zx+7dz6oY8DFn41U/NJ7sFwEgGB0CC07BiS74inYCsYefiI AjJahzq8THOyFozk4+qRP1lw7X2W19bXmuKpk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753180641; x=1753785441; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; b=dLYyapBUuEzuXK/iWqOcSaycgsCDaK22dukNVjaihi4Zl015sHj8dbWja6c9lcgDHb nDhadah2qrOcXhhkt8A+BLEzTYDDl6+IyLoX6d5AG/FQmJh1Frd8xqJukZ4u5jcgYS84 U1YRRt0Kc5LHTHuZWhu3RM0ZK7W6Kv5NwubcHBDDLi+nPSo/ZYTjksXiT7wkR33tqDCt Y8glWXmusVT7iPqP+mB/4JmlCk9DVZzhI0Yn/qz1sRQT+X4ltxpiNqo9jx58qZhWQMSZ RLOPVxLb3cCfQY9E+yDArnr48fG/LsGrGSpLeJvKkSUNhJ5XIccLqV9wH5QIQTzYAF5B 6p4g== X-Forwarded-Encrypted: i=2; AJvYcCVhES6l2rii0pAFdeo9LilJICt+J81Jla8ULoeUsv1kfJkTOFkcQbwKTqUpI9B6/nNP6fzYtZgBjo+MGcfJ@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YyuqVvtw5TNGDcnjZZZV6xqUbWqp/yd5VZPaY7RJrUznfWG0gDo QWjbVl0lGU/DW6vpP9ErIS/XqphtsohSRjlfskwsI6ooMZt+G90ZLcez5SmzTpnv8WTlAg== X-Google-Smtp-Source: AGHT+IGsLBr6Oj77mlcRynFLhJjRKV3v7cn1p6dFAax+lNlsjPTF2VAikgLThlof8D3v4y5gCASHxg== X-Received: by 2002:a05:6402:4404:b0:612:c73b:17bc with SMTP id 4fb4d7f45d1cf-612c73b19fbmr5674780a12.3.1753180641100; Tue, 22 Jul 2025 03:37:21 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AZMbMZdsWMx820FPu3gjhXgtXVHUK7ntex/IQSUySkTGfxWVBQ== Received: by 2002:a05:6402:13ca:b0:602:104a:c090 with SMTP id 4fb4d7f45d1cf-6129fe4b915ls4198584a12.0.-pod-prod-05-eu; Tue, 22 Jul 2025 03:37:18 -0700 (PDT) X-Received: by 2002:a17:907:720d:b0:ae3:c767:da11 with SMTP id a640c23a62f3a-ae9ce17e845mr2376706266b.50.1753180638627; Tue, 22 Jul 2025 03:37:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1753180638; cv=none; d=google.com; s=arc-20240605; b=cA/TIThbOQOgELM1R+/7nM7Q6C2iaRl7yQ/pR3n8yB+1D7Wef1VK5z/DyX6C5JRMYB fopQv2GSqTyJUbSKY0GKg66jG5LGKvFAiDDgbgolyGPvYPaAaXFbFYVIPNdMiLDRVe/j KTntRBpTFLhhl/5jFBVCMYCMxFyVFtUu9hG/QxEFx4eU1+/4fOmI0hDzybv8pWVxvEfI BuHtn0UtTq4IAV9AHshfvjaa2cqsi2LsVW5a2TaZzF3Lm12Usp/0EyIT/V+8SbqgSeow kgdTUtz4g1fQkwOIxiCj4YEQfEOSwrw/zMpnyEGIbsDPTw/PiSaYXEAv//RavdfFjFMB HM9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=B0R5rRW0Dwv8g9EBflVK6bi6TKX/71M89TmluJsUG60=; fh=4gXLHhtG5blgxpWML+oiv0GiMs5uzMuOuNd/RJVWDWw=; b=J034O9Jrf76p6sCSTzwwXO5YyEAwybNjd7b1vI4NtKW8fElVfPCCSKx3yH7PXgFAzM yfeuCkninSl7jprVhLIgbNdCKlH1+n+HrLxO3s0z1zDzCpyIr4hgEpO5lS+oZLlD8Gfk AzkzUihJqYrPlJNY7B56qYtQK9TGSduhD0rLeCoyc9+EUVP+umEsENpegDyn7iWPgz5q vc6WiIo3Dv9EFSCk2JnDyx9Sw9EqmJItqngZv35aOKO3LI9C57XOCKRvNouEKfT6RFcD xJ217z8fZ7HeHifGYEUXSCC9Okny1XTkMeufLKwX0QY5rYTNpQtnPJj20saONhx0vCoI b3Og==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MYUKn22w; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-af10243b6bbsor113528166b.3.2025.07.22.03.37.18 for (Google Transport Security); Tue, 22 Jul 2025 03:37:18 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncsdH1gu/J19CMy2I6jYzMuidk52cCy1nbcRg29G2uGxrtKVUKGhQtYBW783PVL fdsFpBhfCvGP3E5c6Xv/aN9Eh3KYFftQGSX8e92K5uCj7dEQPyO41KbsIzJO3/uYxjluNwPohfr iQeRRumozuuIxsy/9nVRqASD0VPZVlDbztDLk6kr/p3P7wXr93DkWCdYjVh6MII3c+iUe3JtzqO TCj5axzoYeS5oVXKTwd+RGjRDVFxBozZZAxGOaREhNKlBQtkqpX91/9MrBMcg5CG0AkJTgsOs8A WfJdkcKqBMI5611UV78ijN2hOID6XmSGEnJZW/u53oXekevkAB/GnwEkOfkFLz2jWm8gyjA4yt+ vztCRBxLe5x5AiJZQYvFGTvvlkLpWR69PfI4hHLw8J7qphPI6A2rW7PBR0Ng= X-Received: by 2002:a17:907:cb81:b0:ae9:c494:1ade with SMTP id a640c23a62f3a-ae9ce199db0mr2520430366b.53.1753180638060; Tue, 22 Jul 2025 03:37:18 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:2bba:d7b0:8e79:c982]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca310e2sm844568766b.79.2025.07.22.03.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 03:37:17 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH 3/4] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Tue, 22 Jul 2025 12:36:17 +0200 Message-ID: <20250722103706.3440777-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=MYUKn22w; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/imx6ul_tsc.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..a6066643bd48 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -74,7 +75,8 @@ #define MEASURE_INT_EN 0x1 #define MEASURE_SIG_EN 0x1 #define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_DEF 0x02 #define START_SENSE (0x1 << 12) #define TSC_DISABLE (0x1 << 16) #define DETECT_MODE 0x2 @@ -92,6 +94,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -188,13 +191,15 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -501,6 +506,17 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "fsl,glitch-threshold", &tsc->de_glitch); + if (err) + tsc->de_glitch = DE_GLITCH_DEF; + + if (tsc->de_glitch > FIELD_MAX(DE_GLITCH_MASK)) { + dev_err(&pdev->dev, + "fsl,glitch-threshold (%u) must be less or equal to %lu\n", + tsc->de_glitch, FIELD_MAX(DE_GLITCH_MASK)); + return -EINVAL; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,