From patchwork Wed Sep 10 13:58:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4274 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B23253FA5D for ; Wed, 10 Sep 2025 15:59:26 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-628cc072d53sf3219045a12.1 for ; Wed, 10 Sep 2025 06:59:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757512766; cv=pass; d=google.com; s=arc-20240605; b=jDQ6nKyXxB9i62JYLPe7H6uFJbaDH85uYy+WLQvDjE66U8+Md/cmE0VSoAUnj0EPJ/ czqVKmStJ5cgyjvoS9BpYikwIqM/Vu2aERBLucgADm+Q6C6niKO8cHx0ChoYohIODh+o tMKiHh8U8aVJT7DtBdAlCbBIoO8uTVTgHWjpj5lfEbgkQbxQp0sd7fxD5kng1yRiY+Tl kQbFmd5jlgyiC3JSOzrkILqcfmii1lnL4GuTVs/2Zt6paMbyY3IYf+SdpqrBAF0VcBTi TozE4OC8BpGoyl0eg8ewVqonfI3+akJqvNyvlbKHzMSbpwxexT/jozn5hDSXxBW1WJk9 xGaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; fh=9OyKKFKmJ4lIilkQe0GBWB/W4FrSMXX6PpbXuNaMjBE=; b=jqejtFfkjxTaJUc8dPulpg+tOpV5DSdNd/2ae582dReQIFzvplhl695zJOCEgWM6EL wUCdz17m2cDX11+0MBzatyGFUpjmXmXGCAJFEqbXXnB303LXqTUbrk8HXqa/UMRBb8B5 lEURT4Ud7ApMHX0477MQhrUFjngXTz8aiO2z7hno1+BjtjuBnGvsTHBEnb+1PyOI5Bo0 syqfEAW7exxFvwG7ZXAB3OUGZWjpSsA7N6Cwz/OfLotNy5oVg7a17iWR+Q7r9MF1IU0v Ujliv/3r/+5gpc/r05CpXamQ1+KUAblmjw5mxTHFI2ERP5bYT0cgQ950I4GhVMnbyye0 cTFw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="U/W67J38"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757512766; x=1758117566; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; b=Gl5IfV4MqqXdu5UZHwM1+uhS5hjZ/R03x3+eP/BmYjGp2FDwRsyyqr1e0pAGhOoha0 ICWgwNNiT5ht3XVLGohWU5ZPrOAFlN1oLUx29dAOp/l6+tZ3GPg0WD80XTKEXZFaOdSz 7hg4STb5cNQ/HRHpUn5sthGEUetCtJSXN+Ya4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757512766; x=1758117566; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=caRuVMvZU4mj559QiA5FDIYylRJectxLC7J/y8bOFEo=; b=YMFcZZYiOTXKrzU7Sur42NHwQqBHi9yLtErGQnvGqs9vAlGdghSLpE8OGzWdlWqKwV bgkWT8802jcfEuAqCGK1++W0jybmUh4OGxkG9bk+7XXCNHVHQsngp3SSsTn0yU4ftAPw JxoxI7VW0q+rZWj2NT4F2NZGEJUjgPZXCJ2JzsQTszCdI5c97z/ieFHCINktH0HXawFw Rq2KKrFRLbI3jT8bUcUQyLFMzd9shSbC/3DOKFXAINY9F8bK6c47xsASvzJlZR57GXzt acCRFbJrG7vzJyT6VeCvfD2fy7osPRAwJP9czKYs2HLUBDOeGNFW4FWMPWhFRd+KVDRh hZ4g== X-Forwarded-Encrypted: i=2; AJvYcCVvuKm7RVCDjcDe41qvB+o1MOTPckiutJ8yF7uwvEOL7hDvMDER9I5EBDynQZWF9jRJ5+y2AbdwXjAtii6/@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YzQ3zGVp2mGj3rC/O/zH6peUfKAavClUaGu0GJ2qkJvrWfjeWSv uaAoEb0vPdks/VVaETx8lVRBsxr8QBJdCYHJeKsY/gOH0sXIYr52M+tjbcOKHPNWcnF3TA== X-Google-Smtp-Source: AGHT+IE+NA/LcPptmTeaj8qkondfytVBkuJeSkc3uxEpc5VkhUOvoUo/+Y4BG/yZ+pkfOHO/pYz5pQ== X-Received: by 2002:a05:6402:5203:b0:627:6281:e441 with SMTP id 4fb4d7f45d1cf-6276281e8d7mr11598306a12.23.1757512766053; Wed, 10 Sep 2025 06:59:26 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4i6LWbCcncdEknBbepUk8IYUjVOzRvihAjNsdfckDVcg== Received: by 2002:a05:6402:23cf:b0:61c:3fe3:ce7d with SMTP id 4fb4d7f45d1cf-62146c05117ls5078120a12.1.-pod-prod-07-eu; Wed, 10 Sep 2025 06:59:23 -0700 (PDT) X-Received: by 2002:a17:907:3d8f:b0:b04:6cf7:75d4 with SMTP id a640c23a62f3a-b04b1764321mr1833838566b.49.1757512763492; Wed, 10 Sep 2025 06:59:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757512763; cv=none; d=google.com; s=arc-20240605; b=bQkATBWZQmJq67GDjOdVYVCGkTCcrbf3Ax7yHsyULy/r6DrzXsSfgtnPwq9r6a0DdU 0Qf/9/x+YWje/ROdeMZG80GpoiiCzGCsiHfhnsENPxGlKZeA8YJdCLiKBt3So8SVfztV qKKPMP1IrPPWswu+5CiiinUFc0p7PJIQoDfW6CD23xoSc9TxpsfbUL33u5mJjsDPAc3F d7iS/Nxfn+ymZqAzjMFd7nX5SCOkrUys9HXEnXj7Uf5/3+kHWtNLLaYNJ5MQzrBEGEgu 7+Ai/s+Gf18tDnnocii+7/RsCpuhIHNtvONp0HxpmG6dQZkAhBQH1xS+7m9Lcaze0JzI lmrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=B0R5rRW0Dwv8g9EBflVK6bi6TKX/71M89TmluJsUG60=; fh=4gXLHhtG5blgxpWML+oiv0GiMs5uzMuOuNd/RJVWDWw=; b=GboIZR+DYpj4ViZx2i/OmdqYrdjO43dUhWxKHAghZptiqCEZCgxJ36fxIrwbzzL3LF DmsP588F5lnmrPTy6udPBTlokwwDY7zf6wUETQwE6LUK4SPd/i7bMdXwilJwnHkSPun7 k0QlyBlWJmE+x850akEwuT/P7FPPlHPUeOv9I2JEi83YvB3rEPJ+70brIzgPdiM2wwRt rLvagsmRDFL7eOLJrXPmTJhfUkE8KBQWReBFW+HfvThOY8fhzmMYNGOX+nCpQugigfZA CKRaVZ2BHSsfuZtZwa7owin7ep2gsHr9lYTV+uGe74qKEPd2RMDFnDnKiF0BjQ+vMmSI YLsw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="U/W67J38"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b045922c96fsor823512866b.13.2025.09.10.06.59.23 for (Google Transport Security); Wed, 10 Sep 2025 06:59:23 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncu+MQZO9S3IVma7dA9OkLgM2PD2zRcp0OYLkTRXs4NzHknZHQdHa0NyKUSjcZ1 2SNzjJnuo1rcQH1UPQKNsWm93dT627gLC+X+4Mhp04pvQ21pmokLMIcVPA5Lq2wVCzEYJfEOrvy lsrP/YsatmvH3oS5T+ha8/+woqXOiQvVV0ZY3QG6Z1/9WGkeWI8mA34XiFune/H878+d9dHsich hPV7cxJJcZ9UjWB5msafUe1/t/vUvl+SeUl91v6gifW7QQaql4ie1+d7xynRT2SiUv01Ln7C41g wMTtAA10KUewyYUqCyyBPzwXus5vQxbOXQrGlEblKiOZ9djOhYjbzHF3AtWzw4Wa0Oc8XPXTxL6 1zcvFslJ/mHSO6fQvroQhYrFe9be+DgtNxBhiEX3xKpPkirt/dtd9/QAxPBE8FKxQS9c6GEoSz1 R90Or9pn+Dp7Bsv0wtpzgMQG9su84/iA7Rdg45jzbwR4uRlyboyox5bX1sBcBf1bfA X-Received: by 2002:a17:907:1c25:b0:b04:5c90:8013 with SMTP id a640c23a62f3a-b04b173763amr1525363866b.45.1757512762970; Wed, 10 Sep 2025 06:59:22 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07833a4e37sm172523066b.76.2025.09.10.06.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 06:59:22 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [RESEND PATCH 3/4] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Wed, 10 Sep 2025 15:58:37 +0200 Message-ID: <20250910135916.3939502-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> References: <20250910135916.3939502-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="U/W67J38"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/imx6ul_tsc.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..a6066643bd48 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -74,7 +75,8 @@ #define MEASURE_INT_EN 0x1 #define MEASURE_SIG_EN 0x1 #define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_DEF 0x02 #define START_SENSE (0x1 << 12) #define TSC_DISABLE (0x1 << 16) #define DETECT_MODE 0x2 @@ -92,6 +94,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -188,13 +191,15 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; basic_setting |= tsc->measure_delay_time << 8; basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -501,6 +506,17 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "fsl,glitch-threshold", &tsc->de_glitch); + if (err) + tsc->de_glitch = DE_GLITCH_DEF; + + if (tsc->de_glitch > FIELD_MAX(DE_GLITCH_MASK)) { + dev_err(&pdev->dev, + "fsl,glitch-threshold (%u) must be less or equal to %lu\n", + tsc->de_glitch, FIELD_MAX(DE_GLITCH_MASK)); + return -EINVAL; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,