From patchwork Sun Sep 14 17:15:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4284 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 56B003FA44 for ; Sun, 14 Sep 2025 19:16:22 +0200 (CEST) Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62efab531d8sf1411445a12.3 for ; Sun, 14 Sep 2025 10:16:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757870182; cv=pass; d=google.com; s=arc-20240605; b=UCto0KVXn0452znKNXUbWUoU/844VIbxgiQJA5txYvlkt/QYbjo4L+md2dolycNbLo CsRdRdy/NxYPu1jYnRDC7sR0cYjyO0HNzJsbAteqahyghFZdi1XWvdpBLFvYFF2/3H91 MHv84OGqME8XurPzzgwoE1iEjLyC1tXgVHTs77XDfxtKChAvzPeo0hX/wZp2B6HmJ48k yBFkRsKwHSNcYUX50cTn9RUn4S7CJ57zuFnvsIEPsjJGow1paJY/zajyoYamvRUUKDpx ENOZxBKXC9wQy+2eHoGeW2EE5nsnK4qRrAKCeXdCrdBwpQfYMoRMlgu+AtkgVbf7q4s2 TvPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ot3VmZ+boF1x4NVi/L3plaINCZaH97iELO+mpw22L94=; fh=12aTbU+HkKh6QOWrDN+KUcGix+A3WgA4RvTsYkDVQ0o=; b=VLZUXlTpuBz/DgQdHDJd5ZkMKXtt/RTf89bu8fe9+3fc90hYB7JFlCiBVsy0abIfik UkM5ZAx8UIWHVrC6nWhMmBywTmmu5OtNBjrW6fwMpGRIAsf+e5TglB4nT+2GI4D85mUi 6lxDBCLWikul2pOEL1JfwRMecobd12edCp/iifBTtR+4gQGCCiUr3Jeck2lzziX5h9sL NZnZHPb0CYFHnyfBIe6eewoo/N8VAPSQlyfdKvZm6UN1zG00CMnJDwC1lOEYtG2KVsSR rKg58xRW3AjopXuz/VkIJgcfROa+Idl6xH7YPcF1Hi1d+t9pck/vDc41sTU1xNnn/qdd SI7g==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h26Ojo3O; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757870182; x=1758474982; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ot3VmZ+boF1x4NVi/L3plaINCZaH97iELO+mpw22L94=; b=afVBJezRdBegwk1H2+nBdPEmHvd288bLe3Y0c+nxq/0ar4qKM1uJUFLVGejQ8wyO7s +jbaXNMz72fkoyK1Q7IhEBxg6nq+g+SCHx0bB4qtnSKDlbZU8bqr0a1/0xqffU3K6cVw FnW7L34vZD3Cyen+ioLENymqtgXEA+DdrEquw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757870182; x=1758474982; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ot3VmZ+boF1x4NVi/L3plaINCZaH97iELO+mpw22L94=; b=RQvlT+3Xe/yB1MWGrHo0z88C7hZ1aHBQsSaooYkHD9ufAEkr55fmODQNrs097QWSxF qb+Sht2PkQFW7F4Ek3er+AB0TWg2gOljFBbdGAbCQOQ1MYGi0WhEiytaVfVwVfY0wbfp PkoRd/rQN6obcy6sccKN/Yn++K5oY4/YfkRHRnD+DBhC3rFkG5TbsXp4aeu9D4FOXkgs mv1RjcEbAbFZNK6LvT1yqdS0yJ0eFZ3ntKGKuMNI0VAe5AzqtMm2uuIzvz9tXVHRtxH+ RHcUhj5I7t8axQR2cKwivWLbSdYTfibgR3AwZFBoolA/I0RYgNdRVX4jTiUlO/DXg4u6 4GqQ== X-Forwarded-Encrypted: i=2; AJvYcCW6u2gL9VXyM3sp4wJxk+LNaEIZ0aM0nZS7EV/bMV3XROO7JXI0c+ehmgBtjilABBWNNRXGuBIlfAjh8tUW@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yxv1qs505qjUduZqBMRazMWYJZdQIjZGEQ7GN2t/6IixbXA1xxM fJm05Zf18r86PhcT598nVcLjq8JLZTBREF60EfAXPJqbKw4qRFrQH58Pl00eSfrPcdIdBQ== X-Google-Smtp-Source: AGHT+IHLHn2pIhXLZ2NKJWx0nFJKfOjGhRPomRu6pQU6M2gF8IDEuRAGvz8sJsT6bHN24s1rDusrWQ== X-Received: by 2002:a05:6402:34cd:b0:62f:2c1a:920e with SMTP id 4fb4d7f45d1cf-62f2c1a94cfmr2728553a12.28.1757870181743; Sun, 14 Sep 2025 10:16:21 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd6ZkMrDTo8+sf+dh1elDbDD6U0eLvxsZSg/AUeHjCbY4g== Received: by 2002:a05:6402:a0cf:b0:61c:ef7f:7d32 with SMTP id 4fb4d7f45d1cf-62ec03bacf3ls2795604a12.2.-pod-prod-05-eu; Sun, 14 Sep 2025 10:16:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU+DvW3JIPDpLVg4CWgMKYl1OQXfeJQgSd41dz5X3wam5ylRo4Z1OBkeEbSgva1O/3XxJEPELpsN5OIpEc3@amarulasolutions.com X-Received: by 2002:a17:907:d90:b0:b04:858e:c200 with SMTP id a640c23a62f3a-b07c37e11cfmr940579566b.32.1757870179264; Sun, 14 Sep 2025 10:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757870179; cv=none; d=google.com; s=arc-20240605; b=ij9Hu5pnEJibwkW1NSL1UUNW/fLVC/e0sg/0b4b87sVGFwRF4xVqk2VwonmJWnkuHR c/urCcseAVyxq+WlwukGYNg5HS6RYiKJ/6ctuVngoMRPP/pa0IuyVCLVPvOjjIG7jm81 C8tXJO2BupWJNYEYAGHVXwq4BMORtNIJHLQ/ZadmC4ZrmtElN/JT5pTG+8GT5kOP0pQb MYwB1v+oPHbdFlIKpxSH05cSZg7EKrRY8+o+JKssvcv6IlRjLgkyHTirJL5UiMIiTNlg jruLxDSJvaO733ihR//9R8y0g1G6tFO7OedaZVhieHmKvMtSpYxXFD1qLyjIbEJleNvQ TTbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=VnBZKBOJmiN67eQQM1Bf1khwvZJgal4hwMc9eP3h39w=; fh=gLSIshb9VzFk3mkgfXzx0b00rwFxwO/rjRKjOCeSzDQ=; b=k24BDbLDNSyaIVAwa4we85Bi++Ffxsnd029gPtyQtUo+B1WPOVdQ06CBdLJU4ZYR8q dJOMrIA+dI2jV0c1A3/zdD4mNs8mHhIDpC6LAC2ougi3XZUDabgj2Ad285X/PexhIRoE MyxLIXHc55mCQjv3xCKRBP5qOb+TCA0R0JVIHMmHqyjOsf9WKzvbhGUqTl2fUOoOyhb8 Ojrbu9/bpo90XHhCyD2iXx7MvzCosYaEvuIiRw9vHtPw/8M9zpOI6ft0kYDmj5fjGk+A C0BAGx/i9tqFNvw55VBhviMlr3cz2YuKtSUppzz3diUwlxcjpZSCao2G1oUSapIyU63w 3l8g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h26Ojo3O; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b07b31280c7sor284169766b.5.2025.09.14.10.16.18 for (Google Transport Security); Sun, 14 Sep 2025 10:16:18 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCUkmyBFGQNP2tUlcctrPaf0AV+Z7rYgM2MXIQlyAo5w1KrVfjUJvGgwIya0ejqrO5CO2lcUQX88lOTq1Hhm@amarulasolutions.com X-Gm-Gg: ASbGncsz2E0+2SBUWKXtXMLv6emVSvxI1WvWNpGy+STqmmVd3azuu+rBcCY/tQGKeZ5 oZSiXJAF9HtbY9VwaVHe1Lpdftm1hZeJejzGt+T5NFNg6rMkOgnA1JDi0p+xIkFLV0Yl66p89T4 E3xpH/15YxkA2FWPTZKxLCQ5AVX6+zwRErSbDYopI3dU7vMNBZmYswB9YDdVV96qykpu6XhvTmW Hbrq8FHq12Na11Rqetcbt3Tj9bLEaybRLLEtAM0ipkpYddNV8BG/0fJT6gsA5YwvXezc9pFhi9H xALmL1x5V3Mw0ou0uRqLp+CIh210ZdNgUL59CjRaSOn4pjLGluFpI3fdHMuxMAZyG/Qi7vS1rTb HYyHWVZJjXLrqG8DZ6ZM2EtTv1Bz4LcbRIWvTTBPiBnfEPeabsqKbYD7aL/aXl+5rxqOX8hkDls um3XZW71hI0TZ68+8ZTlVoxa5eD9xppTMBRz59n1wiZJBI52Av642qayzeqCAJ+agP X-Received: by 2002:a17:907:2da2:b0:afd:d94b:830d with SMTP id a640c23a62f3a-b07c3a7b887mr976251766b.62.1757870178516; Sun, 14 Sep 2025 10:16:18 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b334e76dsm776980466b.102.2025.09.14.10.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Sep 2025 10:16:18 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v2 2/6] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Sun, 14 Sep 2025 19:15:59 +0200 Message-ID: <20250914171608.1050401-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> References: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h26Ojo3O; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v2: - Add Reviewed-by tag of Frank Li. - Move the patch right after the one fixing the typo according to Frank Li's suggestions. drivers/input/touchscreen/imx6ul_tsc.c | 96 +++++++++++++++----------- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..e2c59cc7c82c 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -20,25 +21,23 @@ #include /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -65,19 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_2 0x02 +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) struct imx6ul_tsc { struct device *dev; @@ -112,19 +118,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) adc_cfg = readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &= ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |= ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |= ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |= FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |= FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &= ~ADC_AVGS_MASK; - adc_cfg |= (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |= FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &= ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); /* enable calibration interrupt */ adc_hc |= ADC_AIEN; - adc_hc |= ADC_CONV_DISABLE; + adc_hc |= FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); /* start ADC calibration */ @@ -164,19 +171,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; - adc_hc0 = DISABLE_CONVERSION_INT; + adc_hc0 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); - adc_hc1 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); - adc_hc2 = DISABLE_CONVERSION_INT; + adc_hc2 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); - adc_hc3 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); - adc_hc4 = DISABLE_CONVERSION_INT; + adc_hc4 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } @@ -188,13 +197,16 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; - basic_setting |= tsc->measure_delay_time << 8; - basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |= FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -250,7 +262,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) usleep_range(200, 400); debug_mode2 = readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine = (debug_mode2 >> 20) & 0x7; + state_machine = FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine != DETECT_MODE); usleep_range(200, 400); @@ -278,8 +290,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) if (status & MEASURE_SIGNAL) { value = readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x = (value >> 16) & 0x0fff; - y = value & 0x0fff; + x = FIELD_GET(X_VALUE_MASK, value); + y = FIELD_GET(Y_VALUE_MASK, value); /* * In detect mode, we can get the xnur gpio value,