From patchwork Sun Sep 14 17:16:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4288 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 729893FA44 for ; Sun, 14 Sep 2025 19:16:27 +0200 (CEST) Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-61ec9b48225sf520079a12.0 for ; Sun, 14 Sep 2025 10:16:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757870187; cv=pass; d=google.com; s=arc-20240605; b=YIxiEkVTiE8yo70APHWduSaBInsCbVpbQ1loJAc551XrecfLtR3T+RnrQn0nkCsmFn fav+MlupqozeHHcK+yjDD/aITuOv2qK2uW3NlVW8hyFH2YBcl5xio2tPAmQ8zOMn8cVu nkJDizz3zxjjtbmobDmQtDJ4UlyymmhE3LRlcQj8JlQiuzkwQqvjYnzCD6UtYNV5vYEd tb//x9rxTq2yGuEXzxjY2Q1JJdNS6tGQy9Ip4sWxMgmMyo8IjAd10HXbPL7I8cuEQ0zD 01AffIsYurxYgCcbVkfyOAd4uIjohpz/0BtXtGkisk164zHQ7hNFt0sxVqAgxB735CyW VMgw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=9htcS0XI4ZVUOslNeh29BCh0vYUNMn0q1GDj+Xr/DJE=; fh=n2Vdyw4HBsjhz4qesH9jhHOwop6KAi9661iQcPoIoU4=; b=HT8fo3HQifxGeOYN6CH6fsblbGLAcjIdIPC/589t2VNcN/Kzwu16HNua7FsTBawVTj 9w7+lAdwfl4gvVzqyqfwqX3PVdccIec0WQ8NPfiKGt7NLFL2t/7i77RwQHzk0/mxSjzO 2h9/iff5sslOARqfwhSQ6b4PlENRkkNoj5GAnExu8IUgnqxJlLPJjymN+hUlBBR/0Q2w ZPHt5VZiUmrFmFglRpX1XpmGbYfIBp1qEGo7dM3RqKKS69+BcYW7DBg1cRgOMh0sVlt3 Gmqg5pfBPW+kuEZF3+K4UqHdmjEuNaWL5HikMczovZUfABaYjWM+xAUo0TP69qfO4vad HIKQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lNekeq6m; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757870187; x=1758474987; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9htcS0XI4ZVUOslNeh29BCh0vYUNMn0q1GDj+Xr/DJE=; b=AmeU1HMORpZQn4EI9D53cUT1vwwMrXr+50a79qQOfOYJ8tstQin/yjYAlp+SuWvAup yUDgJVeF31WQUprMG7pmpLWf2Cmei7UMjRIZtoomNma4XvLrpEqmnj+BLgphslgj/4eV E9HAeCLiVDJGWyMLwWOBMdXTVce0l+a557Tyg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757870187; x=1758474987; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9htcS0XI4ZVUOslNeh29BCh0vYUNMn0q1GDj+Xr/DJE=; b=HG6stZKpfouglQEV9a0gUUX3zSiKj4H0qgMr81U77xtHUivSubO9mRmxg7EFh5moZ1 UD8Z3sgaktwRaim5FmcVy1Y+e4CYjiTbK00Hd6tIh7/f6vlDaEp0txl/ESi4SWWUQo9S dMJ8WeX8UQLMK+5nJldDFCsA3/e91xc90g5BbZiEt7EYoqX10fIbl7RmvJFoAXJxUtSc sLkKpM/2Wp+n7NxOfdLauIhaegQUARIHlR4MkzQzPCBInETezq+EhlGT0Gab1hWXUIHB 5AElFIzPm7AGK4AFNDcIOfX9uFCqw9r7rG4puegzIzJ83k46XhCtrjS9Ay2Xc0hwZvYQ 4fyA== X-Forwarded-Encrypted: i=2; AJvYcCX8G7mg7dGulp1vLJsBmMNZuNQECPtniqkhCtjkL1njifUnqTukfz8q9Q2CdXATrQzBNay8YM5PpiqPaTxb@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YxPehHoQcoPSWhXpO2eclUTe65BwfMrfdcBAMMzA660F1t5ey7U wWbW6TINK6dpNg51gwRJi0CszW2gjB9e4kCUAW844CtxEJWYCpW3DTnnAus4Dw7X+8O5Tw== X-Google-Smtp-Source: AGHT+IE/aECZWBlYiFMVmRUMHn94YVJOTYxK96KTaA8WzdobpKZC5Q5dQl9IbZteajN8Yhdw5ftsjA== X-Received: by 2002:a05:6402:5211:b0:61f:2ad5:50d7 with SMTP id 4fb4d7f45d1cf-62ed82fed26mr4983383a12.3.1757870187023; Sun, 14 Sep 2025 10:16:27 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd6X7klKyG5DH+G9K4eaeGa7ZO/rl1OADVC7vsDz6yuWKw== Received: by 2002:a05:6402:505b:b0:61c:bbda:af7f with SMTP id 4fb4d7f45d1cf-62ebab26cedls3849224a12.0.-pod-prod-03-eu; Sun, 14 Sep 2025 10:16:25 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUyRgPiEtBfa4KQb0pez4neI5lKAaMqND3hIkHa8GFceYbdUkaBV7XYo3/TKMFkK0/uYTONzPqEHtTLjD1/@amarulasolutions.com X-Received: by 2002:a17:906:478c:b0:b04:2533:e8dd with SMTP id a640c23a62f3a-b07c3a8c7a9mr961644566b.60.1757870184711; Sun, 14 Sep 2025 10:16:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757870184; cv=none; d=google.com; s=arc-20240605; b=eoUxY+zjJys9pY9iCzWq98J97w/Jwn8ExcjMBdClzzLkflyy/EejvVcrFkSf1/qMDO lE5HtvadpR0c1iv09NWijU7PgsNetRGH5I4NrZlHGQ4x2yRS31IgIlCfOJKtNHyZTh0G vvK0fbq3vEamU9T/poR8REwJWrRHJH7sHIgeXEioSJrd/74j/vdkUSFu5IRBwi1kJXMH pzFxYzO4AnYdUlUjZXAZUd6YRUssHHdWWZYh61zkgGUDpCJRr8A+QDHsnVO4Y9hnfQ0D 9UpZLFXlIx/sUYOYL74pDDg9GLokuKaYfh5t3wDryJ6PwJuqYBeeZ9XOPIdp1ib5czqf SWnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=VeIUZQnFQ6a6zAGoQDZv+bvlaQadCTCZH0QLhkeT9NE=; fh=tdX/A93tEDTqpHwtJ8vEVRZXOehiaNB/m5tTixCHvio=; b=AwbSlB5kzZIKFm6BE4gM8I0zsLwjPI0lkJIAnRVGc6tQRvyL+FODRtNRqf62jy9TOf F/MdOq9gH2Y1GsxuZUbr2DLVBUZiUm8zAJT0f6G+2XIHLx351zB685V0OnJa86IhFz2z YUkddnvVCOmS2/Nc8n19Kx5touPGAjk5NoPlznELLDlWsf5mqrVC8XzkTHxZ+pkrZrTr 9WTU/Yd7pyE6vHjFWkQIRYECeRUQvdp32d2kuFh7UBWZ6b24RzzgzmD0YpUCqDotQ7tB Eye/HFz0pjXUE/qMAL9KkE2wg5VZqdUDx5T9eGGMcFt6Sx6xlF+JhFLfcBD2nC388mWd 267A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lNekeq6m; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b0b77347d49sor107573866b.7.2025.09.14.10.16.24 for (Google Transport Security); Sun, 14 Sep 2025 10:16:24 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCWixTo3LEFitPXiUbAgxpWIaSDu7SzDQJJx2u8C5BiVdJwUf0lP56oQei4/Sdu+gdh0Hc8g3bjPIcWilofw@amarulasolutions.com X-Gm-Gg: ASbGncsIkdZdPGbQtTxZliBFXyH3L3tK6+MRpx7/TmorVIggErSN60MmvCrkSqVr3XI M4c055Tl9bJuw17P9e2Ll0F/l2LuiHDo0LwfHZU4RdOp0p7YIy/+EqWFpDphCVTam2Zb/maHSNs HeCy+7kCHxROzlfysaiieNY32BPADOt+kIdmUKRlOa2uH2KEIR7z440k97uBzOmmjC48VI1nsr6 uSd6S+av9G3BmalohDNuDOyaUKYV+z2C9bCzpNS+agKhcgY26gABQwE1TU6tNdDSOm+3McJtSW5 mSAJlr76qGBrU2Bt/7vUZupMl1i6YmUFEekDCoCZIxyU/2SckUsIcEhExUBPJYjycUHUM+UuW9u oFZEKIMWbDdHqK7ZLCjeKxRAXKpCEOHuQ3GX/DcaQCD6LnXWv8Qp/Qvpekm5k1ZIr2RNO7T4tsg dMSa6/cCuPp688ggJfEuv7U420YjDMsjnvD3RrBov2d66/a/hrztsGKacKNAzjyTOW X-Received: by 2002:a17:907:78b:b0:b10:aab8:3816 with SMTP id a640c23a62f3a-b10aab8432amr71331666b.32.1757870184256; Sun, 14 Sep 2025 10:16:24 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07b334e76dsm776980466b.102.2025.09.14.10.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Sep 2025 10:16:23 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v2 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Sun, 14 Sep 2025 19:16:03 +0200 Message-ID: <20250914171608.1050401-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> References: <20250914171608.1050401-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=lNekeq6m; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi --- Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index e2c59cc7c82c..0d753aa05fbf 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,26 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "touchscreen-glitch-threshold-ns", + &de_glitch); + if (err) { + tsc->de_glitch = DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate = clk_get_rate(tsc->tsc_clk); + + cycles = DIV64_U64_ROUND_UP((u64)de_glitch * rate, NSEC_PER_SEC); + + if (cycles <= 0x3ff) + tsc->de_glitch = 3; + else if (cycles <= 0x7ff) + tsc->de_glitch = 2; + else if (cycles <= 0xfff) + tsc->de_glitch = 1; + else + tsc->de_glitch = 0; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,