From patchwork Mon Sep 15 19:53:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4296 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id 282FC3F080 for ; Mon, 15 Sep 2025 21:53:57 +0200 (CEST) Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45b9a856d58sf3788205e9.0 for ; Mon, 15 Sep 2025 12:53:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757966037; cv=pass; d=google.com; s=arc-20240605; b=LUQnAi89nlOx9fXpAooamY0rgyyJUJzWxkrzRjWTNNCi+EWhqCrBqj2xS9r91kdOQV HC5iZlovrNkKVqJc3s58PURdA6PzVeOcF3Ry8LuZPdIZrGPUy8oh2Asbx2kpN9TtK4AJ /3mkC/JoWylUwyh995jBl1ha+0hbcpHtYC7nqeFGPAGmCzfPnscr6gLeyaae596rvwtT aHYo7/AC+XcxsmLtP7Ekd/HX+BhWbyjghnCy5Cm1SdVE+eJiHDBHUaz2CbDsI8UeglEz O3CIR5ZW0DG/0mDOcdbmlaFdtmhTSvwcSydyVGIK07OD/fHXrxyCjgO/kZnYiZI6KRRq oxUw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; fh=P3JVgG4mAYCIQrkn29lsYs2z8mBCszPZpnMQqZIN2C8=; b=bb+WRIP4WIMS/bVy0S2vpNhi41OK6L0R3Kp/0QJrgA+xJPZCDK14Sqpdgl0wfeK/Cr PDNc/iC8ulm4pESKmOpnHH705HO7UxHIz7XYR9PvuQ1/d8LofPLMpExDpSd9RHVJ3/vK ZgYbObMRA7Ft5cvxNIQsm4o8F/NsdQlWK7RHyQPt0ycmyjHel37wvMeMH4OT8A8KC0vB Dk8ZXGB8EAlMkURmdlo+2SXEkMwx2lZHV1uXU206OPDeuCbQ2iALQv08UmNGq0XYmNgc bnvUbLmiViSGE9SQJ246nPPclmrPvpFWXrlqdtBypwjqJWriOmLEwTt8T2X5bnWvsHaR gg7g==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=oXbkOeC3; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757966037; x=1758570837; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=aNm5CAvmg6sKm4dVjV1MSTnCd7MMCnhmDf0zGTwUixuNhkUkQvomH5clXsDRCdB6vz vEA3E2gFpLZW8HIxhn8CpIiVdxPmB8GyxI9qa6129jeddDA9HCEMQImwIGBTyQj4pdtE xPvf33s6lbnjGRP6Dk9r6BGItBTjR833DUYK4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757966037; x=1758570837; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qN+uwctul0mboouksWJmgzE4mbbYiYLV+2AkFXHilkY=; b=nyH+3jTb7pZjocRYk/CUweLbmIGDHPCdZJVeP0MAX6h7fHHhF4JHA7osLUaQaS+8J0 jiyv7Yo0O/OzuPRf57fARqmrGoXtV+Z9vwGC5q9aXQTv15OaGTfOhSfq3nyHeJ11Gtgy 5jUefVgf5laIQ/H985aLXTO/35ont4xVYUSrwdnlYKri/GMEiRGiQn9XFGfbJ+TCidhU OmBTA73bKafxGJsgZbiRQSgGUpLdk+xiSdBJnyFfDT4J1iUrkKr2VJz3mEBCJ9oka7AW ucIo/zr62ZBc910bRPAVvK3cqxox00hl7nF/TuLmtVDA9phukmynhxWa9KvRpjWmoKBg rVeg== X-Forwarded-Encrypted: i=2; AJvYcCUa0CxFNtNxeQs5ZPaA7tV8GSBhnLds3p0/5xcOWaE9dmQ9sLZ2FlFDwWdw+9Nc6BaaHnJMKk5dGU2CMgGc@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Ywa0lDjj4Y5MJcRMy235I4XoL/F+bfSfzqRZboidRVt1VuiKBey yHyuADqu/dZkuM1RV65W+/qovP7RCwXzyu+W1nHr5KOptsxRaJmjXv43aGeKRCxiiFHxbw== X-Google-Smtp-Source: AGHT+IFdyD2ZQ23bUJEqE3SOzT2qYkksKKhf2KwU7UYnO/tbc4Nw2uQqiyWVubbteI9mIoRJn+98KQ== X-Received: by 2002:a05:6000:430c:b0:3ea:87f8:da54 with SMTP id ffacd0b85a97d-3ea87f8de98mr4354809f8f.33.1757966036713; Mon, 15 Sep 2025 12:53:56 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=AZMbMZeD7aQyUTq0QltHTnbx+IXrBYggVPcfohSjUqxBkvQmMQ== Received: by 2002:a05:600c:1e22:b0:45b:4b3a:86f0 with SMTP id 5b1f17b1804b1-45f28dc3b29ls14854645e9.1.-pod-prod-07-eu; Mon, 15 Sep 2025 12:53:54 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWcbiyIX1nmCRApn5XDOkh+yN97p/3ZqrjL7lBzIuWq4arWcYD2RNjWvU8QaCYZTacEbYhfLwKTWn0SxNkt@amarulasolutions.com X-Received: by 2002:a05:600c:a47:b0:45b:47e1:ef69 with SMTP id 5b1f17b1804b1-45f212089a5mr129527125e9.36.1757966034370; Mon, 15 Sep 2025 12:53:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757966034; cv=none; d=google.com; s=arc-20240605; b=OvFXbfmxFVtyz0EMO5Mz20JJD8dQBNxgPEUJ6uyfb9lPlov9OqhBMst8VKS+4k3QI6 7wk7b0CzbQ3su5nfDrd3ZFgE7RrTtVTLsZsA15UW+eTYXstXPzOvHCBenU/99nv1eaeL 1lqyQ0hI9r8eKgXVee9JMKS1MR/1bOsRKlap6GsKM5vAwn+0kejHGLtXpFzCWcca0BzW yiR/GSl25rYOkHBT/XgbZrmpI9N3luRm8onNSmB5er6j6ScC+aNRdDnqKR5gdtbSI1RC 1O/huP7uVHGTPkPPoTAbjAg59WTdj5iGLDBsqGsywi57bF9HprWEaGynXom9xMY26Xwy XNNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=kDNPkG1BJO1AhX7f67y0O0jm17yTyZBB5A5XJjEod98=; fh=4r2FKoJYVAAk1ErAKinVOvyBq9BIubAQXF71UbBHRlQ=; b=J2K+l+z9d49g1r5lYkweYlBFUWfS8hhhxZjmgLxfjxf29w4+LhjMyO9fS0J3vhuZVx SRYotgNfHXXQd5WG9YLelRqzTXHJfQ6U93g4OqMs8r01e68yCMLMtXSlOegU2ZiRgMah b8P7yrQpFH01XrImXl4pD8rR7MGlSE8tqrcz9zFhVJDPsmEj/l/7yVjVU6iMgijNJuIU EUEloX4oY9gKikMkZEQCf22CsK92k/CsVuskZI5twfbg6UoRvY3c7fAuQ53hYjjumaM4 AW6scF4b8ZZeSQZO+TAs5QuvisFh26mhlECKdZn3sAUqdmp0TBTxUt9FWqOCh/KUeDck OUdQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=oXbkOeC3; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-3e93267259asor1324517f8f.11.2025.09.15.12.53.54 for (Google Transport Security); Mon, 15 Sep 2025 12:53:54 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCWffJak1S/idT9K5xpwhBt15wU83u6JGt/MgIbpMpjKInONCLfjXuwbj2gY22PW+1ZLsB4qTxfGNSZOE8E9@amarulasolutions.com X-Gm-Gg: ASbGncucT4os3hMGfgLhkwdvvpKcY8s1vIcNNcLpO2Y/ZeRRhkf9TNFmRed3s7FVBvI vRx4yyBfEqzxcaj0W9f3f67TjfOP6cQUmedOyqYTlXQIfprF9aJUMzuZeAMJlvYNEbiLao1t4Wo odKVRrmB3Qwq5QxSJs1R79HeQ01x7cMWQwAEPJTtL5P3XdGAi7CzIXA/ptimiA99I0SgV1JM7eC EGBIvOk+OM3aWTSY19Di9vRo2RFBhILl4BB2MsgV0gzTBhSubwgoPngw+j4CNt7C/0JHZ8WfmbJ oI56NkAdVGegum6C8I0Lg1ekDAPXfD6P3pHUWRXKH5HacSQZm8a2j/3JU+Xkpsvm5IcG1yXIK4y Xvvl7Q1gkiQy+NoBTnp9DK8EuIILP+K8AadFCQesqEZ08iiJAbhdVNX4z0cK1T10nEWQ1FNf1Tw == X-Received: by 2002:a5d:588f:0:b0:3ec:1b42:1f8d with SMTP id ffacd0b85a97d-3ec1b422172mr1270888f8f.10.1757966033866; Mon, 15 Sep 2025 12:53:53 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.40.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32640f49sm530985e9.9.2025.09.15.12.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 12:53:53 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v3 2/6] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Mon, 15 Sep 2025 21:53:04 +0200 Message-ID: <20250915195335.1710780-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> References: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=oXbkOeC3; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- (no changes since v2) Changes in v2: - Add Reviewed-by tag of Frank Li. - Move the patch right after the one fixing the typo according to Frank Li's suggestions. drivers/input/touchscreen/imx6ul_tsc.c | 96 +++++++++++++++----------- 1 file changed, 54 insertions(+), 42 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index c2c6e50efc54..e2c59cc7c82c 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -20,25 +21,23 @@ #include /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -65,19 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_2 0x02 +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) struct imx6ul_tsc { struct device *dev; @@ -112,19 +118,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) adc_cfg = readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &= ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |= ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |= ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |= FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &= ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |= FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &= ~ADC_AVGS_MASK; - adc_cfg |= (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |= FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &= ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); /* enable calibration interrupt */ adc_hc |= ADC_AIEN; - adc_hc |= ADC_CONV_DISABLE; + adc_hc |= FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); /* start ADC calibration */ @@ -164,19 +171,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; - adc_hc0 = DISABLE_CONVERSION_INT; + adc_hc0 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); - adc_hc1 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); - adc_hc2 = DISABLE_CONVERSION_INT; + adc_hc2 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); - adc_hc3 = DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 = FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); - adc_hc4 = DISABLE_CONVERSION_INT; + adc_hc4 = FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } @@ -188,13 +197,16 @@ static void imx6ul_tsc_channel_config(struct imx6ul_tsc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting = 0; + u32 debug_mode2; u32 start; - basic_setting |= tsc->measure_delay_time << 8; - basic_setting |= DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |= FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -250,7 +262,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) usleep_range(200, 400); debug_mode2 = readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine = (debug_mode2 >> 20) & 0x7; + state_machine = FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine != DETECT_MODE); usleep_range(200, 400); @@ -278,8 +290,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) if (status & MEASURE_SIGNAL) { value = readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x = (value >> 16) & 0x0fff; - y = value & 0x0fff; + x = FIELD_GET(X_VALUE_MASK, value); + y = FIELD_GET(Y_VALUE_MASK, value); /* * In detect mode, we can get the xnur gpio value,