From patchwork Mon Sep 15 19:53:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4300 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id A05D73F39F for ; Mon, 15 Sep 2025 21:54:02 +0200 (CEST) Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3e9c932a4dfsf834417f8f.0 for ; Mon, 15 Sep 2025 12:54:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1757966042; cv=pass; d=google.com; s=arc-20240605; b=PW+xMDjMMlcPFMdbbny2TEw8OBwe6KpQ5C+s4e92if7x3iBObg3i1igoYiDzJKIrNk KbXUZ8aDZHGzBLrSQIO1iVtgn964xYN7Xgbhcm0r7vBUPFjK8sii2I0ILPZt2eWrf/U0 vGHpi+Gj0NJVZoUu42OtMMN4aR8eZkiod1xxPOD/2fnsxVsyQG1UVoh7i6f/fyzHhQ+h d2O2i8TKJa3C2nZBIW9qVH4PcA9MNwvGnibGFZzDEoT6onlnh7Z7yzmdbHN5mbuvybPu 9z5qcN8AzEBCJiYL9wAVZj6XhEOssJCmX0p7W1YkncE+aihPTL4gbWIm864GYu4KHB9g noCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=xho2GEbVJ6t7/hhJagNPkmIHSDQbTt5cIW6Z3kRphwY=; fh=rQ+G7i08TgUCcMxUhfb51mOPtiyasUExrYokvbZwOrM=; b=Y4U5xHsXolcz+nfx63RkWShk6b5zF/uZxID/K0QV4hup4dbwoM1+yvohnYyjkDXXPP VJT8cDs9VxwCGbUHyMGnfzyXkhMstl02Rd5ID6FXxCNegQLLMmNjlzO4nvwNJSTIdK/U lgg0Qp/0xuF+GFj9U5w4bv6gGVFMU1aA+acB1bSPsL03lqVJ3okB2aknPUE31BSVrUSh taJs6H1BE1PE/kRKaMg6jeJIRTOWgePLHkY1MhkyzkRr5hw7qXKuUBa0SR048jMs2ZrP QH9EDybaX9t9WjpCHLumhFOuJ420FO5yv/HctVpsCOwwkvZ7gdGK8M+MW5Rw/Mnly6in 3+Hg==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hsgyD6g8; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1757966042; x=1758570842; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xho2GEbVJ6t7/hhJagNPkmIHSDQbTt5cIW6Z3kRphwY=; b=HH8+6fvBVDphrorb9r0YmLLqW6+rF+iVWBHS/qPYvRu7DaLXS6hGShdv+AxqqEfbI9 +rdt2ef2gEkG9tsNLcgi9OVUMXkuu/2I1wEvo417u5hz18udfp2Uk8GsYbAV99qtZko2 DNuAjSS8HxvlfcZO9hgJUoeAtcIyGrR57fbV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757966042; x=1758570842; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xho2GEbVJ6t7/hhJagNPkmIHSDQbTt5cIW6Z3kRphwY=; b=u3tzJ5/uyhV1UO9fGqNCIxiMvtaM2u7pT5OOZZ2Ik1wK9Jy4rAdGlCSNWWLTSJmeZK /fmjkg6OR06u75p7DwpFDn2e9oAfYlnnvVNbRf2tqXO56FwUvettxUX1KIvkcudAHbJE Mg7JBG0gT3s/pyzHCrONOqh+iv6QSApCsZxMsle0SRkY5G6AtpNoYrieupSio6qe9tF8 DgcTDTAVad7MEy+Wx1vYoUe2YB75NCTS6vddVf9ZQpALLjd+JKOnRigKsukSN/47+Jh2 v+4YSWznws+jcXHjdeOk0AaVuGOaaDBKSgPNG6RB/DLq4YjgeWNly4hxaxJWV50BD4aY xDqw== X-Forwarded-Encrypted: i=2; AJvYcCWRSJzgSxLDZzI2uYZ5aRoeebFYDZR4aSernC/AABteJI65hhjpkISkGSbp2v27kQTmbQ5QaAEZnCyIzV4P@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yy9F53pzQWyNscDtdSyXLxqx5jeIwefmXE4Ksj8PFKtnLPwILL4 /iruNFPeIMU4yUD7b66GZHgtoR9/82PyzzABScPCZaoHZA9Eg1a4hrxKpMR+6X5QiCphTQ== X-Google-Smtp-Source: AGHT+IEcYo1DzoXhBV9H2RahdCjMWMkHCMKoH4SulS3CBFpXHGRKiVa0BkJWB6QrZyTGd2oM5ojWoA== X-Received: by 2002:a5d:64e8:0:b0:3e7:6474:1b63 with SMTP id ffacd0b85a97d-3e765a36129mr12880659f8f.63.1757966042230; Mon, 15 Sep 2025 12:54:02 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd4+Ye9temeUK/X3LcG5yuS0itGWgDTB6V2X6z0cr6VwcQ== Received: by 2002:a05:6000:1acf:b0:3e9:4a9a:eead with SMTP id ffacd0b85a97d-3e94a9aeffcls1010935f8f.0.-pod-prod-01-eu; Mon, 15 Sep 2025 12:54:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWawaV2tu4qxzYWwuHBKLCxoqbItIxrb53u2bwBB8Cad93zqfmK5FISnMoCTM4QrOmiXjOj0O8Qt9B/dBGM@amarulasolutions.com X-Received: by 2002:a05:6000:2f88:b0:3e4:74dc:a3bb with SMTP id ffacd0b85a97d-3e765a05168mr12528894f8f.40.1757966040043; Mon, 15 Sep 2025 12:54:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1757966040; cv=none; d=google.com; s=arc-20240605; b=NBg0mhtbYwxRCkoQomL9UlDhkEsNdou/cXAWYzapxPKLBO1PC//5VxbauZIZf+2Hrn yazv9gkLTjlGvJs3YRuw4R/uWhOclu3lJrTBsPp8NsbyWuDnD+mGFMz3r9l4L+cmLhxR byq0E38h4yqfMOwNsqPT0+b8MtEbH7wVMl7Dgu1gUrErDXjYupKk3Vte3UZGfh+jPr1Z WtR+/56UlGMOQVEj46/TrggUmdLS3XRmvRaDIYwa1FJ9+ilmS8PwimEcCOtBh/E6Gp27 f9GCWyzvfzFZvY1titgmJysOLt/AjsM2I1UfbWadhlFI/2zRyhFIeWcoy2BGrpzU2RKN clcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GqadXdSW1D0YdX9y/VYCHcP9OLLjsnrvbDdXfqIeuyU=; fh=ZbSWFubu2e88LXFQlJ3UJoPbPBgq8ymXR2bgFVSTM2M=; b=Lo0jQYGCJsvejs6UXdiG7uXhaxzCJpAghQhtGZDq8+tNz7ElncRJNlnlei0MRbSf3I IBFoGJvE3hTJFiV4bEzt+0Aq4iAwclMKnNAvxZGoVpZsp4qDqa73td37Sb8xDxXB41/U 1lzhDyOhHJEX7Cyhk7LomyEJYF7KFIwK8Z6ozbqQQQqjk5Zh3pQ6xRs8iGbrNWVwTSHc 6jpbiFAlrS698xWMiaC4nw5wTxS3pabRWky6c7H67TSWJXFJaGnYHJQsauC/EPPFMbpp 7eVqKSarcNE8/irXrAsidi9HaZRgGaeeqIyWQrm+q4Q0yZ1RrSRKXLmK3/XF1F/bSrsv iRkg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hsgyD6g8; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-45f28db0ed9sor12671695e9.2.2025.09.15.12.54.00 for (Google Transport Security); Mon, 15 Sep 2025 12:54:00 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Forwarded-Encrypted: i=1; AJvYcCUOwb4UzdDGz6Dced/aFN7m+H0p87K3pk9Zz5Z8+nK3VNAEQKKCisJhhBqwqxwNq9lt72le4RRAOv7XND3P@amarulasolutions.com X-Gm-Gg: ASbGncuLzSppcvO1puKn5oosyxw1fxKjDKljGi/3F5u8wJrlNu6XrV8AVlDQlm/KedY fQPBfSuuntE/BjXxpb+qzM8cuYwbaqsjpCdY4GsXqb+lRWyZ9E4TyAsoRl3CmJykV680h0I6TiN A5lMskbVyQ3DJPQ9FTetQCG6T4A2NPuaIOkOYZjCWojQjylmYXQjtMqjI05uTRE4kuEH6fDTNPX 6CAiD+pUY6ILdv4enFzW1P8KdPpKqmEi/9ZQAzxKrY6+iw72R6uM9N5Tp5AfRU7N0Nb7clDOJ4k +jBxPTDFFhse/GPZ5NZ2KJlDoblnxaYfOhtnxx5y80a5ucWRqZZVAzTDw0Ab8twtOjskCJnZ9VJ K3XrPIpJtk55ectzIKMOBj2bFOBfFsQhur8EPZDAse89Ug3hWwLg2udj1ZaRmli0= X-Received: by 2002:a05:600c:4453:b0:459:dde3:1a55 with SMTP id 5b1f17b1804b1-45f211f2fbemr160469475e9.24.1757966039580; Mon, 15 Sep 2025 12:53:59 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.. ([2.196.40.230]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32640f49sm530985e9.9.2025.09.15.12.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 12:53:59 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Frank Li , linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v3 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Mon, 15 Sep 2025 21:53:08 +0200 Message-ID: <20250915195335.1710780-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> References: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=hsgyD6g8; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi --- Changes in v3: - Remove the final part of the description that refers to implementation details in fsl,imx6ul-tsc.yaml. Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index e2c59cc7c82c..0d753aa05fbf 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,26 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "touchscreen-glitch-threshold-ns", + &de_glitch); + if (err) { + tsc->de_glitch = DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate = clk_get_rate(tsc->tsc_clk); + + cycles = DIV64_U64_ROUND_UP((u64)de_glitch * rate, NSEC_PER_SEC); + + if (cycles <= 0x3ff) + tsc->de_glitch = 3; + else if (cycles <= 0x7ff) + tsc->de_glitch = 2; + else if (cycles <= 0xfff) + tsc->de_glitch = 1; + else + tsc->de_glitch = 0; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,