From patchwork Tue Sep 23 14:37:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4353 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B58443F145 for ; Tue, 23 Sep 2025 16:38:01 +0200 (CEST) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-62fc37713d8sf3105991a12.0 for ; Tue, 23 Sep 2025 07:38:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758638281; cv=pass; d=google.com; s=arc-20240605; b=Zqe3YUjGAqNQT84bFNm0iJs4GgJmG5XMUeN7GnyqBn7HeK4e8cNE31hy5Ejtni95mc X3Jwto0EVK/cK2KrrCxh1y6iokjIw2lIyi5kez9DjIs0PijyRskcqhINOWhXwcIkp/5l QFPCh1I7+rqeQMDEO0RiuIYm0N1YYBwlET15L1lByt3AcG0sGhU462HVKvFYhXsJb+Gs HaiVLTrALhASNx06wJxy/v5hNgK8c7nze0zk+QaHb6oWLC6gXtUBjxDdr1b7qpEcE+Cf fMB8+p6OuKN7svB4IeX7RbIxfBHwcSLwWZyvdnS0xAoIVmOJprsvMS/2XcVoSpp1StYd bt7Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=grTnZqEdkVXS2oPt6FqFPLo+C/A98c59IIPzNcg6dKw=; fh=nomPcRPGcD8lZOogb+d8Fmp9BNj7/ImHa5CI5/HdG6k=; b=P5L+IZEr9TAzG1JEGEYHvmq06FMHi+g4mbZYPsJTbR3bfGhSkUANGDaU22qbXHAZtG dTPbw7g0hgZ72A4rWN4HgBn8h32eDZKed8XmmS6iEQS8x+t5fvyT/EoeUPRhKKNsHRXX 7B72jQl4rxruGC3Ek8BEMMNmgqjhHA86fJvt08gxTzzWLeo8cl/75V0w4KcBIum49Uxh ZbkPHFY8PWPBQtNJyO5p0XMN6Oz9b8KCyfRR0NjSFIgT366atuz6sj0Q5d8KG9bT08HV lsusM9ztJCYeLLtNAuFIYbaacpaof8Gf+t1yBPL40UUhXzoXfZsAUX0yGhxuTS2fmJyN wucw==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="kPaf/4xj"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1758638281; x=1759243081; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=grTnZqEdkVXS2oPt6FqFPLo+C/A98c59IIPzNcg6dKw=; b=muQNtsUES8WWBBfKsvAHgeUi1PSU1OrKpMdEZlA8ZWPovZYrUztfs+HGrJ08qVi5gc Bpp4lJ7FqrfXUzO3SYLDOh6sQqJBEvIEtAk3UngfI9Vev5S48YKBV5eCaNZhwe7l+vaf 8H2h5k8Prp9YSj65Z/vViKq1vgjuxt6wI4oV8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758638281; x=1759243081; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=grTnZqEdkVXS2oPt6FqFPLo+C/A98c59IIPzNcg6dKw=; b=YsBzhRIajowndpxZhaAnaIfj8bsuAkua0ci1NIF3kp8uQ8Z2ymY8ihXs0hAcAuD5dC gHbFnKMGXDtWdCJlG+jqKis3AhKF3qVAolsClarzDhwFhsh9iQdMUFxDvcP+Zkg5qM81 7jOUkkrzxMI6qRYETuHt6FcWs5c0qfT8KbdDRNWCGnhSi/toFzAQ77NHdVMSk4SPyPP6 YoWmPQLg9q0sFjwpKKY2L8Scr2Q0WPiCHGyFUJFmaQ4tsDJc9g2rpINaQe4ROtzuzkLi eUSYYjrlF480/cRyLZghkSV2Bzh5IfYOHjQwRjm8TtZkyyOH7SaykdUQhhu3DcsPIXWy hhRw== X-Forwarded-Encrypted: i=2; AJvYcCVLnA030GCc4yfOAE/8aePgvvEXX8eN+IkVgbNWvIiLlm26BaBwfrU3nn2/dW50Sj4TVknv8FuU4mDVHBgR@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YyzjSQi0fKbIqbKx6+HDM205mtA73+hL6vMD1kXtGAu5iNJgQMw XZqPU49iq4xJiUj5cFQCqTF/wNeyQq9bu2ckpHVs9Vf9SGc2B3aPuRn+qo0w22V7NxLjzQ== X-Google-Smtp-Source: AGHT+IFvrGzeo89iqjfCbnNojItOITQHGw0H0xQ8fIKAuHSGztF7qsRRSRLHPF5yOIvQyoie/LFtrw== X-Received: by 2002:a05:6402:1003:b0:62f:386d:aec1 with SMTP id 4fb4d7f45d1cf-634677f71e2mr2356837a12.27.1758638281276; Tue, 23 Sep 2025 07:38:01 -0700 (PDT) X-BeenThere: linux-amarula@amarulasolutions.com; h=ARHlJd5v40oaslxDYmtozF+3qzPlsdNETLpQhrSnph84XcIjsw== Received: by 2002:a05:6402:21cb:b0:628:46e0:3cd8 with SMTP id 4fb4d7f45d1cf-62fa734db56ls4808065a12.0.-pod-prod-02-eu; Tue, 23 Sep 2025 07:37:59 -0700 (PDT) X-Received: by 2002:a17:907:60d3:b0:b1d:368e:3ae5 with SMTP id a640c23a62f3a-b3020f1e2a5mr262071566b.0.1758638278838; Tue, 23 Sep 2025 07:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758638278; cv=none; d=google.com; s=arc-20240605; b=XUhMAh+ogYc/H8pB0v3yVwJldAIQJMrWNRYDcvc46JQ1QRtwEFIQu0xDGtTBD2VbtQ v7CyEP6GEIPc49f1UL3V7nKv1cepujPDtYvSHKkpKCYLo2KqkH2iPW9gXG7lhphfUOZt FUqQZE2xNZrFZp0ugBE4aeeKPnUMvIyNHtGrcKf6Zg8d/LV5fdU3hjbO9E5aOEvYsmUf vZ01u+Tsbej0O9KXI/tsFTXdiNLXfOZD9MUb5uCwh/LFA/CrgX9OhwkWrcIMuSe7xEj8 m4aUpNrD37hXd3OGSBFOL3TvVgZy2csPvGwj2NgMRtqYpqKPmOvKm0RBgO9VAin/AOC1 NfJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=s1NZM4v8G7kVFRobZkkcSJXgVxob1GWmO5LhOiwNAgs=; fh=07XXofEZG9d+QeVy8dz+2QB2lNQ+zt329x24x7giHEI=; b=YdB6sI9AptiO1P3dCnzqbpZNuv/sLNb7E1UZqgnZt/A6eNozcDHkBGWPUvPFxjYA8b zWt/rhQKm4fCS5IAK3yGv/2pcQtCgJyXcQTpzjwuC02DYzjImmGZzFGWZnWCs+M4Alml Fpv59iTjgE6JnpnKHBVomLabmmDJvd0ecQylkPRNIcz05cngj8mLpSUry91sKlVZepXq zJxzXWxV/BTQJA075f2a5+eyAvGBnYhg5E0delZv6LEWzvfa3y08yrxfkCwKuTmD5WXD Jl8ZTfmpJIAr85t8QsuD5MAmO+Qo5HR1ZavYTbQztlK2f3o0412yQgYJeabqGnL190NI QkRQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="kPaf/4xj"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b27bb5ffce7sor301663266b.11.2025.09.23.07.37.58 for (Google Transport Security); Tue, 23 Sep 2025 07:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: ASbGncsscPZfKGT7QNElkP8RQYuxTC3cBatpqGpGgjK1seCFyeGcxtHjNLI/PctjW7M HW2I5ApG3uZVuxKRHZogZ4X5WICSDlN4L2ZCWqWQufDJW1yQ1PHsijb7A++hypbb9orz7m2pF/I M35SFmT8Bmi7RA29YATKAAZLnfim9KlJc/nESLdKu0jDzh4aWHRVZAFeTRWGkSs5JuBlL/ZoJ1K PKmpSxKzsAX7DXURmA+25vOpZ5SWL3DPFfGWLlf4GCQLWzG8Se6lYgl8V/W1T4WbvRuudL9ubA5 TnNUuDcY3gGzcEORexRSoQFCVpsimAVjQUEJgn+A1bRkmi5oZML6bDM5AVGjtQA8tpf/cbNrPoz ZbNF+5wMeGXdaMYvCkqjdiClhEryUK+nSJyc4YWxVLRhrYriEdXbS1LcNRlV3FY7aXQCTsmiUip NSqhG3gPP9G3WUKQxphdXmwX+jsXiD1HkU28OQ3MugKvKDnvoGCb5JgxMr91yyUEKv X-Received: by 2002:a17:907:7b91:b0:b2c:3967:eb71 with SMTP id a640c23a62f3a-b30268949e6mr298598066b.3.1758638278355; Tue, 23 Sep 2025 07:37:58 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-56-38-125.retail.telecomitalia.it. [82.56.38.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c7asm665204666b.28.2025.09.23.07.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 07:37:58 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Frank Li , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v6 6/6] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Tue, 23 Sep 2025 16:37:37 +0200 Message-ID: <20250923143746.2857292-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> References: <20250923143746.2857292-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="kPaf/4xj"; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=pass header.i=@amarulasolutions.com Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Set the glitch threshold by DTS property and keep the existing default behavior if the 'debounce-delay-us' is not present. Signed-off-by: Dario Binacchi Reviewed-by: Frank Li --- Changes in v6: - Rename the deglitch property from touchscreen-glitch-threshold-ns to debounce-delay-us. - Read the DTS debounce-delay-us instead of touchscreen-glitch-threshold-ns. - Udpate the cycles calculation. Changes in v5: - I didn’t remove patches: - 2/6 Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros - 1/6 Input: imx6ul_tsc - fix typo in register name even though they were accepted, to avoid generating conflicts detected by the kernel test robot. - Re-work the commit message - Add Reviewed-by tag of Frank Li Changes in v4: - Adjust property description fsl,imx6ul-tsc.yaml following the suggestions of Conor Dooley and Frank Li. Changes in v3: - Remove the final part of the description that refers to implementation details in fsl,imx6ul-tsc.yaml. Changes in v2: - Replace patch ("dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold") with ("dt-bindings: touchscreen: add touchscreen-glitch-threshold-ns property"), making the previous property general by moving it to touchscreen.yaml. - Rework "Input: imx6ul_tsc - set glitch threshold by DTS property" patch to match changes made to the DTS property. - Move "Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros" patch right after the patch fixing the typo. - Rework to match changes made to the DTS property. drivers/input/touchscreen/imx6ul_tsc.c | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index e2c59cc7c82c..85f697de2b7e 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -79,7 +79,7 @@ #define MEASURE_SIG_EN BIT(0) #define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) -#define DE_GLITCH_2 0x02 +#define DE_GLITCH_DEF 0x02 #define START_SENSE BIT(12) #define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 @@ -98,6 +98,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; struct completion completion; }; @@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) basic_setting |= AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); - debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2); + debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); @@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) int tsc_irq; int adc_irq; u32 average_samples; + u32 de_glitch; tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL); if (!tsc) @@ -513,6 +515,25 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) return -EINVAL; } + err = of_property_read_u32(np, "debounce-delay-us", &de_glitch); + if (err) { + tsc->de_glitch = DE_GLITCH_DEF; + } else { + u64 cycles; + unsigned long rate = clk_get_rate(tsc->tsc_clk); + + cycles = DIV64_U64_ROUND_UP((u64)de_glitch * rate, USEC_PER_SEC); + + if (cycles <= 0x3ff) + tsc->de_glitch = 3; + else if (cycles <= 0x7ff) + tsc->de_glitch = 2; + else if (cycles <= 0xfff) + tsc->de_glitch = 1; + else + tsc->de_glitch = 0; + } + err = input_register_device(tsc->input); if (err) { dev_err(&pdev->dev,