From patchwork Sun Dec 28 15:17:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4398 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id B2D333FA64 for ; Sun, 28 Dec 2025 16:18:36 +0100 (CET) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-64d2db4625esf6296187a12.0 for ; Sun, 28 Dec 2025 07:18:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1766935116; cv=pass; d=google.com; s=arc-20240605; b=GjwW/jRlOZn07hyK0FtIiUtGRatUl1yS9iw89JCjEiR/kt7Hi5GQUNdRy7aIbQuWrM MXtNc32BnoZnj+JnhptYqA5t4X1lfidrjP9hi8D8D/DgkAW/5drA1qY+K0J5zq3pZbH4 TgspI3MLOtAcLffrXz/fWfdlme3R4jac9fvipaFCFSC/vgvetDdb55LSPR15xjGS7Qgn UDwIAJik6HH+HM38J6KOgcJXsiepDMFiRWz0kTXJhcfZoLYmJCQQviZiyZAxNKgd08V6 Rwno5aaZwLr5o2m9JIRBAJCVnrt1uzYSJemb4FpS2MYrfDa+bGMh7s6XqCrlnaNMTt6w Ro0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=NkGaZC5LqdWyoP/43KJbLvVDjFswEJv2fNN4EcM0Tos=; fh=J0bTeVH+s1OlQPaviM7JQRkcLOnsehW3/9EN3jvvJao=; b=U1KkmC40yJvM9cTg9MBOP61/kFdcPrZCLrt5/LpqkTo1dWmJLaKJWGAji+8V+g3hDQ oegYHMX+UZtLbRrm063GYGkQueeIz6kZAm6djtqynAL4UBF/PU0gbGxd/2mdDfcHzLi4 86s5m+icXnxZ67yLqUjkQyhxYsDuCIKfS+kiMPyry5hBja0JcsAcJ939IQfBXLi3eVIx UUq6n+n7PnIUGYPNSti0K0iiMz7UA3rcXcYb0RO5WMzusHjFYAjYZAGEjEqD9Cs2NNhu CphJ8qRn6V05Lfpq/aKKLGeNIyB+GGNrbQVwggqziJXAVuUZp5+XWRDysLm0vtsPiS3/ ba7A==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Bm4cq+My; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1766935116; x=1767539916; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NkGaZC5LqdWyoP/43KJbLvVDjFswEJv2fNN4EcM0Tos=; b=d8uj7XPtk6cj5e6SNmUhU0fYv5o0NDpzj59vDDhOdU9tcYYDZyQs3t9SIy23tG24rQ EXuoMqqEKBRUQZt6i6Ef6IvuVCLLXcRNDfs8OnRAx7nIY4w/4fOHaGcjj8vKihR9K7Bk Hbj4GQxVQDJ0dxrH0Mw0pGUywkk2cNqGJeJy8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766935116; x=1767539916; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NkGaZC5LqdWyoP/43KJbLvVDjFswEJv2fNN4EcM0Tos=; b=mHZ/UnYwR1ImaKfmumI5EtbQSXNHUL/wkMJmHHIhU/kHWVlLluoR4Nj3CyzAMqgeWX /13fhfPTvL8dVAO1EYry5gB1+KbUXKvEB9gsGomV80Ov/NJqBmlgSKQrlXHx2IZwtFvt 9MjIKkYFWmPjP2/JLFz1EpDmtyPs3hHB8KkBXCHzMipDalQTTGrGkc2sIJ6/1BQQRtHK vulcg05iisEOM4nciCioN9Uapq8JnKLqQoZ2/pUDuNqPxDsl99vjvIxEMEeoSb5YdJC+ FRZ2tb3zn8mdvKc6GhTVA+KOHklknnWQYW77tbie1ZDEMsbZpMpbSlP2A4yJY9SGOydb 8Tnw== X-Forwarded-Encrypted: i=2; AJvYcCXYzFQpyKQf4G3DZ96kDi6coHMHhZxPA1IkEdLma7UNqkj8lTid0CvHUCz3kb+C+jvm2XBZ0SanUnMNd5DJ@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0YwlMm5hvUo73fEbyNjgVipkJJ0QGXcdEUfawA8oMly7N2NHKPTO SJJkZqBycnC89Cyo84I5j2cYJRu37bKXiFpb8Lk6p0bbOU4LC+CAIur7v9++SMV5cHR5pg== X-Google-Smtp-Source: AGHT+IF4Aa7WYWgN+ygiTpcWejAPuBnCWYXU+4WoyFGf5OsLRWI7j0fk59cZKD7K5QuoSgEHKqNFPA== X-Received: by 2002:a05:6402:358d:b0:64d:250b:5a8c with SMTP id 4fb4d7f45d1cf-64d250b5df4mr20542121a12.25.1766935116260; Sun, 28 Dec 2025 07:18:36 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com; h="AWVwgWa17AIprHPukwW35WiL1EYypS0cePTt2/TFTBzfUrSllw==" Received: by 2002:a05:6402:304e:20b0:64b:58c2:9ba4 with SMTP id 4fb4d7f45d1cf-64b58c29c42ls907684a12.2.-pod-prod-01-eu; Sun, 28 Dec 2025 07:18:34 -0800 (PST) X-Received: by 2002:a17:907:1dd7:b0:b80:4033:7735 with SMTP id a640c23a62f3a-b804033782bmr2050928066b.28.1766935114222; Sun, 28 Dec 2025 07:18:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1766935114; cv=none; d=google.com; s=arc-20240605; b=YuK9DrxJb5qzPRJqUNYn/q6H0nKE6qK88A0wq/wTqVQkIQuvzAxRRVSyar6qTfhswY x2HTQZxYhIicojAB4+IWcK2i1YykdtIC12ppflF00y10Jcbpwv7nhwcQRM68v1y0IFMn gazufCfJb/iVYIOgHmgskSSvrGjNa0NGQ6sxFO0Pj4OMxlyS40NvrpT6EtrF02TyupQG L/eQGS8Qy1RtUguD7U2lyWi9x5EG0jtNwfLYLmbhjm9I9Uk9RFCpYbQTzHF846aRYPuP vkqF+vnpwVerAZ4DfsMBwVwD04I3UaVnR7w2B1ZHxbNDZAkysT7LZrdlKCH1sC04CrtQ EscA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=KhmMxxr1x0XNjGMnJ9VY+5ttKFr1CekD4DbcXhJyhT0=; fh=omVnkh8GL0769KNbVjCBch9MCT0VbhUb3/ehbrVLWgY=; b=bwZzpSRhkoVd8afqVKKr5ttCeMpS3WvQGBd/VD/q4/Z8ky60OO9gggKOiuuTOFO7r6 49ud+gsIqYpH6XJKyFJZCk8hYSYR2vvv2X2Q9w7fK7fGgL15e/EzT+BB9vkB1ZxXNiQ/ htNXdsiTjyQOdqpE/uVfjAoFDZf5dSNixrUaI0j/ObbQRuu7w6o8/a2wks/9ZCTMdY4j 58OpGf6dZ4+cgpIbELifoQ77vh2sf59XS552Z0FSA5VdI9f8bXRGmILTeJ+YBRdeGvYA VteO0vizziAz59UDsb+63aST5+5AmiXNY4ABuqzBVytgoAkGlku2469qaw8io7zlQXVx bhmg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Bm4cq+My; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b8022fa1933sor593123366b.7.2025.12.28.07.18.34 for (Google Transport Security); Sun, 28 Dec 2025 07:18:34 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: AY/fxX7XosD04XO/kXwaHuWx9/fzva5Cu6QZFVA/uAzvdHQ5rcDkYb87y13MSyzJgKG Qat73EYvlAS2TD4oTcq+YMcTaxem+pK3OfWqIADVQ3H4Dt5epzE6UC3OdSH6/dXhxFnEnN1G28P KSjBHcjosZRUUJMo3985QokkiR9YBu9JrQb86eJ1bEwTkBOlCeoV8D4YLKwXZb1OtGsyLUtXzQo iETmV0pdyggkll81zGyLyeUTYSfdozOxwY6GjLwN1Gj0W3orw+Oa8bZsllDM2Qbk2wLxRPzG9UF OougwIDvdjl3f3wPj7vmrKKJ3Pu3Krg6GXOwnwMmFg++/vr7tNBJ9wna8ItC+RIi04DWZ97xvud bqu02Xzmj3ODKOUezcsoswNpb3ylIffolKnQCbLubcVcA8cDy1FnBNXV/C4RzO84yWN80dmfPV+ 3Lh/VnbZgdhRv6sbp7kPILQ42YzCAgEfPauHa9oAubPGxtwFi4/KTTVhaYyIXLlqAZehhgWwGj1 asnp/oBGgNwKBIAYWs/mCVfkuITtKQZ/cgIMkFfglK3TD9NOPu18IoTpH30BSfM5ZuLrNtJmaZj 9Ltaxwuwbql+Tj/HSvTAkw== X-Received: by 2002:a17:907:7f1c:b0:b83:976:50f9 with SMTP id a640c23a62f3a-b83097652a7mr1283225766b.61.1766935113743; Sun, 28 Dec 2025 07:18:33 -0800 (PST) Received: from dario-ThinkPad-P14s-Gen-5.homenet.telecomitalia.it (host-95-248-31-95.retail.telecomitalia.it. [95.248.31.95]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91494cd7sm28502224a12.16.2025.12.28.07.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 07:18:33 -0800 (PST) From: Dario Binacchi To: u-boot@lists.denx.de Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Sughosh Ganu , Tom Rini Subject: [PATCH 3/5] fwu: use FWU_MAX_STATE_BANKS for bank_state array Date: Sun, 28 Dec 2025 16:17:53 +0100 Message-ID: <20251228151824.25667-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251228151824.25667-1-dario.binacchi@amarulasolutions.com> References: <20251228151824.25667-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=Bm4cq+My; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Replace the hardcoded size of the bank_state array with FWU_MAX_STATE_BANKS to improve readability and ensure consistency between the structure definition and code that relies on it, including the mkfwumdata tool. Signed-off-by: Dario Binacchi --- include/fwu_mdata.h | 5 ++++- tools/mkfwumdata.c | 5 +---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/fwu_mdata.h b/include/fwu_mdata.h index 43b3487c4a23..b84a9987f769 100644 --- a/include/fwu_mdata.h +++ b/include/fwu_mdata.h @@ -94,6 +94,9 @@ struct fwu_mdata { } __packed; #else /* CONFIG_FWU_MDATA_V1 */ + +#define FWU_MAX_STATE_BANKS 4 + /** * struct fwu_mdata - FWU metadata structure for multi-bank updates * @crc32: crc32 value for the FWU metadata @@ -120,7 +123,7 @@ struct fwu_mdata { uint32_t metadata_size; uint16_t desc_offset; uint16_t reserved1; - uint8_t bank_state[4]; + uint8_t bank_state[FWU_MAX_STATE_BANKS]; uint32_t reserved2; // struct fwu_fw_store_desc fw_desc; diff --git a/tools/mkfwumdata.c b/tools/mkfwumdata.c index 0d1697622e6a..c2fd3d4232f5 100644 --- a/tools/mkfwumdata.c +++ b/tools/mkfwumdata.c @@ -30,9 +30,6 @@ typedef uint64_t u64; #define CONFIG_FWU_NUM_BANKS 0 #define CONFIG_FWU_NUM_IMAGES_PER_BANK 0 -/* version 2 supports maximum of 4 banks */ -#define MAX_BANKS_V2 4 - #include static const char *opts_short = "b:i:a:p:v:V:gh"; @@ -292,7 +289,7 @@ static void fwu_fill_version_specific_mdata(struct fwu_mdata_object *mobj) mdata->metadata_size = mobj->size; mdata->desc_offset = sizeof(struct fwu_mdata); - for (i = 0; i < MAX_BANKS_V2; i++) + for (i = 0; i < FWU_MAX_STATE_BANKS; i++) mdata->bank_state[i] = i < mobj->banks ? FWU_BANK_ACCEPTED : FWU_BANK_INVALID;