From patchwork Wed Jan 14 16:16:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 4433 Return-Path: X-Original-To: linux-amarula@patchwork.amarulasolutions.com Delivered-To: linux-amarula@patchwork.amarulasolutions.com Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by ganimede.amarulasolutions.com (Postfix) with ESMTPS id D29023FA12 for ; Wed, 14 Jan 2026 17:16:46 +0100 (CET) Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-64b4b64011dsf2702892a12.2 for ; Wed, 14 Jan 2026 08:16:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1768407406; cv=pass; d=google.com; s=arc-20240605; b=eSXyUXMRrlgsIvdeZrTw9aAdkE+x81Kai5KrlhA807AJio85hB/+4Sy41272pQy8aS qsNmSZkHodDfm06nmnXkN9U+I8aoxhbTqTP5L0dyOvS9Rp0sjOpnKHv41ewzxRhPdDra JgO3Vrk+x6/NoCYXb0NVW88o3sdaz2BGbwUMFFeGbbLy0iNg6iQqG/sXdkE70H3i3FWr baaFnOkwJhn0eXgd/5xTR6jrdBHp9Pz0aJTZe6U1otjqgyNO+sqqLigiCfe+fVPxsK40 7O+q3umhb3u/atILSjuNpaGGVSCJF/vVIlWZz499Rn2O4qXGTO2KUqnZ8cU0GKzQnNgt fUvw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=0TRbmFShjUCo5O1NB6VK1kRZeGQvODkbYmsz35R/3ec=; fh=NpZMo7u3rtyf0zal0faAED4QmOSIb2wLOPkkVlnOPpE=; b=YsIuOQSZkbDfI60skAYK3QZL/IIXD8afLWpZwRF8rqWZAu5lV9LEihZHoME71YJay/ DpBQGGkXvHUmv6Ce7TD20KUTwQWl8mxM+jxeO+oVgIs7E1zuPHEM76eTjPF81bTP25tp XkHO4Rn9zXs2zyizCbLwSevOXjiybFuWNdKrCH0q8zpNatnocmAkf1nTM5IoVBQempb3 22gij90gQdWeXk3k8TpTYhJpLmmKXToKSrxFfxvfOM8KX+za0TdtkFPS9UjwG+QadlsH 5fx4yEyPqfEI18UjIYbbvx/TeB5h6c7K8h1BFDGXjedOjCYVYHEFOKx7774cdL6sx74/ XayQ==; darn=patchwork.amarulasolutions.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=RL3Gyayv; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1768407406; x=1769012206; darn=patchwork.amarulasolutions.com; h=list-unsubscribe:list-archive:list-help:list-post:list-id :mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=0TRbmFShjUCo5O1NB6VK1kRZeGQvODkbYmsz35R/3ec=; b=cfKaG7DHzTzcOKXA+0KtnqDkXiZkMTZ0abmYWZufNKpRy53oxs4/+SfyabPzZVZcT+ BIZvhHC3OPw+nIB9Qij6lW4cxR/c7t1h3zRsDThXxgFVt1Zrl8SPkPnvQIUkE3+tbUxY wtn3CSaJROWqEBItqxQMhIbnfOcPCqt+NElik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768407406; x=1769012206; h=list-unsubscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0TRbmFShjUCo5O1NB6VK1kRZeGQvODkbYmsz35R/3ec=; b=wYS3LwsgwWmlckfOTTXABnxiJorWaXbEd7f1f0I8sXs5JXCn8z2g4MRp3+vJnnIfzN 6g+MCHsgUl5s2ZdWUIk0YPpVld7tKtD6nXUgx9VcHr1+EVBgz/5bnlYOAjk4a3I6rW49 PLxPkU1Nq9kS4FSvjw0dQFXGc6ADjEup07CcIq8RfZQaY6nsxFf4bIcRJsrfeKxtMv6L WADTlIaShalbRXRrvY+saxwBX5ahfxtKmdEHORzF3wqDJIJ+uw0Kbau/qww0xTUJs9CD C0fXqciZmHshPvTHKdRgQdd86Pfe2ibIIS7EMHNoxpK+CD1O+hbHu7O/rA4a8BE+Abxh /G3w== X-Forwarded-Encrypted: i=2; AJvYcCXrkXz6JLy7lb2q9k3pebbIM5pi4oNVKzEH4AWvQSKUx/rCsFQ62x2Dn+Nu7VjczbspXv6lH9ZehOoELi8F@patchwork.amarulasolutions.com X-Gm-Message-State: AOJu0Yz6VBT44+thzOE4FrhcdMSYgyH6bwsDNTen0edeP+y9FUoiZ1AL RTy2pT8MBBATHwFJ6zZTedXyUcEPj1+LjpmKTKOXNDm0mERo4Q7gTBe0BRI9Kd+5GkEjZQ== X-Received: by 2002:a05:6402:2710:b0:649:cb6e:61ea with SMTP id 4fb4d7f45d1cf-653ec124882mr2616362a12.15.1768407406355; Wed, 14 Jan 2026 08:16:46 -0800 (PST) X-BeenThere: linux-amarula@amarulasolutions.com; h="AV1CL+FzP+MycN+ovrLGX8BsmD47bH0JOIuv5aTb3UjYLbuOSQ==" Received: by 2002:a05:6402:5154:b0:641:5a07:215b with SMTP id 4fb4d7f45d1cf-650747c86dfls9883597a12.2.-pod-prod-06-eu; Wed, 14 Jan 2026 08:16:44 -0800 (PST) X-Received: by 2002:a17:907:3d8c:b0:b86:e938:1b1c with SMTP id a640c23a62f3a-b8760fdac43mr281957066b.5.1768407404325; Wed, 14 Jan 2026 08:16:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1768407404; cv=none; d=google.com; s=arc-20240605; b=TvqyxZdPYuxd4bRdPxN+5sx+IGzET7uob+Ez6vPwoYJdG07EyK/iWM1ZS8bbDkxD7y 8gV90b08zeie3YRbUIKCBjNX25n7ANqAvhkTq2YKHNCPTtt6mD779eATAh/9IJ2rqYCp FSRV0gMb4ZqAKeiaRgvW6iFu/M+7SDM51QO7Bwu+69FGhm5fmIMHKvNXMMDad/lcufJn JMjFqFaRUilKVNikeOWV58HRPUhIXrtuXJC4ZdEY8aMaA4glti6yQ7Qk1UFrI5NjQXk2 MuuhMd0xPOscA5Xo1EKYD6u4pNMNiv0+YBuQzWp4HMTfWcAQ2IjjqVEU/00sNqHEZbln jsBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=jObGM6uTHAsqYMn8EnUpzjFhVdbTLdpJ/rOYX6vi+YM=; fh=AdINyqa0RrhYjILkNDREXbEInCFvYIP+gW50d4EJsQ0=; b=MO+ZMPWgY6ZpKyuSduisy1WgY4/RHQBaFqQm1ZGFxg3zsaXdpfLGyYeeUAZ/i5Bhy2 XAhaAl8bMPAn1Zcm3cFozRY8tK+ZZe/QELotFdFgyxXuxd88hZ/DXvlkf3xTAXU+QOFb nVlomptnReajD7D+GQu9ZYCfqWIxEbt1dMFSIwInY22EhaiB7LQ+qjbJdVeUF4etFCe4 k7C+Ra0GJvu2cpeZiuXAsS1p+HY/B2WLzDX85afIShEupe+eQCoUOdqyNuxUpgMi9b/u r+EmZU5IfVK/klGh+09DeebyM/KGAzLzlyT9ARa4MAdjdxX5gEbrMu7ynwAw5iiLvJTk toqg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=RL3Gyayv; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a640c23a62f3a-b842a27c0a9sor759230166b.9.2026.01.14.08.16.44 for (Google Transport Security); Wed, 14 Jan 2026 08:16:44 -0800 (PST) Received-SPF: pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; X-Gm-Gg: AY/fxX4CckoVjzzZVVq4c9aEM03b1H4GDKFUQExvu5CJH4pIoGLJ4qraW4U4sFtcdY0 R1ohtPsWB7iFUgpUk6tMymryEhMYnLH+LITXK5mAdOJQReCBfaipZlsDI+OUU/EpOAk4/orzN1Q zMea0o+KEctKLMQ0GUZdd5YZeY1CfKc2NvdfwrrAylmKm8SwtH6hhIb0yuVlLJNX9QHhf+H+0a/ vOb/mC6rVAxV67hMtkghaYpoBjaggVK2WsEclyY/vcQFVm0xfhoWnLr9cjQa1cUOofNksNXiVZG E/Jc+1WUJeZJPQ7gcnkAXNBY9VV5eljPfV+RaVRloWH87RJn+5VYx/tGqopPGvnUc1g0an9RCFK tYe+ApHAXjvBuvVRm2ypSucM+mHALNxpCYM3dJDeH0g7Y9XgpdVGYyvLMDa0Ops2drRTvoY/6ku zNmhrYtHTEbSeg9ao/oEWVgAxWmcq4xH3Q60Dz5T1KqpScsRVn36PTwlCCsAylUDsWwUf6pSk3V x5HQW2gSvGgn31jmu1f3/7nHH9Q+M0zSM/o1l8ICPIStcTn2bgm5F0/wRAylMzJptU3fw== X-Received: by 2002:a17:907:6e94:b0:b87:2471:def3 with SMTP id a640c23a62f3a-b87612c049amr281323766b.55.1768407403679; Wed, 14 Jan 2026 08:16:43 -0800 (PST) Received: from dario-ThinkPad-P14s-Gen-5.amarulasolutions.com (93-47-52-235.ip111.fastwebnet.it. [93.47.52.235]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b876dd0e9ffsm152281566b.37.2026.01.14.08.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 08:16:43 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Michael Walle , Neil Armstrong , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 2/4] drm/panel: ilitek-ili9806e: split core and DSI logic Date: Wed, 14 Jan 2026 17:16:17 +0100 Message-ID: <20260114161636.1076706-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260114161636.1076706-1-dario.binacchi@amarulasolutions.com> References: <20260114161636.1076706-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Original-Sender: dario.binacchi@amarulasolutions.com X-Original-Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=RL3Gyayv; spf=pass (google.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com; dara=neutral header.i=@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list linux-amarula@amarulasolutions.com; contact linux-amarula+owners@amarulasolutions.com List-ID: X-Spam-Checked-In-Group: linux-amarula@amarulasolutions.com X-Google-Group-Id: 476853432473 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Split the driver to support multiple transport buses. The core logic (power, GPIO, backlight) is moved to a dedicated core module, while DSI-specific code is restricted to the DSI module. Introduce DRM_PANEL_ILITEK_ILI9806E_CORE as a hidden Kconfig symbol selected by the bus-specific configuration. Signed-off-by: Dario Binacchi --- (no changes since v1) MAINTAINERS | 2 +- drivers/gpu/drm/panel/Kconfig | 8 +- drivers/gpu/drm/panel/Makefile | 1 + .../drm/panel/panel-ilitek-ili9806e-core.c | 129 +++++++++++++++ .../drm/panel/panel-ilitek-ili9806e-core.h | 15 ++ .../gpu/drm/panel/panel-ilitek-ili9806e-dsi.c | 151 +++++------------- 6 files changed, 195 insertions(+), 111 deletions(-) create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h diff --git a/MAINTAINERS b/MAINTAINERS index 317e76cc99e5..67117d8cf483 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7913,7 +7913,7 @@ F: drivers/gpu/drm/panel/panel-ilitek-ili9805.c DRM DRIVER FOR ILITEK ILI9806E PANELS M: Michael Walle S: Maintained -F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c +F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-* DRM DRIVER FOR JADARD JD9365DA-H3 MIPI-DSI LCD PANELS M: Jagan Teki diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 692cd474910d..333e981eda96 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -257,11 +257,15 @@ config DRM_PANEL_ILITEK_ILI9805 Say Y if you want to enable support for panels based on the Ilitek ILI9805 controller. +config DRM_PANEL_ILITEK_ILI9806E_CORE + tristate + depends on OF + depends on BACKLIGHT_CLASS_DEVICE + config DRM_PANEL_ILITEK_ILI9806E_DSI tristate "Ilitek ILI9806E-based DSI panels" - depends on OF depends on DRM_MIPI_DSI - depends on BACKLIGHT_CLASS_DEVICE + select DRM_PANEL_ILITEK_ILI9806E_CORE help Say Y if you want to enable support for panels based on the Ilitek ILI9806E controller using DSI. diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 00071a983242..13034cadb8d8 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_HYDIS_HV101HD1) += panel-hydis-hv101hd1.o obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9341) += panel-ilitek-ili9341.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9805) += panel-ilitek-ili9805.o +obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_CORE) += panel-ilitek-ili9806e-core.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_DSI) += panel-ilitek-ili9806e-dsi.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9882T) += panel-ilitek-ili9882t.o diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c new file mode 100644 index 000000000000..c088685d9d85 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c @@ -0,0 +1,129 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Ilitek ILI9806E core driver. + * + * Copyright (c) 2026 Amarula Solutions, Dario Binacchi + */ + +#include + +#include +#include +#include +#include +#include +#include + +#include "panel-ilitek-ili9806e-core.h" + +struct ili9806e { + void *transport; + struct drm_panel panel; + + struct regulator_bulk_data supplies[2]; + struct gpio_desc *reset_gpio; +}; + +static const char * const regulator_names[] = { + "vdd", + "vccio", +}; + +void *ili9806e_get_transport(struct drm_panel *panel) +{ + struct ili9806e *ctx = container_of(panel, struct ili9806e, panel); + + return ctx->transport; +} +EXPORT_SYMBOL_GPL(ili9806e_get_transport); + +int ili9806e_power_on(struct device *dev) +{ + struct ili9806e *ctx = dev_get_drvdata(dev); + int ret; + + gpiod_set_value(ctx->reset_gpio, 1); + + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); + if (ret) { + dev_err(dev, "regulator bulk enable failed: %d\n", ret); + return ret; + } + + usleep_range(10000, 20000); + gpiod_set_value(ctx->reset_gpio, 0); + usleep_range(10000, 20000); + + return 0; +} +EXPORT_SYMBOL_GPL(ili9806e_power_on); + +int ili9806e_power_off(struct device *dev) +{ + struct ili9806e *ctx = dev_get_drvdata(dev); + int ret; + + gpiod_set_value(ctx->reset_gpio, 1); + + ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); + if (ret) + dev_err(dev, "regulator bulk disable failed: %d\n", ret); + + return ret; +} +EXPORT_SYMBOL_GPL(ili9806e_power_off); + +int ili9806e_probe(struct device *dev, void *transport, + const struct drm_panel_funcs *funcs, + int connector_type) +{ + struct ili9806e *ctx; + int i, ret; + + ctx = devm_kzalloc(dev, sizeof(struct ili9806e), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + + dev_set_drvdata(dev, ctx); + ctx->transport = transport; + + for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) + ctx->supplies[i].supply = regulator_names[i]; + + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), + ctx->supplies); + if (ret) + return dev_err_probe(dev, ret, "failed to get regulators\n"); + + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(ctx->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), + "Failed to get reset-gpios\n"); + + drm_panel_init(&ctx->panel, dev, funcs, connector_type); + + ret = drm_panel_of_backlight(&ctx->panel); + if (ret) + return dev_err_probe(dev, ret, "Failed to get backlight\n"); + + ctx->panel.prepare_prev_first = true; + drm_panel_add(&ctx->panel); + + return 0; + +} +EXPORT_SYMBOL_GPL(ili9806e_probe); + +void ili9806e_remove(struct device *dev) +{ + struct ili9806e *ctx = dev_get_drvdata(dev); + + drm_panel_remove(&ctx->panel); +} +EXPORT_SYMBOL_GPL(ili9806e_remove); + +MODULE_AUTHOR("Dario Binacchi "); +MODULE_AUTHOR("Gunnar Dibbern "); +MODULE_AUTHOR("Michael Walle "); +MODULE_DESCRIPTION("Ilitek ILI9806E Controller Driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h new file mode 100644 index 000000000000..dddece62cf42 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef _PANEL_ILITEK_ILI9806E_CORE_H +#define _PANEL_ILITEK_ILI9806E_CORE_H + +void *ili9806e_get_transport(struct drm_panel *panel); +int ili9806e_power_off(struct device *dev); +int ili9806e_power_on(struct device *dev); + +int ili9806e_probe(struct device *dev, void *transport, + const struct drm_panel_funcs *funcs, + int connector_type); +void ili9806e_remove(struct device *dev); + +#endif /* _PANEL_ILITEK_ILI9806E_CORE_H */ diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c index c337c4f1a1c7..ecdbed8d4a3a 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c @@ -1,15 +1,12 @@ // SPDX-License-Identifier: GPL-2.0 -#include #include #include #include -#include #include #include #include #include -#include #include #include @@ -18,7 +15,9 @@ #include